From nobody Fri Dec 19 21:10:53 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8817B2FABF8 for ; Thu, 4 Dec 2025 02:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764816503; cv=none; b=HIYba9UudJuszJ3XihQGjm5jD86tCy6lCmcfFJzLIVCU/S82zSSfVYK+v06vvHCe2NRaHJfUbCQXlKOZLt+rUQ4js+gCAjXTy7n2hZi8Bxizd9eZap48g2gYfsJT2GENsm7X9im4H70cke9wNkf8kzHa39vGqi2KiKm1gGI8icE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764816503; c=relaxed/simple; bh=JLIdNXPMejF737Jv1xzF5GicNRibkuRDb9iX4pmjoI8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=p0hhXtxWiwWbrS4IzXhKMO7c0/rCa7EJY9MgB9HL6zwlu32VhxkgXkFOaapSTCAlqBGtGuSqgPOpNLn0YErDFwPXpQvAKmuRrcBpOgNF6wnB/y+V87pTB8WXcnDKnyBh8Mb5piD+pTSlcpdJAIbBQWzjCOdxI1EiRngNwV/fwuY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XnTVzxer; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XnTVzxer" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7d26a7e5639so507942b3a.1 for ; Wed, 03 Dec 2025 18:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764816498; x=1765421298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=XnTVzxergD/1zjfx76F9BSZzo9o/r0VE4vDIgGpatGyKsylXlNTt8/JfEdgckLk/yr hkAFbZxasrhonowS2EDvdXciSVHsxS1pEeEoP8/jsN6c7EPCX8LgKfwHQRs00HoSy2lW l12VjGbzqTnuNwEfsX86Syi2dqwsBOwXG2OkPQ2C7m0Ym3ecytJMD5lRVQzeeZM6WiDF YZ3I4Jkqy2+DnLqyB2X1lej4eHSaRDqc1WxWgmdHns7VwFDY5nktnDDFdGLEaN3S2uln pQUl2mHUkCIasI1iUL6cJgi0HACsN38Yqbt/y36jBJ8IlOtC91rjigv9uWygK4qKoKyr nj9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764816498; x=1765421298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=bKyDeHvKmbbIfG6tiINuZBM6MbuB1ziMCiCGv6eF0yk14B6na+EhP5uDc2yJm2LSkD Yn+v5GLH20ZbZ/TmZBrykYC0oWrRcyp4pPoHl5txDm+vUdFT2b2roZ71BKTCyo/5OIm5 vxqHJPu2KpcctuJFNdcMMlS4qVsa+E39NGUnwZwxqsndzADa5FGefOV/a+g4EV8e9t7H yHaCNYGetdHTcZkxfOtJDiYkKGLCA/V9UskQG6zTBTKez3l6tK4BiFfT7el9RYmFQ8bg CIbdiYFXC0hz0hUnhMdY/JGRXEYPDcb7+Ky2the+HTDbPEPQxEJ+yWRMwOJ1H7bEFyfR bSlw== X-Forwarded-Encrypted: i=1; AJvYcCWbt4eIuvlZSvJLAFuyr1CU1z6KeNVTevuFXhZAPlAIMs7XqoXjnH4Mf4ZKYRmZ+WY8ru/pz3J80qHkVQ8=@vger.kernel.org X-Gm-Message-State: AOJu0YxtnEY+iaf1qqo19rkedM/D9B3qOSxilyFDptQTSWuAZ/VCDEV8 qKXbfDbRdAUtI+Y8zeHB1LSq8eYNSWkbW4xAhLJ5xlIkowWRKmjsvAzk X-Gm-Gg: ASbGncv4SGNxBGVz7BuibhlIsrfm3tQO2MZH+FgfdpmzpUB4cgCkeKRpOX71PGfLwLQ wf3YsafYxi3FGYASNsLe7T963tRoZ/e+2u4b/mJLPd/PaWjGWLkt1cELgUh5dIepegyx8EjTu3t I71YmYNY7CVYjPBsy7Ft0+W26/11iDr2KrUPUT2EfcQAHm9PtaaLpj0xVtFWhTHC5kzE43xdnl/ PAa2KJVLzQJC/rmGNUAiGdocwrPnh0enPpN08gHDyVsronOLjN9bAjM62m1eyMsb496qUgVbOIk S2D/Sn614WtQQuLQRYcx8wTNgS2uqYi7YW0ZJ59BO5qp/EVQeBt9hyGI7fITIQoi4Ma1cGrOvEO jTma4VItf8SoQJ9YyED0aYJQwMTzt4D6OfghV/PRcaV1+HRUQBYo3mWgh63msoJTDzNTs3R54Of hEosnR38cDjFV3Clz4A95EyuilRg== X-Google-Smtp-Source: AGHT+IEThN9cBQeL3cXuDOIc1+uCaHf9ep2wDNPFjuh/TeOr5B3FR/bA1QanG4XfS+l/fJbBKZDCrQ== X-Received: by 2002:a05:7022:4595:b0:11d:f441:6c9b with SMTP id a92af1059eb24-11df4417192mr2091918c88.22.1764816497778; Wed, 03 Dec 2025 18:48:17 -0800 (PST) Received: from localhost.localdomain ([104.128.72.41]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df76e2f3csm1838847c88.5.2025.12.03.18.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 18:48:17 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com Subject: [PATCH v5 1/3] bcache: fix improper use of bi_end_io Date: Thu, 4 Dec 2025 10:47:46 +0800 Message-Id: <20251204024748.3052502-2-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251204024748.3052502-1-zhangshida@kylinos.cn> References: <20251204024748.3052502-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Don't call bio->bi_end_io() directly. Use the bio_endio() helper function instead, which handles completion more safely and uniformly. Suggested-by: Christoph Hellwig Signed-off-by: Shida Zhang Reviewed-by: Christoph Hellwig --- drivers/md/bcache/request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index af345dc6fde..82fdea7dea7 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio) } =20 kfree(ddip); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static void detached_dev_do_request(struct bcache_device *d, struct bio *b= io, @@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, ddip =3D kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); if (!ddip) { bio->bi_status =3D BLK_STS_RESOURCE; - bio->bi_end_io(bio); + bio_endio(bio); return; } =20 @@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, =20 if ((bio_op(bio) =3D=3D REQ_OP_DISCARD) && !bdev_max_discard_sectors(dc->bdev)) - bio->bi_end_io(bio); + detached_dev_end_io(bio); else submit_bio_noacct(bio); } --=20 2.34.1