From nobody Sat Feb 7 17:22:46 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494881FE471 for ; Thu, 4 Dec 2025 01:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764813041; cv=none; b=GrqQ2j6VWGaqPww4gM6yduxId7c3Y89iJzVnAUPmM5pqyt2qp2W+rSymySGQ5eQ3SXZNUcjdm0Gw63cbaNE2VG5DIGPsSsHTJJfowJu5hGmT0NyKQsetLu+NRHCTvHwyldyxDKc1/74zq687AUSpH0en7e9xF2AzTOy+qL1WooE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764813041; c=relaxed/simple; bh=tRhvoIKyb42yV6KlwWScJicOvd2+zvfd38Lli79BE38=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=bukcFbhyBrjQRaBkzMMnAMDNvVPmULGBijZjIFxdiRRBXSPvZmSYw00eyVU7Wr25aKF9ArkJWObZSEUvRPA6RsAWnHK3ndIRtpnlNFUYbzl4Po8GXMeEERhXOEN91LOysrof+mp/UG4L/rWSt3O+rebEMSflKuh+BHp7Fqt3htk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TWYW4ti9; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TWYW4ti9" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3436a97f092so442170a91.3 for ; Wed, 03 Dec 2025 17:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764813039; x=1765417839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Bi2f0uRChyGj6ugafTr27+ZC+WWnAEAMXr4AoMnk9zQ=; b=TWYW4ti9w8NkLmQHNrY5IkWzbeuEPJkSwylrJBmvkJU0yCmdnyTmsVPxWl2k89WnY0 Bz2Je+Fz+E0vF7tVWIxAg44puM80ivybRqnXDaYiWYEjC372MZ/e+BbAhb1d/KgcDI0e k6PhjopHDlasqgRPJ/LaZ3Mx3AmMqIc5QiYRSM9XKvI6LDGJM/BjI5VJjCn/vn38/bbz h11a1lrzNReW/UaE1D1WcOZubwkQXxJKlbJw5Ig/nDoCFDZ5yXGFBCRCcLTgsRSo+niS OYTU+FPp3VMDk1tW3to96nPdCw13Untg9pW/WW3j93FK+XLGDYsdgT8tBrVnr0+IkeBR a1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764813039; x=1765417839; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bi2f0uRChyGj6ugafTr27+ZC+WWnAEAMXr4AoMnk9zQ=; b=OsFx/gPhdz4lNAfc1snurQ1zaqfN5RvDDv/WJfzI1t+lDYq9LOJcGGoWkWbU0Bjepu bVmVPtA/HM2u8jdmup4rXqC6RYtrZ7xx9lMHgUw4HIytMmVIZNRt/c2AK6tD/KsvKYKJ SPOsIz4Ugqi10+Z3K4nIEtA307EW0QMB5LHtQxpvUsil4YPejsRmiEonqDpWfj9PJgKR gX3Tdl1o74Ie6owj9i134t6Zi/ovRmE+rnNomi1QOPnAb+lKDhSOzFpOA0NEYAE/3uR3 EGDhLNjEwFn1N/jjLYJWB8MZkkLqpMZ/fSS6fuC4rfToWEKTPIuIhfXlxsEjdN7ADjt+ aikQ== X-Forwarded-Encrypted: i=1; AJvYcCVhPXdg1vjJEivUhnbdmcoA16H62MsJTt2KwmBtlUPyB1+8MmynvIsJlYExVlFBmIrEfsDIPnluzwoU+Uk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyut0Yx4lG2hZXzOw651a8DQiDNk90nhi7RnX+6h8bMV5n6Wq6l wRZcLYDgKAC6THXBnv/nPggjkrvLWtxU2UYWd2XJgBuadi29nV4ooJDe X-Gm-Gg: ASbGncuY1hy4tNfYLDcdeJo2ZNo9GCqWR3m2h6iNseokN6JPZT/S3wr2A9FbNIP1POI Pt/OuYVjwwMSu1j+mQa65pu2b2H9o/yqkzKBN14roIeeY33eeG/p0DMUn2G2dfUwZ4yfW6n5I3t uyzSyC52lbF4VYGLqTlWfPhoPXafGmfpCfLi+AMXcHI6T6J9bixO7DVu0LhGG1B4ykZdlCgflSv 8+jwYYgHfeySAxTyj9c4BJLLxyAcWnJWoygrOhOkXg43O+SAuoDMzQmmE7AYZMwco34vU/jkISz 2roVUAGGRetRUGpWQh+B4lVtWSFPAzXX/gno4PRlSIOYRfBzaWPthPT3swfQN9xOHfliZ2lojUo 1CxWI1WIZya+xQ51KDnH7EJPW6HyFZb0wBO3bzn/RH3WsJiTETwmVabAVy11v8qBi5ChqxqM9BS Vya/7AVIhJizk6n8LP74Hp/Uk9mxF4UOq2LeFhfRU8Qjc= X-Google-Smtp-Source: AGHT+IFwM76BWKmkeHL4wr1V/4kuESlCwbW3oUtmXbOXn65/m2X3jtGdqqnbdflwI1cV4dGvYPp3iw== X-Received: by 2002:a17:90b:5251:b0:33f:ebc2:634 with SMTP id 98e67ed59e1d1-34947d88ed4mr954071a91.9.1764813039478; Wed, 03 Dec 2025 17:50:39 -0800 (PST) Received: from localhost (78.31.125.34.bc.googleusercontent.com. [34.125.31.78]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-34912a2d392sm1424922a91.8.2025.12.03.17.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 17:50:38 -0800 (PST) From: Chia-I Wu To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Grant Likely , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, tvrtko.ursulin@igalia.com Subject: [PATCH] drm/panthor: fix for dma-fence safe access rules Date: Wed, 3 Dec 2025 17:50:34 -0800 Message-ID: <20251204015034.841235-1-olvaffe@gmail.com> X-Mailer: git-send-email 2.52.0.177.g9f829587af-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 506aa8b02a8d6 ("dma-fence: Add safe access helpers and document the rules") details the dma-fence safe access rules. The most common culprit is that drm_sched_fence_get_timeline_name may race with group_free_queue. Fixes: d2624d90a0b77 ("drm/panthor: assign unique names to queues") Signed-off-by: Chia-I Wu Reviewed-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_sched.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index 33b9ef537e359..a8b1347e4da71 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #include "panthor_devfreq.h" #include "panthor_device.h" @@ -923,6 +924,9 @@ static void group_release_work(struct work_struct *work) release_work); u32 i; =20 + /* dma-fences may still be accessing group->queues under rcu lock. */ + synchronize_rcu(); + for (i =3D 0; i < group->queue_count; i++) group_free_queue(group, group->queues[i]); =20 --=20 2.52.0.177.g9f829587af-goog