From nobody Fri Dec 19 21:12:55 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521572EBBAF for ; Wed, 3 Dec 2025 23:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764806125; cv=none; b=hmU9Y14NsxymBqxrnBqAbA42HBILaqLz0qTV35r17dPPqAGLL86e3izUDZ4BFpXy+2dvrWmZKNRPLgIZ1HVfips3UYVnO66SthuEraKpGwRjh34T5qX3AFFlyfvkG7VfQQnpW+mRrZOzKLsjgccsNMFJ4BWPW5fAu4DvrWqS64o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764806125; c=relaxed/simple; bh=5lPAz5VlLI08P1uVjaFt1MkxmOS3Vp3ERDWnkGTatgs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YQYyuwTgiMFj4EbvhxWZ71+1JKU8OgrwUE+aP6sbuZJIYoKWPt+kCZ9pvYX6Y9Tp0fWtBH2atc0aZFHcs4nQu+m9QVWYu34bodSQglNwB+OVGucIjImZf2+XbRDiMbRsRBgVWdY84ioAQmTMwy6YfGNCRklRCBHZe4kQ/p/gOlo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=KQ7Grldz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="KQ7Grldz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764806121; bh=5lPAz5VlLI08P1uVjaFt1MkxmOS3Vp3ERDWnkGTatgs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KQ7GrldzSf5rOzTLlOp98QzKm6RHTMBjV9EtryNoie7syC0rCVUpp1UdoKm3XfyNW PYa5lb/uvfLWtJ5+nmTNMDuEiQBf5LqnewLHdFFkjUoaXDv18cJHLU6RnZDQzw02ZJ SqyZeNj1lsAIsWeBew+VU7EbLed61KIZcVQVG0Vyqwfxe1037aPpav/ike2JU3kC1j 0q+mFXKgexB6ub5xpGGWl7BS089AmksYr+jFvEWkI1sMygrJy+NiV7i90fHo2IMOJI QK6L5FWKMmDodSmBwWZHRWi30jdJyIXrpHgSax/KtpjIt0VgxQoeCSHWphMEqyE7Gi VaEauBjgpAVXw== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3FFBF17E1104; Thu, 4 Dec 2025 00:55:21 +0100 (CET) From: Cristian Ciocaltea Date: Thu, 04 Dec 2025 01:54:10 +0200 Subject: [PATCH 2/2] phy: rockchip: samsung-hdptx: Cleanup TMDS PLL config table Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251204-phy-hdptx-pll-fix-v1-2-d94fd6cfd59b@collabora.com> References: <20251204-phy-hdptx-pll-fix-v1-0-d94fd6cfd59b@collabora.com> In-Reply-To: <20251204-phy-hdptx-pll-fix-v1-0-d94fd6cfd59b@collabora.com> To: Vinod Koul , Neil Armstrong , Heiko Stuebner , Dmitry Baryshkov Cc: kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 Drop a bunch of unused members from struct ropll_config and make the static ropll_tmds_cfg table more readable: * add a table header * sort rows by rate * convert hex values to decimal (for consistency) Signed-off-by: Cristian Ciocaltea --- drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 81 +++++++------------= ---- 1 file changed, 24 insertions(+), 57 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/ph= y/rockchip/phy-rockchip-samsung-hdptx.c index cafa618d70fd..4b9b36c50623 100644 --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c @@ -336,12 +336,7 @@ struct ropll_config { u8 pms_pdiv; u8 pms_refdiv; u8 pms_sdiv; - u8 pms_iqdiv_rstn; - u8 ref_clk_sel; u8 sdm_en; - u8 sdm_rstn; - u8 sdc_frac_en; - u8 sdc_rstn; u8 sdm_clk_div; u8 sdm_deno; u8 sdm_num_sign; @@ -349,14 +344,6 @@ struct ropll_config { u8 sdc_n; u8 sdc_num; u8 sdc_deno; - u8 sdc_ndiv_rstn; - u8 ssc_en; - u8 ssc_fm_dev; - u8 ssc_fm_freq; - u8 ssc_clk_div_sel; - u8 ana_cpp_ctrl; - u8 ana_lpf_c_sel; - u8 cd_tx_ser_rate_sel; }; =20 struct tx_drv_ctrl { @@ -412,50 +399,30 @@ struct rk_hdptx_phy { }; =20 static const struct ropll_config ropll_tmds_cfg[] =3D { - { 594000000ULL, 124, 124, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 461101250ULL, 97, 97, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 71, 1, 53, 2, 6, - 35, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 371250000ULL, 155, 155, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 297000000ULL, 124, 124, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 162000000ULL, 135, 135, 1, 1, 3, 1, 1, 0, 1, 1, 1, 1, 4, 0, 3, 5, 5, 0x= 10, - 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 185625000ULL, 155, 155, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 154000000ULL, 193, 193, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 193, 1, 32, 2, 1, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 148500000ULL, 0x7b, 0x7b, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 4, 0, 3, 5, 5, - 0x10, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 146250000ULL, 122, 122, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 244, 1, 16, 2, 1,= 1, - 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 119000000ULL, 149, 149, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 149, 1, 16, 2, 1,= 1, - 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 106500000ULL, 89, 89, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 89, 1, 16, 1, 0, 1, - 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 108000000ULL, 135, 135, 1, 1, 5, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, 0, - 0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 85500000ULL, 214, 214, 1, 1, 11, 1, 1, 1, 1, 1, 1, 1, 214, 1, 16, 2, 1, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 83500000ULL, 105, 105, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 42, 1, 16, 1, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 92812500ULL, 155, 155, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 74250000ULL, 124, 124, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 65000000ULL, 162, 162, 1, 1, 11, 1, 1, 1, 1, 1, 1, 1, 54, 0, 16, 4, 1, - 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 50250000ULL, 84, 84, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 11, 1, 4, 5, - 4, 11, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 33750000ULL, 0x70, 0x70, 1, 1, 0xf, 1, 1, 1, 1, 1, 1, 1, 0x2, 0, 0x01, = 5, - 1, 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 40000000ULL, 100, 100, 1, 1, 11, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, 0, - 0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 27000000ULL, 0x5a, 0x5a, 1, 1, 0xf, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, = 0, - 0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, - { 25175000ULL, 84, 84, 1, 1, 0xf, 1, 1, 1, 1, 1, 1, 1, 168, 1, 16, 4, 1, = 1, - 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, }, +/* | pms | sdm |= sdc | */ +/* rate, mdiv, mdafc, pdiv, rdiv, sdiv, en, cdiv, deno, nsig, num, = n, num, deno, */ +{ 594000000ULL, 124, 124, 1, 1, 0, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 461101250ULL, 97, 97, 1, 1, 0, 1, 1, 71, 1, 53, = 2, 6, 35, }, +{ 371250000ULL, 155, 155, 1, 1, 1, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 297000000ULL, 124, 124, 1, 1, 1, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 185625000ULL, 155, 155, 1, 1, 3, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 162000000ULL, 135, 135, 1, 1, 3, 0, 1, 4, 0, 3, = 5, 5, 16, }, +{ 154000000ULL, 193, 193, 1, 1, 5, 1, 1, 193, 1, 32, = 2, 1, 1, }, +{ 148500000ULL, 123, 123, 1, 1, 3, 1, 1, 4, 0, 3, = 5, 5, 16, }, +{ 146250000ULL, 122, 122, 1, 1, 3, 1, 1, 244, 1, 16, = 2, 1, 1, }, +{ 119000000ULL, 149, 149, 1, 1, 5, 1, 1, 149, 1, 16, = 2, 1, 1, }, +{ 106500000ULL, 89, 89, 1, 1, 3, 1, 1, 89, 1, 16, = 1, 0, 1, }, +{ 108000000ULL, 135, 135, 1, 1, 5, 0, 1, 9, 0, 5, = 0, 20, 24, }, +{ 92812500ULL, 155, 155, 1, 1, 7, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 85500000ULL, 214, 214, 1, 1, 11, 1, 1, 214, 1, 16, = 2, 1, 1, }, +{ 83500000ULL, 105, 105, 1, 1, 5, 1, 1, 42, 1, 16, = 1, 0, 1, }, +{ 74250000ULL, 124, 124, 1, 1, 7, 1, 1, 62, 1, 16, = 5, 0, 1, }, +{ 65000000ULL, 162, 162, 1, 1, 11, 1, 1, 54, 0, 16, = 4, 1, 1, }, +{ 50250000ULL, 84, 84, 1, 1, 7, 1, 1, 11, 1, 4, = 5, 4, 11, }, +{ 40000000ULL, 100, 100, 1, 1, 11, 0, 1, 9, 0, 5, = 0, 20, 24, }, +{ 33750000ULL, 112, 112, 1, 1, 15, 1, 1, 2, 0, 1, = 5, 1, 1, }, +{ 27000000ULL, 90, 90, 1, 1, 15, 0, 1, 9, 0, 5, = 0, 20, 24, }, +{ 25175000ULL, 84, 84, 1, 1, 15, 1, 1, 168, 1, 16, = 4, 1, 1, }, }; =20 static const struct reg_sequence rk_hdtpx_common_cmn_init_seq[] =3D { --=20 2.51.2