From nobody Mon Feb 9 02:55:33 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB26521D3F2; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858928; cv=none; b=Nuq/dSWU6k+An0WD/UbqxUfgwFKWeHlxAmxAMBCzNeswvDsEMQlvN27jTWg9c65u9PuSG61REBVI35mH8T4i/X+dbca+PscJqoSdmGcyYaFgUdq/N6ZlRoDwjTKzP6vlmpjNr5JeWdVU34Vjv1vfOvsc6RtwSzn7YBXa8KByJBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858928; c=relaxed/simple; bh=jPeKXp5utHWCmJ034LIIEEaXgu0uiG6IuPhf7HjwWdk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TfOhJuUfbktccZiEm/bgBqUqjvdoc80+/UADbjf2JAW58UMDLVx/2NAesl/wDF45nd9vy2GrW9uFVZrULIw0tCZcqFGw41v090ofBbJmTvvHsiiebDicM4mkoZgLSFGGlykwC4ucFJfSec5SfTV6jpIsbWczZGjFNJwuq4EtRGM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VSXpnxh4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VSXpnxh4" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4A5A2C116C6; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764858928; bh=jPeKXp5utHWCmJ034LIIEEaXgu0uiG6IuPhf7HjwWdk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VSXpnxh410YNDq/GX8Gi3oyoJzhK0vc446t3WUFgciw3U5ygIXj27BDKZEICX8EU3 wAZ/9Y15GCAC7r3I5Qwz9OwyyuztEWqfD7f18ZYq17JoGb6vjqyKAULkdsnXr+hnBi rzy65SZ+NL1vg/TzDjwFKflhEGQvjcNAT4xXc+Gv9kHKoyJdWOxdHtqNwZQ1OdzpFc +FQ4obAB04hNUgP1mKf7yPVEtJ9Tj1kls0YT3LNCAXJUA1VEjUZVkUx1To9Ytg4maa kQ9LCNeJIceiskwEpe5ZQjJdpd2Foll3FBpfVXAGB3QXCPYH8Eoxe3XXgkCYgpAYP4 ODVgMg2P64umw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B91DD206AC; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) From: Petri Karhula via B4 Relay Date: Thu, 04 Dec 2025 14:35:26 +0000 Subject: [PATCH v5 1/2] backlight: Add Congatec Board Controller (CGBC) backlight support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251204-cgbc-backlight-v5-1-26f1be6a69c3@novatron.fi> References: <20251204-cgbc-backlight-v5-0-26f1be6a69c3@novatron.fi> In-Reply-To: <20251204-cgbc-backlight-v5-0-26f1be6a69c3@novatron.fi> To: Thomas Richard , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Petri Karhula X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764858927; l=7500; i=petri.karhula@novatron.fi; s=20251118; h=from:subject:message-id; bh=jPPzAj6k7o9cTUnE2JsI/iT2OWREzjVZAUPlsVbfUts=; b=Bk0GBhg7OudctdI8gFrYdiTWOjRc7a9wytfDUaHg4BndpHgXN6k/j1dsRbw4RnirqGTOQzCAH 1kp4ToYeZfBBj7sBvwFOVuKhEW2Kn+WZmOUlOb6xt66z5SZ9C+KUYFM X-Developer-Key: i=petri.karhula@novatron.fi; a=ed25519; pk=LRYJ99jPPsHJwdJEPkqlmzAMqo6oyw7I421aHEfDp7o= X-Endpoint-Received: by B4 Relay for petri.karhula@novatron.fi/20251118 with auth_id=567 X-Original-From: Petri Karhula Reply-To: petri.karhula@novatron.fi From: Petri Karhula This driver provides backlight brightness control through the Linux backlight subsystem. It communicates with the board controller to adjust LCD backlight using PWM signals. Communication is done through Congatec Board Controller core driver. Signed-off-by: Petri Karhula Reviewed-by: Daniel Thompson (RISCstar) --- drivers/video/backlight/Kconfig | 11 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/cgbc_bl.c | 180 ++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 192 insertions(+) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kcon= fig index d9374d208cee..702f3b8ed036 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -249,6 +249,17 @@ config BACKLIGHT_PWM If you have a LCD backlight adjustable by PWM, say Y to enable this driver. =20 +config BACKLIGHT_CGBC + tristate "Congatec Board Controller (CGBC) backlight support" + depends on MFD_CGBC && X86 + help + Say Y here to enable support for LCD backlight control on Congatec + x86-based boards via the CGBC (Congatec Board Controller). + + This driver provides backlight brightness control through the Linux + backlight subsystem. It communicates with the board controller to + adjust LCD backlight using PWM signals. + config BACKLIGHT_DA903X tristate "Backlight Driver for DA9030/DA9034 using WLED" depends on PMIC_DA903X diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Mak= efile index dfbb169bf6ea..0169fd8873ed 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -27,6 +27,7 @@ obj-$(CONFIG_BACKLIGHT_APPLE_DWI) +=3D apple_dwi_bl.o obj-$(CONFIG_BACKLIGHT_AS3711) +=3D as3711_bl.o obj-$(CONFIG_BACKLIGHT_BD6107) +=3D bd6107.o obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) +=3D backlight.o +obj-$(CONFIG_BACKLIGHT_CGBC) +=3D cgbc_bl.o obj-$(CONFIG_BACKLIGHT_DA903X) +=3D da903x_bl.o obj-$(CONFIG_BACKLIGHT_DA9052) +=3D da9052_bl.o obj-$(CONFIG_BACKLIGHT_EP93XX) +=3D ep93xx_bl.o diff --git a/drivers/video/backlight/cgbc_bl.c b/drivers/video/backlight/cg= bc_bl.c new file mode 100644 index 000000000000..ab27e14338a8 --- /dev/null +++ b/drivers/video/backlight/cgbc_bl.c @@ -0,0 +1,180 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Congatec Board Controller (CGBC) Backlight Driver + * + * This driver provides backlight control for LCD displays connected to + * Congatec boards via the CGBC (Congatec Board Controller). It integrates + * with the Linux backlight subsystem and communicates with hardware throu= gh + * the cgbc-core module. + * + * Copyright (C) 2025 Novatron Oy + * + * Author: Petri Karhula + */ + +#include +#include +#include +#include +#include +#include + +#define BLT_PWM_DUTY_MASK GENMASK(6, 0) + +/* CGBC command for PWM brightness control*/ +#define CGBC_CMD_BLT0_PWM 0x75 + +#define CGBC_BL_MAX_BRIGHTNESS 100 + +/** + * CGBC backlight driver data + * @dev: Pointer to the platform device + * @cgbc: Pointer to the parent CGBC device data + * @current_brightness: Current brightness level (0-100) + */ +struct cgbc_bl_data { + struct device *dev; + struct cgbc_device_data *cgbc; + unsigned int current_brightness; +}; + +static int cgbc_bl_read_brightness(struct cgbc_bl_data *bl_data) +{ + u8 cmd_buf[4] =3D { CGBC_CMD_BLT0_PWM }; + u8 reply_buf[3]; + int ret; + + ret =3D cgbc_command(bl_data->cgbc, cmd_buf, sizeof(cmd_buf), + reply_buf, sizeof(reply_buf), NULL); + if (ret < 0) + return ret; + + /* + * Get only PWM duty factor percentage, + * ignore polarity inversion bit (bit 7) + */ + bl_data->current_brightness =3D FIELD_GET(BLT_PWM_DUTY_MASK, reply_buf[0]= ); + + return 0; +} + +static int cgbc_bl_update_status(struct backlight_device *bl) +{ + struct cgbc_bl_data *bl_data =3D bl_get_data(bl); + u8 cmd_buf[4] =3D { CGBC_CMD_BLT0_PWM }; + u8 reply_buf[3]; + u8 brightness; + int ret; + + brightness =3D backlight_get_brightness(bl); + + if (brightness !=3D bl_data->current_brightness) { + /* Read the current values */ + ret =3D cgbc_command(bl_data->cgbc, cmd_buf, sizeof(cmd_buf), reply_buf, + sizeof(reply_buf), NULL); + if (ret < 0) { + dev_err(bl_data->dev, "Failed to read PWM settings: %d\n", ret); + return ret; + } + + /* + * Prepare command buffer for writing new settings. Only 2nd byte is cha= nged + * to set new brightness (PWM duty cycle %). Other values (polarity, fre= quency) + * are preserved from the read values. + */ + cmd_buf[1] =3D (reply_buf[0] & ~BLT_PWM_DUTY_MASK) | + FIELD_PREP(BLT_PWM_DUTY_MASK, brightness); + cmd_buf[2] =3D reply_buf[1]; + cmd_buf[3] =3D reply_buf[2]; + + ret =3D cgbc_command(bl_data->cgbc, cmd_buf, sizeof(cmd_buf), reply_buf, + sizeof(reply_buf), NULL); + if (ret < 0) { + dev_err(bl_data->dev, "Failed to set brightness: %d\n", ret); + return ret; + } + + bl_data->current_brightness =3D reply_buf[0] & BLT_PWM_DUTY_MASK; + + /* Verify the setting was applied correctly */ + if (bl_data->current_brightness !=3D brightness) { + dev_err(bl_data->dev, + "Brightness setting verification failed (got %u, expected %u)\n", + bl_data->current_brightness, (unsigned int)brightness); + return -EIO; + } + } + + return 0; +} + +static int cgbc_bl_get_brightness(struct backlight_device *bl) +{ + struct cgbc_bl_data *bl_data =3D bl_get_data(bl); + int ret; + + ret =3D cgbc_bl_read_brightness(bl_data); + if (ret < 0) { + dev_err(bl_data->dev, "Failed to read brightness: %d\n", ret); + return ret; + } + + return bl_data->current_brightness; +} + +static const struct backlight_ops cgbc_bl_ops =3D { + .options =3D BL_CORE_SUSPENDRESUME, + .update_status =3D cgbc_bl_update_status, + .get_brightness =3D cgbc_bl_get_brightness, +}; + +static int cgbc_bl_probe(struct platform_device *pdev) +{ + struct cgbc_device_data *cgbc =3D dev_get_drvdata(pdev->dev.parent); + struct backlight_properties props =3D { }; + struct backlight_device *bl_dev; + struct cgbc_bl_data *bl_data; + int ret; + + bl_data =3D devm_kzalloc(&pdev->dev, sizeof(*bl_data), GFP_KERNEL); + if (!bl_data) + return -ENOMEM; + + bl_data->dev =3D &pdev->dev; + bl_data->cgbc =3D cgbc; + + ret =3D cgbc_bl_read_brightness(bl_data); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to read initial brightness\n"); + + props.type =3D BACKLIGHT_PLATFORM; + props.max_brightness =3D CGBC_BL_MAX_BRIGHTNESS; + props.brightness =3D bl_data->current_brightness; + props.scale =3D BACKLIGHT_SCALE_LINEAR; + + bl_dev =3D devm_backlight_device_register(&pdev->dev, "cgbc-backlight", + &pdev->dev, bl_data, + &cgbc_bl_ops, &props); + if (IS_ERR(bl_dev)) + return dev_err_probe(&pdev->dev, PTR_ERR(bl_dev), + "Failed to register backlight device\n"); + + platform_set_drvdata(pdev, bl_data); + + return 0; +} + +static struct platform_driver cgbc_bl_driver =3D { + .driver =3D { + .name =3D "cgbc-backlight", + }, + .probe =3D cgbc_bl_probe, +}; + +module_platform_driver(cgbc_bl_driver); + +MODULE_AUTHOR("Petri Karhula "); +MODULE_DESCRIPTION("Congatec Board Controller (CGBC) Backlight Driver"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:cgbc-backlight"); --=20 2.34.1 From nobody Mon Feb 9 02:55:33 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1A65B5AB; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858928; cv=none; b=mzuMtTsNfiVyFRqj1dj4MfaHQFA8b4lIohi0AY4K5JoyRnov/yvjY8Izm0ASSpTF3X9RnPgAlMqGFvayXcz8rqijJJQCH9DLRj6h3DD4MTCCphpU79G/5WFynxKU0YUwj0d2XguZx1gJQa+cgiZwJAXtImIxK+W8Csg+raHoG4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858928; c=relaxed/simple; bh=jcPepnZLZgpDua5txvocFEmcFpPGA3RIdeogtsflON8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z4mrD3r4YIQ8gUDk9ZJJ0FMQQfO1ZjnpCTOTGeWFsFiMdOuTfc6vPi7459qLgA/ypX/vYhDzjRF30ffVuKOXYyc5F3By2nEWAQQsN0UyNI5CSFozbl53Hmqc+us4x6m3i0BxLpqd3k8xSNi/uh0NUQuDNBZjs6LKMILPwUA9QT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qv3J2RDL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qv3J2RDL" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5A52DC116B1; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764858928; bh=jcPepnZLZgpDua5txvocFEmcFpPGA3RIdeogtsflON8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qv3J2RDLwPlkbGtjD7fB8ZxiEBr1/tQ1zXFJtXLkt2Le/h+/PGf4lodjfJiVob+2p b/VPSyHrw7b0+Z6OPp5JEN06qvN8ltpfqzFt4QLT9My+iWF6JRXIaDQ/1+kwxd58O/ oLEtHaG4eCzTsigp0uVSoWpu548QgZrG3z/HdH+n4zlvwnufM9RvSw8M90v1aD8C28 qSItcXzI+YfTKiPsWoHoeAK2CcfWg3ExgU3X071gfnjPRkJ5Uo3pFjXcARg+KFoKJ0 V+fOWcrHRgo6cqI24kKK2UzUTk/Yw+zW23qs2cqwtU8rPCQxKnY6fCc3Mv+J35Osme ktrovyxVz1QAQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4D6D206B2; Thu, 4 Dec 2025 14:35:28 +0000 (UTC) From: Petri Karhula via B4 Relay Date: Thu, 04 Dec 2025 14:35:27 +0000 Subject: [PATCH v5 2/2] mfd: cgbc: Add support for backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251204-cgbc-backlight-v5-2-26f1be6a69c3@novatron.fi> References: <20251204-cgbc-backlight-v5-0-26f1be6a69c3@novatron.fi> In-Reply-To: <20251204-cgbc-backlight-v5-0-26f1be6a69c3@novatron.fi> To: Thomas Richard , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Petri Karhula X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764858927; l=730; i=petri.karhula@novatron.fi; s=20251118; h=from:subject:message-id; bh=KPNSZCbWidPbzGQwgMCbuFj/C6Dnnhi7zAXThQ+Pso8=; b=qodL7XDtf8qnh34WGfen5MG7V/8ECPtObHwrm0SZEeQ7KZYuXD00kUX91CRBxrVkTBH+KPESd tUPwb80sfWgB5lJeyV3gkaXjleoV+IOHUAMvMhAkfirjJ/j5kbwOpzV X-Developer-Key: i=petri.karhula@novatron.fi; a=ed25519; pk=LRYJ99jPPsHJwdJEPkqlmzAMqo6oyw7I421aHEfDp7o= X-Endpoint-Received: by B4 Relay for petri.karhula@novatron.fi/20251118 with auth_id=567 X-Original-From: Petri Karhula Reply-To: petri.karhula@novatron.fi From: Petri Karhula The Board Controller has control for display backlight. Add backlight cell for the cgbc-backlight driver which adds support for backlight brightness control. Signed-off-by: Petri Karhula --- drivers/mfd/cgbc-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c index 4782ff1114a9..10bb4b414c34 100644 --- a/drivers/mfd/cgbc-core.c +++ b/drivers/mfd/cgbc-core.c @@ -237,6 +237,7 @@ static struct mfd_cell cgbc_devs[] =3D { { .name =3D "cgbc-i2c", .id =3D 1 }, { .name =3D "cgbc-i2c", .id =3D 2 }, { .name =3D "cgbc-hwmon" }, + { .name =3D "cgbc-backlight" }, }; =20 static int cgbc_map(struct cgbc_device_data *cgbc) --=20 2.34.1