From nobody Fri Dec 19 19:32:45 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93049306B2E for ; Wed, 3 Dec 2025 18:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764786002; cv=none; b=uDM9U4duWnYY0wwuHnaoB3atIdNMCe/u3KuvUC5vyf/4gCuaZgSKOI52eA2S/631nXh8QAAsJ+F2ivKId0PvR9tAm6GTQm/3WSG1c798WUMh1LalZEV4Grmu46NUrhoExxD3p9FF21zCCAS+JcizOiA+Yak5jf7dFI4lbtG1I+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764786002; c=relaxed/simple; bh=H8AwiHRnq/MCnVsoklQdec+4YNyo2HGWFkIhf2lY4gM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HFQCGtCoYU+BfDYVGsLVwhcQChk2Sb3bXZjhPfhoM44oXdSkXlz1y/222xJD0resBKKgldOEX2Hv3GHNNwz7O6HURC5zVHjnbbs8vdE8z+YkdtYM4rsXM6YGUJJTiatdEJ5Ts9OGvESQUaP56ixkxcHsx4piNqVGrDg0Kd+whSI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CV7aHWaY; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CV7aHWaY" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so468345e9.2 for ; Wed, 03 Dec 2025 10:20:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764785999; x=1765390799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v9ZHiU1o0pJELuts86Z685yYz9R3gCIIvwtPmT4YfOM=; b=CV7aHWaYoUutndKZ6ZKahT/7buLw5+eS5p8gaDQTvzfbK9uewq+dp1vsnCbPqAVXov BvffHkLXZJqzqPPbLPZ3Sx8E4gZVSdPKBtVn6jpss32F1xMyN2Hv5ZiFlsB1XNIJb/Op UMjgsc1MT7Y5fm4sOKTFnSp8qA26TsDGXGT3xj1umJflgVVQ+k9xhLtzAnqegXZNfY6i OXEnku6uch+gAjiIyVBjwfTF98VYcWGKF6V90wNXEtg/1ZXgtH3KFVFy9LmIXTpKb4u0 UuNjOpDBeRbjA5ZRCIQih9Hepi1XnFxnl9Mv71iaUcOe5p6g05Y+xfimrt+vea9lIXhI hl7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764785999; x=1765390799; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v9ZHiU1o0pJELuts86Z685yYz9R3gCIIvwtPmT4YfOM=; b=HFNo1tzzfvLUSh/JVQjk9CUtTFGTyIyL55YP941kjUEFkB+xJhWsF2b+ovnrgjdm+W wWB0xmGXP6wuJxVhohHDygpEvOfK4agMFXMxhbRIzBhi5vncf4eIROTRYvxyQkglFjAg sIQPjfjZ6m8J/1dwTFWbyU0adtozSqCpthtzt97odjLBOIvS+Aw0uBLNiMfURIoWn1kc imf1nDmKpC0LorpbWf4jA2f1Fa/7rt+PF960BlIZVaQXV9Y4Aes2qC0hXiFSpgiBruTg wRyxMhhw2HJYfCvf7/ilQ+2U67EQw4FkjMjrv5EPIKmaQ8q7USTPR8pqCcxW113OBq3Y 6o7w== X-Forwarded-Encrypted: i=1; AJvYcCVjlFh3KAXua/LujIH9Uc0Ry67eezadvbfGcHU/jJ6vF/7KmaAkAse/x0qxHpdIoRJlWOH9nYjy3bcI65c=@vger.kernel.org X-Gm-Message-State: AOJu0YyywiTIR1N0hkv0j8j6cj250ToCX5n1MQJL6i0LYsK2mHc77y8S 458DHg36eMfvxTPhjocLnsTDrsdHRrPC1EpivY4Avn7hJCLkbD+JAx3m X-Gm-Gg: ASbGncvOZCfp72C8hGIBQT0Cajel+e6dOvUaSHTOAEQdNrIOKNByawza5oJLlERxrUl EyVBjc9L3DvLnoFONbfIaxTJYVxWjX3/W6rNLI8yo9rwmK65Bvuf0KtucDTIFhVlWSg/oxRb82o AUiD4eee0tkbVlAU83GqgkwmF4UPwkHCnY2Ti8C21hCt+i9wDN+S1JBI9zbIYqc4Chs61AUfPWg WCwEKR1XerPUlXj9J4otyeQfehYM+ZdPeJQcuXjXK/zPCFfdjdBa9iIJmLQyaRgc7l/QhbWNThj kfKGDb9E7UBU3rlvBqqiPGCKFSPoK0vRwmMUtEx6wfO+eMoNazP254cxmcgLcKPg/coMpHayOO9 VfmkVsLqaFe8yHB3Yp88NLjyE9DTutyKxPiat9bOEhCWp5EWNJ8CW5ErtrRjjBS+DpUi51YjQ5y +81a1576o+Sd476OAWvFLs0fnitdfVULJWclUFAUxEdp2FCLi9TSiNgA== X-Google-Smtp-Source: AGHT+IHZKgnW9x4VKIYpwKAtdK+00D4dW5+LduzrrHUqeHH4B0Fqr8ROUycf8i6Wv6Rqr/yc41RSiQ== X-Received: by 2002:a05:600c:1d0c:b0:477:9c73:268b with SMTP id 5b1f17b1804b1-4792f39cc97mr171025e9.33.1764785998691; Wed, 03 Dec 2025 10:19:58 -0800 (PST) Received: from akif10xe.. ([2400:adc5:14f:4100:f44c:7909:c68a:ff47]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4792a7975c8sm68766565e9.1.2025.12.03.10.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 10:19:58 -0800 (PST) From: Akif Ejaz To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, alitariq45892@gmail.com, Akif Ejaz Subject: [PATCH] spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call Date: Wed, 3 Dec 2025 23:19:21 +0500 Message-Id: <20251203181921.97171-1-akifejaz40@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The pm_runtime_mark_last_busy() call is redundant in probe function as pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy() internally to update the last access time of the device before queuing autosuspend. Remove the pm_runtime_mark_last_busy() call from the probe function. Tested on StarFive VisionFive 2 v1.2A board. Fixes: e1f2e77624db ("spi: cadence-qspi: Fix runtime PM imbalance in probe") Signed-off-by: Akif Ejaz --- drivers/spi/spi-cadence-quadspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-qu= adspi.c index 638edca3805a..bf0677949ba8 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -2011,10 +2011,8 @@ static int cqspi_probe(struct platform_device *pdev) goto probe_setup_failed; } =20 - if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) { - pm_runtime_mark_last_busy(dev); + if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) pm_runtime_put_autosuspend(dev); - } =20 return 0; probe_setup_failed: --=20 2.34.1