From nobody Fri Dec 19 19:33:22 2025 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C3D3254B9 for ; Wed, 3 Dec 2025 23:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764803306; cv=none; b=sqXgrd9eXLRwUH5gIJz5v5HpnS596ZopIiP4whUQ0h0jk/h2zdq7WzqUkV8A+GmbvskEWku/4Hy/BXbI7RWKShPWRnytnHeGR4wsQuP+mxLz20bQ1KzGcm74vbGNS+2CszZ5Nww9zHKIT9MmLLwfHK4+bgGhuSD5wZTGGxAExE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764803306; c=relaxed/simple; bh=kAuLkSJxYp7cuKuaQPJkcRsbqs0N+yrytleAHB7qlK0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=cedPUSds0foJrUB+u05LZZDzi4YubDENP9mBMvChh9PLUm6QH0XR1DiKVhbR9N7wR0lRl5xKuF4W2rfpTDNuP3iLlMJd3ZAe6dD8W6KtfRGrj2jqaMu4q7xmqo5g0ITljqvhC+Gsu2/b4wCQZ+lWXubZk5W0TW9hoa7vs2FhUDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CBAC9133593; Wed, 3 Dec 2025 23:08:22 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf18.hostedemail.com (Postfix) with ESMTPA id 5AB5832; Wed, 3 Dec 2025 23:08:21 +0000 (UTC) Date: Wed, 3 Dec 2025 18:09:24 -0500 From: Steven Rostedt To: LKML Cc: John 'Warthog9' Hawley , "John W. Krahn" Subject: [PATCH] ktest.pl: Fix uninitialized var in config-bisect.pl Message-ID: <20251203180924.6862bd26@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5AB5832 X-Stat-Signature: zzegj9mij3i3kme88gzgmo3mz9q81aeu X-Rspamd-Server: rspamout08 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19GqUcOUKhEuB7W9Bn5OWdcsCjNfLJ4fmk= X-HE-Tag: 1764803301-320684 X-HE-Meta: U2FsdGVkX1+9LINdW0gpFbH169C7/6Jd0FSnzcE6lu3cluEQfZAvmfdAMdtaOePXSackxcjDiBc56W5gTTCcZ0koXiTj8ii0kt6F0IBBmFD/F98tKuOVrW0B5MNigvpQIqxvJUYchAj8MRwDgsRyf8YsB+ZLhULW1t5RR6BG+jrdCS88czCz9gBL87U62rzFYoPbRw4MFFnTKzBzgmngCXqlpBTxI3SFFc5y9XCO5aDK2zvxiWMi6Mtb81guZrUmUj7T3QBWql2CNUYZbsig3u3IsbNxPBZDz5dNnfgIVT2kJ2hiu9s+5cTfKB+lP7koQ7qohlBeoYNnJwHphN10OaiRE6ZW9YLuFpUBzVRTS0M0ssD04phk7AYiMyT9nXrvSaDyGnlGllc0j5QSNTAuuQ== Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The error path of copying the old config used the wrong variable in the error message: $ mkdir /tmp/build $ ./tools/testing/ktest/config-bisect.pl -b /tmp/build config-good /tmp/co= nfig-bad $ chmod 0 /tmp/build $ ./tools/testing/ktest/config-bisect.pl -b /tmp/build config-good /tmp/co= nfig-bad good cp /tmp/build//.config config-good.tmp ... [0 seconds] FAILED! Use of uninitialized value $config in concatenation (.) or string at ./too= ls/testing/ktest/config-bisect.pl line 744. failed to copy to config-good.tmp When it should have shown: failed to copy /tmp/build//.config to config-good.tmp Reported-by: "John W. Krahn" Signed-off-by: Steven Rostedt --- [ Better late than never. John reported this to me back in 2022, but I kept getting distracted before pushing it forward. :-p I just came across it again in my INBOX (I never archived that email) But my INBOX has 8000 messages in it, thus it probably has more of these = :-/ ] tools/testing/ktest/config-bisect.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/ktest/config-bisect.pl b/tools/testing/ktest/con= fig-bisect.pl index 6fd864935319..bee7cb34a289 100755 --- a/tools/testing/ktest/config-bisect.pl +++ b/tools/testing/ktest/config-bisect.pl @@ -741,9 +741,9 @@ if ($start) { die "Can not find file $bad\n"; } if ($val eq "good") { - run_command "cp $output_config $good" or die "failed to copy $config to $= good\n"; + run_command "cp $output_config $good" or die "failed to copy $output_conf= ig to $good\n"; } elsif ($val eq "bad") { - run_command "cp $output_config $bad" or die "failed to copy $config to $b= ad\n"; + run_command "cp $output_config $bad" or die "failed to copy $output_confi= g to $bad\n"; } } =20 --=20 2.51.0