From nobody Mon Feb 9 04:46:48 2026 Received: from mail-qk1-f226.google.com (mail-qk1-f226.google.com [209.85.222.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BD1C2F6167 for ; Wed, 3 Dec 2025 11:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762214; cv=none; b=MyZymZkooBGB30A6LH6vjLq6yQUm5BJGVJSu93LTZ86+7bGKRrKURGvdsOigqtoUoYyG7053QEOQNusHyvFMGBGyt+i7JWEJHX5/si8Znx5uoDUuEmFi2ZR73bE9uuSIWBd0Q6b+XAvbboQp6O7NxZrogXVzQ8ajfurd2uDH7cE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762214; c=relaxed/simple; bh=4J7PIolAnA+0ar2aFpYpjYwUmB3rJDZiGwj5VvC7eK4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WQqa88m2IzqhoqZZTk7pVXXxKhM87Am9VVm97l7Ka/Q2U2nGFp8p+lyoJ92nE29dkd5HU9D0/NVoI3LVSv2u+OAIA82k/AffF78gTHco90FGGKUkt88BANpb+1pZui0OVq48N0hjhBmYybDuGgXUSrV7/LXIJdT9qCnH9g/R144= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=eCvtRU7S; arc=none smtp.client-ip=209.85.222.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eCvtRU7S" Received: by mail-qk1-f226.google.com with SMTP id af79cd13be357-8b2d7c38352so88245085a.0 for ; Wed, 03 Dec 2025 03:43:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762212; x=1765367012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ciwg4/3mhwvtZ0RPA5sXQX/xfpLeKOSvzNQ2tetDUpM=; b=vZ3LCQxwxsEtpryrvPOyYkd3CavF488qm5ymUozrk+Bd0DGBBKSw+wH+qOtnh5K51g ww9jHbzJWZ+R9xrQ22DpSAsVJGnOT438B+6pYPXFc7MIjcr2YaPjV+FjsaGEbX/g+UDO 5nMhqRTAiYhpffYfdRTRXEMeu28EstWIrlLr0i4bNLgrN/hYKJ7JV590AUNPJlZiTVGY /I38Et8B+WvUgYB2xZek3rZbBNOvf0EwVKe7BIux5KUY9xY5n9/eMJ4Dn66g+Z720B8J phGJesCyqbJDR4IbfvJnoeucatK+ihAKZ8Hek6bBDlbczo9/Q5Pi+74totgs+LsSc9jW OXkA== X-Forwarded-Encrypted: i=1; AJvYcCX31Sw6xnH11EK3t4jgAR03dBo1Mw0vyL26I9XORnT/VV1CwzZ3jTmcmKfhBwYw0axFZZeLC6fJPFJ69s8=@vger.kernel.org X-Gm-Message-State: AOJu0YwOdCcNEChTyQr5mN4uhp9WI7jBIr60fDAoe7hpXiloGrugrY+T dnmzY6X3RoOBYTi0uOrFltnafYZfxtHJjGIg7/BFrkODLxx5ZXDfhIEMqpym8EOkE5pzBtAHj2o FydbNlTs0g82lHfQFwdPmMAV41pgdql6tJwym/SkRTq5OR+U+qQi/k2aTXLy4FN8FDZ07mx1oda aFcy1dAwUrE9UNjBZn5mu1WmHAeO9EsT+vE7w23IbWeBYWuHiYiUyO7zL2WnPOAAkrYTWMm0iER 8SToFxB/b3Scfo/HeI= X-Gm-Gg: ASbGncsz9zPTZpjcxH8OIwBeo7rK3oDysBgp9+apfTnkr3tLb6eTXR+ruRdFT4t6Prf Gmz03Doj6wpCqE0xCvPacliKrcL0b9dHdIDobYxwDz1B40ue9YdEocAGv71FYJByk8OOsV5NQsQ trFRzskrV4YvkJVtc0ZcIJ23i/W5NuYj6Sf0pkHV7uYmyHq1sIcGmPvBn8uK7Kit2H/85gZiZFr OJOYdUYTBV0YcA9pV5kBliXCXCIyCgURnMFKK/chknCOMvWWIz748100hZqCVxH6wUn0oE0eXk7 dj1OJDnJ61vMrlc4kR4ukWUPDuvyjbwKb9fuoId6io1zkX8WOfsglDjPfff2FbRJVuKJeSU1XSP 4uVu+jOi5DYsXRAYavgCSlzmEHU7f2sg2h7dMQRqnQ16G1ZjppSnGtep5XWjld7OxJjivDe/owy qDrjDyk09pMQIlWBJGNn1AgtVFWciyjwAIh+4crgYDaA== X-Google-Smtp-Source: AGHT+IFUWAr9A8B5jlhTOa393+FIu6H5ZGdXbhm4tkfR5uog0aHPs8l0AbI84LsI0dY2/noUU4N1VuR0gtth X-Received: by 2002:a05:6214:53c9:b0:884:70ed:5414 with SMTP id 6a1803df08f44-88818d0bdf3mr35402466d6.17.1764762212037; Wed, 03 Dec 2025 03:43:32 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-88652ae6291sm25177866d6.17.2025.12.03.03.43.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:43:32 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b55a033a2aso190795285a.0 for ; Wed, 03 Dec 2025 03:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764762211; x=1765367011; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ciwg4/3mhwvtZ0RPA5sXQX/xfpLeKOSvzNQ2tetDUpM=; b=eCvtRU7S2TvoYVerT7b6TmljL9Gma0+FVwnVaYKew/yGaH7ChZcJlSJjMoK+hn9Msu R1TJejhYZw+w9qyjT370GQkgsmC4s/sRnI5r6D2uxVCUuF5VZE2vOyns5rB2yMJFF4Wn faqPACpF8KPZ77Y+NMX1Am5+A3K/1tWdzbxOQ= X-Forwarded-Encrypted: i=1; AJvYcCUZ03axK5Il3VZ3gpoZd3Z+nKAlcv5GhpbRO4g0zIHRqR2b3WbeI18G9W2qbo8RYnuMN6D8WKDjv7pAU9g=@vger.kernel.org X-Received: by 2002:a05:620a:2681:b0:8b2:dd78:9288 with SMTP id af79cd13be357-8b5ac0684b3mr900416285a.13.1764762211384; Wed, 03 Dec 2025 03:43:31 -0800 (PST) X-Received: by 2002:a05:620a:2681:b0:8b2:dd78:9288 with SMTP id af79cd13be357-8b5ac0684b3mr900413085a.13.1764762210951; Wed, 03 Dec 2025 03:43:30 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b52a1b65bbsm1284727985a.33.2025.12.03.03.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:43:30 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.1 3/4] sched/fair: Small cleanup to update_newidle_cost() Date: Wed, 3 Dec 2025 11:25:51 +0000 Message-Id: <20251203112552.1738424-4-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112552.1738424-1-ajay.kaher@broadcom.com> References: <20251203112552.1738424-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit 08d473dd8718e4a4d698b1113a14a40ad64a909b upstream. Simplify code by adding a few variables. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.655208666@infradead.org [ Ajay: Modified to apply on v6.1 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9a7aa83ca..2f296e2af 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10937,22 +10937,25 @@ void update_max_interval(void) =20 static inline bool update_newidle_cost(struct sched_domain *sd, u64 cost) { + unsigned long next_decay =3D sd->last_decay_max_lb_cost + HZ; + unsigned long now =3D jiffies; + if (cost > sd->max_newidle_lb_cost) { /* * Track max cost of a domain to make sure to not delay the * next wakeup on the CPU. */ sd->max_newidle_lb_cost =3D cost; - sd->last_decay_max_lb_cost =3D jiffies; - } else if (time_after(jiffies, sd->last_decay_max_lb_cost + HZ)) { + sd->last_decay_max_lb_cost =3D now; + + } else if (time_after(now, next_decay)) { /* * Decay the newidle max times by ~1% per second to ensure that * it is not outdated and the current max cost is actually * shorter. */ sd->max_newidle_lb_cost =3D (sd->max_newidle_lb_cost * 253) / 256; - sd->last_decay_max_lb_cost =3D jiffies; - + sd->last_decay_max_lb_cost =3D now; return true; } =20 --=20 2.40.4