From nobody Mon Feb 9 03:49:07 2026 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B2912F5A03 for ; Wed, 3 Dec 2025 11:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762212; cv=none; b=Yg3vghP9KzqcVROBFLfARPz8UR5gFn6RbFqdJbb0UXOViwYtxIXcXAIjPxFQedGsfXV1h2z/lCzivG1n2zwSWmCkBTlb61OwLG3gLeKQk7h5ZUYAgNI3X6YEanU+crYpylEnFzEJZGPWt0IsusBkvCfwCJ88OUOxkDrGYZnM5xw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762212; c=relaxed/simple; bh=6CPDYjvsBfV3Kcd80YC7yRDSERboeJo3FZe5VW1pFCQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uPonpTSDqc5XVeWGahHnZkNB1GfnO8VH/QFcQbYmgtTXMlD6p/xiFJCF9zJilrL3PZZiw+tHHSiZoHA20WlMQkbeIp2+VecKFzTNx+n4qFMoncnaR9r1f4I+dcOvR5WqBF5LTRn297SLmNeSkbQE7Y9yDr/QmQVPr8PJ0nDEl1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=RDrzF7S+; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="RDrzF7S+" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-297dd95ffe4so58329395ad.3 for ; Wed, 03 Dec 2025 03:43:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762211; x=1765367011; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zG5ObQTvL5bWOa2rL3As4NqAHq0IGlQkowqc9ibYGAQ=; b=qKFrVMYhhMLMRZAtDnA9g78U2rQhfKecbGfswUxyNYWBi1HJZdw9ZanJKwj3Qs1uxV 5MT47bsoVG+fvf5vn5Pj6JHVOI8kT0aSnRXul5nAFxVk9LfhxVjDQXEABBtCf9bNwfES ajrZyxoVDPXFxyxsv6vBi04l8/UNjQValABnOCuYTkmfY7GH+bSD6ubWjMuvWWeGle5h 1CN+jUnZR+oRG1+XEE+gOBHmC8ft3XrCnwgScBX7kPeyCY9VNUj23a24mXiizLT1pkE3 GgaPxKcogwsLjhbsFoWuN9RmG2mNcyB2PInWUC7GOHaDWYqh0D6yEl+Y/K3Yqbur6WYd bG0g== X-Forwarded-Encrypted: i=1; AJvYcCVoT2bha6Im5js+12+4Y2U3c9oV3LCAG6ChTmUjE2wWLFGUgOCYC0Mz+gk5ANVcoV+M1fEQZRrM6T3VeSo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4ViqjNJVEBsTm57BSHiL/YM+erpBBJHY9KpfWXedo/bdQrBdq 13QKGVdpA4ebaXhLgXYVY40u2GXbZLvZdODPbb4JsWwcazGj1QU+/OLLTIILJN9jU1hffRZODCv JZS0dSLKRqo7Sqjpg5qQQgFLgrXEX1CHy/Ed6Z8Mn+R3/Lud3TazMBYGxJ7hSX1u/sdqmvR94ME 9pPzlODsA2Ojz744zpQ/o9bi0syZri2S7LckrRJdQmdGEetMtu4qOSKC+pkcIE98WdF3biUw0EB NIa4A+XIdZ+LI+v7po= X-Gm-Gg: ASbGncuKN4Ax6iRlpHMi9gmIKGgqgR/waYpYRTJ9/qpPDnYMI7BZj/3jCGqmsmGQLm8 CmAPGImuWvmCtmbxK4bBbuytVElAPpwl1N1/Ebs2qCNW1gBq581eCz05frpzKCOVo1l8iVpSf65 LIdt+h1cmTtUR4prs0rogXiQ0ov9jhBNhJsXT4B3hyX23/7GGrDS48hhRyBrL+ti0NPfim7hZut pC+AnQigWNPx71O/9JaIgAoXmNS3epXTI3gum4iCubXfkfIr5/Lxt7cGx2DN9v1nd8DxnskO/HU wKs3elSUxjWv0aOqsRuIOO8gaYVmUoZo6v/nhhz+Rk0aW7+j4FoTKGNXeBKvJp9LUpN/QPovPZL kdR90Ec6zjVqT0pMFkuFQh64rT00k7sZWaYnUTzFkKgCEpsBh/UqLOcKaHpVUjBT3tmN5gzk2+I NZAZ1FNkJFlbS0Fd9dWCYSnlkEyNvA4DFO9JxN/H0zrl4C X-Google-Smtp-Source: AGHT+IEiviN8Zjgz+aphRSFSB0qz3HmTHB7lRb/q5V7/C1cVkU4sdSwXHHOGfwe/eJo1iRocc0+aF5nvAfro X-Received: by 2002:a17:903:987:b0:298:33c9:eda1 with SMTP id d9443c01a7336-29d683f42f2mr19718745ad.43.1764762210655; Wed, 03 Dec 2025 03:43:30 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-29bceaac314sm25223545ad.29.2025.12.03.03.43.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:43:30 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b2e4b78e35so1277920285a.0 for ; Wed, 03 Dec 2025 03:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764762209; x=1765367009; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zG5ObQTvL5bWOa2rL3As4NqAHq0IGlQkowqc9ibYGAQ=; b=RDrzF7S+U/fsXbSOW2mHGkPI4c/dhEacqtxeabgXKZh0NRO/miYdEevVZlQDIBjGPz 6Kgy73myU/tp9pFxCxaEdC0UVLC5UFffsZcPEOdqnct3PcIKMyjPEyOKirdd+LN4UcWn SetzctYQvombdU8HifKyEQd2Y7jayoVWzHZjY= X-Forwarded-Encrypted: i=1; AJvYcCWZVjxlDse1HtJ/Q7SrZZ2mHyYKd1I2uQ+YiQIucYUbRSBpV6gGSTtMQQKwVkSKIMl4sGLNaQPcPIQ00eM=@vger.kernel.org X-Received: by 2002:a05:620a:40d4:b0:8b2:d26f:14a8 with SMTP id af79cd13be357-8b5e47a74f9mr206606485a.9.1764762209423; Wed, 03 Dec 2025 03:43:29 -0800 (PST) X-Received: by 2002:a05:620a:40d4:b0:8b2:d26f:14a8 with SMTP id af79cd13be357-8b5e47a74f9mr206596985a.9.1764762207862; Wed, 03 Dec 2025 03:43:27 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b52a1b65bbsm1284727985a.33.2025.12.03.03.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:43:27 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.1 2/4] sched/fair: Small cleanup to sched_balance_newidle() Date: Wed, 3 Dec 2025 11:25:50 +0000 Message-Id: <20251203112552.1738424-3-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112552.1738424-1-ajay.kaher@broadcom.com> References: <20251203112552.1738424-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit e78e70dbf603c1425f15f32b455ca148c932f6c1 upstream. Pull out the !sd check to simplify code. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.525916173@infradead.org [ Ajay: Modified to apply on v6.1 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f5a041bc3..9a7aa83ca 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11589,14 +11589,15 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) =20 rcu_read_lock(); sd =3D rcu_dereference_check_sched_domain(this_rq->sd); + if (!sd) { + rcu_read_unlock(); + goto out; + } =20 if (!READ_ONCE(this_rq->rd->overload) || - (sd && this_rq->avg_idle < sd->max_newidle_lb_cost)) { - - if (sd) - update_next_balance(sd, &next_balance); + this_rq->avg_idle < sd->max_newidle_lb_cost) { + update_next_balance(sd, &next_balance); rcu_read_unlock(); - goto out; } rcu_read_unlock(); --=20 2.40.4