From nobody Mon Feb 9 05:22:33 2026 Received: from mail-ua1-f99.google.com (mail-ua1-f99.google.com [209.85.222.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1602F5469 for ; Wed, 3 Dec 2025 11:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762209; cv=none; b=KQF+f9RjlnW0Udm6VYfBoAHL8cgqcDw56IOUTW/+FKuq/NGZ9aiB+LAWD2nlalOT4kBTI0BEtJrlBC+aYQyCh9pTc1mwHMKbz3zzhRkpfgBgDAsDTwrxRIA5abhRoVDW7PALXauNrLBJqFxVbqcOaH4dAyTRNA2U0ke8+5klFSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762209; c=relaxed/simple; bh=0haK8KYriPaTG6SlT0IxDG6YPomgA9ogsrkebaJgMvY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Src8SJ4u4nmSU7SQZdLa1GhKcRzYeK/WNZnOynHbnZYsPU/zYqla/KOemn4gknoSCFcAY0VmCwcajscGk444FtXaXPCgORcst4Z0NWaY6BLiiCQpIQJB9yULGPKvMIsKWNq2OpnTtw+5O5/BBbXGwWRw2RBKRM2ojS+2IF/d1t8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=c33GpDac; arc=none smtp.client-ip=209.85.222.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="c33GpDac" Received: by mail-ua1-f99.google.com with SMTP id a1e0cc1a2514c-93518a78d0aso3470049241.3 for ; Wed, 03 Dec 2025 03:43:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762207; x=1765367007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PH4ANwBhxoAuPZERs6KPB00evBiCDrU2sux4zg9pefE=; b=wVLzgiMQElO7SVNk2XvowBJjBKAcL1dU7StYOMi1kjFkwH3PgIVPC898ePter1g+1P d7g/bGJ+7eii1SqC0ATFRZj2lcBUMAYfqFZn+L3QaJega3pzccNDoljQgYV0Rk6R/VC9 nGTjcPCl4ciQPQKyPFiTzI3+BFv4EaglHoOet4loQwJa817feTFwgbg9/PI0Qy4H95r/ wEabFiHHqFmTdFcbo1tG+fRfGJIsl1LvUQSKRDT7+4frDa51xUQDtwpWupElShE1jtrW 5Eoe5uBU0pRFOzcVHcl6DGsPs40RNYBR3SDVj02dg/VI1udtnIIrd6EPZFIKtAuuOKdA t+AA== X-Forwarded-Encrypted: i=1; AJvYcCUDia7WY9Ed/iIk0T5kTJG7zfN25nwHxHMAMxfr8+FoiySWsHwf7lUaLW66ADYJBoilmPwo3c9Q+z2rz8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7EENPdjAY4PC68bXbe20IoY0fBHNy7K2A6dtJywbAB5jdSVHh yOMu0n5eIeh7N3mep5AJJ2naO7xSYP1h8Xku9/EzMNcvgcDwBMQ01JyyEIRA7naT7DQkHkLWAH1 Rmm2+HV90zPWVS5dToPmgnIZVZUFxFr/YA7R+e5GwO+rAJE50t+T7a8KzlhjuDIgXQMCtPw3S9z iqpQx9gTUxDiXCinWCB7w7a6SqePRoMlk1b2YH9IUu0H9ADTkHZ1O5Yx/qNXShLHPizQ4m9lnkM y237YEjbcayns4vw9g= X-Gm-Gg: ASbGncsFLmxge4k2bEFI73KTzOvR8BaoKpClb9H1ruE6gJaM++ZFvRO5QS1NzGtxF2b COaM2i4dPC8eD8ogunNGrMFUfRvfnFV0FN1CoCkNcpUChPkW0+t54rjKgN7tpURWxjudBXzqrpd 7QYYzbcDrZK7xyn2GtNI11/ptFNjaLY0YX7SV9lB00FumNnUQBq8iTka+TsCeCZvAgQwnvPEs7H hMhjy70FinzWWa6ca3DLy+1qB6vlyHecSNCJNOTpPyIrz93YlYHOAs9wgCP4+kDPMhI2PUY52lj HnZVbAVe9EiEDisnvlOBPQvuhWYTKs6B4QFl9t3xvM6L2k42vWLAmqwtMpKA2rham2xRCSu1DKf 5XSTx+j1DbnBeJzEIsKkMeV3i64DitJXKrKviazuZqtu4DcnR2sYFPtUIBBdfXFPuWKtnvWRd6d HH86B/o4Qoxm9RospY1Jr8al74oTZvCmSECm738q92gw== X-Google-Smtp-Source: AGHT+IGJYu0qAH9E50S6K2W+VPo7xdzKsYgmuEfyk0r2qnGVjAeGcAoSkF1BIRU158zvLmJhQf6ZBfUKUl7H X-Received: by 2002:a05:6102:26ca:b0:5db:2828:c133 with SMTP id ada2fe7eead31-5e48e248052mr415775137.10.1764762206800; Wed, 03 Dec 2025 03:43:26 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id a1e0cc1a2514c-93cd6c3c3cdsm501540241.1.2025.12.03.03.43.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:43:26 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2217a9c60so2003975185a.3 for ; Wed, 03 Dec 2025 03:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764762206; x=1765367006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PH4ANwBhxoAuPZERs6KPB00evBiCDrU2sux4zg9pefE=; b=c33GpDacu4sKVV4JVk/MiC3oBzKDaPajZvZN4Ke74wseoS+hHOLl4VXDIRVOmslLsa h4MG/15feVz7u4lRMHLSlbh9A5iSKA+s+ZyVvwYYNxzSIBQWLiZ9acmMvKsqnbS/XRd/ NNv7gqx6Z32tkuQHYdiW0ZHiJ5rZu7a2c/aGg= X-Forwarded-Encrypted: i=1; AJvYcCX+TEnscrhXIzviXxZtVWlbPxq1wAkt4hk8IwFlhSPvR50AP0n5D9WXsSMKgaZzHk/cveQCg4LFTBm0biA=@vger.kernel.org X-Received: by 2002:a05:620a:4049:b0:8b2:e87e:1093 with SMTP id af79cd13be357-8b5e47a151emr228686585a.3.1764762206314; Wed, 03 Dec 2025 03:43:26 -0800 (PST) X-Received: by 2002:a05:620a:4049:b0:8b2:e87e:1093 with SMTP id af79cd13be357-8b5e47a151emr228684385a.3.1764762205927; Wed, 03 Dec 2025 03:43:25 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b52a1b65bbsm1284727985a.33.2025.12.03.03.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:43:25 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Joseph Salisbury , Adam Li , Hazem Mohamed Abuelfotoh , Chris Mason Subject: [PATCH v6.1 1/4] sched/fair: Revert max_newidle_lb_cost bump Date: Wed, 3 Dec 2025 11:25:49 +0000 Message-Id: <20251203112552.1738424-2-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112552.1738424-1-ajay.kaher@broadcom.com> References: <20251203112552.1738424-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit d206fbad9328ddb68ebabd7cf7413392acd38081 upstream. Many people reported regressions on their database workloads due to: 155213a2aed4 ("sched/fair: Bump sd->max_newidle_lb_cost when newidle bala= nce fails") For instance Adam Li reported a 6% regression on SpecJBB. Conversely this will regress schbench again; on my machine from 2.22 Mrps/s down to 2.04 Mrps/s. Reported-by: Joseph Salisbury Reported-by: Adam Li Reported-by: Dietmar Eggemann Reported-by: Hazem Mohamed Abuelfotoh Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://lkml.kernel.org/r/20250626144017.1510594-2-clm@fb.com Link: https://lkml.kernel.org/r/006c9df2-b691-47f1-82e6-e233c3f91faf@oracle= .com Link: https://patch.msgid.link/20251107161739.406147760@infradead.org [ Ajay: Modified to apply on v6.1 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b6795bf15..f5a041bc3 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10941,14 +10941,8 @@ static inline bool update_newidle_cost(struct sche= d_domain *sd, u64 cost) /* * Track max cost of a domain to make sure to not delay the * next wakeup on the CPU. - * - * sched_balance_newidle() bumps the cost whenever newidle - * balance fails, and we don't want things to grow out of - * control. Use the sysctl_sched_migration_cost as the upper - * limit, plus a litle extra to avoid off by ones. */ - sd->max_newidle_lb_cost =3D - min(cost, sysctl_sched_migration_cost + 200); + sd->max_newidle_lb_cost =3D cost; sd->last_decay_max_lb_cost =3D jiffies; } else if (time_after(jiffies, sd->last_decay_max_lb_cost + HZ)) { /* @@ -11630,17 +11624,10 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) =20 t1 =3D sched_clock_cpu(this_cpu); domain_cost =3D t1 - t0; + update_newidle_cost(sd, domain_cost); + curr_cost +=3D domain_cost; t0 =3D t1; - - /* - * Failing newidle means it is not effective; - * bump the cost so we end up doing less of it. - */ - if (!pulled_task) - domain_cost =3D (3 * sd->max_newidle_lb_cost) / 2; - - update_newidle_cost(sd, domain_cost); } =20 /* --=20 2.40.4