From nobody Mon Feb 9 07:07:44 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB8D2F5A13 for ; Wed, 3 Dec 2025 11:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762023; cv=none; b=gz5sfhL6VoKs1MQd0JL/3CHqGOW47p1lNNBRJFf5Ch5FYsriauEZAi2C8IMO+X0lcGppTJuCdwUxrLUxEPxTijoUJZykLOd691+cMWL9G1yehY1PcGQUc26Dx3ocKPlWcqJO6NSfVGfKMkuAlNeBZ2GpeWsGJ9I28KLDQSv0HpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762023; c=relaxed/simple; bh=9EPDhCCtWaRo4rHvSMa36kDhj/Pz8zBcRzcppxUZU6c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bgqVvVplwPYsJktlMslOUKi5JmomWLrSSmBBaBjCflEAmvFq10zBtWYYc1+BMWkg6r/PEAJT2KZisNtFYFFQTSfiYVYBvzphs6loHsE0aCoib9T1TF7IoGiCoRSgiLDjHBpo4pDyZmH2e4YbPrmQ0Lr7aUCsVwXYEImXe/GL7QA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=AB8/2xrR; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="AB8/2xrR" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-29ba9249e9dso73837435ad.3 for ; Wed, 03 Dec 2025 03:40:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762021; x=1765366821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1iH4y3Zrgl56i/VHQKgTMa01v/ge6GrCshnPXW5Ao8U=; b=O9v0HvEhXNYzQP68lDuJtDu1O1CbN9XvkupP9oIPtwQEFRVCnSTf4vJji9QKadbZn0 vKjjmiKmzlyMGLhbDTpBmS73lYQpK/2GM+SYBa0yR1D2GK4Qv8o5w/bBWx60y/UAgsy/ pyhmUSuBbbe9GfXfZhOwWb6Kq/QOv3qLlAknFZWp38q5lHAYfw8mhT1f/Px0piO9xKYH wcVBmSpFji9iAaF9zgO0oTLaXCDzir004xLOJa1i9rI6+YyavuSIy18WFaNqRjdxYANY 1Q2H5scqrZ3C5RWGl2bn6ZAluhIpSqAwk/+/Z/iSBCr1UW90e8EFJyOppwSmHa4oMTHb ajqQ== X-Forwarded-Encrypted: i=1; AJvYcCWwTmjXLaS4hh9Z0d7j1q5/eXEadyz2qTu1NqgxTWiSZ3f0RxOqTKe6PVtnkise8SiuI8qFdzARm6nUeoc=@vger.kernel.org X-Gm-Message-State: AOJu0YwahhsKHkzE2fq7ZmpAUps15Ai2PA1+2GuxEPZ115DEJbSKYwBo BqsKDeE4JAd64yvdIqSIQPMoVcBaAu1AUDQBud78FIsXlXW1RvJhr/e1B2RlXOWn0R3jg7QlTkL LKisjW36NR1QpIEAjD+4axlZIgTRtiJnAytMjHNdZ5+064f1zcidTQDeQVCMo36bnDegwxgaeq6 9R+amn/HY4pbJCgWa1HflVs54YEVwEFfm/jNmNsunmv6lsTwCR5LqRIqWjFCv1oE0p3YnoMHFCB RQirmcerAZf5rW21kk= X-Gm-Gg: ASbGncsPeGV1OSD1KPdXKWJGmxDVWwAhhEAhk0E3SWMy2yfhk7ADIUKKuDSew2gj25+ mzx+wntGYUdKIMIMmvnYvasjtZZxTdjEbHPY06v8S0WAlBoNqopgzg1RAg8Do4K3xteXOLRb2dL xxl7PYsWtElLDoDwt3J3Ros+z9aKYcBvtJq+SbfpBb8Doa/Yb46GfOPBKnqTQEWFkIfUG32cpS1 Qkc/DcSC/vfIyvHY8Q//KT/ianGyuCx/2nyqjCW1+jKubAsStwVlPncZfZ4KdYygwcTiaqJx3y9 C8bUJfOsG+vlTIUoJLuVhxnxHjEZVzQ/q8iZ0NmfKboOqLk1w2TWZ2rbgW+PFQ1isMc+avHasG2 YZYUf7fsXDvWRSqvvEnjM3FSNp6NuhGdfcCrRjnvpcR8Vo6h6oeGV7G1u0U3kqA6jVp8ric5eG4 IMBzTZojmpj/CZEH9YVuqrmvu4Z0W4QYh4itE273WTvw== X-Google-Smtp-Source: AGHT+IGJxp79l1IQkhy7FWwf6kKFdDo0iSi1boqbC70KB0B9bOgcAk1SJnokvqw2A1428b23Z0FpaZnuvEwO X-Received: by 2002:a17:902:daca:b0:298:529b:8956 with SMTP id d9443c01a7336-29d684767a9mr23236505ad.56.1764762021415; Wed, 03 Dec 2025 03:40:21 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-29bceb26697sm25971425ad.58.2025.12.03.03.40.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:40:21 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-bddf9ce4931so9746966a12.0 for ; Wed, 03 Dec 2025 03:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764762020; x=1765366820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1iH4y3Zrgl56i/VHQKgTMa01v/ge6GrCshnPXW5Ao8U=; b=AB8/2xrRsmJY1SqLLMRtCGW5LrZAlJLipFOHhN06PQ1uk7N24w2hZRwHlIWBm6brzD YQFo3GuirYp7lT34BNz4Cjo7gVDPnHLmnsVssSGdl3Fnpba6MsdlQtokcA6uS+awux4f ivWhunC49HuOwmCIWXt7W5jqfZ0kHHJcSBuRI= X-Forwarded-Encrypted: i=1; AJvYcCVyZkXAALnd0nqVPZezvQ97RYp5lhhUeEvrmtC3YULxJW7rylnx1DkxPen3o2eBSgXEd4agqedz1UzTiiY=@vger.kernel.org X-Received: by 2002:a05:7300:6c89:b0:2a4:75f1:fb27 with SMTP id 5a478bee46e88-2ab92e37150mr1660502eec.25.1764762019545; Wed, 03 Dec 2025 03:40:19 -0800 (PST) X-Received: by 2002:a05:7300:6c89:b0:2a4:75f1:fb27 with SMTP id 5a478bee46e88-2ab92e37150mr1660479eec.25.1764762019027; Wed, 03 Dec 2025 03:40:19 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a965b1ceeesm63324781eec.5.2025.12.03.03.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:40:18 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.6 3/4] sched/fair: Small cleanup to update_newidle_cost() Date: Wed, 3 Dec 2025 11:22:54 +0000 Message-Id: <20251203112255.1738272-4-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112255.1738272-1-ajay.kaher@broadcom.com> References: <20251203112255.1738272-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit 08d473dd8718e4a4d698b1113a14a40ad64a909b upstream. Simplify code by adding a few variables. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.655208666@infradead.org [ Ajay: Modified to apply on v6.6 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e47bf8d6c..f93a6a12e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11706,22 +11706,25 @@ void update_max_interval(void) =20 static inline bool update_newidle_cost(struct sched_domain *sd, u64 cost) { + unsigned long next_decay =3D sd->last_decay_max_lb_cost + HZ; + unsigned long now =3D jiffies; + if (cost > sd->max_newidle_lb_cost) { /* * Track max cost of a domain to make sure to not delay the * next wakeup on the CPU. */ sd->max_newidle_lb_cost =3D cost; - sd->last_decay_max_lb_cost =3D jiffies; - } else if (time_after(jiffies, sd->last_decay_max_lb_cost + HZ)) { + sd->last_decay_max_lb_cost =3D now; + + } else if (time_after(now, next_decay)) { /* * Decay the newidle max times by ~1% per second to ensure that * it is not outdated and the current max cost is actually * shorter. */ sd->max_newidle_lb_cost =3D (sd->max_newidle_lb_cost * 253) / 256; - sd->last_decay_max_lb_cost =3D jiffies; - + sd->last_decay_max_lb_cost =3D now; return true; } =20 --=20 2.40.4