From nobody Mon Feb 9 18:01:26 2026 Received: from mail-pg1-f228.google.com (mail-pg1-f228.google.com [209.85.215.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439E52F547F for ; Wed, 3 Dec 2025 11:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762022; cv=none; b=dH7TP9WE8rbTQWIM9h0eMfyDGmnPJmjV/4e9SPLGd8hG51BTvBzn06tFwFRccT5fzopGZ+cgOebYODvCDNBl4VF39lSyIspvfiN2lnZQmoV7wkP5LL/9/E4SzIlOy9yAeGjITXdNuTWvk6Yc6sC54Mzpkrc+cItrRsjINzMy9Mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762022; c=relaxed/simple; bh=TXO5NRp5c5ShzA2cY2ZOV+GiFeT9eyDUZ2fy1Hg+chk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YpX3egZalQzSLetifq5E46avCimQvAe5d1HLR3PL/o9e6iUMflGNcELULZJlh1EUsYMWuG5hsXLZu/KkL5T3SRgJFM8QAAh2gVWeEvcVDPD69VJ0ypVrZ7rt21/8om4fIPYkVPb+kEpXD2lbNg4B8AWKcfDWH8o4XJ4TgYZFMNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ZR30DkVY; arc=none smtp.client-ip=209.85.215.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZR30DkVY" Received: by mail-pg1-f228.google.com with SMTP id 41be03b00d2f7-b4755f37c3eso4309485a12.3 for ; Wed, 03 Dec 2025 03:40:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764762020; x=1765366820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7amVhtvbqglJSO4BYYfWbBRtTIKW47Hm7wnmb8VHueI=; b=cAWUAkLCA5MEbXTItYcIm3a34tLxy1kxsA4YiUZDTC68oq2rUGASmIwvF54oAAbueY oGrjyl/9oQV4TY9uo9RP9g3CfDt0XuYNkCmpBQBQYP7CqEI60nLfiTHZxzS6hKQnCpN6 2owWI+smVMFZd2mKEanwGoHmShEWoIoOf0uXlm3/jcNNFkzwi1aG9zLdNggYs0AgiPgF chJsUW+BsFGaxbboNWqjv0SU5jjwoS9lN3vA3keEbLPHgcrrL4pUQJpvfthJyY2pD97r l3WNoAfGjPfRb1dHStxvTP5tkjvVZ3jptilc/W6/469fz0zGLFKfljW5ENPy6YLtpWdB Tmnw== X-Forwarded-Encrypted: i=1; AJvYcCV1FCDwnvJT/hMsBZ7R8PJvEYrEzHlovl7owzrZ87kTE4EnhJxF0c5ha+mQ77wb9SRlRKvD3D1bqNB8lmg=@vger.kernel.org X-Gm-Message-State: AOJu0YySaygD8x+nwZNgv4kHW/Qjr3n10FwuaEImbH6pnkwdbH5juq6a ynDePBKzdCIHbqHRv8A9zfZ5OYbn1sJ6Pi7oT1TUZYS/2FpF/22/jlYBdZMtgx63iK/GmHjVNdQ 3sKQCfRcUua+XRq9DASrppJsfJkj/asRUi1WnmOmG1LkiTsmJuGQYF0xE1ftQGtlKMA8J2ya1VO ulCRKINrPkg4+OMpJsuqfnhFXD9yxVXBYOkmJHD2MTfCEBJgXcrZI2CUyWTnUi4pokCaMX9FZom zKcm7NxJmg3bu0z4ds= X-Gm-Gg: ASbGncu0qdt3NpPGeuM1zevLn6fJNajPqWz5sOhoGZzJYuqVJOLSi/YR2AH24ENBlgO o0qdBIH/lEHWxhVSyO5oh6/N7aUZIh+y+1N3m/YdBswePe3+TfAAHN34ybYvkCtRupTIWYEP5P9 ZeemmMn0DAdyFtHyIJaMNL8ecn0cE8Zc4qlA6UxIFcOJcZ1Xh8BdxCVpA9n2mdpah8c/Vmmdwnj 5cwbAlfFOmd9M05mhBsJOs+JJ5GuhW7GDQOrIXTNF+oII5PUbxtsGBaLwqnhGHIRnefl8Hlqo53 IU6mjDfp0P91TPs9CDBwiOpZvHYWUy0ZqJghGCFMNMvyeofbqAvLvBs04G/JnFRAPFJgo82mX3P 8houzDWwLuHdrCi5vAU0q4jINcQlnyEl0nxOzGNvO7TCTG1CZGCp5vfLdy2OOYIIImvklUaJaMw E7jV1QygKuDAsBahNwxunFG8eHQoiv/k/8TGP16g6Hsp7l X-Google-Smtp-Source: AGHT+IGPVODMQPOGLt3YYFR9bsSg4fiAj1eDOnr/nkb0YDXHI+iuXrygsf4wTZLSKVKoDkh9ce+2fZNMfeKZ X-Received: by 2002:a05:7022:6610:b0:11a:2ec0:dd02 with SMTP id a92af1059eb24-11df0c507e6mr1719707c88.33.1764762020354; Wed, 03 Dec 2025 03:40:20 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-11dcb033199sm2523724c88.4.2025.12.03.03.40.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:40:20 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-be8c77ecc63so5819940a12.2 for ; Wed, 03 Dec 2025 03:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764762018; x=1765366818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7amVhtvbqglJSO4BYYfWbBRtTIKW47Hm7wnmb8VHueI=; b=ZR30DkVY36hEaEfuFdqDX72BWm6wWQsr5dgvaKIS9h64neBLnEJKZZWqjsANu6km1b NIyDKQDbntGtkvRM0IawWUgr/vfDgHWOn/uewg49V8IzolFNszdBDp3ElT686QgZqjNf 8EzpWV95snjPwJfxieTJE8axNinxLtFw00rfo= X-Forwarded-Encrypted: i=1; AJvYcCU8aNDA8pYSK+XlfP28bffWOQt5mx9WnReNYjWxmRRNvd+07ZY2fwcX/eCzb1K1rUaCvFqaMlxDUqhxzro=@vger.kernel.org X-Received: by 2002:a05:693c:800d:b0:2a4:617a:419f with SMTP id 5a478bee46e88-2ab92da3943mr1071054eec.2.1764762018407; Wed, 03 Dec 2025 03:40:18 -0800 (PST) X-Received: by 2002:a05:693c:800d:b0:2a4:617a:419f with SMTP id 5a478bee46e88-2ab92da3943mr1071036eec.2.1764762017869; Wed, 03 Dec 2025 03:40:17 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a965b1ceeesm63324781eec.5.2025.12.03.03.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:40:17 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.6 2/4] sched/fair: Small cleanup to sched_balance_newidle() Date: Wed, 3 Dec 2025 11:22:53 +0000 Message-Id: <20251203112255.1738272-3-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112255.1738272-1-ajay.kaher@broadcom.com> References: <20251203112255.1738272-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit e78e70dbf603c1425f15f32b455ca148c932f6c1 upstream. Pull out the !sd check to simplify code. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.525916173@infradead.org [ Ajay: Modified to apply on v6.6 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 842d54a91..e47bf8d6c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12362,14 +12362,15 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) =20 rcu_read_lock(); sd =3D rcu_dereference_check_sched_domain(this_rq->sd); + if (!sd) { + rcu_read_unlock(); + goto out; + } =20 if (!READ_ONCE(this_rq->rd->overload) || - (sd && this_rq->avg_idle < sd->max_newidle_lb_cost)) { - - if (sd) - update_next_balance(sd, &next_balance); + this_rq->avg_idle < sd->max_newidle_lb_cost) { + update_next_balance(sd, &next_balance); rcu_read_unlock(); - goto out; } rcu_read_unlock(); --=20 2.40.4