From nobody Mon Feb 9 15:50:28 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 123622F6165 for ; Wed, 3 Dec 2025 11:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761893; cv=none; b=JC4R7EVIY+RcLVFG76UH0es6rro48qJLGzwFWEW2SkOKvvu50Ag5LHBLPcEg1fYx9RJ9G9JYkwK+vBKIewgEZONiRiv3Zxsmp2+HU1OUqJbqAOIKvPzE8QMg0b5c5Y5PUwU/YBTfGyBEHIyKYhUi7yYpsbkU0xy396BlwhWGqYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761893; c=relaxed/simple; bh=ZG5mzj65CsSbn+sH8RL7YDJ3FtnnWDUbqNPW06zJwbA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rYx4pwyk24ji9fXeMxcFME7Id0j9kJH/WY5k5SSl+Zmn0SQGKklHappJpLP3XOkC8b1igFBRArV6xnLQCo6TamhdCRhN4Un5WYpYNdwvJBtJ98QFVx2zZUqAqqQN5n4kTnQgeGb3SmhpwAabbaQuowPHFTuAzKXJT6bDoYAakjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XRzimyoa; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XRzimyoa" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2980d9b7df5so78030795ad.3 for ; Wed, 03 Dec 2025 03:38:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764761891; x=1765366691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xaYvaRoI/zaMoFXpgyvVSoj5rbLS0T6qMiMhubQCjpU=; b=qEYX/fBhLwN4uiV/wFv8XKrewcEkubJPu1pcZo+12hNYVOOcaeZFOE+qPmdhSMy6wS CcDNVeVtxZnrwSqDdeT+btg30kL757UV6y2GJRNyiXql/5IUmPvT8qZLOLRHuMAGwgH/ tZ/Z0cUCMkxVOr6IrcyRF6nyNT4zNfuntDyYeGmW5W8cJKSRzTifvObFgz78y818modp mfdbOa/rhYaTuAtEHkjfdV0vbNq0QGulJBI+ExLVWQzduMAcyDWFY9vQPlPxpvlPGQBA TIgc07/y1JdKWNQprpW7hFmpm1gTTdIFOl5kQtFNTGlpe+WoqHdRvUgLHUTI1A3j3QWH KTXw== X-Forwarded-Encrypted: i=1; AJvYcCV/SR7nmrRIZ2JiaemDkXuR6tkLrKKFHlsbwNHp9ituz/nbfsNWTM2nEz4ImkPz5rOZuKCRcKaLFLCrRHY=@vger.kernel.org X-Gm-Message-State: AOJu0YypzApsK/N9y7BWXr5/H2YXWaIy2XAXH4GmR9HOCPY/jTKwsUoV qmQA/2frNcvdJlZ2emiuknl6tfE/z8xM8RyNAi/FFKbyeJ1K+cpwSHECtSp550bZC6s78+S9ajV VvnvKa1Ml1hyKPpVhmNDsIbfXpOjsVzzMJNmoSkqgxy9ygGvsMJ4BTt9i4sQoZVGFSKRrQMMLjH AGDegqSYdSiCylAjVKu9TgFbfVIBKO4CBcSwe8ZZriN67nENIhXuaZPtTo1nV0RFuDlIHxdip+W 6XgDB0QGj7qK3NiJLA= X-Gm-Gg: ASbGncscsm56mJ53jGD/PNuL/dwSGSR1OXtDIUw1h2s7CQdYLDMi2odzNU3njUPH027 wyxoaEPc+rZiJTS2cYYVjVIwXr54676cP9JHi/sRu/fO3gjKriQxDqFbzFxG02wIxRCKoSylAlu wAJPlSFxTRCEIPRxCq7CTMeMSEpO8KTknGD+NOdvHMOw1IBqXItxTJXRR4eQhm6USEzdarNXwjs OakQBfs7UiqF+sxORCMk9hBQT2ylZJK7RJLSUUwaYMBGF+6XzOi0G8rMteYFZK073IN+bp9YHNI RCFJoe340TN7J1kJ597gyvMNNUgxiGZWj8vS3QmBNdf+ucYgWlA1VL+WO6DhF5winl0kh/UN0gm R+VtVJKdIIIG6OMUOxlqjbxuZJUFUPuMfBot/daeIk2D3jtKxhKMMyVc9WvLFSfDZKGw4LyDTpl NWDbHa/ZJcIAd3cyl4ifvTqSFo2ErZyv9wDhGiSw07FhLy X-Google-Smtp-Source: AGHT+IEFlo65ERy01RVtmlheO8GqVjjDnPfUxcCJtlpP42JlCTz+Wk9igLpKO0c9NXZqDeSSiU+z/JHjgdJ+ X-Received: by 2002:a17:902:f60c:b0:294:cc1d:e2b6 with SMTP id d9443c01a7336-29d683e6c95mr23674095ad.59.1764761891250; Wed, 03 Dec 2025 03:38:11 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-29bce41b327sm24100325ad.6.2025.12.03.03.38.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:38:11 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-295fbc7d4abso81066895ad.1 for ; Wed, 03 Dec 2025 03:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764761889; x=1765366689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xaYvaRoI/zaMoFXpgyvVSoj5rbLS0T6qMiMhubQCjpU=; b=XRzimyoaMKPExMb0l3iKOwitOheD2OMaKMpr227o6sGMdcft4trTuejuBJ2qTpeElk jv02tbiWKQ3q+TPTjQmv2J8Q984KjqgwHSGkAuwseYIEi0ogMxjgRzvycPguaXUn93uC MvjPpBuRWpLXv33iXTi3SLpRufD8xNodic7qQ= X-Forwarded-Encrypted: i=1; AJvYcCXvUQ7/vtXZrCtHKyxsBdO9Kz+cXnEfTetGZ7TzLbiZDzjD/hXflFDtMzgtePAXI/fA+xUEz13WVo+vWz4=@vger.kernel.org X-Received: by 2002:a05:7022:160a:b0:11b:9386:825d with SMTP id a92af1059eb24-11df0cebfdamr1730601c88.42.1764761889426; Wed, 03 Dec 2025 03:38:09 -0800 (PST) X-Received: by 2002:a05:7022:160a:b0:11b:9386:825d with SMTP id a92af1059eb24-11df0cebfdamr1730570c88.42.1764761888840; Wed, 03 Dec 2025 03:38:08 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb03c232sm83169465c88.6.2025.12.03.03.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:38:08 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.12 4/4] sched/fair: Proportional newidle balance Date: Wed, 3 Dec 2025 11:20:27 +0000 Message-Id: <20251203112027.1738141-5-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112027.1738141-1-ajay.kaher@broadcom.com> References: <20251203112027.1738141-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra (Intel) commit 33cf66d88306663d16e4759e9d24766b0aaa2e17 upstream. Add a randomized algorithm that runs newidle balancing proportional to its success rate. This improves schbench significantly: 6.18-rc4: 2.22 Mrps/s 6.18-rc4+revert: 2.04 Mrps/s 6.18-rc4+revert+random: 2.18 Mrps/S Conversely, per Adam Li this affects SpecJBB slightly, reducing it by 1%: 6.17: -6% 6.17+revert: 0% 6.17+revert+random: -1% Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://lkml.kernel.org/r/6825c50d-7fa7-45d8-9b81-c6e7e25738e2@meta.c= om Link: https://patch.msgid.link/20251107161739.770122091@infradead.org [ Ajay: Modified to apply on v6.12 ] Signed-off-by: Ajay Kaher --- include/linux/sched/topology.h | 3 +++ kernel/sched/core.c | 3 +++ kernel/sched/fair.c | 44 ++++++++++++++++++++++++++++++---- kernel/sched/features.h | 5 ++++ kernel/sched/sched.h | 7 ++++++ kernel/sched/topology.c | 6 +++++ 6 files changed, 64 insertions(+), 4 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index 4237daa5a..3cf27591f 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -106,6 +106,9 @@ struct sched_domain { unsigned int nr_balance_failed; /* initialise to 0 */ =20 /* idle_balance() stats */ + unsigned int newidle_call; + unsigned int newidle_success; + unsigned int newidle_ratio; u64 max_newidle_lb_cost; unsigned long last_decay_max_lb_cost; =20 diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4b1953b6c..b1895b330 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -118,6 +118,7 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(sched_update_nr_running_tp= ); EXPORT_TRACEPOINT_SYMBOL_GPL(sched_compute_energy_tp); =20 DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); +DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); =20 #ifdef CONFIG_SCHED_DEBUG /* @@ -8335,6 +8336,8 @@ void __init sched_init_smp(void) { sched_init_numa(NUMA_NO_NODE); =20 + prandom_init_once(&sched_rnd_state); + /* * There's no userspace yet to cause hotplug operations; hence all the * CPU masks are stable and all blatant races in the below code cannot diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ae5da8f34..189681ab8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12217,11 +12217,27 @@ void update_max_interval(void) max_load_balance_interval =3D HZ*num_online_cpus()/10; } =20 -static inline bool update_newidle_cost(struct sched_domain *sd, u64 cost) +static inline void update_newidle_stats(struct sched_domain *sd, unsigned = int success) +{ + sd->newidle_call++; + sd->newidle_success +=3D success; + + if (sd->newidle_call >=3D 1024) { + sd->newidle_ratio =3D sd->newidle_success; + sd->newidle_call /=3D 2; + sd->newidle_success /=3D 2; + } +} + +static inline bool +update_newidle_cost(struct sched_domain *sd, u64 cost, unsigned int succes= s) { unsigned long next_decay =3D sd->last_decay_max_lb_cost + HZ; unsigned long now =3D jiffies; =20 + if (cost) + update_newidle_stats(sd, success); + if (cost > sd->max_newidle_lb_cost) { /* * Track max cost of a domain to make sure to not delay the @@ -12269,7 +12285,7 @@ static void sched_balance_domains(struct rq *rq, en= um cpu_idle_type idle) * Decay the newidle max times here because this is a regular * visit to all the domains. */ - need_decay =3D update_newidle_cost(sd, 0); + need_decay =3D update_newidle_cost(sd, 0, 0); max_cost +=3D sd->max_newidle_lb_cost; =20 /* @@ -12927,6 +12943,22 @@ static int sched_balance_newidle(struct rq *this_r= q, struct rq_flags *rf) break; =20 if (sd->flags & SD_BALANCE_NEWIDLE) { + unsigned int weight =3D 1; + + if (sched_feat(NI_RANDOM)) { + /* + * Throw a 1k sided dice; and only run + * newidle_balance according to the success + * rate. + */ + u32 d1k =3D sched_rng() % 1024; + weight =3D 1 + sd->newidle_ratio; + if (d1k > weight) { + update_newidle_stats(sd, 0); + continue; + } + weight =3D (1024 + weight/2) / weight; + } =20 pulled_task =3D sched_balance_rq(this_cpu, this_rq, sd, CPU_NEWLY_IDLE, @@ -12934,10 +12966,14 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) =20 t1 =3D sched_clock_cpu(this_cpu); domain_cost =3D t1 - t0; - update_newidle_cost(sd, domain_cost); - curr_cost +=3D domain_cost; t0 =3D t1; + + /* + * Track max cost of a domain to make sure to not delay the + * next wakeup on the CPU. + */ + update_newidle_cost(sd, domain_cost, weight * !!pulled_task); } =20 /* diff --git a/kernel/sched/features.h b/kernel/sched/features.h index 050d75030..da8ec0c23 100644 --- a/kernel/sched/features.h +++ b/kernel/sched/features.h @@ -122,3 +122,8 @@ SCHED_FEAT(WA_BIAS, true) SCHED_FEAT(UTIL_EST, true) =20 SCHED_FEAT(LATENCY_WARN, false) + +/* + * Do newidle balancing proportional to its success rate using randomizati= on. + */ +SCHED_FEAT(NI_RANDOM, true) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index cf541c450..78b40c540 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -5,6 +5,7 @@ #ifndef _KERNEL_SCHED_SCHED_H #define _KERNEL_SCHED_SCHED_H =20 +#include #include #include #include @@ -1348,6 +1349,12 @@ static inline bool is_migration_disabled(struct task= _struct *p) } =20 DECLARE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); +DECLARE_PER_CPU(struct rnd_state, sched_rnd_state); + +static inline u32 sched_rng(void) +{ + return prandom_u32_state(this_cpu_ptr(&sched_rnd_state)); +} =20 #define cpu_rq(cpu) (&per_cpu(runqueues, (cpu))) #define this_rq() this_cpu_ptr(&runqueues) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 4bd825c24..bd8b2b301 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1632,6 +1632,12 @@ sd_init(struct sched_domain_topology_level *tl, =20 .last_balance =3D jiffies, .balance_interval =3D sd_weight, + + /* 50% success rate */ + .newidle_call =3D 512, + .newidle_success =3D 256, + .newidle_ratio =3D 512, + .max_newidle_lb_cost =3D 0, .last_decay_max_lb_cost =3D jiffies, .child =3D child, --=20 2.40.4