From nobody Mon Feb 9 18:01:24 2026 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE85E2F5A1D for ; Wed, 3 Dec 2025 11:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761892; cv=none; b=EDnH5UAD+g5Jmv33vgOVsai9QrlIBLInfFxOol/MshmGawtpWjWmegr5TN53Ec1x8d27E8Z8gNqq6MMF5egRvn559bzlyxXGvGNSoVGtOA3NiVjV9a2XxO5Y/atP92UTKfrQn029vYZnfJkV98roGKqSIDZm54tGceCjujryXa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761892; c=relaxed/simple; bh=/IlEpooVPRR4biFYwUdCr22YNedtY02/izr3qt8kbDU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ReNCxBlUhEjt6LpzyGOaWn111U8MuIbAJwXX5SosOoPSQpv59v0j3wXcI/ahJMmf9nNaAn2zU/esLfKDCZ56NH+37EzIr90IptNutC6lvRFXVQjvO8FKks4Dq9pc6gMPY4PlqW0D/ycidRRWOGRYbEHrpBd8QAhpJkpYAfqudxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cNXKv9Ua; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cNXKv9Ua" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2984dfae043so57460855ad.0 for ; Wed, 03 Dec 2025 03:38:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764761890; x=1765366690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZLfHsULW/WFUBHVOGU/nqYd2laF33Pp/+LBFX8T/D0c=; b=cAoBiuJ/AzHDkc4RZFTHrjkU68k2nNhbBtOHAuloCF/mucNgmyJzPWbWXJARse13gD /afcHy4rDhghPQhhnVGnp9mj6SaJTOZT1cfUfvgR1u5ZrC6ISkFFQhfw48S1trOlIqrx RxmLpKP77wAz7DhBnqIKgSOnOyKiIG9goP3VEFfIWA/qMElhEkosHBXCx1oFM//OJwLe crhSnnBq4wSmCo1PF6yKJlL2v+tSsf/1kw6qjILeHYssSTLY9FTo+o/q9krCU1kxHHDU hLDRpnR6u2Df+pN8O4qqprIypkD7cMxfg5hZ9gIH0R+uAs1v7avgVEmKmZ98puJ1bNyf x1rQ== X-Forwarded-Encrypted: i=1; AJvYcCVoKCP1FYwD3ENvX4e+QWp5drbNs0SSA9f49cFhtrX3XVCCOvRIIlwswagqq/KYLGtReaU5iWZYKAowPCU=@vger.kernel.org X-Gm-Message-State: AOJu0YxGl5kywSEtcacQhAFAn6/XJqxhrfNzpMB4236Ue2kwQaMtMyqV ND7KvDogpaWTjT7orBWVa3f7G55rYA+dcRYITWI2gkm8q73Uj3mczSsavrMNLj2w8yeRI1qUcqs A1qY2KMdZV4AyQILynroiDP/2XELyM/jWJx6Mrg9G0yL5U8dXSnPCQXcJk2304zPIqT5zoYHkdW eUzXBkjiygnmtLlHzImKnlg8uDpGOe3uU7aWLcgBgQgPCzS27R9hFx7aoPhoS/vLOVZd2WyzOMT SZDJ2qMPU3gMdvJGEw= X-Gm-Gg: ASbGncuIVTJovRyuakeCH5zxhRBficZCAmG8hXj/xz/abDlpjCHM7kkIEMU8Gz+TPhQ ixTmE4MZZ4z4D3phfZ6vpHHI/ljFtn+aH+vev2Z/WQtTm0Gg/n4a/+S5g5rV140AgMgi+gD9fRK osIZLjHFIS7djQL7ikiHlH4blS6L1syeqPWu4kDjiccmrf7XfT9L4OTU+klmKANIUOCPAzZj0Xi OiSJmLyiOlSW2OJpe3V3kjvaxjFihLCK8pIiVQUnWSLuoIpTRaUPq+wxkkDPFRnOzrIDZ77tM8m qH0/fZsrVfXXszqayV/f0Czpc9l5Ebvo8iZtHOt+rXrVHsyY57EWxzUy80/XOkMu002aJHbRAem xtFLm0sgR4AQ6ydB8xZmYkx9kp37EUk3l9JrvCkYFx3/I50pPApfjY86D4raXwUayZKWwY4ht8G kqhe5kDqn1i2MUBmyAmrdLU2d696QcJlKXjGiQLVmsxw== X-Google-Smtp-Source: AGHT+IFtIVrkQ5aP1hOd8dg7rETHZnCWu21yaJ65PUEju5KN1J7k/9Zx87wHA9b6AUSyqAOHE2ZB3L3QlKUl X-Received: by 2002:a17:903:2442:b0:295:7806:1d64 with SMTP id d9443c01a7336-29d6830aba1mr27159855ad.25.1764761890119; Wed, 03 Dec 2025 03:38:10 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-29bceb0d145sm25777315ad.56.2025.12.03.03.38.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:38:10 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b6ce1b57b9cso6763708a12.1 for ; Wed, 03 Dec 2025 03:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764761888; x=1765366688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZLfHsULW/WFUBHVOGU/nqYd2laF33Pp/+LBFX8T/D0c=; b=cNXKv9UayeM9Kp//+A/iNLVmRBnMSHyGtCtjAOUbae+h7b3Xot2jaeVYD8FCHxD+39 R3ytN5PSprHQ8FwV9lFjNhnVndkydax9UnMPaUT5fTeAiieKyxYHG3gRCqIeCCrwj3Uq eGYXbGZFZuzAf6gSpJH1FNbYdqPUzT66XarIw= X-Forwarded-Encrypted: i=1; AJvYcCXHVsI6vI59jKntnS+ekr4geiYWiKvZCnzqIjpObaJY88O5URAD6K+zDC51TqOFDfagb8gmBvg4HWk6umI=@vger.kernel.org X-Received: by 2002:a05:7022:412:b0:119:e56b:91d1 with SMTP id a92af1059eb24-11df0bb9dd7mr1558617c88.2.1764761888044; Wed, 03 Dec 2025 03:38:08 -0800 (PST) X-Received: by 2002:a05:7022:412:b0:119:e56b:91d1 with SMTP id a92af1059eb24-11df0bb9dd7mr1558586c88.2.1764761887489; Wed, 03 Dec 2025 03:38:07 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb03c232sm83169465c88.6.2025.12.03.03.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:38:07 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.12 3/4] sched/fair: Small cleanup to update_newidle_cost() Date: Wed, 3 Dec 2025 11:20:26 +0000 Message-Id: <20251203112027.1738141-4-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112027.1738141-1-ajay.kaher@broadcom.com> References: <20251203112027.1738141-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit 08d473dd8718e4a4d698b1113a14a40ad64a909b upstream. Simplify code by adding a few variables. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.655208666@infradead.org [ Ajay: Modified to apply on v6.12 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b6637954e..ae5da8f34 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12219,22 +12219,25 @@ void update_max_interval(void) =20 static inline bool update_newidle_cost(struct sched_domain *sd, u64 cost) { + unsigned long next_decay =3D sd->last_decay_max_lb_cost + HZ; + unsigned long now =3D jiffies; + if (cost > sd->max_newidle_lb_cost) { /* * Track max cost of a domain to make sure to not delay the * next wakeup on the CPU. */ sd->max_newidle_lb_cost =3D cost; - sd->last_decay_max_lb_cost =3D jiffies; - } else if (time_after(jiffies, sd->last_decay_max_lb_cost + HZ)) { + sd->last_decay_max_lb_cost =3D now; + + } else if (time_after(now, next_decay)) { /* * Decay the newidle max times by ~1% per second to ensure that * it is not outdated and the current max cost is actually * shorter. */ sd->max_newidle_lb_cost =3D (sd->max_newidle_lb_cost * 253) / 256; - sd->last_decay_max_lb_cost =3D jiffies; - + sd->last_decay_max_lb_cost =3D now; return true; } =20 --=20 2.40.4