From nobody Mon Feb 9 15:50:29 2026 Received: from mail-qv1-f100.google.com (mail-qv1-f100.google.com [209.85.219.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 421402F5480 for ; Wed, 3 Dec 2025 11:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761890; cv=none; b=qOKArg3XO9DbFQxTMweoOW7zLYiukqK2w3LIavUrp4Bqey2QhJzgbFoCcLtyVbJtp/uS00znDNlVhIZpygYHXRl/LIuwD721deEUNxGEMD2wjxPiN4bvNUq1MOzWNrtoVacHc3MPJogHL0Sahd2M4EkgJUYH8hGbztFA5syw3mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764761890; c=relaxed/simple; bh=2i0Nr3FF86hxTZ+uwa8LSg7RhEJAMHkbIJrtE6kLfCg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uROcWI8RbbSsLdb3G7xPXWwA2xpVJhzl1eCJ/x7wpuWBM1ojVp/JW2GihF8WbGwPOEsvPTt31jlfw0KYuodNUZFog3vfTF/gNkKiZx6g3PrxmFj6KdRZ6wSpeqH5qBG1n25EZII82I4kic+439vMl4O1acbdHYU367ZIk/lhrNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=STLroqKn; arc=none smtp.client-ip=209.85.219.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="STLroqKn" Received: by mail-qv1-f100.google.com with SMTP id 6a1803df08f44-8823fa3bd95so7083656d6.1 for ; Wed, 03 Dec 2025 03:38:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764761888; x=1765366688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G5hKdYszeQOOdLcK2HxRZCwJUCsOXMz/ue3SXkECFJE=; b=wEuRufeMKlpnUsO1au/CjqDh4FA03IcSR455V8N+JR18W22AWmTnxUOO5L3kU+1n/T chsupZKw2HDLPxlEMdJoZjWvqpLNZ1uLCE+ELjhKJFWPVwx7syjC6CRfvSGBpWuzdfq4 6xJanSoGaQYOrebegpcOCcclBI2CxMgd1WPvod/s/jV7ezYWVh5qHEjGV3B2xTOBnckF HOyleOJ98mbvmSnqQOAF1l7EIWYgn6bufL62UCdPbqkhoWbfZ4ZM6Uvzhj6sLYycEbyi 5+/+o1tftWdXn84eTwpYGRchTtpALTuA4PiDtE5T9mhvVamVBB9xzn02CluAS/ahMJAP tcAQ== X-Forwarded-Encrypted: i=1; AJvYcCWNWo1mDGrDBvmZz3vHiJEXbLyYJ10QpoVWqWd4PedGGaohSEdL/4MhbYo2pHNG5fdsn6oQjK71HmUReVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/topmGmuNajLEDlN7B9pYEi6Tn+FUYkIy42zBW7k6B9VBkyZR pVs3Jy1WWFoaLXDIjFEqp6rzX2AdAkzruxA03J27WgMmCR9Y6uQJ1EqRtiAHLLucDfj1B1kEpbi yrVywfoy7PZk8EnrVKOBYu/Agr3p7NUaDPvMiMNTLIDIiXKdejPl9udjiC9GDnQZiNLxJa1pXl4 LTLCS0F4LObpcj8eYfL2wsn7VmeD9jaA7raJK1s2WDP/6I+W+W4k67QbVztEF49/1Y+jetYzopX QM521iFPDwRElrIEjA= X-Gm-Gg: ASbGnct60+KYpoxaJQXfTvjWdtE2ro443OAsfxc4x6BzJKJqObJWd1BJYEkGkpw5szM dQWvPt8XcQYFBpy9DFW3TAJY7KCIMvEUKnLPIxRCCFea5sL2NHqPKS3kibW3GAzcYtktaqdPJms iT6cEjaWb5g0A3se/TLCqgbUm02gHMMou66gbygr0Un85RpZNV5aha57afGxSQzNxQkieK4IObv MxKhpzsAl7ACsxqZiZMsdJVVDYSgt2GBqErY4XE24sGvkRhW8CFDFlSHAW8TBAv4roW+M5Yis00 oO8+dhn4a03TlW7qLEbArpHBqQLFbFxUKn04PpOTv0bUoeDE5gp+Vqjpqg1D0dks/HrmVJtcMJ1 OcppDdt9WNEqzdryGzlbJM34JSn3Vz3XkGXF9bw+FDBIBd5HpLYJMwukfs8UW+qy45nZgrFyOW6 bRV4iXVQZ+3sjEnrdbWxH1wp9QB4BcCGjA8xnrMVzdDjUF X-Google-Smtp-Source: AGHT+IH+TVin+GhXVuC+joXRUnuz0kHU2yfAe07KEXivXcKXTRpJjAsZmAJAKNQwHo1iiGEyGDT5C68AuqDM X-Received: by 2002:a05:6214:212a:b0:884:6f86:e093 with SMTP id 6a1803df08f44-88818b7c63emr31642166d6.5.1764761888110; Wed, 03 Dec 2025 03:38:08 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-88652afaaf5sm25832976d6.22.2025.12.03.03.38.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Dec 2025 03:38:08 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-11ddcc9f85eso1260404c88.0 for ; Wed, 03 Dec 2025 03:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764761887; x=1765366687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G5hKdYszeQOOdLcK2HxRZCwJUCsOXMz/ue3SXkECFJE=; b=STLroqKnv361Ygg4J8nI65gyJxGR3L0MtGYeB7d0NWYmHSyoWMjVjHoYLM+vr5aNIf lxB2LBf+5wVEkOXiMVGrUEvGL1Vih0/BmouS2vP8+rF0EBjcd7MRT9fAvFwznaeuGhFu 5xNHLx4SpXmK7S31BLa2yO5LcCphCo2T7WcLI= X-Forwarded-Encrypted: i=1; AJvYcCX8WCHTu7P+a1qupzkrk4wvu/q0AwLJ++Xqu3/uvtI1w1Tc9i9IDQtxmMndeZAbSHlL3uJWAl29EAQDaig=@vger.kernel.org X-Received: by 2002:a05:7022:6299:b0:11c:883d:1ef0 with SMTP id a92af1059eb24-11de94870femr3672951c88.15.1764761886896; Wed, 03 Dec 2025 03:38:06 -0800 (PST) X-Received: by 2002:a05:7022:6299:b0:11c:883d:1ef0 with SMTP id a92af1059eb24-11de94870femr3672933c88.15.1764761886322; Wed, 03 Dec 2025 03:38:06 -0800 (PST) Received: from photon-dev-haas.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb03c232sm83169465c88.6.2025.12.03.03.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 03:38:06 -0800 (PST) From: Ajay Kaher To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Chris Mason Subject: [PATCH v6.12 2/4] sched/fair: Small cleanup to sched_balance_newidle() Date: Wed, 3 Dec 2025 11:20:25 +0000 Message-Id: <20251203112027.1738141-3-ajay.kaher@broadcom.com> X-Mailer: git-send-email 2.40.4 In-Reply-To: <20251203112027.1738141-1-ajay.kaher@broadcom.com> References: <20251203112027.1738141-1-ajay.kaher@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Peter Zijlstra commit e78e70dbf603c1425f15f32b455ca148c932f6c1 upstream. Pull out the !sd check to simplify code. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann Tested-by: Chris Mason Link: https://patch.msgid.link/20251107161739.525916173@infradead.org [ Ajay: Modified to apply on v6.12 ] Signed-off-by: Ajay Kaher --- kernel/sched/fair.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7ba5dd10e..b6637954e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12895,14 +12895,16 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) =20 rcu_read_lock(); sd =3D rcu_dereference_check_sched_domain(this_rq->sd); + if (!sd) { + rcu_read_unlock(); + goto out; + } =20 if (!get_rd_overloaded(this_rq->rd) || - (sd && this_rq->avg_idle < sd->max_newidle_lb_cost)) { + this_rq->avg_idle < sd->max_newidle_lb_cost) { =20 - if (sd) - update_next_balance(sd, &next_balance); + update_next_balance(sd, &next_balance); rcu_read_unlock(); - goto out; } rcu_read_unlock(); --=20 2.40.4