From nobody Fri Dec 19 20:55:05 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21A2245019 for ; Wed, 3 Dec 2025 08:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751669; cv=none; b=H39Hl+Mjq/pCvb4cm2l7Mz0ooQMdyhnllH9RzSDIJYR58ATQjeMqnmgmtsDkh4A0xtXcbAYHjW5EjX6x/6r63b2OgOQy7EL7GkJfEuydAeiIGJQTznKMkHg234ERwSPOmYlg8llxepUZtHQhXNkq1y8xs+HCrdEWbjo4VLtogIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751669; c=relaxed/simple; bh=j7aftyeMQBxQmLD2VgkpnIAk3TjocxVjecaK5X2WABk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DDkb2Dtq2ljQ4RiZW2l2YGtSJKrlSTrWNGWVOAY7kp7AXO8FNKOt1W8StRVhc7SqYZaIcYIPdZQJlg4RtwZqnpuXrvQNrVQR2hA+SRtZRKZnl4mX/FoOPOHdkaQ1pzfXquY0gBr9cQ5wYhWIWvS36ky+jF7YA76axosFhZ4JiEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ExDbezac; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ID4zYzDr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ExDbezac"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ID4zYzDr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B32uAEo3714842 for ; Wed, 3 Dec 2025 08:47:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=E5gNIxh3Gb+LzB1aO4jZ2Kbf7EVoMlAyT34 czuiWpKE=; b=ExDbezac+elO40UH1KJnclqcT3bUoaA4lFso/2hsD1682yiM1EA Jv0+vK3JrXXxhQokd2gh4nnHjd08Aen2jx25uD56iZaM0z3w7pwPKeUhOGtBRm8S G0Yi04/RCInTVCOSEGq5nNS6utZGDsAb0+K6FUFARacPz02P4MrD5LeWOdUGp8gA qPGpkFe/+i/r+R8OcMCLwECp/EsQWg1a4qmC+VtYaU09bDPRSMaATJZcgT8ciy6g W3RcmqnofRvfTCFSGJqwUlUqAv11oVD2tWd3JlrtyxX7Z8Ch+z+xQCpM82zS4aje CMv0rz8izYyKxlIrcOpPtsukTXsB1CQGL+A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4at3r22jj1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 08:47:45 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2217a9c60so1960863185a.3 for ; Wed, 03 Dec 2025 00:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764751665; x=1765356465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=E5gNIxh3Gb+LzB1aO4jZ2Kbf7EVoMlAyT34czuiWpKE=; b=ID4zYzDrSykv2ObY3COVrGunm6XGNwI8J+5loP8I7RmTzjNC+PhFMgyTEcVa8jMb3W INu5B1QHSBbIO44185zlMcSPLUgMZkIOlj0Ei9b7im4LqwcYxRPhJlSNLJhsIl8Dmwuo o/93yXKvvyopPX0QbJ7Zf7ZYxUE1pF6LwXKVIl5loF8hNkYDH5wu2aeNalF74grIalir 88rmeBa0hJRCgvzPv8T4/gFvFZh5WiiMo19RMY76lt8qNr7zFbY2YPXwzIta9Oj+lQ8h 4VSO85MkP9pu3RhlD72glxuCjAX7/EA72s8J/+Wq0u7/oUWyHU8/Y/7nRaNIoLwZxoQi i+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764751665; x=1765356465; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E5gNIxh3Gb+LzB1aO4jZ2Kbf7EVoMlAyT34czuiWpKE=; b=eu2lQk0kzd+F+4bNHe7nYN0910pDI+OZFNTzgN+xjRH8lzVtvkGzxqRSN8VcCy9cCE Ke5r1g/tAZ2y4FEOOaRDsAChMJg+9iIxvZq64BEoY8eZxrrRNQSW0Iqwjg0sUX1vXm34 ZyEFjB/wbfKrAbavIaLQI8Vc4s4obDboyLR0BF99FFSRkuLOKHBFoiIywn9QlxHs65/V lVQMeEsV05WyilosiY2myGfyLwqds2EXBCyFOexCvCdTfyTriVJMHX0JGmEttcl+OLdj uOVGWcbbADxTa1jvRQwJY6r+Rqeh1FC0KaXNtkEx+dVZDzQcLfqli8O7Sb+tVPkB30S4 Cytg== X-Gm-Message-State: AOJu0Yyy0OiVhg38NyVqlBKNTcRtLqcWWCUyOtGum+WWmE4JSJ6IaIP6 44gRKyEO6tLOHc0v4cipI0xTq9+nzfXXH1ClyOE3I6vXSKpHS0IAu4QFCMNwCoiib9eiWPg+KRm uph/9Sg2krMa5atJxaBkSgrRPRYS9p+A2Q5TDp8h819vpriPvdHlkGaK2YPyQxbvuvPA= X-Gm-Gg: ASbGncttf0Z6Gytzgjb2Qyx7h2JAD3uhPDTxL/cMtRU0i0Zi3UBmf4CAWNAExUssju4 peVoFIg4iFN011F0MZaPryh0GqaKRJjRVoaaeKc/eomJeM/u3QXSWfRulFT9NRBL8+DfpPgFz2B M4hl/rG7n/ylvvKiAX8H4HBS0fRr5bA8MmmtKnK62lSS2FAD0+WIlMr9nbu0cM5M5wqpFo1wXJ8 Qtz1SUEEv99+lBLdmSA0OYj945DQpMFm7CJxK9UpbRvRbLmT2GBy8wkTXhgMzh79Mj1EVdqENx0 wQ+EHcZdV9APIzV8xBYa/a9IVN70Yimq//d4m08DJkRojG6XdtZtz15y02OICc3HUmP0JvBUrQn Wy8ITymUkf1e6765Qcgo= X-Received: by 2002:a05:620a:4506:b0:878:16ad:3a5b with SMTP id af79cd13be357-8b5e47a16f3mr201544285a.14.1764751664958; Wed, 03 Dec 2025 00:47:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdw3Ha5EKkMIhcuTPyxKBKXlPagP269PAdYGLGahfnDyWymdi9Ge1/d1BEoKBcF5RUkOnzng== X-Received: by 2002:a05:620a:4506:b0:878:16ad:3a5b with SMTP id af79cd13be357-8b5e47a16f3mr201542285a.14.1764751664546; Wed, 03 Dec 2025 00:47:44 -0800 (PST) Received: from brgl-uxlite ([2a01:cb1d:dc:7e00:4927:87f9:56d:9fc7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792b14ad9dsm11271165e9.12.2025.12.03.00.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:47:43 -0800 (PST) From: Bartosz Golaszewski To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] regulator: check the return value of gpiod_set_value_cansleep() Date: Wed, 3 Dec 2025 09:47:37 +0100 Message-ID: <20251203084737.15891-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: TubzIzBGORaTsUzdDcEnMEaZpa4ilSSZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA2OCBTYWx0ZWRfX3jmRR3uSQ5hd lHWuV6w+S/XN3F7YRdLwgkBdHXmAn49X9LFEeV9VB4QqZDMYZhj4CGjOgmIlmUcM5KUGOc2ckgW JV5mEYJmU0fP/xzlJUg69dnzl9E0gVMUn3HJpNheVzS3lSr0UJ1gdILHRGUMXiQMhJvvAef43fx /kMgaIC11D4AUWpR8WAaXQg5Kwzu/BUlLNLueccQZT4FJE+ts4msDQvWxI+INuGzpXq6Dg0mGbx 71GCuRxoMSFgfSN7yalXn6yL9ON2xLJTCf2BWlMOdjNm2A6HJy9FggbLUfsKrAn8DWN3Ed4H8x4 VqmltSMeJqiHp4jywizM0MUylRpt750XOYbXSrBwRLnZEYKEOyDLcf/LuJbZlMz/rbUpkymbMjl 8f10Dpb+qcv3CAgJsFQmtWrAyCJVbg== X-Proofpoint-GUID: TubzIzBGORaTsUzdDcEnMEaZpa4ilSSZ X-Authority-Analysis: v=2.4 cv=c+WmgB9l c=1 sm=1 tr=0 ts=692ff932 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=E8K05Lh0vZh6IYaEiYgA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-02_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1011 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030068 Content-Type: text/plain; charset="utf-8" gpiod_set_value_cansleep() now returns an integer and can indicate failures in the GPIO layer. Propagate any potential errors to regulator core. Signed-off-by: Bartosz Golaszewski --- drivers/regulator/core.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f4987f54e01b..4b6182cde859 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2823,14 +2823,18 @@ static void regulator_ena_gpio_free(struct regulato= r_dev *rdev) static int regulator_ena_gpio_ctrl(struct regulator_dev *rdev, bool enable) { struct regulator_enable_gpio *pin =3D rdev->ena_pin; + int ret; =20 if (!pin) return -EINVAL; =20 if (enable) { /* Enable GPIO at initial use */ - if (pin->enable_count =3D=3D 0) - gpiod_set_value_cansleep(pin->gpiod, 1); + if (pin->enable_count =3D=3D 0) { + ret =3D gpiod_set_value_cansleep(pin->gpiod, 1); + if (ret) + return ret; + } =20 pin->enable_count++; } else { @@ -2841,7 +2845,10 @@ static int regulator_ena_gpio_ctrl(struct regulator_= dev *rdev, bool enable) =20 /* Disable GPIO if not used */ if (pin->enable_count <=3D 1) { - gpiod_set_value_cansleep(pin->gpiod, 0); + ret =3D gpiod_set_value_cansleep(pin->gpiod, 0); + if (ret) + return ret; + pin->enable_count =3D 0; } } --=20 2.51.0