From nobody Fri Dec 19 21:00:04 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D6AF13D521 for ; Wed, 3 Dec 2025 08:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751224; cv=none; b=g8VBMT59MgQMcovgMD10YIaIZKcIlKoZ2bNtQp/sOTT2+GPtsqgAE78y3eodXN5O//bHuhms5n+pzCmJlVfCQcrsqnxI4c+f5uZvJsGLK6lxKq9tWt58MQZ+RhChE7KHZDSI1UAXH8loTV7AvY6RkBEuLwa3zq0wD3M8D7CbG4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764751224; c=relaxed/simple; bh=4tL0XX2v/ImuD3AFNfZ4adVGbiSeuEmx4UDTbFLM42w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MmtstkTNTMRRPnI8SlDimG8vUbpl8Ou99E3HFXg24HBLMoNFV8/BIji+B7wfHNrLzwIwFQ/BaxVDIG9FVdJEMNX44nF1OtKMjKr0Q1C7EMFSA6Pbk2iV6Xdjwa5/LtlCtI5W/e6Q+l7xFyZgej9cvF9RezVnd6gc3dAnehOmha0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iePUb59a; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iePUb59a" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42e2e77f519so2787817f8f.2 for ; Wed, 03 Dec 2025 00:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764751220; x=1765356020; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4YERDsBGY6ZLvdjA/h59CXe6bvksaKRM4k4+72p5hrE=; b=iePUb59a6az4TZ9QGFb2jy68nUCq/BUJBnpqHoharVoNx9iRxbsxnLM2XrAdriH+nq K6ekMIvvhdl4ngDvUDt0PREdQIcEy3HNGPmtw3u5dzbQsaBmAi0MjI2NysnKL98i0GSz SKEZMtOTR2PB9cv93Ar6bM0v/a5StjCABARdhvisdPHZSNQHf5b/PRLtcyjAZZe41UwR kBnpSNseKsEn+SJsgJjZoiGhd0Yo5XXeHxCz8GbNpCSBMEsI7+/7V5NnTyju/Ew9x303 zygx8cYQ3VCv23kGYm2+u+Z+d1noUcbO/bsz0jAoeYxC9ae1fI9Ow5CgatuM8WrOWym7 tIXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764751220; x=1765356020; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4YERDsBGY6ZLvdjA/h59CXe6bvksaKRM4k4+72p5hrE=; b=MW5S6w/SCxxLnuoUszkdU8XfhMxNw1IeWnWMIHqQCxFXM81UpkshbRzRjVjN/sAMSY XosBPJhYf7Yx7M2CNmBRpN00MOx/a/qg0u3V8NWacSsuZyJmwJ9y4wwdEFd1RJiMK0C8 NGDN47AZHKaytuUUVtujeH6FqdovSsPe5Gw2SsOwHAPKY5d/ryF1MQCO47HNChtLShqT WojFzwrZAOVB3yZ8T4btUwWThKb9UtMmAA0w3UXTFrCGU7AbKGzJgo9wLsudNRL856Yd nKjnOP+IMuH3sa2gdgscsy2++rXcIvGI6K6DuoxDLl10HVg3Hv21KQBAupkhavcjOpgQ xw5Q== X-Forwarded-Encrypted: i=1; AJvYcCX2FzZm9ir8k7wFeat5b1KLmuxB/J2BFrLaZK0lzZj185fJAk5S7d/juiIHV6CNSX9IrL0h6Kepx5HDqqo=@vger.kernel.org X-Gm-Message-State: AOJu0YyCuqcN54bcxS9Qr1y19hfmZf35L/OdOggSeALb/y/4/QFZtBOk iXIIPF/bRArlRjQ+uT/f9iWjc++2KGisZMZYNi54zjSROVocRWinnme7BGeeCEeUDZI= X-Gm-Gg: ASbGncu6CiEVu8qyZqCGmD3xwQoY3hd0i6ptAGb62uQF9ThIdgK1oWDKP3VpQ86chXJ uh266AtQl6C1Fk1oevcqGfuuv7xeYkfvkz2m4z1sxaBVVvMHWf8+NLR4cobDbgxIvZR4w+gg5xq fmiOUJLsbHKPukhdun5fkJyo64mPV329/YLLmjPPxwzGGfrvj6+voacbG8AorVF49aEECrTajYH rGxDJmoL4OjNq7NzsBxuSnImOJvYO4l8mDlF5/5qnloHPGT0a/uFdCuf2s+sduITYGgRXU8EPTY uTYk+V72JlUcYunDf6TQ6E7S87iX//tD0nUDenHZPCQadu15/TreOxQQsPx41mBD4ML1f59WChq us21Q7V/V2/uKwPOh6FUF0h87BbYEBYGMiMIPN7ZxtCcpkSLaczvG2wLqXzenkF1VmaCWUchDUY eDf6SRGFW+LhgKpg== X-Google-Smtp-Source: AGHT+IHVEClXbp6BY9v3fd/AR/zU0b09wXoFomhN0Hpcg3MQgKrJuvMAuL4hyn8XkHo8dIiZVZcvnw== X-Received: by 2002:a5d:584c:0:b0:427:813:6a52 with SMTP id ffacd0b85a97d-42f731c9b2bmr1334752f8f.41.1764751219713; Wed, 03 Dec 2025 00:40:19 -0800 (PST) Received: from gmail.com ([147.161.143.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca9aea3sm37223405f8f.35.2025.12.03.00.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:40:19 -0800 (PST) From: hariconscious@gmail.com To: perex@perex.cz, tiwai@suse.com, cristian.ciocaltea@collabora.com, cryolitia@uniontech.com, franta-linux@frantovo.cz Cc: khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HariKrishna Sagala Subject: [PATCH] ALSA: usb-audio: Initialize status1 to fix uninitialized symbol errors Date: Wed, 3 Dec 2025 14:03:20 +0530 Message-ID: <20251203083319.58555-2-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Initialize 'status1' with a default value to resolve the static analysis smatch reported error "uninitialized symbol 'status1'". The 'status1' variable is used to create a buff using "kmemdup". So, ensure to initialize the value before it is read. Signed-off-by: HariKrishna Sagala --- This patch fixes the below smatch reported errors. sound/usb/mixer_quirks.c:2462 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2467 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2472 snd_rme_rate_get() error: uninitialized symbo= l 'status1'. sound/usb/mixer_quirks.c:2495 snd_rme_sync_state_get() error: uninitialized= symbol 'status1'. sound/usb/mixer_quirks.c:2501 snd_rme_sync_state_get() error: uninitialized= symbol 'status1'. sound/usb/mixer_quirks.c:2522 snd_rme_spdif_if_get() error: uninitialized s= ymbol 'status1'. sound/usb/mixer_quirks.c:2535 snd_rme_spdif_format_get() error: uninitializ= ed symbol 'status1'. sound/usb/mixer_quirks.c:2548 snd_rme_sync_source_get() error: uninitialize= d symbol 'status1'. The below is the flow of 'status1' it is used before initialization. snd_rme_rate_get -> status1 is uninitialized and passed snd_rme_get_status1 -> passed as is snd_rme_read_value -> passed as is snd_usb_ctl_msg -> created buf from status1 using kmemdup usb_control_msg -> sent buf for reading/writing Description of "usb_control_msg", states as " * @data: pointer to the data to send" Later from Usb control request, dst buf is copied to src buf but usb control msg request is made before initialization. Thank you. sound/usb/mixer_quirks.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 828af3095b86..06903c5de087 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -2449,7 +2449,7 @@ static int snd_rme_get_status1(struct snd_kcontrol *k= control, static int snd_rme_rate_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - u32 status1; + u32 status1 =3D 0; u32 rate =3D 0; int idx; int err; @@ -2483,7 +2483,7 @@ static int snd_rme_rate_get(struct snd_kcontrol *kcon= trol, static int snd_rme_sync_state_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - u32 status1; + u32 status1 =3D 0; int idx =3D SND_RME_CLOCK_NOLOCK; int err; =20 @@ -2513,7 +2513,7 @@ static int snd_rme_sync_state_get(struct snd_kcontrol= *kcontrol, static int snd_rme_spdif_if_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - u32 status1; + u32 status1 =3D 0; int err; =20 err =3D snd_rme_get_status1(kcontrol, &status1); @@ -2526,7 +2526,7 @@ static int snd_rme_spdif_if_get(struct snd_kcontrol *= kcontrol, static int snd_rme_spdif_format_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - u32 status1; + u32 status1 =3D 0; int err; =20 err =3D snd_rme_get_status1(kcontrol, &status1); @@ -2539,7 +2539,7 @@ static int snd_rme_spdif_format_get(struct snd_kcontr= ol *kcontrol, static int snd_rme_sync_source_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - u32 status1; + u32 status1 =3D 0; int err; =20 err =3D snd_rme_get_status1(kcontrol, &status1); base-commit: 4a26e7032d7d57c998598c08a034872d6f0d3945 --=20 2.43.0