From nobody Sat Feb 7 23:23:05 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6744114AD20 for ; Wed, 3 Dec 2025 03:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764731486; cv=none; b=oCcj8w4d7urLIII0m5O7Q1GE0QTOOaJIaEdEOE1/dI7ik4e4jKcaES0MSg1WHThRAop/9o0J/XvgKvKrLzD268+qIkh7OnG7MmYBMRpoe+yo0yRVx4xs02t/3ggmMtBf5itCex53Dlu2olb7kiQhICwiLpJKY8aszj1nqdWLXMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764731486; c=relaxed/simple; bh=x2vPXVHvawbRmTSpa9nZ10yNkz8WbOY2O1cL4hKi4NY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=P1sze5mB3uL50lvPvdE73DyboxpzKsewNwRTJkUxft9q+Vlse1UC02Opad2aRRRXgX9b61f4sRK5VAC1if+yCHvF3J89JD67fE87Y93WwGdYxop2hygFR5vmfh9e9p9fSxeifHt1YbGNzfDT2V1PPTs7zodgkc32jfPblIPTUNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EW2wCpul; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EW2wCpul" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3437af8444cso7310348a91.2 for ; Tue, 02 Dec 2025 19:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764731484; x=1765336284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4tkMX4RDJDZIgVTWOWoySUpMyJ+T716kWz62BdzG6AQ=; b=EW2wCpulgOoYLeqmbHpM2rDPzoQ+W1CV+I6dKPhDFIb8cw2PlYh2dbnU5oDVrzYHao 26JD7QKUZVQp8ayCa+PL1JJ7rsj/ula2kHzbYMJvgNPc9gFFtVopFhWRsCreNGDaVhoR NvqwkD0TBXX7qC53/Ayi1sajeiOxW1AbB3YIVhKEeB5nkFHf/i+PgviXVNucpHCattu/ QeXFXR/43EzOd6rniu3epiZiCUyg49vPIfp1zPwWxYpa5tZczc1jM0UfjMT3YBHemY6x D20pHso4nXKttCegsj1MP5LVYSwK+h06pyVSb8PAzOQolM+ZL2THB3g0fTy6c2eeFDCR 9yCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764731484; x=1765336284; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4tkMX4RDJDZIgVTWOWoySUpMyJ+T716kWz62BdzG6AQ=; b=EZPxI1pybzx3VQLAg/RBROfyi9bGWhapYyflcHVvxpBRTxGytraHXSevB1Jfj3CTqE PmbjQxJaDHVupkJ+gs6tXc07eXbBXuKKb8+S0hQG5BRD5bwgutMM+qwEzvZkX0Hb31kB 5i+gpwypX5NMcAThv3uJRT7vgmB4srJc+wPDuG0nOVmqq8/BnTfm3CT0gMd9Ow6VREN7 /2JcWLjOiMtwGTBj1CurDD4/goP2Lq7Y+Gxtqty4HDvXZ+EZeMgOmw8LZ2NQ1gPdcGz6 QZzuLakP7DVXWd02cMGcVcOEi3P166c18LkRn3FWe8HPRSnNBeuCU3gTh0SlNoTHvGr8 Wu6w== X-Forwarded-Encrypted: i=1; AJvYcCXczoN1RNfmGjt7u4zDsacGfPBBtkDjEhR1b6KyG/DSrbeo7rYHekjIRKjVAZi0O8GSba8azPTfh4fKVX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/6MwsRJFrvZbrxfhJOuzFMCfP2RmPni0J7ITJPAbTsMUvKGTg 0uIJk2wD5+e2OhSzQ4H1ehPxS7uHN9AsdJQdmAKjAKn565gyDYHXhLAhZ+2JCscI+MI= X-Gm-Gg: ASbGnctFgcVpFq0xZiIMqOTJ3g3RhZWuFLXa53kPwVhKjb2jrunXkstmY+3jR+gyBbj SnKmpA0JAnyNY0KAzRFjCeyoRiy7XziRwpO/ZBULwQeN8get7xJmbPkG3tBTlci4vwgMy/nE9SW OicElBETPNsYoKpRqtZZrdvdNdgaDHaC3r1JDrpTWi+jjxjCKU9dlF2nPCB6drmHvlH02A+k3qZ JUj6xnBhDYnTaU6lxoDstL9QmuO5v3yPIvXqJjiCCpPl0InBN0CZkxkBhqB0sMFWg1Q3D+soeij 5ss3yoG42GEum2KYIdbUVuqNeeb9gPc7ijS6adeR4sar6FcQ7/9gFJh8XGZ6ZdZzglr84Lnc22S NLFNr3qO9uUhl02m2PtzDx5opHsK2WxL+zs9SkYAaC0lrPl3o2lM9lThbzSjyXXXJ X-Google-Smtp-Source: AGHT+IGRgr4xbKY54/iIc5o4xSlER4wuJj6q8wopL4MWcTYp7loGtaJLfbyQRr5XU0wcHz6Hn//Ckw== X-Received: by 2002:a05:7022:60a:b0:119:e56b:9582 with SMTP id a92af1059eb24-11df0c53421mr780545c88.7.1764731483540; Tue, 02 Dec 2025 19:11:23 -0800 (PST) Received: from gmail.com ([2a09:bac1:19a0:20::4cf:1d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb057cb0sm95783853c88.9.2025.12.02.19.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 19:11:22 -0800 (PST) From: Qingfang Deng To: Christian Marangi , Antoine Tenart , Herbert Xu , "David S. Miller" , Richard van Schagen , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: eip93: fix sleep inside spinlock Date: Wed, 3 Dec 2025 11:11:17 +0800 Message-ID: <20251203031118.32421-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When busy waiting, usleep_range() is called in ring->write_lock's critical section. Remove the sleep. Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 cry= pto engine support") Signed-off-by: Qingfang Deng --- drivers/crypto/inside-secure/eip93/eip93-common.c | 5 +---- drivers/crypto/inside-secure/eip93/eip93-hash.c | 5 +---- drivers/crypto/inside-secure/eip93/eip93-main.h | 2 -- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/inside-secure/eip93/eip93-common.c b/drivers/cr= ypto/inside-secure/eip93/eip93-common.c index 66153aa2493f..00772c7be189 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-common.c +++ b/drivers/crypto/inside-secure/eip93/eip93-common.c @@ -496,11 +496,8 @@ static int eip93_scatter_combine(struct eip93_device *= eip93, again: scoped_guard(spinlock_irqsave, &eip93->ring->write_lock) err =3D eip93_put_descriptor(eip93, cdesc); - if (err) { - usleep_range(EIP93_RING_BUSY_DELAY, - EIP93_RING_BUSY_DELAY * 2); + if (err) goto again; - } /* Writing new descriptor count starts DMA action */ writel(1, eip93->base + EIP93_REG_PE_CD_COUNT); } while (n); diff --git a/drivers/crypto/inside-secure/eip93/eip93-hash.c b/drivers/cryp= to/inside-secure/eip93/eip93-hash.c index ac13d90a2b7c..13b723bb9830 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-hash.c +++ b/drivers/crypto/inside-secure/eip93/eip93-hash.c @@ -270,11 +270,8 @@ static int eip93_send_hash_req(struct crypto_async_req= uest *async, u8 *data, again: scoped_guard(spinlock_irqsave, &eip93->ring->write_lock) ret =3D eip93_put_descriptor(eip93, &cdesc); - if (ret) { - usleep_range(EIP93_RING_BUSY_DELAY, - EIP93_RING_BUSY_DELAY * 2); + if (ret) goto again; - } =20 /* Writing new descriptor count starts DMA action */ writel(1, eip93->base + EIP93_REG_PE_CD_COUNT); diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.h b/drivers/cryp= to/inside-secure/eip93/eip93-main.h index 79b078f0e5da..45afeaa51d00 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-main.h +++ b/drivers/crypto/inside-secure/eip93/eip93-main.h @@ -14,8 +14,6 @@ #include #include =20 -#define EIP93_RING_BUSY_DELAY 500 - #define EIP93_RING_NUM 512 #define EIP93_RING_BUSY 32 #define EIP93_CRA_PRIORITY 1500 --=20 2.43.0