From nobody Sat Feb 7 21:50:39 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689372116F4 for ; Wed, 3 Dec 2025 01:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764725566; cv=none; b=SpFXPvvm7h943qq530x4IyyasYtXCogUoI7MrHMEcnUY40LAwEkKQFl4WMRKOqg7c8P4PtdjGk9yfPK/GpRr2fTEKuA+6pDYnecC7ssFYwCxvsQTA5VOmbk7P2GN/dQ/kP3lXmZUjGm6Z+7U+3CmdaSJxY7+t7Qnqj57cvUaRTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764725566; c=relaxed/simple; bh=HdqN0TjGIINEFptm7Nvl1znQRgZDb6swtYIHkRRlvIY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KKVgy92+ZVoD1GkBj4UgnWumNgJbvi3O08DtNwHvmXA4lE0QVumKXdBavZ2s1AZlTXJE9ED500MsEYVxsSL8gj+uzGrjyWZsUpeWZAFgnoioXtKl/z6NRnDhgJ+0j+JkuKSfwatpoNJu3O9IYf4pxGkOX48G36Tmcni6r/5Dros= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rm1mcVsQ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rm1mcVsQ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779d47be12so50150665e9.2 for ; Tue, 02 Dec 2025 17:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764725563; x=1765330363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eTOcccqrFLWwThaWdKzVQ7M4eJzuu19XG8wwoiIcr+k=; b=Rm1mcVsQgogqApaF7FxdSsJ/tywpUGq+2mhOw7nhSKfS0rYy+CFBlD9A5SERBKpJru w0PK57his4VxpChY+MuSroGv9Z2KQx9hn7idacI+Z++j7hBoZNYjEhKuOTiEZLrXnNMx mwp5IBp1xV4efHN32HmoXqDwtsCW6HdIB81bslEkwksZiQSgW1QHFX3PXYCVh5o0qhdv X9hfbcMDwm6pAtMV2uVDDAdTBCwCd66er7xi2OuYoj/2DS7r7TV9thTaElhY5gW461ZT 94eXdZ+QiuMr1FcPz0SJWxwlsfcmf8duEZe08bb+TMPpcTxNY8dGTk7I7B4zPkT8IxQ4 GfOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764725563; x=1765330363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eTOcccqrFLWwThaWdKzVQ7M4eJzuu19XG8wwoiIcr+k=; b=VAelta8tP1mqF08I8Z+WQcJPUUYHOVf0lxD65NVdwQwLLywuMjJBKVF2t01g1LGiXL v00UydyVhGATwgpHmDv7uX66lk5LocqrGAqgBa5y+k6vnBGLrHIVp/xwd2KWGnbH8fzU NXzrLRhpbkcJrgTN6fxu67w5q3EBb/YnqW2tYATCDLt6SOmpTqFGN08ZrQN6fk8kovyv fzLkUpvjmMYZBps8yTUCUQZlt5XQtOFfIc6zGAo/Arggb72Ei5QLScmIHnYl7k47BJvt 9pvRmBIGCkA+6LthPcdZTWJTvWPTBR5WKX6YXCIC3CRZQc4U3W8WV8BwbExUuDlQs3p1 wWiw== X-Forwarded-Encrypted: i=1; AJvYcCWdMf7xM3rJdJhMcoItX3OvyjPVI7p06+qAuOtQDY7FNaU/iJnoD6usMZslqzxnseA6phsVtZ7Yv4BhFwc=@vger.kernel.org X-Gm-Message-State: AOJu0YyvbVdzJdO0Qk5UsxgqkmfH20/HHWmjVJSIESzkc1sa1t8tsrm4 MD5RtRkLaAXtV7ir6vxdT+peyZOWpvi6psSVxKK0tFXMeZdtslhVZ1+O+PjURDcm X-Gm-Gg: ASbGnctPzY+OpGxZdlS6pATyG4MjefeCUsn+dc7ZHl6nXD5LtGRHiD95utXSZzlLdZt FANbAgFXLy2YSCJYSvGuCookcXzQ2Sxa9wKrC2qSb82iCeA9lvrw0EwXXzQJQ3numQRpavsCkxB B5jh4TS+ajTsRhAv8atH7Op5MPt86HDUCvX9c8cuPj+fCV3coz2tbVpZ6mYNG3K1cOgr/NBVY/k sOxa9yusPi2q1p016dNJ8pfOJFCqp+Df67R/ryJD8rtHh70U9SybGbHH08b2lfO+caBL5EGpVfs dNXiQK4Bb1DojdGCCY38Hk1YwDym2GZz0DB1VBKHaTAqrgV7/0GfMh3kV3S7NzYNkjvexbiGIYg +fnu4okf1dYnF2m1WCAwWESoAxEUrBsDgChK3cAKowKPqoAOxiY/6Gpe/SJlMNsMsJp4Tkht/JA sLMe62obt7xAbGksdX X-Google-Smtp-Source: AGHT+IEET8MMX8Xhn2CMl4tEK1KqNLyGoioso3/ZgB1ZWKgRfMhon8oV9N2dNt1Y7AkGknU75WSwKQ== X-Received: by 2002:a05:600c:19ca:b0:477:557b:691d with SMTP id 5b1f17b1804b1-4792af3d28amr3978995e9.25.1764725562735; Tue, 02 Dec 2025 17:32:42 -0800 (PST) Received: from felix.localdomain ([169.224.5.245]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca1a310sm38151131f8f.26.2025.12.02.17.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 17:32:41 -0800 (PST) From: duccdev To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, duccdev Subject: [PATCH] staging: rtl8723bs: clean up comments in rtw_ap.c Date: Wed, 3 Dec 2025 04:32:29 +0300 Message-ID: <20251203013229.696285-1-duccybaka@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed 4 multi-line comments to follow kernel coding style. Improved clarity and fixed overly long lines reported by checkpatch. Signed-off-by: duccdev --- drivers/staging/rtl8723bs/core/rtw_ap.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 0908f2234f67..210fa5388a01 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -391,7 +391,7 @@ void update_bmc_sta(struct adapter *padapter) =20 memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats)); =20 - /* psta->dot118021XPrivacy =3D _NO_PRIVACY_;//!!! remove it, because it = has been set before this. */ + /* psta->dot118021XPrivacy is already set earlier; do not reset it here.= */ =20 /* prepare for add_RATid */ supportRateNum =3D rtw_get_rateset_len((u8 *)&pcur_network->supported_ra= tes); @@ -658,9 +658,11 @@ void start_bss_network(struct adapter *padapter) cur_bwmode =3D CHANNEL_WIDTH_20; cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_DONT_CARE; =20 - /* check if there is wps ie, */ - /* if there is wpsie in beacon, the hostapd will update beacon twice when= stating hostapd, */ - /* and at first time the security ie (RSN/WPA IE) will not include in bea= con. */ + /* + * Check for a WPS IE. When WPS information is present in the beacon, + * hostapd updates the beacon twice during startup. On the first update, + * the security IE (RSN/WPA) may not yet be included. + */ if (!rtw_get_wps_ie(pnetwork->ies + _FIXED_IE_LENGTH_, pnetwork->ie_length - _FIXED_IE_LENGTH_, NULL, NULL)) pmlmeext->bstart_bss =3D true; @@ -841,8 +843,16 @@ int rtw_check_beacon_data(struct adapter *padapter, u8= *pbuf, int len) memcpy(pbss_network->mac_address, myid(&padapter->eeprompriv), ETH_ALEN); =20 /* beacon interval */ - p =3D rtw_get_beacon_interval_from_ie(ie);/* ie + 8; 8: TimeStamp, 2: Bea= con Interval 2:Capability */ - /* pbss_network->configuration.beacon_period =3D le16_to_cpu(*(unsigned s= hort*)p); */ + /* + * In the beacon IE, the layout starts with: + * - 8 bytes: timestamp + * - 2 bytes: beacon interval + * - 2 bytes: capability info + * rtw_get_beacon_interval_from_ie() extracts the beacon interval field. + */ + p =3D rtw_get_beacon_interval_from_ie(ie); + + /* pbss_network->configuration.beacon_period =3D le16_to_cpu(*(unsigned s= hort *)p); */ pbss_network->configuration.beacon_period =3D get_unaligned_le16(p); =20 /* capability */ @@ -1147,7 +1157,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u= 8 *pbuf, int len) /* update AP's sta info */ update_ap_info(padapter, psta); =20 - psta->state |=3D WIFI_AP_STATE; /* Aries, add, fix bug of flush_cam_entr= y at STOP AP mode , 0724 */ + /* Aries, add, fix bug of flush_cam_entry at STOP AP mode, 0724 */ + psta->state |=3D WIFI_AP_STATE; rtw_indicate_connect(padapter); =20 pmlmepriv->cur_network.join_res =3D true;/* for check if already set beac= on */ --=20 2.52.0