From nobody Tue Feb 10 07:44:21 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36902D63FF for ; Wed, 3 Dec 2025 08:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; cv=none; b=owwNdUvplKmlRFMAaLY4rvTydhJ+0j+LX8GEm6W8IiZ+oUW1yux8IprgEASfqeM66SICiBEvG21AP1vaUURvu61aNKDX/+j3Xd83LHlIHDwdL6NrxzDPLtcBSrMzd0kywf14mocAa2/snkWhWZreygCCfI0XJGz5ulw+5F/efGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; c=relaxed/simple; bh=TZXuHFaq1KyCSjmm/uTwxEj/hY+OqQUuzjmQobk8SFU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sm3bOkg+BA6omxJm3+UhI4Xiz/s+nYruydq0ETpibRGAtT+5D0Y/GylEBeVgDmMRma0I5efKiMsaBvt9rjkAwXxDw9NfO6diZVWBXRxoFpL2nuU9tsn1g9ymmN5rM+IgxONAfNFR0Ps831kuS1BvXc41d2esX0BHIoexd5WFUSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MXi03m5C; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MXi03m5C" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-594330147efso6159981e87.2 for ; Wed, 03 Dec 2025 00:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764752140; x=1765356940; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YQl0/Jxgcp0DOIGMQfCvGhWySrzIG1pMZYIP0O7Y5Yc=; b=MXi03m5C2tB48/s/KiMlCD8h7B7mS2jhwMWPQN9PC1O+Rek5eL2cxhHaYmlG7p79vV 0OsItXF1i6ZzR6zP2VbG6K7CoYemwqDHaxCxtZC64TeNa6PyzZwUqAH0mB8Ti/sbdkti Lo3XSC8qqmyd0gKjEJtVlHyogbTdLicN6NjI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764752140; x=1765356940; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YQl0/Jxgcp0DOIGMQfCvGhWySrzIG1pMZYIP0O7Y5Yc=; b=cimss8GNLLuD6C/4aSCkbA0N5JN8hgNbFrw1Xf+GN4V+tBBjjN3EhszL2+JtPvHkFi HYBbWSfTw1Vwn7VnqJ1pmPvJTkKu97/uNy5j9kfBL/t5ltPCCKGPyDmAK0BOKCczURrK VC3+AMEcyusCSSg24kogVqY6mPxHJxhC3/XLrRsIoeWf9gQEwdegi2fY50iOiT+3x2lf bbeoNu8CrSFCJXzUgCPjTERy9eFfwlRYegxGo2GYXS49uhq8029yAPWfPBcXlXT4IwqA hIzaGNqMku7NUotX/tA249Ep0GeuZbT8FUhtSGu2tZ0M2QbsYvKfkwTDRJpwxdWnw3DY hv5w== X-Forwarded-Encrypted: i=1; AJvYcCWfSWsn2K9nwcIDYMij4xKprBkq4X4dDJlKmPSsytwuJUgpG+LUfhIoKWzN9hpyhGW2dC7R9m2nkPtEdck=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1qB7PInzYC+J5tcVNnqbnfGr4G1iuOVkUr/Xr5edCKBhIAFly B73O5wL9B65Vd3WnDYrL2Z0kWIX0ZmfQP02R/yMGkmlH3dyJ1aYImVwue0bQpLxzlQ== X-Gm-Gg: ASbGnctbFhhk6sNvdIYURHVKWpEg+H8vvO2hA9W/h1l9kiNM6kzUZqkCnOLHS9UycEF Mz+zbpzldf5WhsxVl5+bmShOTNQWdq//x7RQvR+vNrw+/EfJgHTTaPJg9XunknRolHu2ezBCkJk TO9I4MNyX065LNq5xY5ShhjO3vX25PoaG2yIN1WwDYh14UM26aHvEoZxkQcBqgoaPuqZqsjNJ6J IxP0eak0f/7PoLx0+WVyHxQtlb1TQSx4qwtN1/xwVhf5/Adh6gOTPbWLpK+8oLUc44eGZ8CyxWe xMZm7J1zt72iwdfFPyjPNG1hBr5iJvcuSaHxfagR7hx3YJao64WbNL/2eSzZOqMyuOJ2aU02p/5 b8rhk2jVDlaH/RUadBsk1re86+ieqeorefLd8pXrisiBWsLx9iYMxk6Xi+sTwQ8BPLDTBF9FdPV XIWzXg9DA/TI4J/XPn1m6pIVVHlHSs3QNLfKG0p8yIwPwRdqQvPS0vESdsRXI4/8BbkbaXGw== X-Google-Smtp-Source: AGHT+IGlFlHmXIUMj1dgYAUXjSWNyqsmGRvD2s4S8AesPq+R0ZFdEvdTmQACTlVbKUfIiYs7iMs7OA== X-Received: by 2002:a05:6512:2307:b0:594:2934:8b83 with SMTP id 2adb3069b0e04-597d3fab04cmr678826e87.30.1764752139753; Wed, 03 Dec 2025 00:55:39 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596bfa43f3esm5315377e87.47.2025.12.03.00.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:55:39 -0800 (PST) From: Ricardo Ribalda Date: Wed, 03 Dec 2025 08:55:36 +0000 Subject: [PATCH 3/3] media: iris: Fix fps calculation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-warnings-6-19-v1-3-25308e136bca@chromium.org> References: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> In-Reply-To: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 iris_venc_s_param() uses do_div to divide two 64 bits operators, this is wrong. Luckily for us, both of the operators fit in 32 bits, so we can use a normal division. Now that we are at it, mark the fps smaller than 1 as invalid, the code does not seem to handle them properly. The following cocci warning is fixed with this patch: ./platform/qcom/iris/iris_venc.c:378:1-7: WARNING: do_div() does a 64-by-32= division, please consider using div64_u64 instead Fixes: 4ff586ff28e3 ("media: iris: Add support for G/S_PARM for encoder vid= eo device") Reviewed-by: Dikshita Agarwal Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/iris/iris_venc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/p= latform/qcom/iris/iris_venc.c index 5830eba93c68b27fa9db87bac63a691eaca338d2..730f2aa1a83b2f4f90227ab9a7e= 04aee7c2c3cfe 100644 --- a/drivers/media/platform/qcom/iris/iris_venc.c +++ b/drivers/media/platform/qcom/iris/iris_venc.c @@ -408,11 +408,10 @@ int iris_venc_s_param(struct iris_inst *inst, struct = v4l2_streamparm *s_parm) us_per_frame =3D timeperframe->numerator * (u64)USEC_PER_SEC; do_div(us_per_frame, timeperframe->denominator); =20 - if (!us_per_frame) + if (!us_per_frame || us_per_frame > USEC_PER_SEC) return -EINVAL; =20 - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + fps =3D USEC_PER_SEC / (u32)us_per_frame; if (fps > max_rate) { ret =3D -ENOMEM; goto reset_rate; --=20 2.52.0.158.g65b55ccf14-goog