From nobody Fri Dec 19 20:52:53 2025 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5430B2C0F9C for ; Wed, 3 Dec 2025 08:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752142; cv=none; b=Gg/J+EMeZz/fsyHZ7jFQCsMfL2Jm9voIA4F5CbfRKY4jDvZ7gJ87xRkRI3dHeO1ClWwkE4NNNYVi5emxe3jyHvrlCo21GPva8goj0mM4SRRclRtzh2yiN2ad+/Pwc59fpD0QwzKV0twXFBuUEgbKTOwlI3rHAdFvij8cYAH5DtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752142; c=relaxed/simple; bh=KRjf6rI6QeytErOhTZc6Hqc8yif5VI8/8ZIpds2a6M4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RBHMUo2DiO9sFYephoPIhm0VH8FODB2MIX4gh1PCwL0d6sRwlYchLQqsvovSrMFKjkjXYuFZ5+rByVaqbsT7cWrZFaidKHi4STd+NCyuFARPBxgALrTSm5xnb79wyAnbZd54BZpZGNzud3oqLlplaaPZ2FJf06IFKlcDsdbDdBo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nL/66nl6; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nL/66nl6" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-596ba07504dso5519202e87.1 for ; Wed, 03 Dec 2025 00:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764752138; x=1765356938; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=woHXwxvxfwFTv0q/SqwVCTAjIUDR9jdYwm8dKIe3Yl4=; b=nL/66nl6Eo1iAwyzy1bN5vCPXgxbn5AKL0d+N0TobH598vXYk/lCGHpXemuKlCiRVE Oym1V5T1VktChhfnfNAgk/IXDJel76XomfDUGu9xGbe2sb/XomFsKBKackAnwiZDvTw4 Pjp2mbX+I3wsoBlwVUAliWFfO/rFKKfttW6Do= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764752138; x=1765356938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=woHXwxvxfwFTv0q/SqwVCTAjIUDR9jdYwm8dKIe3Yl4=; b=nh64yFNCT9yVndeeyMMi5qzrlCgfBpiD94FJjCyvUcv77xqzX0wly7O4I4CMXVEz2+ EqIl2QtpP8w413/M/mR6VpmAiQK1bcf+Fah4kzblYWFuJ8LqovUIARVrpNkG9380DGJq ev/2AieOmMvE39OaFKd009ZQtjMJQUKNXVnhS5XPas+KgFpuuQINDRN1fYZyvZyZUnph aAM5oSxV7GOkIkUrh9grSHSruVIdES3n/nN98U2DuyZdio754dSBAWoq/NHnggoDQg66 88ZOXBJcaXe2fuZjqmret9hom0iJ7vJ+nVQDFmz7GcVoS+vZnGfolKZAn/L8DQNn1y8w qeUQ== X-Forwarded-Encrypted: i=1; AJvYcCWLtNE85uQ4oiSnLcoIBE4VcLiiHopjPWZIzbeNlNuTn3ppnIU5Eg9Np8w7rlhWUbwWnoXwMrt2Y45b0Yg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz084jwJqgGKvVciZ0Thcoc68KJDQhPULKBnZLVy+JcuDVoq+Cx 1jq3UzmfVFiW4bO7q7dllXfrN6BIMRGSBHCz+mYVvNOvzs3PZ3xPPOXpl1yRxvluMQ== X-Gm-Gg: ASbGncvLsQUZZ+HtWMxeuGZgVxUSqq08wbfCoQJPCbz9zKyuRggXw1g/A71EXYIxpU/ 4ksqPpIu/CVUXSg3XzVxaS38Yxzfp+KiC5KzLyKJ4ge94q7E0NpYqSBAqsvFvCiQiUIruiGNjFk +lrUWlIA8omBHHsNgcjWk9FGsehNI2OaaiRY9yf4GK84b1BEc2WUIE7BDn+2SjPCKj6mxTJOPIG TGa8STTEHcIuYWhOL4RtNqm3qkWKdB5dIbycn4toTzDoGqhZ0VzZT5XvqVaA9l5ZU+egivMzEEx U6LSYB44JHfRPDOj/xWbwv+P8jLc69u701eVUfVJi0rp0y3cvZfk8NLYC4+8dG2Qh+6M01s+bK5 Y4doFYOMyLwkKMihFYIGN+wbjWNhMluBSszMZqCi+kELJM3ahBwU1lhxJqVqmoQ1eiWLdjZJR5T KhCCbyIH6Gqhk7hozOI8rgsh1z/KKEJ8moAziyKSuxpWegRt7jJP7IzPOPHON7XiKg6DJLqcuTA inMLVzJR5rjWjZAZ74= X-Google-Smtp-Source: AGHT+IFTKSoVv7lOSXtd9iPwhZeRSNLFxYSPOIOsHgyo/230WEcBofLQ8T4STXRlBe4/0ZQCEDG4nw== X-Received: by 2002:a05:6512:b8c:b0:577:2d9:59f1 with SMTP id 2adb3069b0e04-597d3f37650mr683682e87.19.1764752138351; Wed, 03 Dec 2025 00:55:38 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596bfa43f3esm5315377e87.47.2025.12.03.00.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:55:37 -0800 (PST) From: Ricardo Ribalda Date: Wed, 03 Dec 2025 08:55:34 +0000 Subject: [PATCH 1/3] media: uapi: c3-isp: Fix documentation warning Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-warnings-6-19-v1-1-25308e136bca@chromium.org> References: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> In-Reply-To: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda , Stephen Rothwell , stable@vger.kernel.org X-Mailer: b4 0.14.2 From: Jacopo Mondi Building htmldocs generates a warning: WARNING: include/uapi/linux/media/amlogic/c3-isp-config.h:199 error: Cannot parse struct or union! Which correctly highlights that the c3_isp_params_block_header symbol is wrongly documented as a struct while it's a plain #define instead. Fix this by removing the 'struct' identifier from the documentation of the c3_isp_params_block_header symbol. [ribalda: Add Closes:] Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20251127131425.4b5b6644@canb.auug.org.a= u/ Fixes: 45662082855c ("media: uapi: Convert Amlogic C3 to V4L2 extensible pa= rams") Cc: stable@vger.kernel.org Signed-off-by: Jacopo Mondi Signed-off-by: Ricardo Ribalda --- include/uapi/linux/media/amlogic/c3-isp-config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/media/amlogic/c3-isp-config.h b/include/uap= i/linux/media/amlogic/c3-isp-config.h index 0a3c1cc55ccbbad12f18037d65f32ec9ca1a4ec0..92db5dcdda181cb31665e230cc5= 6b443fa37a0be 100644 --- a/include/uapi/linux/media/amlogic/c3-isp-config.h +++ b/include/uapi/linux/media/amlogic/c3-isp-config.h @@ -186,7 +186,7 @@ enum c3_isp_params_block_type { #define C3_ISP_PARAMS_BLOCK_FL_ENABLE V4L2_ISP_PARAMS_FL_BLOCK_ENABLE =20 /** - * struct c3_isp_params_block_header - C3 ISP parameter block header + * c3_isp_params_block_header - C3 ISP parameter block header * * This structure represents the common part of all the ISP configuration * blocks and is identical to :c:type:`v4l2_isp_params_block_header`. --=20 2.52.0.158.g65b55ccf14-goog From nobody Fri Dec 19 20:52:53 2025 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F2B2D062A for ; Wed, 3 Dec 2025 08:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; cv=none; b=i4u1N+E+yfKQL8Ev42iL0pplN1M9R7h1O6Yva6qPMHYsPnAtiW9fDYpTt6FknvrXRxoI7j1y36wvsb2SlEvcuxvRR0dEwPXxdDr0Rx+ByX+MKz8GarZIJTWNd9lrmgHsSrYT5pl4nLLcRkO6x3IyI61pIf0pycC1DemP3iq0JS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; c=relaxed/simple; bh=3oJz3ZltYDqpWr5+uCLuJCyHQnDQ/0WypPYIDHiOHFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TbMsnK55xk+AgHPDJqEFicjPyrS7YzanTk/XK16rSXjDcSSEoMzykKIrhXDITPVJ+zUlrJUQyo5F0obR8hOJ44VFYOwTKPD11QPVC9JWTchLQp860XZ3SXTKUsC30lL4SfOOh+4pI2+t1CCTvJI9R0flalSUOkVEx+8DpIkS0rU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=HqlZFvJU; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HqlZFvJU" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-37b97e59520so41880131fa.2 for ; Wed, 03 Dec 2025 00:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764752139; x=1765356939; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l8y22R6XWDK/GOldRzQWK9Q2C3Ir5yEJKiaGjpAlLmI=; b=HqlZFvJUMBtNMJAhJwVy7XovhNQjsZYMYnevf456rShaLAG89zUNxnBFi2AEt58EqA m59umu08WtramawEKQi6cUwIW33eeMbAps24VSl+RuJjhIBAa+wePg5dafBOxr2vBEK7 W6liiX9uwkAT5I+4CbUZ8aEAPCqJkXg4telYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764752139; x=1765356939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l8y22R6XWDK/GOldRzQWK9Q2C3Ir5yEJKiaGjpAlLmI=; b=f3QM7bZw6kX1VhMkdLM9T4xn+Md6Kx4SatxkbutY/zkGXKEu80vUiwwU/V642kOunv lly28W8gityDJMtWPARKXtuyxdj3jaj/2sqA3OPZhCX2K16RjahMppqKuxFUYtokPYJS ZKD7rSZIWqoRylsS0Lb1Mef0mEa0ZOuDcXGNtJK0Ug7jQnn52fC6uEWREZ2qflfx5xqH WOwQwUJ7HQd6E+WmwAv1swpVjRkBMR/98ZgBi/1yqaA/V5+LUpG95rQKRiko98Tc7t4I Li6szEMzGRdiKYlqrvaxCZD6wO2c2xCm4D+Kj6ZNw0Zg5YL0pc9WLinjm5iHr8S+Ofxj 7nZQ== X-Forwarded-Encrypted: i=1; AJvYcCXLW5vJSUGWJLV/4XyMAgrdLndVh1HgePtggw/2lpBFU+3L7yL+cwsWJQ+vd/KKOX2kHtfkto+OvbRxvss=@vger.kernel.org X-Gm-Message-State: AOJu0YwkC2bOFHG5Hl8UZdgj08sQrSmhoaUAAtikA8Q9R4Hz4xKp0hin mUyxSxVSy1gjy/6qq+h8jSeJPk6hwhpPaxTMxPOp7ufgtOgIo6X5p5YjAdjRQSMvybHazEvd/uS P0W0= X-Gm-Gg: ASbGncvJ/oWj7PRBdwhHt260/fztsW/COL4gfdrmirijrlUF12SxQS4StTRu094MGqs zxoDUH9Qmh4yABThqjn6p9LTuiaTAX4ZfxhBv7WyLy4zpPsXsUA2jJ4Hr47aQstj6fMrAqQhv6a QaOHrQXKrlddVUBPdToYrnZmtdNHdSLMI2cWf9sGpTIDT5KK2N3N1ibL1Ozn9Wi8qJ6ijPFcZ+K +9u/+wp7TSR9wsSOvT97L0YTq50RelEG8Ky4yKY7+8MKJNbIC32CuC3MDI/1y64oXfCVlikQRWm f4zWgEMINbQ3iUVF8P9e6Z7XxNlxZE8Ii7He1ReR+NFHwu2oDnhilhZc44Q4ZCgwMaSrxYpEbr1 MEG8tK9CvRdFGwyZuYBNOqcU96kPc6d1xK1blURizkh3mANySscXfnZeTTlxWJYURo/kF/PP+IU LJZhBK5GVSijOO9ESku/r+nTndI+rn0pm5iRVuPAn9k8X2ZFse2bEeQRjeU8TJL5CZeHTRrQ== X-Google-Smtp-Source: AGHT+IF3xsdoMGrgPPAVSpklnW3yTghz2fpZ17/ANQgtvfY6FupWoRh+Pdfp2OA8LBXT6KUdlKgBEA== X-Received: by 2002:a05:6512:3094:b0:595:831d:22e9 with SMTP id 2adb3069b0e04-597d3efd920mr696138e87.1.1764752139058; Wed, 03 Dec 2025 00:55:39 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596bfa43f3esm5315377e87.47.2025.12.03.00.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:55:38 -0800 (PST) From: Ricardo Ribalda Date: Wed, 03 Dec 2025 08:55:35 +0000 Subject: [PATCH 2/3] media: iris: Document difference in size during allocation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-warnings-6-19-v1-2-25308e136bca@chromium.org> References: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> In-Reply-To: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 As we get ready for kzalloc checking for invalid sizes, let's add documentation for the cases where the size is different but valid. This patch fixes this cocci warning: ./platform/qcom/iris/iris_hfi_gen2_command.c:1215:9-25: WARNING: casting va= lue returned by memory allocation function to (struct iris_inst *) is usele= ss. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index f9129553209922fda548ca320494ae6ae797854c..ab91afd0597045bd876d0411b08= b5a3421b12c70 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -1212,5 +1212,13 @@ void iris_hfi_gen2_command_ops_init(struct iris_core= *core) =20 struct iris_inst *iris_hfi_gen2_get_instance(void) { - return (struct iris_inst *)kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP= _KERNEL); + struct iris_inst_hfi_gen2 *out; + + /* + * The allocation is intentionally larger. The first member of + * struct iris_hfi_gen2 is struct iris_inst. + */ + out =3D kzalloc(sizeof(*out), GFP_KERNEL); + + return (struct iris_inst *)out; } --=20 2.52.0.158.g65b55ccf14-goog From nobody Fri Dec 19 20:52:53 2025 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36902D63FF for ; Wed, 3 Dec 2025 08:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; cv=none; b=owwNdUvplKmlRFMAaLY4rvTydhJ+0j+LX8GEm6W8IiZ+oUW1yux8IprgEASfqeM66SICiBEvG21AP1vaUURvu61aNKDX/+j3Xd83LHlIHDwdL6NrxzDPLtcBSrMzd0kywf14mocAa2/snkWhWZreygCCfI0XJGz5ulw+5F/efGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764752143; c=relaxed/simple; bh=TZXuHFaq1KyCSjmm/uTwxEj/hY+OqQUuzjmQobk8SFU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sm3bOkg+BA6omxJm3+UhI4Xiz/s+nYruydq0ETpibRGAtT+5D0Y/GylEBeVgDmMRma0I5efKiMsaBvt9rjkAwXxDw9NfO6diZVWBXRxoFpL2nuU9tsn1g9ymmN5rM+IgxONAfNFR0Ps831kuS1BvXc41d2esX0BHIoexd5WFUSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MXi03m5C; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MXi03m5C" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-594330147efso6159981e87.2 for ; Wed, 03 Dec 2025 00:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764752140; x=1765356940; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YQl0/Jxgcp0DOIGMQfCvGhWySrzIG1pMZYIP0O7Y5Yc=; b=MXi03m5C2tB48/s/KiMlCD8h7B7mS2jhwMWPQN9PC1O+Rek5eL2cxhHaYmlG7p79vV 0OsItXF1i6ZzR6zP2VbG6K7CoYemwqDHaxCxtZC64TeNa6PyzZwUqAH0mB8Ti/sbdkti Lo3XSC8qqmyd0gKjEJtVlHyogbTdLicN6NjI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764752140; x=1765356940; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YQl0/Jxgcp0DOIGMQfCvGhWySrzIG1pMZYIP0O7Y5Yc=; b=cimss8GNLLuD6C/4aSCkbA0N5JN8hgNbFrw1Xf+GN4V+tBBjjN3EhszL2+JtPvHkFi HYBbWSfTw1Vwn7VnqJ1pmPvJTkKu97/uNy5j9kfBL/t5ltPCCKGPyDmAK0BOKCczURrK VC3+AMEcyusCSSg24kogVqY6mPxHJxhC3/XLrRsIoeWf9gQEwdegi2fY50iOiT+3x2lf bbeoNu8CrSFCJXzUgCPjTERy9eFfwlRYegxGo2GYXS49uhq8029yAPWfPBcXlXT4IwqA hIzaGNqMku7NUotX/tA249Ep0GeuZbT8FUhtSGu2tZ0M2QbsYvKfkwTDRJpwxdWnw3DY hv5w== X-Forwarded-Encrypted: i=1; AJvYcCWfSWsn2K9nwcIDYMij4xKprBkq4X4dDJlKmPSsytwuJUgpG+LUfhIoKWzN9hpyhGW2dC7R9m2nkPtEdck=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1qB7PInzYC+J5tcVNnqbnfGr4G1iuOVkUr/Xr5edCKBhIAFly B73O5wL9B65Vd3WnDYrL2Z0kWIX0ZmfQP02R/yMGkmlH3dyJ1aYImVwue0bQpLxzlQ== X-Gm-Gg: ASbGnctbFhhk6sNvdIYURHVKWpEg+H8vvO2hA9W/h1l9kiNM6kzUZqkCnOLHS9UycEF Mz+zbpzldf5WhsxVl5+bmShOTNQWdq//x7RQvR+vNrw+/EfJgHTTaPJg9XunknRolHu2ezBCkJk TO9I4MNyX065LNq5xY5ShhjO3vX25PoaG2yIN1WwDYh14UM26aHvEoZxkQcBqgoaPuqZqsjNJ6J IxP0eak0f/7PoLx0+WVyHxQtlb1TQSx4qwtN1/xwVhf5/Adh6gOTPbWLpK+8oLUc44eGZ8CyxWe xMZm7J1zt72iwdfFPyjPNG1hBr5iJvcuSaHxfagR7hx3YJao64WbNL/2eSzZOqMyuOJ2aU02p/5 b8rhk2jVDlaH/RUadBsk1re86+ieqeorefLd8pXrisiBWsLx9iYMxk6Xi+sTwQ8BPLDTBF9FdPV XIWzXg9DA/TI4J/XPn1m6pIVVHlHSs3QNLfKG0p8yIwPwRdqQvPS0vESdsRXI4/8BbkbaXGw== X-Google-Smtp-Source: AGHT+IGlFlHmXIUMj1dgYAUXjSWNyqsmGRvD2s4S8AesPq+R0ZFdEvdTmQACTlVbKUfIiYs7iMs7OA== X-Received: by 2002:a05:6512:2307:b0:594:2934:8b83 with SMTP id 2adb3069b0e04-597d3fab04cmr678826e87.30.1764752139753; Wed, 03 Dec 2025 00:55:39 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-596bfa43f3esm5315377e87.47.2025.12.03.00.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 00:55:39 -0800 (PST) From: Ricardo Ribalda Date: Wed, 03 Dec 2025 08:55:36 +0000 Subject: [PATCH 3/3] media: iris: Fix fps calculation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-warnings-6-19-v1-3-25308e136bca@chromium.org> References: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> In-Reply-To: <20251203-warnings-6-19-v1-0-25308e136bca@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 iris_venc_s_param() uses do_div to divide two 64 bits operators, this is wrong. Luckily for us, both of the operators fit in 32 bits, so we can use a normal division. Now that we are at it, mark the fps smaller than 1 as invalid, the code does not seem to handle them properly. The following cocci warning is fixed with this patch: ./platform/qcom/iris/iris_venc.c:378:1-7: WARNING: do_div() does a 64-by-32= division, please consider using div64_u64 instead Fixes: 4ff586ff28e3 ("media: iris: Add support for G/S_PARM for encoder vid= eo device") Reviewed-by: Dikshita Agarwal Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/iris/iris_venc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/p= latform/qcom/iris/iris_venc.c index 5830eba93c68b27fa9db87bac63a691eaca338d2..730f2aa1a83b2f4f90227ab9a7e= 04aee7c2c3cfe 100644 --- a/drivers/media/platform/qcom/iris/iris_venc.c +++ b/drivers/media/platform/qcom/iris/iris_venc.c @@ -408,11 +408,10 @@ int iris_venc_s_param(struct iris_inst *inst, struct = v4l2_streamparm *s_parm) us_per_frame =3D timeperframe->numerator * (u64)USEC_PER_SEC; do_div(us_per_frame, timeperframe->denominator); =20 - if (!us_per_frame) + if (!us_per_frame || us_per_frame > USEC_PER_SEC) return -EINVAL; =20 - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + fps =3D USEC_PER_SEC / (u32)us_per_frame; if (fps > max_rate) { ret =3D -ENOMEM; goto reset_rate; --=20 2.52.0.158.g65b55ccf14-goog