From nobody Fri Dec 19 20:34:56 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 076AE330B2C; Wed, 3 Dec 2025 15:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764777141; cv=none; b=McNWH6HWIvhzPfGtvwxrngId5a2dduZZhL1LkkJHysqWgQChD7ERzbQld9Y4Q7Q6W9cxrnaBIPhNwFlpyF7rVtWPSQLQPhKen1JJftscXbbAtWi+r4vj71gmnBOubzOD2lCHIWn3aUt6jUdjfiDPhiGlB0e9lvZGejg4+QziLuU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764777141; c=relaxed/simple; bh=7BfHN6AbfV/3XWphq1UqLC6aY8Kt9j+ITDN9fR0IN+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hJZajEZH6gy/ty++YE4FrtLvBCnJ0BsV6c5JJvzkarlPUsFAqaNxgbyk+8EFmIejGCj7wkHqTDO/hY/TUjvCGxeuZ8FFOacZdQQL6VcZtEu6KQwqnB+Ww0kcjbxDghwiVPnueeIAK/beVi3WYm6CiyfQGIOnyK7nB3vBx5QY0l4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JTJCyFXH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JTJCyFXH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22510C116C6; Wed, 3 Dec 2025 15:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764777140; bh=7BfHN6AbfV/3XWphq1UqLC6aY8Kt9j+ITDN9fR0IN+A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JTJCyFXHKUHzKoJG3Lb86NmKhXKR/2KFkJQpNCtjBIPofmt/Z3SUCm5IPduKvuA2e neV5ErfWFM4BZbmulwRKhW9zTyNrf8j2cxHfLevugQoEuF63nZ49kNpa6sVEn1REmQ FKhUCfPQ8JGQh3/fV/q9pOPj8+CgMAZNOyKULl9xTrA7YSICOmJc0gkuq5MpuncOcc qtZneoqrtMTO/XXVBEsldMAnYVuzNeY1GaCa1+sCHKL2qDUr0p5BFai8NzfeCWOruM SmdrDaXw+YiLlf+VmuSM7+aySsceWeGTAPJUydQEzKC9mNL1MMNLwA4vtEHadJxlTh KXzbqWdz5lI4g== From: Jeff Layton Date: Wed, 03 Dec 2025 10:52:15 -0500 Subject: [PATCH 1/2] nfsd: use ATTR_DELEG in nfsd4_finalize_deleg_timestamps() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-nfsd-7-0-v1-1-653271980d7e@kernel.org> References: <20251203-nfsd-7-0-v1-0-653271980d7e@kernel.org> In-Reply-To: <20251203-nfsd-7-0-v1-0-653271980d7e@kernel.org> To: Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1384; i=jlayton@kernel.org; h=from:subject:message-id; bh=7BfHN6AbfV/3XWphq1UqLC6aY8Kt9j+ITDN9fR0IN+A=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpMFyyPvQrQuV53L0xsX6mZleciLGEpQB4JBpoW naetL4UzAmJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaTBcsgAKCRAADmhBGVaC FX3UD/0W+TsQKLGHSSRMNMnVO8evJn34RkIenLVLuW94f2sI1Hbw+iG1VNUW9+yY/UYfHUDY3aR r6xXEv9b69RGmXnTcGM4GmGHY3Jb9gCVqp0uaV1YXylGHDNOOvovI8USuOv6m1+yn07WU5qM4ov OPmhKGSuaHvyu1EB4XFxuRXCzrAMckAkFJqnpne8NT4/iVR3MxhX88LKJFJFf7sriIgsLUoux0W vbbxhb+XOLtSA0Rp7B93LN+y5bCu1xTDDhTNwTjYOtFeiDcCEjuCnFKndiTMY1+RO8YBwLYlcS4 rO9UfkJgVtbDmbG9TbBQs7ttR67j/r3fiFwhQCLig4sGnTYHbAq7guCE6zgB/q1LtbjC+T5XgAZ +qqf2IXbmjAdjM2QHaYOAVKtipE9ejFpSghvcBZ9u8LGOze1tL36wNpErC1drsSoSo6yRjC3IwE DiOT4OHSk4/GAj1zaO/8UykIWZVg+cShNm5/4/aawb3xTK7Xw6unrEtEKnEQzIQFj2SPh5ppe7z vOb7RXYG6wztmjtIwrbviiLEW2dZbMkltVcWuReyIf720jOWkivpMuyMUYX0lUrGnqvR083UXvP Y0Tgbh1m85qMPoYADiukxCRNpp+EB0UjddUdCVw5FypEvcc05UBE8rz13NGWX727nKg+oj6HWql mVrGU3t2bvAVDdw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 When finalizing timestamps that have never been updated and preparing to release the delegation lease, the notify_change() call can trigger a delegation break, and fail to update the timestamps. When this happens, there will be messages like this in dmesg: [ 2709.375785] Unable to update timestamps on inode 00:39:263: -11 Since this code is going to release the lease just after updating the timestamps, breaking the delegation is undesirable. Fix this by setting ATTR_DELEG in ia_valid, in order to avoid the delegation break. Fixes: e5e9b24ab8fa ("nfsd: freeze c/mtime updates with outstanding WRITE_A= TTRS delegation") Signed-off-by: Jeff Layton --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 1ef560be2d714c138bc8210d9e7dca50a670a342..b0111104e969057486a4b878fff= b84b84ca97b7b 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1226,7 +1226,7 @@ static void put_deleg_file(struct nfs4_file *fp) =20 static void nfsd4_finalize_deleg_timestamps(struct nfs4_delegation *dp, st= ruct file *f) { - struct iattr ia =3D { .ia_valid =3D ATTR_ATIME | ATTR_CTIME | ATTR_MTIME = }; + struct iattr ia =3D { .ia_valid =3D ATTR_ATIME | ATTR_CTIME | ATTR_MTIME = | ATTR_DELEG }; struct inode *inode =3D file_inode(f); int ret; =20 --=20 2.52.0 From nobody Fri Dec 19 20:34:56 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1D0330B3E; Wed, 3 Dec 2025 15:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764777141; cv=none; b=eWxM6GKYQfZzAVYnqBmz0qDhY8Hc4S2l8SYeJzegILUNCh83Q3+Lyr9/k8Mu48bybWttd51I+MTiFGt0U9O5/e+CeH7VHgy551ptjG07GfyBkqTR0TkNvNHtT3/YCb8fpMPkNv4dAFng+H5aIBkw9G0V9KatzygmkQKvah7sMkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764777141; c=relaxed/simple; bh=pkwmZeXWd97XcHgqH5JzMbaLm2KzN9UnExHYzpplR4I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AMrxz7OFfbDT5io5jiJBxkNatI0UVI+MuO36I/4otmj5y3eoeQzj+qmHj2pI0XTOCZJCFr2XdrfNB6I+/HsquNhv17I6vpDF9/X9JI3yNsjAGHAEVWzepj1Ac9PjhMJkFQoen0xQ5HP87CI+SJh93+P9i4S4ZI8yveyDR91JVgE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O3c9XABD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O3c9XABD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0751C4CEF5; Wed, 3 Dec 2025 15:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764777141; bh=pkwmZeXWd97XcHgqH5JzMbaLm2KzN9UnExHYzpplR4I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=O3c9XABDVAtcQgYWun/miqolUVkTF+aLBzrOEYpmAHx53BLDSFTLXriTcIIYi1eRm ssF3ajrgoBJVtCkVR04EUTQCyZWtdxX5jkYQPkgplnc74xt3IfuYvU92X7zM6YQE7t 69K716JQyhZzG4dFe78rYXhZCmNavgnQUImLlMyoPvu7J8BELnDu8+n8ZL059oExUU mvU/F1zd7YSmCInS2RACodeBUc1SjkGlFwW19M9544FuF9Nji4EG20NAdWdNkTl1YD vk7LqpjacXq48c08l41tcoweJ6v+NJ9W89SR1i9ded2tc2VrRmdjGNqj4cK3QK1nqY 57E8zUZx7foAw== From: Jeff Layton Date: Wed, 03 Dec 2025 10:52:16 -0500 Subject: [PATCH 2/2] nfsd: prefix notification in nfsd4_finalize_deleg_timestamps() with "nfsd: " Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-nfsd-7-0-v1-2-653271980d7e@kernel.org> References: <20251203-nfsd-7-0-v1-0-653271980d7e@kernel.org> In-Reply-To: <20251203-nfsd-7-0-v1-0-653271980d7e@kernel.org> To: Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=845; i=jlayton@kernel.org; h=from:subject:message-id; bh=pkwmZeXWd97XcHgqH5JzMbaLm2KzN9UnExHYzpplR4I=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBpMFyykqfag9qxWIxrPQOQcBSGfIlJAl1VD4SJi 9MWUSJhwLSJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaTBcsgAKCRAADmhBGVaC FQpmEACv/CJZ2b0y2chxYVcdiszzu1XiiyCGKTTHW3QJOEyfSVLKBIAgvCPzbewXhHMZfl5eb3A wJqgdQxAHFvKA3wMMC7SgoCg5Jepz2E1rL6ZB9PrLURZ4nduRxdja5hSO+lnAg5qZ57lIFyqp5x XgY5eANEgJMrpQN3fuW6+xQICoHWregQDa0THkxP+qaR7Tjo765PUtpG9mrmYu1gmRgZzNUbqEt DvppE9eROsZTRlAGgV6D2453Z2j8wW9oBGBwfDkFMr0axm1ZznNwUv0GGU2LLOui3tdJb4PqXun hOZpz3h/hh9qWVzuRx/eA6iQHMzQCdE3ggfSclI9lzw0NPUaXy4kYB/BkPG3UBeS4YJp6mmCHTj Rmx5ysnqcFdAhpCA4kRgY6z+0wIoG16t+zQlhOi1oDlx8WIP36X1AsVCLx+ba99qu2dgNLqJpUE tfy4hzqImxgZGLezT1McCRcjyHAgeqIed1hPNt9YMLgBXEqMsm+89h18LsCWUJnLBzKsjeVx6d1 VIvqWJA2FrVQVG4Hv0TV7nSbN2OxURe5dDFxqMPn6k1mTBDU9rO/1uhj86LyM9WM20ZgHx+lwHo wvlM3Y3ZE0713r99rWKqiHGZ50LaKxZXFl7rAkPSnIaVNNTBTDCk1jdHI0A8NraP5FMYHL8u7sK BDTr3RnrOlgft1w== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Make it distinct that this message comes from nfsd. Signed-off-by: Jeff Layton --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index b0111104e969057486a4b878fffb84b84ca97b7b..22246a1d970c3a1fcf1d821e20e= dd2ca7b1ed488 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1253,7 +1253,7 @@ static void nfsd4_finalize_deleg_timestamps(struct nf= s4_delegation *dp, struct f if (ret) { struct inode *inode =3D file_inode(f); =20 - pr_notice_ratelimited("Unable to update timestamps on inode %02x:%02x:%l= u: %d\n", + pr_notice_ratelimited("nfsd: Unable to update timestamps on inode %02x:%= 02x:%lu: %d\n", MAJOR(inode->i_sb->s_dev), MINOR(inode->i_sb->s_dev), inode->i_ino, ret); --=20 2.52.0