From nobody Fri Dec 19 21:10:08 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 511722E0B59; Wed, 3 Dec 2025 11:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762349; cv=none; b=D2ZvkqLYcv8tolRbNts/BDS15DBk0yNM1CPKh7jaDvA5rozUIi1yzZmjRcfRbMEZArpcK+F4roOmxA/vmxFxhyFZwCc1mjSRBPTWN4FG9+SHYUnVRkxJxH2qwz1tO1VRqilsEi8fKJ7lem5xmw6hIS6e3R5LsP7XDX8vTslVK8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762349; c=relaxed/simple; bh=rSrS/g3GzIPfmw34zxW71s8tJc9N+7opnT4NQUPvLbs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PZmRRCgJbSQZ5TNVwGSDaiNSAxBBC28z17s7bOiKA0nhZquV37am7jJMDsnmgmeQx6p78421KDLPRokvwa5TbefaNk+54lpPezPl3z7VbAV/LFisNuv7yKI2Ino+uRo3Nv2IcfdKhdIbvKjenMlIVt4rMeFUv6SzNRsuAoMEA/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kUIP8m03; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kUIP8m03" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764762345; bh=rSrS/g3GzIPfmw34zxW71s8tJc9N+7opnT4NQUPvLbs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kUIP8m03uVX3YSkENNi5EZ9TI0ShKToihyvXNkhsKuGWkf9B4oEYeHoRdyZ/irGN+ KHs0/oSDbnRpTltz83vxJxrUyFofIZH72R0Ug9Kf0vv3JIiIRFMfDHpfG/xDoHq8Uz 9X2BBYqi1/StLLB1Who3syAAcJoP0DB3LB0sf2AuE9b3i589Udcubh++27YErifIxi 1X6vUvDxVev3gYRtPeypYtHM2P9tldNbHzKd40XuIK1moa+IjHKlVn8wbWYrHWk5ox 8giMK9u6cps6JpTE1yJMPaKnuPhsmSYDZiwvYq59OXZYTlVKxlAiyJE+H416umVzTq whGHDNq75H1GA== Received: from yukiji.home (amontpellier-657-1-116-247.w83-113.abo.wanadoo.fr [83.113.51.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id F1DBA17E1339; Wed, 3 Dec 2025 12:45:44 +0100 (CET) From: Louis-Alexis Eyraud Date: Wed, 03 Dec 2025 12:45:34 +0100 Subject: [PATCH 1/3] dt-bindings: mmc: mtk-sd: Add support for MT8189 SoC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-mt8189-add-mmc-support-v1-1-f5ce43212fe9@collabora.com> References: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> In-Reply-To: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> To: Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei Cc: kernel@collabora.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis-Alexis Eyraud X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764762344; l=1508; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=rSrS/g3GzIPfmw34zxW71s8tJc9N+7opnT4NQUPvLbs=; b=qLmM9GZBF3m4ar3KUTOZb9GLigL1SpHLreXl0Q6p5wNsluo9feCpmh2tnL9pj5Hc2vU5b+qcK /V9eWbtSqbWARtj8OPkzNOQb95BKu4x7Yi34jDqPq2o5Le2P3WyCEyC X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= Add a new compatible for MMC IP in MT8189 SoC. Even though this is partially compatible with the one found in MT8196 SoC, the MT8189 SoC register layout has some slight differences and additional features. Signed-off-by: Louis-Alexis Eyraud Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentat= ion/devicetree/bindings/mmc/mtk-sd.yaml index 6dd26ad314916a3e40cf55ff69a7d93ed63dbdd4..eb3755bdfdf7e001602c3eb8708= 98275085df3e6 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -25,6 +25,7 @@ properties: - mediatek,mt8135-mmc - mediatek,mt8173-mmc - mediatek,mt8183-mmc + - mediatek,mt8189-mmc - mediatek,mt8196-mmc - mediatek,mt8516-mmc - items: @@ -192,6 +193,7 @@ allOf: - mediatek,mt8183-mmc - mediatek,mt8186-mmc - mediatek,mt8188-mmc + - mediatek,mt8189-mmc - mediatek,mt8195-mmc - mediatek,mt8196-mmc - mediatek,mt8516-mmc @@ -240,6 +242,7 @@ allOf: - mediatek,mt7986-mmc - mediatek,mt7988-mmc - mediatek,mt8183-mmc + - mediatek,mt8189-mmc - mediatek,mt8196-mmc then: properties: --=20 2.52.0 From nobody Fri Dec 19 21:10:08 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356DE2EA749; Wed, 3 Dec 2025 11:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762350; cv=none; b=tiNp6K30y+Tl2k344zqs+wOEZNP7qezYo0NWmDthPAaQfTQF5apqgoXuFj07XpVUcveWw+qLVlm86+k8C4AexRvbqPO42u3X9k/o6z7Q3YrtKO9FbSWkRL1LzcjNJ8NQYQk12jn5uczeSLJaDPEOfQEPqwQEUmDaKLfIJxV7r8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762350; c=relaxed/simple; bh=ahjRyiyy4S968JVuF+EhGfPwRd1ZGT+Km4oxLletDsI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DvPVx0l/e0EZzrvuyP4UUYc6MQpSX/hvE4yAm2Cs+wezl5c60eG3p9ym9VVj4BnRi0sme575MYzL2R0SZAdwEC2OA5HF6oZTMyVuDe46G8FawZeqKpTksn+m5KMqJUQtiSTSVg7O00jehNtghnRW1YYwpJeeq5GZGC2Gsl3X4Ss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=iJn0iSWE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iJn0iSWE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764762346; bh=ahjRyiyy4S968JVuF+EhGfPwRd1ZGT+Km4oxLletDsI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=iJn0iSWEQmtFsbubE3gmj/Ic4HB8XEFrxrutItAOSZPJk1hxyLk8YcqaMoX4kafrK EMTV5ahylVkRhWZ15NkNCmx7rMEm224FVu5E9WmdZHym47b+7z/3CW8O9DOmX1753p ppZd62GnfzQGm7PdbED361aJ4letvhbjjiFxMrTaM84SdUQ8r9VqEbFdrB3bZnl3Hi OiJIbDk1W9ACEVfKmjC38jpKzADSbSrfiv54Qp/rOkfHVED0eiKN7Vskp7jmozjoZh ihaf46vl2biX9vUeIuLuCzTGodYN/xHSdiz+/9ADxvAr2kyTfA0O8V9RKZOLqPjBTj IhyJwe2ipYl6g== Received: from yukiji.home (amontpellier-657-1-116-247.w83-113.abo.wanadoo.fr [83.113.51.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id B54DA17E13F1; Wed, 3 Dec 2025 12:45:45 +0100 (CET) From: Louis-Alexis Eyraud Date: Wed, 03 Dec 2025 12:45:35 +0100 Subject: [PATCH 2/3] mmc: mtk-sd: add support for SPM resource release control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-mt8189-add-mmc-support-v1-2-f5ce43212fe9@collabora.com> References: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> In-Reply-To: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> To: Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei Cc: kernel@collabora.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis-Alexis Eyraud X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764762344; l=1669; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=ahjRyiyy4S968JVuF+EhGfPwRd1ZGT+Km4oxLletDsI=; b=I0kjEvvw1OQmZ7oj5gQdhB1Ho/OdyfiGdvfiBs3audUDZdLcvg19Po5Bnc42qT2rlji4W25OE izn4aDlrQI/AD+Tv1sC/zgZ4deRXQfM9lktB2rw/Iy/e7RJljjas8lb X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= The MT8189 SoC has in the status register an additional bit field to release all System Power management (SPM) resource requests. In preparation of MT8189 SoC support, add its use in suspend callback and a support flag in the platform data. Signed-off-by: Louis-Alexis Eyraud --- drivers/mmc/host/mtk-sd.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index daed659f63f6872423edd755478f0ec57e7742b4..4ce596d61640964661374808647= 6c58d8b7b8de9 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -203,9 +203,10 @@ #define SDC_CFG_DTOC GENMASK(31, 24) /* RW */ =20 /* SDC_STS mask */ -#define SDC_STS_SDCBUSY BIT(0) /* RW */ -#define SDC_STS_CMDBUSY BIT(1) /* RW */ -#define SDC_STS_SWR_COMPL BIT(31) /* RW */ +#define SDC_STS_SDCBUSY BIT(0) /* RW */ +#define SDC_STS_CMDBUSY BIT(1) /* RW */ +#define SDC_STS_SPM_RESOURCE_RELEASE BIT(3) /* RW */ +#define SDC_STS_SWR_COMPL BIT(31) /* RW */ =20 /* SDC_ADV_CFG0 mask */ #define SDC_DAT1_IRQ_TRIGGER BIT(19) /* RW */ @@ -448,6 +449,7 @@ struct mtk_mmc_compatible { bool use_internal_cd; bool support_new_tx; bool support_new_rx; + bool support_spm_res_release; }; =20 struct msdc_tune_para { @@ -3296,6 +3298,10 @@ static int msdc_runtime_suspend(struct device *dev) =20 __msdc_enable_sdio_irq(host, 0); } + + if (host->dev_comp->support_spm_res_release) + sdr_set_bits(host->base + SDC_STS, SDC_STS_SPM_RESOURCE_RELEASE); + msdc_gate_clock(host); return 0; } --=20 2.52.0 From nobody Fri Dec 19 21:10:08 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59B62F39DE; Wed, 3 Dec 2025 11:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762350; cv=none; b=cv3VoxlXWqBvHX58EIO2+N38K/mxvKcoV3ziieTzP20spn9KsXucrLJ/VhzLE4DkV0Ez5m1YlQaYkwyhJnwBjVIQDKiarob3MIREQv0RLIQiUVliVS/CsdcK3arorwMLMsf1MlRgZ5XpMubtHUcCckoKV8kLIePoUGRv/9/KtbA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764762350; c=relaxed/simple; bh=7rOHPZhf4PD5pAFldbx7LxIk29O+cfxEaxF+eBGZ1tw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D54KJ4/uTGXuAqX9lsAk74ZAxLgmmBZNMfNWZzUBUP4PJLib4/BlbjumwLSuCVNqG1wK1ALEIheY5rLyJTf0PymY/UC9Scb+xBdfTwEAXR+geCL6U3U011uywusPS5cjBYHs+WnUNa6S4784Fbr+Bpf7MkXiIgnpjmY2eRcw0HI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=GmhYL6v+; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="GmhYL6v+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1764762347; bh=7rOHPZhf4PD5pAFldbx7LxIk29O+cfxEaxF+eBGZ1tw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GmhYL6v+QMpo5rIY30ipper51Gu0HdFzgGWsuDUak1EROzNGEHC9tiF7Ca4IajGDf MzytSZJTCwgTg2J4BKB7g9DR/k6qrsa3Ex2H5XhBaVNqz6tAJedY/GsTFjk60uGhLt EDaI7R325yEFT9cMqFksaRz1g5hew9T4AivNW2YvHOnn4ZHNzuU1oPoVTNtfohMEOJ k4CQ76udrfPEyUOrCC8EynbGf6WMtsKMjjgNLbDiEfH5h5hKFlcwOBOHGtM7FmZxkF RYAP2n+7F3C+mS5aBGOUqBUe8N6NULtqergAmG6/tc5+fcKs77EfPJUxeEjf1A71Yq 9eLxvnHmCaLRg== Received: from yukiji.home (amontpellier-657-1-116-247.w83-113.abo.wanadoo.fr [83.113.51.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laeyraud) by bali.collaboradmins.com (Postfix) with ESMTPSA id 769A617E13F2; Wed, 3 Dec 2025 12:45:46 +0100 (CET) From: Louis-Alexis Eyraud Date: Wed, 03 Dec 2025 12:45:36 +0100 Subject: [PATCH 3/3] mmc: mtk-sd: add support for MT8189 SoC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-mt8189-add-mmc-support-v1-3-f5ce43212fe9@collabora.com> References: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> In-Reply-To: <20251203-mt8189-add-mmc-support-v1-0-f5ce43212fe9@collabora.com> To: Chaotian Jing , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Wenbin Mei Cc: kernel@collabora.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis-Alexis Eyraud X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764762344; l=1893; i=louisalexis.eyraud@collabora.com; s=20250113; h=from:subject:message-id; bh=7rOHPZhf4PD5pAFldbx7LxIk29O+cfxEaxF+eBGZ1tw=; b=SLgz3INqPxcoBYI65advm9kShlkIf/WYvat1ohh0WEg1Xbz3muok1O8f7wjV0GWKXmcr+rjgw vpfwQNz49lGDcW3y7gPbtg+vco6PO887setn29kDXGgjrU/pYQGoN50 X-Developer-Key: i=louisalexis.eyraud@collabora.com; a=ed25519; pk=CHFBDB2Kqh4EHc6JIqFn69GhxJJAzc0Zr4e8QxtumuM= Even though MMC IP in MT8189 SoC is partially compatible with the one found in MT8196 SoC, its register layout has some slight differences and additional features such as the system power management release resource control support. Thus, add new compatible and platform data to support this SoC. Signed-off-by: Louis-Alexis Eyraud --- drivers/mmc/host/mtk-sd.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 4ce596d616409646613748086476c58d8b7b8de9..302ac8529c4f093a541db2d37dc= c8709c3775557 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -675,6 +675,25 @@ static const struct mtk_mmc_compatible mt8516_compat = =3D { .stop_dly_sel =3D 3, }; =20 +static const struct mtk_mmc_compatible mt8189_compat =3D { + .clk_div_bits =3D 12, + .recheck_sdio_irq =3D false, + .hs400_tune =3D false, + .needs_top_base =3D true, + .pad_tune_reg =3D MSDC_PAD_TUNE0, + .async_fifo =3D true, + .data_tune =3D true, + .busy_check =3D true, + .stop_clk_fix =3D true, + .stop_dly_sel =3D 1, + .pop_en_cnt =3D 2, + .enhance_rx =3D true, + .support_64g =3D true, + .support_new_tx =3D true, + .support_new_rx =3D true, + .support_spm_res_release =3D true, +}; + static const struct mtk_mmc_compatible mt8196_compat =3D { .clk_div_bits =3D 12, .recheck_sdio_irq =3D false, @@ -705,6 +724,7 @@ static const struct of_device_id msdc_of_ids[] =3D { { .compatible =3D "mediatek,mt8135-mmc", .data =3D &mt8135_compat}, { .compatible =3D "mediatek,mt8173-mmc", .data =3D &mt8173_compat}, { .compatible =3D "mediatek,mt8183-mmc", .data =3D &mt8183_compat}, + { .compatible =3D "mediatek,mt8189-mmc", .data =3D &mt8189_compat}, { .compatible =3D "mediatek,mt8196-mmc", .data =3D &mt8196_compat}, { .compatible =3D "mediatek,mt8516-mmc", .data =3D &mt8516_compat}, =20 --=20 2.52.0