From nobody Mon Feb 9 18:20:48 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011060.outbound.protection.outlook.com [40.107.130.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73E4B29D26C; Wed, 3 Dec 2025 06:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764744575; cv=fail; b=ccl2x67iGrABlrqcI/wXbcdegDpgu5cd6jgvNde1VB4+kcSLclMlP3XJPpW1WsC+fJvonOb4hSFlLPS9lgOdhmNSkmjGr4JUhnFRPD8H0VuQfB3Cc7RCzRrL7NP+dCFvz9LP/yIQxhjSR8bVK7oUK7coDMKaQH946GcAomrf4L4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764744575; c=relaxed/simple; bh=dyTY8f42gqeHcpeSMjX8ZBehxsXgPnhSsLPdyrwKMr4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FTQyUwIogfwnPZAFpJ4RHkM/azsAiKlec0q1Qv/jLxZIj4w6svQGT3fhh/80ercos425RuBPvrLbx0aY+iAD3W+rDO8QbwTUy2j5j4MDZZ1AwlsQpYpkH/na3aCvaezVZ5NXzuKrwv9haGQQmXoTxua75WPv6TrsH6Orgam09e8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jzAebDob; arc=fail smtp.client-ip=40.107.130.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jzAebDob" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w2BwzeU0/qOd/3Kg2/CMSIF2rLkpLCKUAGVzcvCRUjuClu9NIJeL3q4lV2bYdN7eqeQMmmzO5DhqgnX9+hztplLnnG2OCDvZSRtQ0yjege2EvCR/zrinouz04Pz398EA71s9mshNgtGTG9m0XH7A4tzBf+7zEq7nAFUF0lr/fQcyfbkSBHlb3xK/qAdQUU/Xjlr+GoGMoRvMDn8itZerFXAIoMWni/n0qF1v903cqMOY4778UZixU45IAf7V28aI0iqY9Ubah8Y4cBJbCn642i6cfxt3xP1Ps9wrwYy8hiTcnxc1aCstyXi5OazYegv+bTKcKEcbClvc7tMAbjUcTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SfA+PLd6tFtj0x70r4El0ypxg45D3tDinWqgADov4U=; b=lbxs7X9E4yKCZVpRBYwQM5BA+BO80vyfei78UDyxqnfNExgZ38NnlYPjY5htxGfoxkTDJuC3bdC3x15T6AeMicVsIADZfxe9kUYcIFVOERkS/MsZsxekxgXYggzzqEl3DJBl7jqMZvD4OhqRjIPVWgp7anjYNvrVwAz3LOvpWrA+CyX3JNYKen4a9RPAhSyIILbXTD9H770+BawkynlHtCxuhM5cy6G5aeoBsCHfQxlF4p9yhSbyw/XOVPq6oP8+X06InG2pf4e/+SEIZ4HJXvUHIeInwajh/fQ+ReL/efSaz+JbQ+oaO2qwUIR4GzEpmuLYlVoE5pujc3Z2lVfhRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SfA+PLd6tFtj0x70r4El0ypxg45D3tDinWqgADov4U=; b=jzAebDobcJ01JSZ7ZQ2crIbo94l+2riBhVUjBke5PfhPYzciCyFzFRK2j7rf4tPkLY8eLIRNnd7KyMxj9JoSGloFRf1KF2txI4oYGmOwU0dSBLPM4GPBQsPnc6XJivNNAhP10iYU3A3MAj0mwK4I5+1IcYICUMTtJowZwWToYtep0bmtDTKbACD5o5+1evvpF+TEeXep0pNx9KUZwwSI9GDH70FUFfniyYj6DeDWV9G9XfTQTO8PFdTDBP0Wx7iEvvkmYM2Lf+4f7D4mX56KBqSSIocgXVl81hkmC/YbnBWR3hGWnbfNPr3Bgm/lPBR2FBgwWMUyJ/C0iGudT2yMKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8604.eurprd04.prod.outlook.com (2603:10a6:20b:43b::21) by VI0PR04MB10758.eurprd04.prod.outlook.com (2603:10a6:800:25c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Wed, 3 Dec 2025 06:49:28 +0000 Received: from AM9PR04MB8604.eurprd04.prod.outlook.com ([fe80::e751:223e:aa3d:5827]) by AM9PR04MB8604.eurprd04.prod.outlook.com ([fe80::e751:223e:aa3d:5827%3]) with mapi id 15.20.9366.012; Wed, 3 Dec 2025 06:49:28 +0000 From: Pankaj Gupta Date: Wed, 03 Dec 2025 12:18:10 +0530 Subject: [PATCH v20 5/7] firmware: drivers: imx: adds miscdev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-imx-se-if-v20-5-a04a25c4255f@nxp.com> References: <20251203-imx-se-if-v20-0-a04a25c4255f@nxp.com> In-Reply-To: <20251203-imx-se-if-v20-0-a04a25c4255f@nxp.com> To: Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Pankaj Gupta Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764744504; l=38557; i=pankaj.gupta@nxp.com; s=20240523; h=from:subject:message-id; bh=dyTY8f42gqeHcpeSMjX8ZBehxsXgPnhSsLPdyrwKMr4=; b=Z8UetgwijcNGYLKvnMu8G0RyvqyXpntq0zYCGbaG57enpQj+bw70q9HWKqbrZV6wiDPBp/d9I dRQoWayO1OaCZ6aZoY6vwWxitSZQhaUeqra1WMxOl9cNC7UgiLpAcm6 X-Developer-Key: i=pankaj.gupta@nxp.com; a=ed25519; pk=OA0pBQoupy5lV0XfKzD8B0OOBVB6tpAoIf+0x1bYGRg= X-ClientProxiedBy: SI2P153CA0020.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::19) To AM9PR04MB8604.eurprd04.prod.outlook.com (2603:10a6:20b:43b::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8604:EE_|VI0PR04MB10758:EE_ X-MS-Office365-Filtering-Correlation-Id: d6893d83-34ce-4631-199d-08de32381a8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|19092799006|1800799024|366016|13003099007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RXRZVmVNUmhuQ0hwb3NRNjg2MlVXR1NFcm1YTEFLUlkwZjhFMkVsNzJaajRV?= =?utf-8?B?NzNzdGp4WllHTEJhR1prVXdIbUk2NlV5UTUrZFl3L1pNUW5sdDBUVEVUQzdJ?= =?utf-8?B?Q2g3WEJRT1BFNTVrYlVPcks1TFg5elprR2pOL096eVZXbzFpcFNmNmxGakZ3?= =?utf-8?B?QWZTTTgxMCtPVmpYb1VXUVlUWUd5UGNTcU1SUjBTUm1LMHI3ZWxiQVREUzI3?= =?utf-8?B?MVJ0SG1WRm0vWldnaWt0aHRqUkExYk9GY2VmS0tiYXBtYUN0eDh4RUdkU0ZD?= =?utf-8?B?MjhzTUxwd3hWZnJLcWp0cW1QUm9qYm5UdHlvVXUwQ2NrWWJoZ0MvY1pYT3BK?= =?utf-8?B?MEd5MGJQbkFIVC9vVTJoQW4xSnEvN3A5dlZ5dEVQeHR0ZzA0eit2QkNFSjh4?= =?utf-8?B?M043dnVUbUlWVUlJdW10MlhUQ0hOV3lPTFdLTEoxUitHWHNNQ3k4d3VWRk1W?= =?utf-8?B?OVhtV3VGWkI5dG9nYWhob1phTkwvMHBLd0d3Zy9USFA4RGZPUFpBRzVzTUN1?= =?utf-8?B?V2lWTFNlT0dzQms4cE94VWpEeksvUjc2WkF3aHNjZitubTdqUi8waUtVbEI4?= =?utf-8?B?SUZxSWswYjRWT3VZV2JydU5ZczdlVXNJdGUyQW5XeW8rUnlwTTZTUkdRZy9s?= =?utf-8?B?S1AyenpVaExZL25SaDFKNXUxdTkwOVhPQVE5bStzN3VqcS9oTDVQK2VGV2Ns?= =?utf-8?B?NVdmM043T1Nrcys3dkZTVGY5bXZ1U2xJTzFZR3ZRb2lFb0FOZjNhZ1MzUXA1?= =?utf-8?B?QVA1T0M4eTY5QmRoYlM5dmlvYk8xMk45SlRnSEVidzYwdWozbDY1dTI2VTcz?= =?utf-8?B?ZDBmQUJ0Mi9tcUpZeFJOSWJxamJGbTU5REFIVllUb3RFUFk2OGRJdjZXWkZF?= =?utf-8?B?TUlJWnpGVjc4dDFzT24rcmdzVHBZbDhmRW54QkRGK2t3dk1jV1hPbXpndXB4?= =?utf-8?B?Q2M0VlduQ0Z1b2ZmSEsvOWdtWFgvLzFDMzhGSUlRUnA3Y0RiajErRW5xYTFV?= =?utf-8?B?TTR1QXpXK1pvTG82TmRvNnJNellZcFU4eVIvSmxJUVFZN3pka3FhZy9ONTBm?= =?utf-8?B?VE5BVTU4MGFONDJWcTdiTmdrZHNDSXA0ZjBCTzJZQTF1YWZKOUxLdUxzNUhn?= =?utf-8?B?ZnpOVzZIK3RyOWtITmdJNFJIMW56SWl1QWlsZk9oYjk0MTIwNlE3UDgwem1I?= =?utf-8?B?K0kycnFyWDlGQ0dKc3JkWU9mRS9kMkt4ZUU4bDQvWWtJa016aXVuMGdzcU9Z?= =?utf-8?B?OXQyL0FIWWZZbyt0M0E4dEFKcUlvMTdOWFk2WUtuMGJwUkUwRVdqdU5RaHky?= =?utf-8?B?QUFuTXlzY0ZnTW5CNkg0MVZzUURBVXVNVU5GYVZjelRQMEtROFVNT0RKd3hB?= =?utf-8?B?OWZ5VTB6ZkZST01ETEYvQllrYWJndlFmRE5SWUVsU1RLUFBZNVpNeVJVVlJK?= =?utf-8?B?NVVrZ3F3ZTgwK0xTbVFDeC80SHdGRDBQNmthaE1hNlpDTGpjMEsxYmJ0c2l2?= =?utf-8?B?dDB1cnNQMjlOTXFUcUJRQ1FmR1dIZzZFVVlGV1ZqTVYyVnA0cGpTY0Fiaml1?= =?utf-8?B?dzN6S2JzMlB0d2ZNY0dwakR5Zk15V0U4cnhZWnBpTFNiWmxQN1dqbHlyMWg1?= =?utf-8?B?TS8zenNkWDhtTGRzSDAydHpjMVJrUVBKbmlMcmpBcFRuVjcxbGM5TXBrS1hy?= =?utf-8?B?V3lCTUtpM0NUYmYwMlVTQW1VTHo5WmVmamZST2FTQkJzMVFObCtKVXFNeklL?= =?utf-8?B?aWJSek9obFZnYVdJVTR4QzI2WjN2enYyZE96eGJTcVptemFmdjlidTVuRmE2?= =?utf-8?B?T2ZoM25GYTBSQjFLdGNNZ0RJSUFuQVNNUUQ5NUdZRUk5MmRxd0QyNXJkell5?= =?utf-8?B?M1NWdG44Q3dDOHM3OU0xbWdxK1VkSUdSUTFtQ0dIaFRJclpyYkx6UmZhSkpq?= =?utf-8?B?SUJhUWx0dE5IRVE3WG1VVmprM3lHSUFaUGc5UmdXOWpxWXFCOHhkcWQvcEhF?= =?utf-8?B?K2o1WW1pbDNXUFlKNDdXd2ZDRWEyK1BQSWNGcnBObFhJUlVpWEsyMDlYelp4?= =?utf-8?B?QmM1Nkw0YUF6eGxBdWZjYlJsL2J0SWtIckdEdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8604.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(19092799006)(1800799024)(366016)(13003099007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3F6VHFwWlhSYkN6bTVPa1pCZjRTT2I0Nmp4SkJVZjNKaWIyWDdFZHduTXpO?= =?utf-8?B?dDFPbFRvdkNyT3B4UEdnK05wWW5BeExUakN5eFFUd21aeVVVTTNuMXRlQU9E?= =?utf-8?B?aHl2ekJYRk50SC8zYmZwbkNJVXRyOXJjOUFTc1c2UEZvaWt1LzRvcXRmU3Mx?= =?utf-8?B?cHlKN1lCbDJqTDVDOG80MkswUjRoTnV5TUFteU03YjdadFhzdXlhOC9QYllC?= =?utf-8?B?Q1l3MFVnTzJ0aFpHbk1wcDRWTGdrL3J1TlVwemNZcW1ER2ZjWUo0MG1PaDYx?= =?utf-8?B?TTVYNzkxZ0kvemVIS1pUTENoTXhFcW8xU0VVa3lkRXZGNVYyQ2xSNEIrV2th?= =?utf-8?B?Z1c3Vkg4VFR0NEIxK1l6Qnd2dEIwWUN1WE9CU1Z1Tkh2Slh5aVptQnNvVnFK?= =?utf-8?B?U0JSN1BzMk9UekQ1RFZ4MVduMmFYTjBNdCtHSWpjbVNSbW9FSEdkTUVEQzIz?= =?utf-8?B?OUFZR2NPWUFKTkl3cUxlS0hTU1VTOGROaGVGS21ka1hwL3YyVldoZ3BPdllQ?= =?utf-8?B?RjJBd29qVVkyNU5MdDY0dDZ5SjdIZm54bzdWOGxORDY5dlIwNStkRXRJRC8w?= =?utf-8?B?SERXekxNRlRqMHg5R2ZJMkJxS1hGVDQvcldlQTRDQ244Vnd3ZWt1RXFNRE5M?= =?utf-8?B?T01ZdjFGUEFmak4zaUMxVW9uL29MeVcrV2NVZlNWUEpqN3NoZ2lmb0lTd2Q1?= =?utf-8?B?L0d3am0yQzdiaGltaE1ZUEtsd2VrSTFOS05EUW0xdndTUjBNVDEyeWpyNHdS?= =?utf-8?B?YUE0aUc1ckRRTnNJbFE3MWRpY1lIaFdTZ25xTlhYSnFGTU5MM0ZyUXNYM3k5?= =?utf-8?B?aVFGdHBsN0xYNUpUSWFtbU1yV1hGekRwbURWWlNkVmlKV0lrQzZRdEhQb01h?= =?utf-8?B?YzkxaHhSZUs5V2diajRnTEJnVHpPVG5HR1FDK25rZ3V6cDdzc1dmV2wxTU5i?= =?utf-8?B?Y2YreFI0ZXZ4UGpweU5KbWRwdXlvSldlNkhWYkFqdnZ4V2xIRnROenE5ZmRB?= =?utf-8?B?TUNaRFpwRjllODJnZVU2WXBmUksyNll0K1o0QXp5RmJBRTZTYS90SFZ2RzN6?= =?utf-8?B?b3dXcGlLMTNhNzc0WHMyZXRFMThDeDExQ3Y1TzVIZlJ1emgyKzAyazNnWUN4?= =?utf-8?B?cHhVUXhhL2VrQ2o1Wko4QmJHZGJMMjY4MXJuQjVHQkpxVDF2aWN3alZtT0FN?= =?utf-8?B?THlJdEl4ZjFZWDUybDRvMlh1bnpORDlzSjBHK3BkN0h5Z0RhOFBOZTFBckh2?= =?utf-8?B?VnB6V0ZrVVNDazlEUGpjakNHS214d2YrQUs3MVRseWhoRDFKSTZyNjhqRUJV?= =?utf-8?B?RkNtdXJmTE5JU1crWEFlM0NhZmUydytmTWZPZTV3b2JKbzNZK0tlQWxRdk9K?= =?utf-8?B?b2JqRmZwako3UU9TSnZ1bjNWcVZoWTBlWXkvSDdUbW14dEZOdFh0c1dXU3p0?= =?utf-8?B?V3BUTFFYakRQMGNTTVJqMHY0NU9yYTFpNS9MNWtOaDZTV2Z1d2lpaXRoaExM?= =?utf-8?B?aWZLVXd4N1BPYzRXME01VXhrWTZlWFJ3VHdVdHMwN2ZodjV3UGlvOVlqS2wx?= =?utf-8?B?YmJxdythQnZoU2JvRjBHY3JLYUl0eFlsb0JHUWpkN0lIdjZRbzBNUjZta3ZV?= =?utf-8?B?VFdvTDBGZ3FjeDJUcW1vQjJUT1ExdTZQTHFETklYUzNnZ2MzUjZ2ZXN1SUhB?= =?utf-8?B?ZWErQnFrQTF6WGNhRTJsVUMwdkVXV2k3M3VsMndEcWtnMUJXbUFyV0xOOHVV?= =?utf-8?B?SW42UjJaWUV2SFU5Z2NHSnlTMGZwUGcwNHJISFNkWHhETUhNZE15ak9PZHQy?= =?utf-8?B?WlZhTlFBQm9SZmNobHVobUR6N3JHUFhXaVBoczhtZ05adlJMWkxITThzcFNC?= =?utf-8?B?bnIrVDZFSTNwMS83ZmxMaGdNRm9GY3FScFBBakNSVXBUckdrcXFhUHYwejZo?= =?utf-8?B?cElzN3FhM09EeHBrb2pDekZXQ3FmWGNITEZnVFU4TmdJMVZwTk9jVURSYmVr?= =?utf-8?B?R01LcWJBanZ2cWsyM1drUmxIV3NVYVRyU0pXODRMODV0VzFjZm9OenprVjNI?= =?utf-8?B?d1oxTUdNQ1M4QjFHR0xFK0ZUZWlZY3lML0FPckRBbmZlMFVwNnViTnFiOXho?= =?utf-8?Q?duuwa7e0l1+mui0tzSq8YXne2?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6893d83-34ce-4631-199d-08de32381a8b X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8604.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2025 06:49:28.0445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z/tsDYu2I9XlrmwfooNg9ViCzd6ioYlQq+1fFZECKAHZJu1Ci3KILdo47Nb2t3jKWQUxTq+XjhrqEULSwgDo4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10758 Adds the driver for communication interface to secure-enclave, that enables exchanging messages with NXP secure enclave HW IP(s) like EdgeLock Enclave, from: - User-Space Applications via character driver. ABI documentation for the NXP secure-enclave driver. User-space library using this driver: - i.MX Secure Enclave library: -- URL: https://github.com/nxp-imx/imx-secure-enclave.git, - i.MX Secure Middle-Ware: -- URL: https://github.com/nxp-imx/imx-smw.git Following checks are performed on the incoming msg-header, to block exchanging invalid arbitrary commands: - maximum allowed words, - check if command-tag & response-tag are valid - version, - command id validation check, to allow limited base-line API(s) and restrict following: - exchanging power management commands. - reset requests. - BBSM configuration requests. - re-initializing the FW. - RNG init - CAAM resource release management - SE's internal memory management. from user-space. Signed-off-by: Pankaj Gupta Reviewed-by: Frank Li --- changes from v19 to v20 - adds a func "se_chk_tx_msg_hdr", to check the validity of the in-coming message from usersapce. --- Documentation/ABI/testing/se-cdev | 43 +++ drivers/firmware/imx/ele_base_msg.c | 28 ++ drivers/firmware/imx/ele_base_msg.h | 20 + drivers/firmware/imx/ele_common.c | 37 +- drivers/firmware/imx/ele_common.h | 6 + drivers/firmware/imx/se_ctrl.c | 741 ++++++++++++++++++++++++++++++++= +++- drivers/firmware/imx/se_ctrl.h | 33 ++ include/uapi/linux/se_ioctl.h | 97 +++++ 8 files changed, 993 insertions(+), 12 deletions(-) diff --git a/Documentation/ABI/testing/se-cdev b/Documentation/ABI/testing/= se-cdev new file mode 100644 index 000000000000..dad39ffd245a --- /dev/null +++ b/Documentation/ABI/testing/se-cdev @@ -0,0 +1,43 @@ +What: /dev/_mu[0-9]+_ch[0-9]+ +Date: Mar 2025 +KernelVersion: 6.8 +Contact: linux-imx@nxp.com, pankaj.gupta@nxp.com +Description: + NXP offers multiple hardware IP(s) for secure enclaves like EdgeLock- + Enclave(ELE), SECO. The character device file descriptors + /dev/_mu*_ch* are the interface between userspace NXP's secure- + enclave shared library and the kernel driver. + + The ioctl(2)-based ABI is defined and documented in + [include]. + ioctl(s) are used primarily for: + - shared memory management + - allocation of I/O buffers + - getting mu info + - setting a dev-ctx as receiver to receive all the commands from FW + - getting SoC info + - send command and receive command response + + The following file operations are supported: + + open(2) + Currently the only useful flags are O_RDWR. + + read(2) + Every read() from the opened character device context is waiting on + wait_event_interruptible, that gets set by the registered mailbox call= back + function, indicating a message received from the firmware on message- + unit. + + write(2) + Every write() to the opened character device context needs to acquire + mailbox_lock before sending message on to the message unit. + + close(2) + Stops and frees up the I/O contexts that were associated + with the file descriptor. + +Users: https://github.com/nxp-imx/imx-secure-enclave.git, + https://github.com/nxp-imx/imx-smw.git + crypto/skcipher, + drivers/nvmem/imx-ocotp-ele.c diff --git a/drivers/firmware/imx/ele_base_msg.c b/drivers/firmware/imx/ele= _base_msg.c index b233729dd13d..ef1d89204ceb 100644 --- a/drivers/firmware/imx/ele_base_msg.c +++ b/drivers/firmware/imx/ele_base_msg.c @@ -14,6 +14,34 @@ =20 #define FW_DBG_DUMP_FIXED_STR "ELE" =20 +int ele_uapi_allowed_base_cmd(struct se_if_priv *priv, + struct se_msg_hdr *header) +{ + switch (header->command) { + case ELE_PING_REQ: return 0; + case ELE_DEBUG_DUMP_REQ: return 0; + case ELE_OEM_AUTH_CONTAINER_REQ: return 0; + case ELE_OEM_VERIFY_IMAGE_REQ: return 0; + case ELE_OEM_REL_CONTAINER_REQ: return 0; + case ELE_FW_LIFE_CYCLE_REQ: return 0; + case ELE_READ_FUSE_REQ: return 0; + case ELE_GET_FW_VERS_REQ: return 0; + case ELE_RETURN_LIFE_CYCLE_REQ: return 0; + case ELE_GET_EVENT_REQ: return 0; + case ELE_COMMIT_REQ: return 0; + case ELE_GEN_KEY_BLOB_REQ: return 0; + case ELE_GET_FW_STATUS_REQ: return 0; + case ELE_XIP_DECRYPT_REQ: return 0; + case ELE_WRITE_FUSE: return 0; + case ELE_GET_INFO_REQ: return 0; + case ELE_DEV_ATTEST_REQ: return 0; + case ELE_WRITE_SHADOW_FUSE_REQ: return 0; + case ELE_READ_SHADOW_FUSE_REQ: return 0; + default: + return -EACCES; + } +} + int ele_get_info(struct se_if_priv *priv, struct ele_dev_info *s_info) { struct se_api_msg *tx_msg __free(kfree) =3D NULL; diff --git a/drivers/firmware/imx/ele_base_msg.h b/drivers/firmware/imx/ele= _base_msg.h index 8e5b015e99a2..f8fabac331fd 100644 --- a/drivers/firmware/imx/ele_base_msg.h +++ b/drivers/firmware/imx/ele_base_msg.h @@ -15,6 +15,24 @@ =20 #define ELE_NONE_VAL 0x0 =20 + +#define ELE_OEM_AUTH_CONTAINER_REQ 0x87 +#define ELE_OEM_VERIFY_IMAGE_REQ 0x88 +#define ELE_OEM_REL_CONTAINER_REQ 0x89 +#define ELE_FW_LIFE_CYCLE_REQ 0x95 +#define ELE_READ_FUSE_REQ 0x97 +#define ELE_GET_FW_VERS_REQ 0x9d +#define ELE_RETURN_LIFE_CYCLE_REQ 0xa0 +#define ELE_GET_EVENT_REQ 0xa2 +#define ELE_COMMIT_REQ 0xa8 +#define ELE_GEN_KEY_BLOB_REQ 0xaf +#define ELE_GET_FW_STATUS_REQ 0xc5 +#define ELE_XIP_DECRYPT_REQ 0xc6 +#define ELE_WRITE_FUSE 0xd6 +#define ELE_DEV_ATTEST_REQ 0xdb +#define ELE_WRITE_SHADOW_FUSE_REQ 0xf2 +#define ELE_READ_SHADOW_FUSE_REQ 0xf3 + #define ELE_GET_INFO_REQ 0xda #define ELE_GET_INFO_REQ_MSG_SZ 0x10 #define ELE_GET_INFO_RSP_MSG_SZ 0x08 @@ -92,4 +110,6 @@ int ele_service_swap(struct se_if_priv *priv, phys_addr_= t addr, int ele_fw_authenticate(struct se_if_priv *priv, phys_addr_t contnr_addr, phys_addr_t img_addr); int ele_debug_dump(struct se_if_priv *priv); +int ele_uapi_allowed_base_cmd(struct se_if_priv *priv, + struct se_msg_hdr *header); #endif diff --git a/drivers/firmware/imx/ele_common.c b/drivers/firmware/imx/ele_c= ommon.c index f26fb4d55a9a..a6801c5ae4a8 100644 --- a/drivers/firmware/imx/ele_common.c +++ b/drivers/firmware/imx/ele_common.c @@ -6,6 +6,23 @@ #include "ele_base_msg.h" #include "ele_common.h" =20 +int se_chk_tx_msg_hdr(struct se_if_priv *priv, struct se_msg_hdr *header) +{ + if (!header->size || header->size > MAX_WORD_SIZE) + return -EINVAL; + + if (header->tag !=3D priv->if_defs->cmd_tag && + header->tag !=3D priv->if_defs->rsp_tag) + return -EINVAL; + + if (header->ver =3D=3D priv->if_defs->base_api_ver) + return ele_uapi_allowed_base_cmd(priv, header); + else if (header->ver =3D=3D priv->if_defs->fw_api_ver) + return 0; + + return -EINVAL; +} + /* * se_get_msg_chksum() - to calculate checksum word by word. * @@ -42,15 +59,22 @@ u32 se_get_msg_chksum(u32 *msg, u32 msg_len) return chksum; } =20 +void set_se_rcv_msg_timeout(struct se_if_priv *priv, u32 timeout_ms) +{ + priv->se_rcv_msg_timeout_ms =3D timeout_ms; +} + int ele_msg_rcv(struct se_if_device_ctx *dev_ctx, struct se_clbk_handle *s= e_clbk_hdl) { - unsigned long timeout; + unsigned long timeout_ms; int ret; =20 do { - timeout =3D MAX_SCHEDULE_TIMEOUT; + timeout_ms =3D MAX_SCHEDULE_TIMEOUT; + if (dev_ctx->priv->cmd_receiver_clbk_hdl.dev_ctx !=3D dev_ctx) + timeout_ms =3D msecs_to_jiffies(dev_ctx->priv->se_rcv_msg_timeout_ms); =20 - ret =3D wait_for_completion_interruptible_timeout(&se_clbk_hdl->done, ti= meout); + ret =3D wait_for_completion_interruptible_timeout(&se_clbk_hdl->done, ti= meout_ms); if (ret =3D=3D -ERESTARTSYS) { if (dev_ctx->priv->waiting_rsp_clbk_hdl.dev_ctx) { dev_ctx->priv->waiting_rsp_clbk_hdl.signal_rcvd =3D true; @@ -59,6 +83,13 @@ int ele_msg_rcv(struct se_if_device_ctx *dev_ctx, struct= se_clbk_handle *se_clbk ret =3D -EINTR; break; } + if (ret =3D=3D 0) { + ret =3D -ETIMEDOUT; + dev_err(dev_ctx->priv->dev, + "Fatal Error: SE interface: %s0, hangs indefinitely.\n", + get_se_if_name(dev_ctx->priv->if_defs->se_if_type)); + break; + } ret =3D se_clbk_hdl->rx_msg_sz; break; } while (ret < 0); diff --git a/drivers/firmware/imx/ele_common.h b/drivers/firmware/imx/ele_c= ommon.h index 5bac14439d7d..bdc13d1b715d 100644 --- a/drivers/firmware/imx/ele_common.h +++ b/drivers/firmware/imx/ele_common.h @@ -12,6 +12,11 @@ =20 #define IMX_ELE_FW_DIR "imx/ele/" =20 +#define MAX_WORD_SIZE 0x20 +#define SE_RCV_MSG_DEFAULT_TIMEOUT 5000 +#define SE_RCV_MSG_LONG_TIMEOUT 5000000 + +void set_se_rcv_msg_timeout(struct se_if_priv *priv, u32 val); u32 se_get_msg_chksum(u32 *msg, u32 msg_len); =20 int ele_msg_rcv(struct se_if_device_ctx *dev_ctx, struct se_clbk_handle *s= e_clbk_hdl); @@ -42,4 +47,5 @@ int se_save_imem_state(struct se_if_priv *priv, struct se= _imem_buf *imem); =20 int se_restore_imem_state(struct se_if_priv *priv, struct se_imem_buf *ime= m); =20 +int se_chk_tx_msg_hdr(struct se_if_priv *priv, struct se_msg_hdr *header); #endif /*__ELE_COMMON_H__ */ diff --git a/drivers/firmware/imx/se_ctrl.c b/drivers/firmware/imx/se_ctrl.c index 40544cbc70ca..b8070be57d15 100644 --- a/drivers/firmware/imx/se_ctrl.c +++ b/drivers/firmware/imx/se_ctrl.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #include "ele_base_msg.h" #include "ele_common.h" @@ -32,12 +33,6 @@ #define MBOX_TX_NAME "tx" #define MBOX_RX_NAME "rx" =20 -#define SE_TYPE_STR_DBG "dbg" -#define SE_TYPE_STR_HSM "hsm" - -#define SE_TYPE_ID_DBG 0x1 -#define SE_TYPE_ID_HSM 0x2 - struct se_fw_img_name { const u8 *prim_fw_nm_in_rfs; const u8 *seco_fw_nm_in_rfs; @@ -130,6 +125,13 @@ char *get_se_if_name(u8 se_if_id) return NULL; } =20 +static u32 get_se_soc_id(struct se_if_priv *priv) +{ + const struct se_soc_info *se_info =3D device_get_match_data(priv->dev); + + return se_info->soc_id; +} + static struct se_fw_load_info *get_load_fw_instance(struct se_if_priv *pri= v) { return &var_se_info.load_fw; @@ -203,8 +205,213 @@ static int get_se_soc_info(struct se_if_priv *priv, c= onst struct se_soc_info *se return 0; } =20 +static int load_firmware(struct se_if_priv *priv, const u8 *se_img_file_to= _load) +{ + const struct firmware *fw =3D NULL; + phys_addr_t se_fw_phyaddr; + u8 *se_fw_buf; + int ret; + + if (!se_img_file_to_load) { + dev_err(priv->dev, "FW image is not provided."); + return -EINVAL; + } + ret =3D request_firmware(&fw, se_img_file_to_load, priv->dev); + if (ret) + return ret; + + dev_info(priv->dev, "loading firmware %s.", se_img_file_to_load); + + /* allocate buffer to store the SE FW */ + se_fw_buf =3D dma_alloc_coherent(priv->dev, fw->size, &se_fw_phyaddr, GFP= _KERNEL); + if (!se_fw_buf) { + ret =3D -ENOMEM; + goto exit; + } + + memcpy(se_fw_buf, fw->data, fw->size); + ret =3D ele_fw_authenticate(priv, se_fw_phyaddr, se_fw_phyaddr); + if (ret < 0) { + dev_err(priv->dev, + "Error %pe: Authenticate & load SE firmware %s.", + ERR_PTR(ret), se_img_file_to_load); + ret =3D -EPERM; + } + dma_free_coherent(priv->dev, fw->size, se_fw_buf, se_fw_phyaddr); +exit: + release_firmware(fw); + + return ret; +} + +static int se_load_firmware(struct se_if_priv *priv) +{ + struct se_fw_load_info *load_fw =3D get_load_fw_instance(priv); + int ret =3D 0; + + if (!load_fw->is_fw_tobe_loaded) + return 0; + + if (load_fw->imem.state =3D=3D ELE_IMEM_STATE_BAD) { + ret =3D load_firmware(priv, load_fw->se_fw_img_nm->prim_fw_nm_in_rfs); + if (ret) { + dev_err(priv->dev, "Failed to load boot firmware."); + return -EPERM; + } + } + + ret =3D load_firmware(priv, load_fw->se_fw_img_nm->seco_fw_nm_in_rfs); + if (ret) { + dev_err(priv->dev, "Failed to load runtime firmware."); + return -EPERM; + } + + load_fw->is_fw_tobe_loaded =3D false; + + return ret; +} + +static int init_se_shared_mem(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + + INIT_LIST_HEAD(&se_shared_mem_mgmt->pending_out); + INIT_LIST_HEAD(&se_shared_mem_mgmt->pending_in); + + /* + * Allocate some memory for data exchanges with S40x. + * This will be used for data not requiring secure memory. + */ + se_shared_mem_mgmt->non_secure_mem.ptr =3D + dma_alloc_coherent(priv->dev, MAX_DATA_SIZE_PER_USER, + &se_shared_mem_mgmt->non_secure_mem.dma_addr, + GFP_KERNEL); + if (!se_shared_mem_mgmt->non_secure_mem.ptr) + return -ENOMEM; + + se_shared_mem_mgmt->non_secure_mem.size =3D MAX_DATA_SIZE_PER_USER; + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; + + return 0; +} + +static void cleanup_se_shared_mem(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + + /* Free non-secure shared buffer. */ + dma_free_coherent(priv->dev, MAX_DATA_SIZE_PER_USER, + se_shared_mem_mgmt->non_secure_mem.ptr, + se_shared_mem_mgmt->non_secure_mem.dma_addr); + + se_shared_mem_mgmt->non_secure_mem.ptr =3D NULL; + se_shared_mem_mgmt->non_secure_mem.dma_addr =3D 0; + se_shared_mem_mgmt->non_secure_mem.size =3D 0; + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; +} + +/* Need to copy the output data to user-device context. + */ +static int se_dev_ctx_cpy_out_data(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_if_priv *priv =3D dev_ctx->priv; + struct se_buf_desc *b_desc, *temp; + bool do_cpy =3D true; + + list_for_each_entry_safe(b_desc, temp, &se_shared_mem_mgmt->pending_out, = link) { + if (b_desc->usr_buf_ptr && b_desc->shared_buf_ptr && do_cpy) { + dev_dbg(priv->dev, "Copying output data to user."); + if (do_cpy && copy_to_user(b_desc->usr_buf_ptr, + b_desc->shared_buf_ptr, + b_desc->size)) { + dev_err(priv->dev, "Failure copying output data to user."); + do_cpy =3D false; + } + } + + if (b_desc->shared_buf_ptr) + memset(b_desc->shared_buf_ptr, 0, b_desc->size); + + list_del(&b_desc->link); + kfree(b_desc); + } + + return do_cpy ? 0 : -EFAULT; +} + +/* + * Clean the used Shared Memory space, + * whether its Input Data copied from user buffers, or + * Data received from FW. + */ +static void se_dev_ctx_shared_mem_cleanup(struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct list_head *pending_lists[] =3D {&se_shared_mem_mgmt->pending_in, + &se_shared_mem_mgmt->pending_out}; + struct se_buf_desc *b_desc, *temp; + int i; + + for (i =3D 0; i < ARRAY_SIZE(pending_lists); i++) { + list_for_each_entry_safe(b_desc, temp, pending_lists[i], link) { + if (b_desc->shared_buf_ptr) + memset(b_desc->shared_buf_ptr, 0, b_desc->size); + + list_del(&b_desc->link); + kfree(b_desc); + } + } + se_shared_mem_mgmt->non_secure_mem.pos =3D 0; +} + +static int add_b_desc_to_pending_list(void *shared_ptr_with_pos, + struct se_ioctl_setup_iobuf *io, + struct se_if_device_ctx *dev_ctx) +{ + struct se_shared_mem_mgmt_info *se_shared_mem_mgmt =3D &dev_ctx->se_share= d_mem_mgmt; + struct se_buf_desc *b_desc; + + b_desc =3D kzalloc(sizeof(*b_desc), GFP_KERNEL); + if (!b_desc) + return -ENOMEM; + + b_desc->shared_buf_ptr =3D shared_ptr_with_pos; + b_desc->usr_buf_ptr =3D io->user_buf; + b_desc->size =3D io->length; + + if (io->flags & SE_IO_BUF_FLAGS_IS_INPUT) { + /* + * buffer is input: + * add an entry in the "pending input buffers" list so + * that copied data can be cleaned from shared memory + * later. + */ + list_add_tail(&b_desc->link, &se_shared_mem_mgmt->pending_in); + } else { + /* + * buffer is output: + * add an entry in the "pending out buffers" list so data + * can be copied to user space when receiving Secure-Enclave + * response. + */ + list_add_tail(&b_desc->link, &se_shared_mem_mgmt->pending_out); + } + + return 0; +} + +/* interface for managed res to unregister a character device */ +static void if_misc_deregister(void *miscdevice) +{ + misc_deregister(miscdevice); +} + static int init_misc_device_context(struct se_if_priv *priv, int ch_id, - struct se_if_device_ctx **new_dev_ctx) + struct se_if_device_ctx **new_dev_ctx, + const struct file_operations *se_if_fops) { struct se_if_device_ctx *dev_ctx; int ret =3D 0; @@ -220,12 +427,517 @@ static int init_misc_device_context(struct se_if_pri= v *priv, int ch_id, if (!dev_ctx->devname) return -ENOMEM; =20 + mutex_init(&dev_ctx->fops_lock); + dev_ctx->priv =3D priv; *new_dev_ctx =3D dev_ctx; =20 + dev_ctx->miscdev =3D devm_kzalloc(priv->dev, sizeof(*dev_ctx->miscdev), G= FP_KERNEL); + if (!dev_ctx->miscdev) { + *new_dev_ctx =3D NULL; + return -ENOMEM; + } + + dev_ctx->miscdev->name =3D dev_ctx->devname; + dev_ctx->miscdev->minor =3D MISC_DYNAMIC_MINOR; + dev_ctx->miscdev->fops =3D se_if_fops; + dev_ctx->miscdev->parent =3D priv->dev; + ret =3D misc_register(dev_ctx->miscdev); + if (ret) + return dev_err_probe(priv->dev, ret, "Failed to register misc device."); + + ret =3D devm_add_action_or_reset(priv->dev, if_misc_deregister, dev_ctx->= miscdev); + if (ret) + return dev_err_probe(priv->dev, ret, + "Failed to add action to the misc-dev."); return ret; } =20 +static int init_device_context(struct se_if_priv *priv, int ch_id, + struct se_if_device_ctx **new_dev_ctx) +{ + struct se_if_device_ctx *dev_ctx; + int ret =3D 0; + + dev_ctx =3D kzalloc(sizeof(*dev_ctx), GFP_KERNEL); + + if (!dev_ctx) + return -ENOMEM; + + dev_ctx->devname =3D kasprintf(GFP_KERNEL, "%s0_ch%d", + get_se_if_name(priv->if_defs->se_if_type), + ch_id); + if (!dev_ctx->devname) { + kfree(dev_ctx); + return -ENOMEM; + } + + mutex_init(&dev_ctx->fops_lock); + dev_ctx->priv =3D priv; + *new_dev_ctx =3D dev_ctx; + + list_add_tail(&dev_ctx->link, &priv->dev_ctx_list); + priv->active_devctx_count++; + + ret =3D init_se_shared_mem(dev_ctx); + if (ret < 0) { + kfree(dev_ctx->devname); + kfree(dev_ctx); + *new_dev_ctx =3D NULL; + } + + return ret; +} + +static int se_ioctl_cmd_snd_rcv_rsp_handler(struct se_if_device_ctx *dev_c= tx, + u64 arg) +{ + struct se_ioctl_cmd_snd_rcv_rsp_info cmd_snd_rcv_rsp_info =3D {0}; + struct se_api_msg *tx_msg __free(kfree) =3D NULL; + struct se_api_msg *rx_msg __free(kfree) =3D NULL; + struct se_if_priv *priv =3D dev_ctx->priv; + int err =3D 0; + + if (copy_from_user(&cmd_snd_rcv_rsp_info, (u8 __user *)arg, + sizeof(cmd_snd_rcv_rsp_info))) { + dev_err(priv->dev, + "%s: Failed to copy cmd_snd_rcv_rsp_info from user.", + dev_ctx->devname); + err =3D -EFAULT; + goto exit; + } + + if (cmd_snd_rcv_rsp_info.tx_buf_sz < SE_MU_HDR_SZ) { + dev_err(priv->dev, "%s: User buffer too small(%d < %d)", + dev_ctx->devname, cmd_snd_rcv_rsp_info.tx_buf_sz, SE_MU_HDR_SZ); + err =3D -ENOSPC; + goto exit; + } + + err =3D se_chk_tx_msg_hdr(priv, (struct se_msg_hdr *)cmd_snd_rcv_rsp_info= .tx_buf); + if (err) + goto exit; + + rx_msg =3D kzalloc(cmd_snd_rcv_rsp_info.rx_buf_sz, GFP_KERNEL); + if (!rx_msg) { + err =3D -ENOMEM; + goto exit; + } + + tx_msg =3D memdup_user(cmd_snd_rcv_rsp_info.tx_buf, + cmd_snd_rcv_rsp_info.tx_buf_sz); + if (IS_ERR(tx_msg)) { + err =3D PTR_ERR(tx_msg); + goto exit; + } + + if (tx_msg->header.tag !=3D priv->if_defs->cmd_tag) { + err =3D -EINVAL; + goto exit; + } + + if (tx_msg->header.ver =3D=3D priv->if_defs->fw_api_ver && + get_load_fw_instance(priv)->is_fw_tobe_loaded) { + err =3D se_load_firmware(priv); + if (err) { + dev_err(priv->dev, "Could not send msg as FW is not loaded."); + err =3D -EPERM; + goto exit; + } + } + set_se_rcv_msg_timeout(priv, SE_RCV_MSG_LONG_TIMEOUT); + + err =3D ele_msg_send_rcv(dev_ctx, tx_msg, cmd_snd_rcv_rsp_info.tx_buf_sz, + rx_msg, cmd_snd_rcv_rsp_info.rx_buf_sz); + if (err < 0) + goto exit; + + dev_dbg(priv->dev, "%s: %s %s.", dev_ctx->devname, __func__, + "message received, start transmit to user"); + + /* We may need to copy the output data to user before + * delivering the completion message. + */ + err =3D se_dev_ctx_cpy_out_data(dev_ctx); + if (err < 0) + goto exit; + + /* Copy data from the buffer */ + print_hex_dump_debug("to user ", DUMP_PREFIX_OFFSET, 4, 4, rx_msg, + cmd_snd_rcv_rsp_info.rx_buf_sz, false); + + if (copy_to_user(cmd_snd_rcv_rsp_info.rx_buf, rx_msg, + cmd_snd_rcv_rsp_info.rx_buf_sz)) { + dev_err(priv->dev, "%s: Failed to copy to user.", dev_ctx->devname); + err =3D -EFAULT; + } + +exit: + + /* shared memory is allocated before this IOCTL */ + se_dev_ctx_shared_mem_cleanup(dev_ctx); + + if (copy_to_user((void __user *)arg, &cmd_snd_rcv_rsp_info, + sizeof(cmd_snd_rcv_rsp_info))) { + dev_err(priv->dev, "%s: Failed to copy cmd_snd_rcv_rsp_info from user.", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +static int se_ioctl_get_mu_info(struct se_if_device_ctx *dev_ctx, + u64 arg) +{ + struct se_if_priv *priv =3D dev_ctx->priv; + struct se_ioctl_get_if_info if_info; + struct se_if_node *if_node; + int err =3D 0; + + if_node =3D container_of(priv->if_defs, typeof(*if_node), if_defs); + + if_info.se_if_id =3D 0; + if_info.interrupt_idx =3D 0; + if_info.tz =3D 0; + if_info.did =3D 0; + if_info.cmd_tag =3D priv->if_defs->cmd_tag; + if_info.rsp_tag =3D priv->if_defs->rsp_tag; + if_info.success_tag =3D priv->if_defs->success_tag; + if_info.base_api_ver =3D priv->if_defs->base_api_ver; + if_info.fw_api_ver =3D priv->if_defs->fw_api_ver; + + dev_dbg(priv->dev, "%s: info [se_if_id: %d, irq_idx: %d, tz: 0x%x, did: 0= x%x].", + dev_ctx->devname, if_info.se_if_id, if_info.interrupt_idx, if_info.tz, + if_info.did); + + if (copy_to_user((u8 __user *)arg, &if_info, sizeof(if_info))) { + dev_err(priv->dev, "%s: Failed to copy mu info to user.", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* + * Copy a buffer of data to/from the user and return the address to use in + * messages + */ +static int se_ioctl_setup_iobuf_handler(struct se_if_device_ctx *dev_ctx, + u64 arg) +{ + struct se_shared_mem *shared_mem =3D NULL; + struct se_ioctl_setup_iobuf io =3D {0}; + int err =3D 0; + u32 pos; + + if (copy_from_user(&io, (u8 __user *)arg, sizeof(io))) { + dev_err(dev_ctx->priv->dev, "%s: Failed copy iobuf config from user.", + dev_ctx->devname); + return -EFAULT; + } + + dev_dbg(dev_ctx->priv->dev, "%s: io [buf: %p(%d) flag: %x].", dev_ctx->de= vname, + io.user_buf, io.length, io.flags); + + if (io.length =3D=3D 0 || !io.user_buf) { + /* + * Accept NULL pointers since some buffers are optional + * in FW commands. In this case we should return 0 as + * pointer to be embedded into the message. + * Skip all data copy part of code below. + */ + io.ele_addr =3D 0; + goto copy; + } + + /* No specific requirement for this buffer. */ + shared_mem =3D &dev_ctx->se_shared_mem_mgmt.non_secure_mem; + + /* Check there is enough space in the shared memory. */ + dev_dbg(dev_ctx->priv->dev, "%s: req_size =3D %d, max_size=3D %d, curr_po= s =3D %d", + dev_ctx->devname, round_up(io.length, 8u), shared_mem->size, + shared_mem->pos); + + if (shared_mem->size < shared_mem->pos || + round_up(io.length, 8u) > (shared_mem->size - shared_mem->pos)) { + dev_err(dev_ctx->priv->dev, "%s: Not enough space in shared memory.", + dev_ctx->devname); + return -ENOMEM; + } + + /* Allocate space in shared memory. 8 bytes aligned. */ + pos =3D shared_mem->pos; + shared_mem->pos +=3D round_up(io.length, 8u); + io.ele_addr =3D (u64)shared_mem->dma_addr + pos; + + memset(shared_mem->ptr + pos, 0, io.length); + if ((io.flags & SE_IO_BUF_FLAGS_IS_INPUT) || + (io.flags & SE_IO_BUF_FLAGS_IS_IN_OUT)) { + /* + * buffer is input: + * copy data from user space to this allocated buffer. + */ + if (copy_from_user(shared_mem->ptr + pos, io.user_buf, io.length)) { + dev_err(dev_ctx->priv->dev, + "%s: Failed copy data to shared memory.", + dev_ctx->devname); + return -EFAULT; + } + } + + err =3D add_b_desc_to_pending_list(shared_mem->ptr + pos, &io, dev_ctx); + if (err < 0) + dev_err(dev_ctx->priv->dev, "%s: Failed to allocate/link b_desc.", + dev_ctx->devname); + +copy: + /* Provide the EdgeLock Enclave address to user space only if success.*/ + if (copy_to_user((u8 __user *)arg, &io, sizeof(io))) { + dev_err(dev_ctx->priv->dev, "%s: Failed to copy iobuff setup to user.", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* IOCTL to provide SoC information */ +static int se_ioctl_get_se_soc_info_handler(struct se_if_device_ctx *dev_c= tx, u64 arg) +{ + struct se_ioctl_get_soc_info soc_info; + int err =3D -EINVAL; + + soc_info.soc_id =3D get_se_soc_id(dev_ctx->priv); + soc_info.soc_rev =3D var_se_info.soc_rev; + + err =3D copy_to_user((u8 __user *)arg, (u8 *)(&soc_info), sizeof(soc_info= )); + if (err) { + dev_err(dev_ctx->priv->dev, "%s: Failed to copy soc info to user.", + dev_ctx->devname); + err =3D -EFAULT; + } + + return err; +} + +/* + * File operations for user-space + */ + +/* Write a message to the MU. */ +static ssize_t se_if_fops_write(struct file *fp, const char __user *buf, + size_t size, loff_t *ppos) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_api_msg *tx_msg __free(kfree) =3D NULL; + struct se_if_priv *priv =3D dev_ctx->priv; + int err; + + dev_dbg(priv->dev, "%s: write from buf (%p)%zu, ppos=3D%lld.", dev_ctx->d= evname, + buf, size, ((ppos) ? *ppos : 0)); + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + if (dev_ctx !=3D priv->cmd_receiver_clbk_hdl.dev_ctx) + return -EINVAL; + + err =3D se_chk_tx_msg_hdr(priv, (struct se_msg_hdr *)buf); + if (err) + return err; + + if (size < SE_MU_HDR_SZ) { + dev_err(priv->dev, "%s: User buffer too small(%zu < %d).", + dev_ctx->devname, size, SE_MU_HDR_SZ); + return -ENOSPC; + } + + tx_msg =3D memdup_user(buf, size); + if (IS_ERR(tx_msg)) + return PTR_ERR(tx_msg); + + print_hex_dump_debug("from user ", DUMP_PREFIX_OFFSET, 4, 4, + tx_msg, size, false); + + err =3D ele_msg_send(dev_ctx, tx_msg, size); + + return err; + } +} + +/* + * Read a message from the MU. + * Blocking until a message is available. + */ +static ssize_t se_if_fops_read(struct file *fp, char __user *buf, size_t s= ize, + loff_t *ppos) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + int err; + + dev_dbg(priv->dev, "%s: read to buf %p(%zu), ppos=3D%lld.", dev_ctx->devn= ame, + buf, size, ((ppos) ? *ppos : 0)); + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + if (dev_ctx !=3D priv->cmd_receiver_clbk_hdl.dev_ctx) { + err =3D -EINVAL; + goto exit; + } + + err =3D ele_msg_rcv(dev_ctx, &priv->cmd_receiver_clbk_hdl); + if (err < 0) { + dev_err(priv->dev, "%s: Err[0x%x]:Interrupted by signal." + "Current active dev-ctx count =3D %d.", + dev_ctx->devname, err, dev_ctx->priv->active_devctx_count); + goto exit; + } + + /* We may need to copy the output data to user before + * delivering the completion message. + */ + err =3D se_dev_ctx_cpy_out_data(dev_ctx); + if (err < 0) + goto exit; + + /* Copy data from the buffer */ + print_hex_dump_debug("to user ", DUMP_PREFIX_OFFSET, 4, 4, + priv->cmd_receiver_clbk_hdl.rx_msg, + priv->cmd_receiver_clbk_hdl.rx_msg_sz, + false); + + if (copy_to_user(buf, priv->cmd_receiver_clbk_hdl.rx_msg, + priv->cmd_receiver_clbk_hdl.rx_msg_sz)) { + dev_err(priv->dev, "%s: Failed to copy to user.", + dev_ctx->devname); + err =3D -EFAULT; + } else { + err =3D priv->cmd_receiver_clbk_hdl.rx_msg_sz; + } +exit: + priv->cmd_receiver_clbk_hdl.rx_msg_sz =3D 0; + + se_dev_ctx_shared_mem_cleanup(dev_ctx); + + return err; + } +} + +/* Open a character device. */ +static int se_if_fops_open(struct inode *nd, struct file *fp) +{ + struct miscdevice *miscdev =3D fp->private_data; + struct se_if_device_ctx *misc_dev_ctx; + struct se_if_device_ctx *dev_ctx; + struct se_if_priv *priv; + int err =3D 0; + + priv =3D dev_get_drvdata(miscdev->parent); + misc_dev_ctx =3D priv->priv_dev_ctx; + + scoped_cond_guard(mutex_intr, return -EBUSY, &misc_dev_ctx->fops_lock) { + priv->dev_ctx_mono_count++; + err =3D init_device_context(priv, + priv->dev_ctx_mono_count ? + priv->dev_ctx_mono_count + : priv->dev_ctx_mono_count++, + &dev_ctx); + if (err) + dev_err(priv->dev, "Failed[0x%x] to create dev-ctx.", err); + else + fp->private_data =3D dev_ctx; + + return err; + } +} + +/* Close a character device. */ +static int se_if_fops_close(struct inode *nd, struct file *fp) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + /* check if this device was registered as command receiver. */ + if (priv->cmd_receiver_clbk_hdl.dev_ctx =3D=3D dev_ctx) { + priv->cmd_receiver_clbk_hdl.dev_ctx =3D NULL; + kfree(priv->cmd_receiver_clbk_hdl.rx_msg); + priv->cmd_receiver_clbk_hdl.rx_msg =3D NULL; + } + + se_dev_ctx_shared_mem_cleanup(dev_ctx); + cleanup_se_shared_mem(dev_ctx); + + priv->active_devctx_count--; + list_del(&dev_ctx->link); + + kfree(dev_ctx->devname); + kfree(dev_ctx); + } + + return 0; +} + +/* IOCTL entry point of a character device */ +static long se_ioctl(struct file *fp, unsigned int cmd, unsigned long arg) +{ + struct se_if_device_ctx *dev_ctx =3D fp->private_data; + struct se_if_priv *priv =3D dev_ctx->priv; + long err; + + /* Prevent race during change of device context */ + scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) { + switch (cmd) { + case SE_IOCTL_ENABLE_CMD_RCV: + if (!priv->cmd_receiver_clbk_hdl.dev_ctx) { + if (!priv->cmd_receiver_clbk_hdl.rx_msg) { + priv->cmd_receiver_clbk_hdl.rx_msg =3D + kzalloc(MAX_NVM_MSG_LEN, + GFP_KERNEL); + if (!priv->cmd_receiver_clbk_hdl.rx_msg) { + err =3D -ENOMEM; + break; + } + } + priv->cmd_receiver_clbk_hdl.rx_msg_sz =3D MAX_NVM_MSG_LEN; + priv->cmd_receiver_clbk_hdl.dev_ctx =3D dev_ctx; + err =3D 0; + } else { + err =3D -EBUSY; + } + break; + case SE_IOCTL_GET_MU_INFO: + err =3D se_ioctl_get_mu_info(dev_ctx, arg); + break; + case SE_IOCTL_SETUP_IOBUF: + err =3D se_ioctl_setup_iobuf_handler(dev_ctx, arg); + break; + case SE_IOCTL_GET_SOC_INFO: + err =3D se_ioctl_get_se_soc_info_handler(dev_ctx, arg); + break; + case SE_IOCTL_CMD_SEND_RCV_RSP: + err =3D se_ioctl_cmd_snd_rcv_rsp_handler(dev_ctx, arg); + break; + default: + err =3D -EINVAL; + dev_dbg(priv->dev, "%s: IOCTL %.8x not supported.", + dev_ctx->devname, cmd); + } + } + + return err; +} + +/* Char driver setup */ +static const struct file_operations se_if_fops =3D { + .open =3D se_if_fops_open, + .owner =3D THIS_MODULE, + .release =3D se_if_fops_close, + .unlocked_ioctl =3D se_ioctl, + .read =3D se_if_fops_read, + .write =3D se_if_fops_write, +}; + /* interface for managed res to free a mailbox channel */ static void if_mbox_free_channel(void *mbox_chan) { @@ -246,7 +958,7 @@ static int se_if_request_channel(struct device *dev, st= ruct mbox_chan **chan, ret =3D devm_add_action_or_reset(dev, if_mbox_free_channel, t_chan); if (ret) return dev_err_probe(dev, -EPERM, - "Failed to add-action for removal of mbox: %s\n", + "Failed to add-action for removal of mbox: %s.", name); *chan =3D t_chan; =20 @@ -255,6 +967,7 @@ static int se_if_request_channel(struct device *dev, st= ruct mbox_chan **chan, =20 static void se_if_probe_cleanup(void *plat_dev) { + struct se_if_device_ctx *dev_ctx, *t_dev_ctx; struct platform_device *pdev =3D plat_dev; struct se_fw_load_info *load_fw; struct device *dev =3D &pdev->dev; @@ -279,6 +992,13 @@ static void se_if_probe_cleanup(void *plat_dev) load_fw->imem.buf =3D NULL; } =20 + if (priv->dev_ctx_mono_count) { + list_for_each_entry_safe(dev_ctx, t_dev_ctx, &priv->dev_ctx_list, link) { + list_del(&dev_ctx->link); + priv->active_devctx_count--; + } + } + /* * No need to check, if reserved memory is allocated * before calling for its release. Or clearing the @@ -319,6 +1039,7 @@ static int se_if_probe(struct platform_device *pdev) priv->se_mb_cl.tx_block =3D false; priv->se_mb_cl.knows_txdone =3D true; priv->se_mb_cl.rx_callback =3D se_if_rx_callback; + set_se_rcv_msg_timeout(priv, SE_RCV_MSG_DEFAULT_TIMEOUT); =20 ret =3D se_if_request_channel(dev, &priv->tx_chan, &priv->se_mb_cl, MBOX_= TX_NAME); if (ret) @@ -340,6 +1061,7 @@ static int se_if_probe(struct platform_device *pdev) "Unable to get sram pool =3D %s.", if_node->pool_name); } + INIT_LIST_HEAD(&priv->dev_ctx_list); =20 if (if_node->reserved_dma_ranges) { ret =3D of_reserved_mem_device_init(dev); @@ -348,7 +1070,7 @@ static int se_if_probe(struct platform_device *pdev) "Failed to init reserved memory region."); } =20 - ret =3D init_misc_device_context(priv, 0, &priv->priv_dev_ctx); + ret =3D init_misc_device_context(priv, 0, &priv->priv_dev_ctx, &se_if_fop= s); if (ret) return dev_err_probe(dev, ret, "Failed[0x%x] to create device contexts.", @@ -389,6 +1111,7 @@ static int se_suspend(struct device *dev) struct se_fw_load_info *load_fw; int ret =3D 0; =20 + set_se_rcv_msg_timeout(priv, SE_RCV_MSG_DEFAULT_TIMEOUT); load_fw =3D get_load_fw_instance(priv); =20 if (load_fw->imem_mgmt) diff --git a/drivers/firmware/imx/se_ctrl.h b/drivers/firmware/imx/se_ctrl.h index b5e7705e2f26..5fcdcfe3e8e5 100644 --- a/drivers/firmware/imx/se_ctrl.h +++ b/drivers/firmware/imx/se_ctrl.h @@ -14,6 +14,7 @@ #define SE_MSG_WORD_SZ 0x4 =20 #define RES_STATUS(x) FIELD_GET(0x000000ff, x) +#define MAX_DATA_SIZE_PER_USER (65 * 1024) #define MAX_NVM_MSG_LEN (256) #define MESSAGING_VERSION_6 0x6 #define MESSAGING_VERSION_7 0x7 @@ -37,10 +38,38 @@ struct se_imem_buf { u32 state; }; =20 +struct se_buf_desc { + u8 *shared_buf_ptr; + void __user *usr_buf_ptr; + u32 size; + struct list_head link; +}; + +struct se_shared_mem { + dma_addr_t dma_addr; + u32 size; + u32 pos; + u8 *ptr; +}; + +struct se_shared_mem_mgmt_info { + struct list_head pending_in; + struct list_head pending_out; + + struct se_shared_mem non_secure_mem; +}; + /* Private struct for each char device instance. */ struct se_if_device_ctx { struct se_if_priv *priv; + struct miscdevice *miscdev; const char *devname; + + /* process one file operation at a time. */ + struct mutex fops_lock; + + struct se_shared_mem_mgmt_info se_shared_mem_mgmt; + struct list_head link; }; =20 /* Header of the messages exchange with the EdgeLock Enclave */ @@ -89,6 +118,10 @@ struct se_if_priv { const struct se_if_defines *if_defs; =20 struct se_if_device_ctx *priv_dev_ctx; + struct list_head dev_ctx_list; + u32 active_devctx_count; + u32 dev_ctx_mono_count; + u32 se_rcv_msg_timeout_ms; }; =20 char *get_se_if_name(u8 se_if_id); diff --git a/include/uapi/linux/se_ioctl.h b/include/uapi/linux/se_ioctl.h new file mode 100644 index 000000000000..0c948bdc8c26 --- /dev/null +++ b/include/uapi/linux/se_ioctl.h @@ -0,0 +1,97 @@ +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Cla= use*/ +/* + * Copyright 2025 NXP + */ + +#ifndef SE_IOCTL_H +#define SE_IOCTL_H + +#include + +#define SE_TYPE_STR_DBG "dbg" +#define SE_TYPE_STR_HSM "hsm" +#define SE_TYPE_ID_UNKWN 0x0 +#define SE_TYPE_ID_DBG 0x1 +#define SE_TYPE_ID_HSM 0x2 +/* IOCTL definitions. */ + +struct se_ioctl_setup_iobuf { + void __user *user_buf; + __u32 length; + __u32 flags; + __u64 ele_addr; +}; + +struct se_ioctl_shared_mem_cfg { + __u32 base_offset; + __u32 size; +}; + +struct se_ioctl_get_if_info { + __u8 se_if_id; + __u8 interrupt_idx; + __u8 tz; + __u8 did; + __u8 cmd_tag; + __u8 rsp_tag; + __u8 success_tag; + __u8 base_api_ver; + __u8 fw_api_ver; +}; + +struct se_ioctl_cmd_snd_rcv_rsp_info { + __u32 __user *tx_buf; + int tx_buf_sz; + __u32 __user *rx_buf; + int rx_buf_sz; +}; + +struct se_ioctl_get_soc_info { + __u16 soc_id; + __u16 soc_rev; +}; + +/* IO Buffer Flags */ +#define SE_IO_BUF_FLAGS_IS_OUTPUT (0x00u) +#define SE_IO_BUF_FLAGS_IS_INPUT (0x01u) +#define SE_IO_BUF_FLAGS_USE_SEC_MEM (0x02u) +#define SE_IO_BUF_FLAGS_USE_SHORT_ADDR (0x04u) +#define SE_IO_BUF_FLAGS_IS_IN_OUT (0x10u) + +/* IOCTLS */ +#define SE_IOCTL 0x0A /* like MISC_MAJOR. */ + +/* + * ioctl to designated the current fd as logical-reciever. + * This is ioctl is send when the nvm-daemon, a slave to the + * firmware is started by the user. + */ +#define SE_IOCTL_ENABLE_CMD_RCV _IO(SE_IOCTL, 0x01) + +/* + * ioctl to get the buffer allocated from the memory, which is shared + * between kernel and FW. + * Post allocation, the kernel tagged the allocated memory with: + * Output + * Input + * Input-Output + * Short address + * Secure-memory + */ +#define SE_IOCTL_SETUP_IOBUF _IOWR(SE_IOCTL, 0x03, struct se_ioctl_setup_i= obuf) + +/* + * ioctl to get the mu information, that is used to exchange message + * with FW, from user-spaced. + */ +#define SE_IOCTL_GET_MU_INFO _IOR(SE_IOCTL, 0x04, struct se_ioctl_get_if_i= nfo) +/* + * ioctl to get SoC Info from user-space. + */ +#define SE_IOCTL_GET_SOC_INFO _IOR(SE_IOCTL, 0x06, struct se_ioctl_ge= t_soc_info) + +/* + * ioctl to send command and receive response from user-space. + */ +#define SE_IOCTL_CMD_SEND_RCV_RSP _IOWR(SE_IOCTL, 0x07, struct se_ioctl_cm= d_snd_rcv_rsp_info) +#endif --=20 2.43.0