From nobody Mon Feb 9 23:08:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC120299937 for ; Wed, 3 Dec 2025 06:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764742836; cv=none; b=dkdqj1m3hOwOEGBkY7Q3+u46oun4lGeFuej9I+z290djwqtMcuxzBkifbetEtQfbinYwmxYiB1EOD88jLhFFSdQROZy9rUUESPbeT2XiTmbUhvgBIHRB9Mg9Igzom805xDdpliNTD5hA+I1tAfMUzTjSOxbgQ4liYYw8QNeEZi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764742836; c=relaxed/simple; bh=j0NHr6gaR0hCCc9uJTEGB2f61u5g4pXG4YCVsjBiL94=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eJJcpTxxT9O6mBRa1KJkzDkh+7T2GJ3xkpHlFE4WyxdaJWLrkK1XoUlBXbLiH2ue0ikMlVJ4oE0HgijFipnWCNBKq5yiOeET3jLCPaFw7uK8ylfAOkGY6poUvUJndhrAItiuVVohMW/g92alZAM2VKz+JlAz809J215eQpO8qO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kVizO1rC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ih4J/DhH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kVizO1rC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ih4J/DhH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B34YViK4130453 for ; Wed, 3 Dec 2025 06:20:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H7X39lnwBzI/TnVn7a7Ulf4HCr87WNBcyrTcQi2lH8Q=; b=kVizO1rCnKc45WB4 5/3irJV12OiC+84GIcxQH25yz3h4HZh9DmvnR7VMj4YFTP93JvquJ8V6r65/qHt1 4vegDtE4vo8I5siGS3X8KsbiMyEqNgTULZKQgmP56EYy8f28sSGxP4nLpzTyrTGy u6soXJ32vwqdbspLlbOpxa9RaRpf2PAKzqgsQON31Bq7MmruuLdmBiuxqwmEsgqq FPTW/huT8UqBsMAAcABYBpjcEoE5GyNohqhGJdtul4R20ftyOO/bT8XaMmjlDa54 ijGZ1k6mq53UJU17qYUD7UGCvSV0LJPLRLYxbaCKEI9FW129d3YtmfrCqfC0Gyfo 3Z78VA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4at5e79sw6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 06:20:32 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2958a134514so84964195ad.2 for ; Tue, 02 Dec 2025 22:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764742832; x=1765347632; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H7X39lnwBzI/TnVn7a7Ulf4HCr87WNBcyrTcQi2lH8Q=; b=Ih4J/DhH55Lrl6Wiax8bppk8e8aALVYIF5vYt24idPqFHss+hEoprs48xSdAhsMRPg WJ7jjDn5sTZFawmqmMOmilSD3DzF9iMkFAYRsFY5hcj0CJKDS5YbGOLRuzOYHoFGsHA7 djqbyMEc1jLFy1txxmK6HTcr8v07qpmT94D0vUDm3RhIbzYrQuIEFJz7ms6NtFHVZMr+ iMQxcBi/5Py+Ghf619kSX/LJ9kZTDGIbU+KQDDVLfHNmfPKWSphCOXsKiSgdn3Tzokox 8qcBVjpd6y0erqMtbc77SUATGBKX8PckdGcIe5YZXgOd7/V9mw8+HRgK3kuSkP80umUf 3ZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764742832; x=1765347632; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=H7X39lnwBzI/TnVn7a7Ulf4HCr87WNBcyrTcQi2lH8Q=; b=NB6OM84wxEl5Zc+EvRA3G3LxmnvIYGYhHlr7sJ+QYN03krqA/LFS5CZvqFHkVhq5hJ 1q4j/kp8Ip6ZX1KvpYpni3Di+mjBG9Lx+yxhqX6djCklanWatFy7J/VEmWCSrGQzeVwK JXFvlKUoGQqjGWu3znFKBqZ+FNG0I5+M5ye4ezgzDil2d+/b8LfR9vUaJ/Kl733+vjyF BdbpvqeT1tAqw3eyja4BeYmOsVwdNauxYlCDgsPXaCik2Kh749TP9MKkuGqftJyGnZYB 6thhPlgnwSeLozP4kGKgxqJI2iVpTPsGWERQatJLI2x21+v8dyaI8G+tWhzjiWTT9B9A 9U7w== X-Forwarded-Encrypted: i=1; AJvYcCVMIa6AS/oJ6RfbW4bQm5vxWFcXgm1BHkEmovnhaKxMRxpTOyhkiYGCp5GBKwO84N5vDmUNs5Zh2BhkwM4=@vger.kernel.org X-Gm-Message-State: AOJu0YzN7i/fJSan4aXqz08CecNCf5KmIk/2R72pw6AAmDsLip22UuoU wnyIerQU+uQLa5ub0pzo0G0c17XSvXZeInvCOqSE8RpvSQt0nN9R7jC75T6LWCdteaFrEWPNWPW m5uUKsVFeeczf5eKipaOfXEP/947vd45twutl88BqNC5kt4ThuagvzTGDnhHjFQwalmA= X-Gm-Gg: ASbGncsGWlmGWdrDfwpoNI5IccZdk01Bj+irbvK5Dh6X0iTiY9l5++lCSzol9TPiIBL FszFk5mZ2LYlyIai9FyFkq+hmvIOCUldfjxcdt5u6XKanXPiwVhZPASf4PCVg/RMxz1Uibya9t+ cL6jiJkg+Bkt8Pa2EzCKt+Xx+E+W42z58WYqL83TTBKvMT9DUeSSEbIuPVU7vzwhuDDOjdGm6uh uuEHYrwmyjgCDtnBVUAZI922gKSTD2hMU3Q4BmCwqSV7rXZnfZiP4qBn6+0U11IF9hUm7sjbc7O vOcvSAr27DJXalYuDi97naMM3HYpDm30AkUdRXIN/9a6eSceFozbS03miT47VHQY18mgqoEBliH SYes8suIQZe6P6oc1KJ9oOnRt93HGAw9PT2jxBU+RE7XE X-Received: by 2002:a17:902:cecb:b0:295:5668:2f26 with SMTP id d9443c01a7336-29d68452625mr16565235ad.46.1764742832159; Tue, 02 Dec 2025 22:20:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/AfM1+1l3iWkAPu4Imly3Dl1xs6Svc2Asn6aX3v5k7MV0x1cQV7b3cg48K3NoFM9undFz6w== X-Received: by 2002:a17:902:cecb:b0:295:5668:2f26 with SMTP id d9443c01a7336-29d68452625mr16564895ad.46.1764742831547; Tue, 02 Dec 2025 22:20:31 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb4026bsm174263015ad.71.2025.12.02.22.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 22:20:31 -0800 (PST) From: Krishna Chaitanya Chundru Date: Wed, 03 Dec 2025 11:50:15 +0530 Subject: [PATCH 2/2] PCI: dwc: Fix missing iATU setup when ECAM is enabled Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-ecam_io_fix-v1-2-5cc3d3769c18@oss.qualcomm.com> References: <20251203-ecam_io_fix-v1-0-5cc3d3769c18@oss.qualcomm.com> In-Reply-To: <20251203-ecam_io_fix-v1-0-5cc3d3769c18@oss.qualcomm.com> To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Frank Li Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, macro@orcam.me.uk, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764742821; l=6265; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=j0NHr6gaR0hCCc9uJTEGB2f61u5g4pXG4YCVsjBiL94=; b=0pPNQvrKFk353JrtmMaFC3xvJ/btb22oD1cZih6Nlb+DbvGTBlNIsaC7LmzB5K8k75BVfHV2m whcjjyw/V8MBoDApYRATXAyFZJEn64a4kII4ixSJDTYhvDcSZqZSTVK X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDA0NyBTYWx0ZWRfX8YtLQGKHgyTP pur3jX4/XelP8FVWq8LA6LdCEAQSLeqOf1i5znN7DdaavhyZvqfS2j7heQUmbXCaC3Pv1AiSFf9 52vmg9B5ckm6Mv+O5EsKKZRkWUMGjvKr5SR0tcGATnnKYGeGLdtEJuwyBboI0WtiEyKgmEQlOHH Qtc0jkym3yXPPvE3GsXQYOYRPvOuQK8JIZ42Vi05LIMF5AjyVFB3EUfnk4NNaoPv24ATV5I0d3Q jnGGfxD/opgN5Knkfe9RyS5UrHXeEN9dZKJ/TZo8p5jvr/0cwFWJmt3/b+vcZI6XJ6V7kQXUIgF XHTzU5+EXUXXgyEFVJeqv8z2j24a0IgVzU+PtdOsu+JvFB0qQpm9HmpWc9CZcwuVpb02dQIME7J c1Ier3Btja+5Q4U2JC4UYXcWg4M2Xw== X-Authority-Analysis: v=2.4 cv=KcrfcAYD c=1 sm=1 tr=0 ts=692fd6b0 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=BcPKCTjPAAAA:8 a=EUspDBNiAAAA:8 a=qLoSvkEBCYgc-AYi8KwA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=MNXww67FyIVnWKX2fotq:22 X-Proofpoint-GUID: S9YQPtgg69Ea77l0rdGcmuRMKLPOQoYb X-Proofpoint-ORIG-GUID: S9YQPtgg69Ea77l0rdGcmuRMKLPOQoYb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-01_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030047 When ECAM is enabled, the driver skipped calling dw_pcie_iatu_setup() before configuring ECAM iATU entries. This left IO and MEM outbound windows unprogrammed, resulting in broken IO transactions. Additionally, dw_pcie_config_ecam_iatu() was only called during host initialization, so ECAM-related iATU entries were not restored after suspend/resume, leading to failures in configuration space access To resolve these issues, the ECAM iATU configuration is moved into dw_pcie_setup_rc(). At the same time, dw_pcie_iatu_setup() is invoked when ECAM is enabled. Rename msg_atu_index to ob_atu_index to track the next available outbound iATU index for ECAM and MSG TLP windows. Furthermore, an error check is added in dw_pcie_prog_outbound_atu() to avoid programming beyond num_ob_windows. Fixes: f6fd357f7afb ("PCI: dwc: Prepare the driver for enabling ECAM mechan= ism using iATU 'CFG Shift Feature'") Reported-by: Maciej W. Rozycki Closes: https://lore.kernel.org/all/alpine.DEB.2.21.2511280256260.36486@ang= ie.orcam.me.uk/ Signed-off-by: Krishna Chaitanya Chundru Tested-by: Maciej W. Rozycki --- drivers/pci/controller/dwc/pcie-designware-host.c | 37 ++++++++++++++-----= ---- drivers/pci/controller/dwc/pcie-designware.c | 3 ++ drivers/pci/controller/dwc/pcie-designware.h | 2 +- 3 files changed, 26 insertions(+), 16 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 4fb6331fbc2b322c1a1b6a8e4fe08f92e170da19..22c6ec7bff8840d935803f0b967= 49413b1c3f905 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -433,7 +433,7 @@ static int dw_pcie_config_ecam_iatu(struct dw_pcie_rp *= pp) * Immediate bus under Root Bus, needs type 0 iATU configuration and * remaining buses need type 1 iATU configuration. */ - atu.index =3D 0; + atu.index =3D pp->ob_atu_index; atu.type =3D PCIE_ATU_TYPE_CFG0; atu.parent_bus_addr =3D pp->cfg0_base + SZ_1M; /* 1MiB is to cover 1 (bus) * 32 (devices) * 8 (functions) */ @@ -443,6 +443,8 @@ static int dw_pcie_config_ecam_iatu(struct dw_pcie_rp *= pp) if (ret) return ret; =20 + pp->ob_atu_index++; + bus_range_max =3D resource_size(bus->res); =20 if (bus_range_max < 2) @@ -455,7 +457,11 @@ static int dw_pcie_config_ecam_iatu(struct dw_pcie_rp = *pp) atu.size =3D (SZ_1M * bus_range_max) - SZ_2M; atu.ctrl2 =3D PCIE_ATU_CFG_SHIFT_MODE_ENABLE; =20 - return dw_pcie_prog_outbound_atu(pci, &atu); + ret =3D dw_pcie_prog_outbound_atu(pci, &atu); + if (!ret) + pp->ob_atu_index++; + + return ret; } =20 static int dw_pcie_create_ecam_window(struct dw_pcie_rp *pp, struct resour= ce *res) @@ -630,14 +636,6 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) if (ret) goto err_free_msi; =20 - if (pp->ecam_enabled) { - ret =3D dw_pcie_config_ecam_iatu(pp); - if (ret) { - dev_err(dev, "Failed to configure iATU in ECAM mode\n"); - goto err_free_msi; - } - } - /* * Allocate the resource for MSG TLP before programming the iATU * outbound window in dw_pcie_setup_rc(). Since the allocation depends @@ -942,7 +940,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) dev_warn(pci->dev, "Ranges exceed outbound iATU size (%d)\n", pci->num_ob_windows); =20 - pp->msg_atu_index =3D ++i; + pp->ob_atu_index =3D ++i; =20 i =3D 0; resource_list_for_each_entry(entry, &pp->bridge->dma_ranges) { @@ -1084,14 +1082,23 @@ int dw_pcie_setup_rc(struct dw_pcie_rp *pp) /* * If the platform provides its own child bus config accesses, it means * the platform uses its own address translation component rather than - * ATU, so we should not program the ATU here. + * ATU, so we should not program the ATU here. If ECAM is enabled, config + * space access goes through ATU, so setup ATU here. */ - if (pp->bridge->child_ops =3D=3D &dw_child_pcie_ops) { + if (pp->bridge->child_ops =3D=3D &dw_child_pcie_ops || pp->ecam_enabled) { ret =3D dw_pcie_iatu_setup(pp); if (ret) return ret; } =20 + if (pp->ecam_enabled) { + ret =3D dw_pcie_config_ecam_iatu(pp); + if (ret) { + dev_err(pci->dev, "Failed to configure iATU in ECAM mode\n"); + return ret; + } + } + dw_pcie_writel_dbi(pci, PCI_BASE_ADDRESS_0, 0); =20 /* Program correct class for RC */ @@ -1113,7 +1120,7 @@ static int dw_pcie_pme_turn_off(struct dw_pcie *pci) void __iomem *mem; int ret; =20 - if (pci->num_ob_windows <=3D pci->pp.msg_atu_index) + if (pci->num_ob_windows <=3D pci->pp.ob_atu_index) return -ENOSPC; =20 if (!pci->pp.msg_res) @@ -1123,7 +1130,7 @@ static int dw_pcie_pme_turn_off(struct dw_pcie *pci) atu.routing =3D PCIE_MSG_TYPE_R_BC; atu.type =3D PCIE_ATU_TYPE_MSG; atu.size =3D resource_size(pci->pp.msg_res); - atu.index =3D pci->pp.msg_atu_index; + atu.index =3D pci->pp.ob_atu_index; =20 atu.parent_bus_addr =3D pci->pp.msg_res->start - pci->parent_bus_offset; =20 diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/con= troller/dwc/pcie-designware.c index c644216995f69cbf065e61a0392bf1e5e32cf56e..f9f3c2f3532e0d0e9f8e4f42d8c= 5c9db68d55272 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -476,6 +476,9 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, u32 retries, val; u64 limit_addr; =20 + if (atu->index > pci->num_ob_windows) + return -ENOSPC; + limit_addr =3D parent_bus_addr + atu->size - 1; =20 if ((limit_addr & ~pci->region_limit) !=3D (parent_bus_addr & ~pci->regio= n_limit) || diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index e995f692a1ecd10130d3be3358827f801811387f..69d0bd8b3c57353763f98999e5d= 39527861fe1a7 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -423,8 +423,8 @@ struct dw_pcie_rp { struct pci_host_bridge *bridge; raw_spinlock_t lock; DECLARE_BITMAP(msi_irq_in_use, MAX_MSI_IRQS); + int ob_atu_index; bool use_atu_msg; - int msg_atu_index; struct resource *msg_res; bool use_linkup_irq; struct pci_eq_presets presets; --=20 2.34.1