From nobody Mon Feb 9 16:54:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D996034D381 for ; Wed, 3 Dec 2025 16:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778379; cv=none; b=G8PQgi098r135mqEF5F5qPl8NCLau4ACOI28P+CQCGV9v2yyJrKo6yTbPrswCRKo1HFxox2iTT+RpPW28RSxuhrQHoa5Sgn/RTQtdnSE5qDfKIyKX5QUTxfLXAKgICbSupzqhxFmcntaYhw0iEcgR+nPG3VZJmtl0NqwRKVmxRk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764778379; c=relaxed/simple; bh=8vLELv6iEJw4HQAetXguIPG9JhI9/hFFJQ4g3Jr7e+E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tNIduf4K1xN2tVeXYDcSx8VH5pFdl6ekGUnS17Wgy7WdX/JKxLRu0Cx55mHWPuIyeEKMvC/vXmut9F7tXG6Vn9eHwpMr5AK5Su6TLn7I41/2XbiXNHeRXblb8KxeTAtMQRAj9r8ExzZzRcfsztypyLTZWGsxCx7dW2OKwq+4b3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bFNa4CVq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XX68fA+b; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bFNa4CVq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XX68fA+b" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B3ECrv71904384 for ; Wed, 3 Dec 2025 16:12:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 35fZq0L69H3uQ9aWFEbF/Zr1Rt22YIPmZ+q/BTCJbn0=; b=bFNa4CVqVj6tKR46 M+BoNWqrhNMouPwUVboFCVRaKQ4bLO3B8b/G0PhYU/chjX4//ey/JquE32KCiepa DcauSe6ehk98w7YKA85KrgcDlkaDE4gpzvTiAtDj77DfjHK5UxcWT/ZQejerSXuw q7uS5T8TFbnVeLljXqrHisMTXMPcj0mYuQLo+hbGcbMvHnVbXaxtYjLI/fvW3Cl8 95X8HoyZKR2R9k9bJDxre6W18ujdkb3+aNQpsyE6srGU6MeJNZHMOpRrX8D7BWj/ vs0ihhXPcPGbprk7Nc63WLCY1tPplmJ+R4kP2X5+W0LWjzSHp5EU2m62xyeans8D oN/oLA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atgx3hk39-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Dec 2025 16:12:56 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b225760181so842997185a.2 for ; Wed, 03 Dec 2025 08:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764778376; x=1765383176; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=35fZq0L69H3uQ9aWFEbF/Zr1Rt22YIPmZ+q/BTCJbn0=; b=XX68fA+blNPAalO+bc1JokESpel4tOmfgIsd4CRnufPo9SdMOB2up46elSrLTd+DJC VE7RgiucSAycRCOe5a5zEXCQTpCMbGXMjbCswRqU4EVb29Y2FExctC/x5pq8KGev6AM3 W2P35QuOh6NlumHk82AXgAXCP4iZKwpfNtjuxkvLC8KHRCNxSD05lQkYGhbpMIBclb14 +u3AVfDKV398ORh2OYrwbteEeSaA+O5l0B0nJRg9ARvHNGPYEx1IIRs9aYsz22hSPoKR 3BHiil/5Rpd6AlDO9OuUaEMN4V1VYtTrx8FKqKByJdMcp/AShMhcW5Gpr0/GBI4kphxW 3jIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764778376; x=1765383176; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=35fZq0L69H3uQ9aWFEbF/Zr1Rt22YIPmZ+q/BTCJbn0=; b=mGzQjXGbflyXXom23FghQhmaKuvo8juwUxJSObMAIUGTZnenevaiF/PGD1AWHFj8bW OstAFUr5Y8DMWndlDLEzg2d+VRSTloqs7XoplUMYwXfoTBRa9WPNuR5Q/NuLAVnpSZl3 qF5jqubwz52LtsCn0Rfet6a/GRRJfYBVmz/I6lIF/MVdr04eDNfY38aY0LAyLTpFcuD1 T9u1fab8UNUxP1god56CDIrkRT0DczY1jPR3uqMNsP0dzDVLoOoGIloYjRdfKLja/GpZ PAabE+vkPhmlT7z14chafPnMovdnwpXefgv4w3o/6vWqWYzSgbQehHmKckOpi0PV53fG h6Iw== X-Forwarded-Encrypted: i=1; AJvYcCU8d8ut0lBCIqEj2/xvflU47HW6FIi1rwmc+3wra4qMrUPmpE6tsfrK4ny5239AOgTYyLd+/Kg0uLgoMI4=@vger.kernel.org X-Gm-Message-State: AOJu0YzfMlJvsjJq1dTkqqE2+El3/E+x63a2Xh8zITxN7/sCucX1/7qy 6q0xJN02scbZzi/MLAdfA4/cRTT4hm+O7PCwDAz5TXbWTsQKwLmec622U56W5OLLh4ddfYPayNf ZLvdBPXPcKUVxNyhocKIFxjuaZQiP0Te4a9o7OyOOI8k5KoLfWnYHLJog6AWSapbbYIU= X-Gm-Gg: ASbGncsSZzlrI+6hghVH5aovNWrJFmx9++DJe8Rew9bY/HimFYiIibyApgo/RitF8ro HV1LFB75HgVKiFCgp1LektPBIGIFuGjSnOgfyiJsMXFPgToREsywTBwKLWZFUXFgdv9ZoMKxeYn dO4xM+znUvEGVzNnBlFPW9u7f9qTYgk1c24MS6oImoh2GaOwjDajr47FwUK+iUNYLSxoSe89bXr btbQmODkiWLScTvF3sPdD6SJfBI1lyyQZKK+XDne2vwRKm91BNaZT4wEPYfVaHEbARNzeGQsLqI +bUjqsAuy4a/pxYRsJN/G0wioyj3tw/LVzAgwF1Q1SdN1tMfYkCdDKCNjvgegrkAk5HDeedapAM On18HF+uuA/Pwi5V1KvSpzERdDGBJXtZ2iQ== X-Received: by 2002:a05:620a:468e:b0:8b2:a4ec:6f5 with SMTP id af79cd13be357-8b5e47cd116mr353816685a.11.1764778376042; Wed, 03 Dec 2025 08:12:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFG4cfQjQIEKj3oL685GCNF60vFdQ+dp9XuJDZh+9Clo7l0D/7i3PzHksj4n7pRHY6q6Y6+Dw== X-Received: by 2002:a05:620a:468e:b0:8b2:a4ec:6f5 with SMTP id af79cd13be357-8b5e47cd116mr353813185a.11.1764778375520; Wed, 03 Dec 2025 08:12:55 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792b021cd2sm23688295e9.1.2025.12.03.08.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Dec 2025 08:12:54 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 03 Dec 2025 17:12:39 +0100 Subject: [PATCH 2/3] ASoC: amd: acp-sdw-sof: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251203-asoc-wrong-cleanup-h-continued-v1-2-5142be4874fb@oss.qualcomm.com> References: <20251203-asoc-wrong-cleanup-h-continued-v1-0-5142be4874fb@oss.qualcomm.com> In-Reply-To: <20251203-asoc-wrong-cleanup-h-continued-v1-0-5142be4874fb@oss.qualcomm.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Maciej Strozek , Bard Liao , Pierre-Louis Bossart Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2224; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=8vLELv6iEJw4HQAetXguIPG9JhI9/hFFJQ4g3Jr7e+E=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpMGF8rwJf6F4HnGYCxTIAsD6B/mN7ZkafBO8Io 3uPZi/fSGmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaTBhfAAKCRDBN2bmhouD 13O8D/wLtDL1Y7runIIGFtzkOlA+CEkZuEA3RauUvgrbJF4p/8FKhG46UA5WnVSY+dofmzPguzv 3JEMpkI9+2OIMe8BW0ylRhPhNPmU2lsnBdzFch4z68sSPrieBo9WYaxnjOE7KiH/TZkdIreTi2b Ez7MQrr3cn/MVlBiRT+9wAUgltXkNPuaskYDy0uAFe1DN8ae6h6+iEMuNfc15ax9AvMM/aPfcYO s8wgqXuyCsQJIKJs5voyDTSKYeAT5Ww0CKF79H8hNkx1tmkQ3PfiKXkaLsSE2N5MOAyfTn1U/Mv 96SK177rnS/1MrueB6Ekxht6MahrFem/9MgFnmgGU0gd3q97+EsmebQlatPLc3v6glu0MHRX41o sWbEKLOSqB223g81Nx2oG52uPyaPmunvVYTJmsKUMMcTVFX46xRDhPDdb+8+bfGG2QApbFlNq6G Qfl7la6Io1fxmf2Ne1jY/vyxypQ1bbJNS30hQp8fbXeVdPZTwMhWWSHqu3Jwt1pyaXfJ1RdyWkW TWs6XLG89oTpyLkKoSiaEpo7AGNe/HEbD8LmpMyJHrV4piYy6h0d35wl89ibs0Abb7KjvKnfcKr /K5q9OMs/DBVuJim/9ayN3/+undx9vfMmYtX9Haf7QjwUZQEPRARuL1ODglBNWq/OVlPHupBtql 7aMRCCcRdbr5Nyw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAzMDEyOCBTYWx0ZWRfX2Q1i/tHD7LAe bZosOZ8NL/tnGfxj9mDlT0sexaaSNQJKwd67Y20Jk+aoNsFwAFF0brn179q/UzTar2KVbg1FOU0 kujKsPBeezuUGledwmCGmNMTm4dX6f2iA4IBcKHW+n8r81EDFoy63f1ppEJMPDhubQ+SVPVMHGG LiaQbJkUzzZVX8JOn+N1VEhtQK4++pOMZKvDs6k2igSN/Yuzz+1LHBikRowC8zmtcqZbJXAteA5 C6TrT41X4zq3xAMuvWRGelNArYloJOvxzO0jnj8FhqYCcXhNF7JBvt4WzcMfg3uFrxvbpRQiS0o 3NEjWFtsaKtAT1qdhaclmBFSF1tbEJgHMhw2h4NuCJriSeLeGOPjnswtkB4XvZam7XZ7deiluAy 2KWBwFiAaKHFNQExy6IBfVpIAAYR2A== X-Proofpoint-GUID: WtZ8W3XHGko7UHJBdeV_Arfrsazc1bVX X-Proofpoint-ORIG-GUID: WtZ8W3XHGko7UHJBdeV_Arfrsazc1bVX X-Authority-Analysis: v=2.4 cv=R/QO2NRX c=1 sm=1 tr=0 ts=69306188 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=G7cKtCAg_onYix8Q954A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-03_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512030128 Initializing automatic __free variables to NULL without need (e.g. branches with different allocations), followed by actual allocation is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski --- sound/soc/amd/acp/acp-sdw-sof-mach.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/amd/acp/acp-sdw-sof-mach.c b/sound/soc/amd/acp/acp-s= dw-sof-mach.c index 5677ae63fca9..da815b3f6389 100644 --- a/sound/soc/amd/acp/acp-sdw-sof-mach.c +++ b/sound/soc/amd/acp/acp-sdw-sof-mach.c @@ -270,8 +270,6 @@ static int sof_card_dai_links_create(struct snd_soc_car= d *card) int sdw_be_num =3D 0, dmic_num =3D 0; struct asoc_sdw_mc_private *ctx =3D snd_soc_card_get_drvdata(card); struct snd_soc_acpi_mach_params *mach_params =3D &mach->mach_params; - struct asoc_sdw_endpoint *sof_ends __free(kfree) =3D NULL; - struct asoc_sdw_dailink *sof_dais __free(kfree) =3D NULL; struct snd_soc_aux_dev *sof_aux; struct snd_soc_codec_conf *codec_conf; struct snd_soc_dai_link *dai_links; @@ -289,12 +287,14 @@ static int sof_card_dai_links_create(struct snd_soc_c= ard *card) } =20 /* One per DAI link, worst case is a DAI link for every endpoint */ - sof_dais =3D kcalloc(num_ends, sizeof(*sof_dais), GFP_KERNEL); + struct asoc_sdw_dailink *sof_dais __free(kfree) =3D + kcalloc(num_ends, sizeof(*sof_dais), GFP_KERNEL); if (!sof_dais) return -ENOMEM; =20 /* One per endpoint, ie. each DAI on each codec/amp */ - sof_ends =3D kcalloc(num_ends, sizeof(*sof_ends), GFP_KERNEL); + struct asoc_sdw_endpoint *sof_ends __free(kfree) =3D + kcalloc(num_ends, sizeof(*sof_ends), GFP_KERNEL); if (!sof_ends) return -ENOMEM; =20 --=20 2.51.0