From nobody Sun Feb 8 10:49:08 2026 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C05312802 for ; Tue, 2 Dec 2025 12:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676983; cv=none; b=H76pITtN2MR8wCC0HlTOQHQGioCSExbBb0IMt5ycRbFiS8RlXRK8CDuuRSDk3piRlj+c6uay9Gme1rYoJKmKEbm6VtOSilwvsldrjOJ45w63XLG83z4KL8SZAOzb6E5XlnnEMCvhAbUsgQqwYQQahFFdGw9rTFIon6HnU0L6KQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676983; c=relaxed/simple; bh=fJWPwY723ULgtVgkQjZtPrkYZvNU8HxVmANectBbrDw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XMh86V9yOF102aDSdTK1jnK6tAh+pvUlwkvQzawtkKVnUj99xqZ9VoktogjoJwZZFBEZ1pLRiZIXIbkiTWhEiKcOlvc/hn9UoLTtFh8TIM88DZgbtkCo17ly7fYDxqMwdK6oIYLLeqHkXG6z2/On0IOHoj4t1PAmW8VP/Fi6arM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eK1vCtuB; arc=none smtp.client-ip=209.85.208.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eK1vCtuB" Received: by mail-lj1-f193.google.com with SMTP id 38308e7fff4ca-37a875e3418so40432741fa.1 for ; Tue, 02 Dec 2025 04:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764676980; x=1765281780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jG08/J7Wqu0U4ZYwI7Hu/RQAPwp2mHobhNdvN9y9utM=; b=eK1vCtuBvd+9eG4hUfJxPZBG0hRUT68wQ4iBmVAN7rxkBCUbKZYCSq7iF8pbJvPn89 tg5HdgPPrNFFJbPVYTn+jhvbE35FTuIfbubF5QoQBVbLnDnkNME0vNVNIeMmgqWl6yRu 9bRRWXJZq209rui1DSC8fUmuLqh8/yz7IjzUQqgB2D4PAV1v405irCYNoY+utilKzTif xk8uSy6RDVRi1WjuzW+UgDBwPRJa8+ODvy3eAd3vSnCuI+5CbNrGWSc3NQMITLjVTSL5 BRtMqLrnTigm12GfifVFuYSqx4zLW+m4soqoIFyIeKp+yBgoupdV1aggr3HzSRQU0yDK HP2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764676980; x=1765281780; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jG08/J7Wqu0U4ZYwI7Hu/RQAPwp2mHobhNdvN9y9utM=; b=lss9gR7uygszIABMGfeNulj7SGPwaO6hEINvpVLWAy/LDOtiE9SJPo/926zNNf7HIZ LnAz5xzZpgjG6s9tkAElCX82ItW/EJ7eUXjdoT0YwCx5AusHhU8HWZ5rY2Bppgv8XtwK JUY7phdRU24XnS0NtkIbK4z2NOeesDtQY8EiV4yh7gHuB47LNCpOb8iA/r8Vs1hmB9lB BnzRu3ciOWy37F+FwrppK1gRr5eJDHBdObBUzd9Kgy8rhc3KzB0Eqtul8XoWW7uUVpM5 UQMqJeHZZn/+P7wJUuSyu2cgG5zfmEzUSKZ91YKzNZkPN1z8EXwDwvGWo3/eqrui2BNO L25Q== X-Forwarded-Encrypted: i=1; AJvYcCUIKHsfFxQQKs2RbTEFpcwFLcMlYlgzVe1TavpHHMyZxbSN1X30zIAXPZE/FfNpbVQfwZ6f9VRC/sdOz6o=@vger.kernel.org X-Gm-Message-State: AOJu0YwAHMkpDymVFVjQ3OGPVG0a6MEJuxvPdS3Up68wY410mHcNdlpS 2NQNv3e+9HkwvsQzmJtHq/uzt59EABE8ScKHu7KSIUkF8Dyygt8Ya1VK X-Gm-Gg: ASbGncsMniokRJvJCEyllJHsi+tfFHLiBP95pBIPvsY2G5d9aHONQ3KB51i7qEoMWqb ZO2rekyLzVEIeUGf2opPJUuIdNt6KpcE05UIhyMm00aUfgJMRU5qRWq50374ayY02nBxJiplx6X el5Gu84krFaZuHxmG6o2CUyvEm2k7qaJi35sfbMmb958PG3V+qCY5e2/QEHNGaRJxEKDqGRlJTN I5i/tJ2gjNRnm21nLh3Ov12eeUE3AUAAv3k3MUaG9rP+VidYFDh4e1AkV/OfIVYmy0QkBIjoxTR Me+Y+44gkCgwejs6CY3GoICoqtEbP4JfggmtFtNJLcBZCjPmItul6tCFzUvevknLcFpy+gDQu7r OHW758tRH+HBMoRI41EhZg1J5IvADMdyCls6d+QT7sTupKLtz8gl4IpKdic0DtwM7p8zJcG9OsB hE6gLcZBovbfU6nMbODSyXykef3y6IEGloMoU7Ux/nLONlrRA2JinxLa4vWA== X-Google-Smtp-Source: AGHT+IGGPdkU3+EE7NrwXBfeL0c30Jy8lQQXAxk/MVHA5a3hbDVEH93tWcMS5Zm9tbkt8OF1LdZtOA== X-Received: by 2002:a05:651c:43d8:10b0:37a:4611:9fe5 with SMTP id 38308e7fff4ca-37d077cc7abmr72780701fa.18.1764676979653; Tue, 02 Dec 2025 04:02:59 -0800 (PST) Received: from rbta-msk-lt-302690.astralinux.ru.astracloud.ru ([89.107.11.60]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37d236dd67bsm37720721fa.14.2025.12.02.04.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 04:02:58 -0800 (PST) From: Alexandra Diupina To: Andy Shevchenko Cc: Alexandra Diupina , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, lvc-project@linuxtesting.org Subject: [PATCH] media: atomisp: avoid memory leak in ia_css_pipe_create_cas_scaler_desc_single_output() Date: Tue, 2 Dec 2025 15:02:40 +0300 Message-Id: <20251202120240.14670-1-dyupina99999@gmail.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ia_css_pipe_create_cas_scaler_desc_single_output() may fail, so add cleanup by ia_css_pipe_destroy_cas_scaler_desc() rather than simply exiting the function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Alexandra Diupina --- drivers/staging/media/atomisp/pci/sh_css.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 73bd87f43a8c..4b553209af56 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -4528,7 +4528,7 @@ static int load_video_binaries(struct ia_css_pipe *pi= pe) NULL, &cas_scaler_descr); if (err) - return err; + goto ERR; mycs->num_yuv_scaler =3D cas_scaler_descr.num_stage; mycs->yuv_scaler_binary =3D kcalloc(cas_scaler_descr.num_stage, sizeof(struct ia_css_binary), @@ -4561,7 +4561,10 @@ static int load_video_binaries(struct ia_css_pipe *p= ipe) return err; } } +ERR: ia_css_pipe_destroy_cas_scaler_desc(&cas_scaler_descr); + if (err) + return err; } =20 { @@ -5107,7 +5110,7 @@ static int load_primary_binaries( &cas_scaler_descr); if (err) { IA_CSS_LEAVE_ERR_PRIVATE(err); - return err; + goto ERR; } mycs->num_yuv_scaler =3D cas_scaler_descr.num_stage; mycs->yuv_scaler_binary =3D kcalloc(cas_scaler_descr.num_stage, @@ -5141,7 +5144,10 @@ static int load_primary_binaries( return err; } } +ERR: ia_css_pipe_destroy_cas_scaler_desc(&cas_scaler_descr); + if (err) + return err; =20 } else { capt_pp_out_info =3D pipe->output_info[0]; --=20 2.30.2