From nobody Mon Feb 9 21:38:23 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68257313E20 for ; Tue, 2 Dec 2025 11:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676353; cv=none; b=cBN5TpWpvWHZqk5FsgLy9ersx1eidc91xVumqaoyQ1luWnrrSXcgK74whmqJo0Nx5KkGuSrFfcAs+LA7hpPyJMaj7tQGu6rtahg/Y73PaL1jTz7Ex5CcGZP9L1AW+ZtjQcH1ubbKfc5uRo21Unzc72f/t4B7rpX+qSY3ad+tHRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676353; c=relaxed/simple; bh=8zxbYHTC/vFoDDVlLNN1L+clSwYxFA+WMrxYCr2Ewcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tvtcqY9YT9xI92loidXeAt3UzLvvS9HIjHhYzZADgLfc/jgxD+6a6MY9y8az2eKtiS8+k/p/yJuMLu+Bk13ORhddyGNw9CUmM5tFXRu8sUr9+DCUbmUim+GwChU9wJXxo55WXJoMJcD6WXMQ359/qbHU0VRvsTdUPvkYlz9h3Hs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=pIIpWUBX; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="pIIpWUBX" Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 272F7403EA for ; Tue, 2 Dec 2025 11:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1764676347; bh=cwVszfkAi2lPLgwK1Qc8I2xQFtjDa28JTJArXKCEz6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pIIpWUBX3AyMft7l6C6TfYUO7s/fPDUopET4OXunzYqx5lUxMm8K+c9+izGjUg+JW aEKjPKITSZpOUvZnNLE0BG0Ldbq82v+ElIfw8escs+xkmHPDj3XjnhVsVcRYQEh7eL Eqal78EsLfMzBW5wXl+JXlGwgW+lVRZsTXnoQxcBfLZt3rsPy9tW4F8bgwknwKlzrl wc5YChieqYbIXzQUj6FeBvTxeUCLFrCetQWjjuBZQTPab+oMM0a5uGVmRvH5sP+3Ho RnTvrQXFjljdmaTzTLTQQJlVmMGfDYF3J876V7SV1gP8BjadiHMFnFEXV5jTGdxQPP IZh7MRKDthAxSoWk3+0Efzc47VT9fREYFe0jSVzkroFpJxT/2RWErB2EMO6L8yIupw yBqWL1Rdos/z4yFBkzb/rYlWejO4turcmqGcnCyD/RCMqPl2AqQcz77sejLJ7uI8TT BwPD+C1QzJuXs55BSjy5uAn3EtlfaeRwmdxxQiYjLGgfDTywLzLCXxQAF5ouqqEWMh bkCQeeYR1wwbK5traHjH92uP12PkQrY46r/e3YQg+0e/MKRdpqSr0c0avTZ4WQFqOb GCAV3nN6JgpqrMfwJ4FWP9mvkEnYN4AYDydGjKU9JiD5zhPaSNpu2m2eWsJes/TDvR 0vS2c8OLBWm8cEEG2mlTaw7g= Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-64095d94c2cso7346809a12.1 for ; Tue, 02 Dec 2025 03:52:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764676341; x=1765281141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cwVszfkAi2lPLgwK1Qc8I2xQFtjDa28JTJArXKCEz6A=; b=xQxL+23EDxxXINP/fiLaTMdXC6Rj5ES2hJLGpSSYk1CDLz8vPsPtZf4XwjvZm2PzPU lk9vDIno4Wo6ikKLVKHAOzmaVJ4j1XRAXaOj33YRqZNqmI55GwpftyqU3MkfhNMHIeBg TWsH4JAt5inAhCN6WIN+tLI+1f2hd/ZuHseV6VLGyB23QKR/WugCbosa02zTJRheHvBe V34mQLd/gRMjKIfUmNxqo86MSESw/uj8LGayM5CUC599V9Jv5nbc8uCghB8S0LlpOV1X ShS4dwCI4Vv79zSlWso7nZep3vvEtYLe0ygNJOh6snZAlToZDJ+bGN5yyJJEVmBiI9An xhCg== X-Gm-Message-State: AOJu0YwCB3qyVzCtdAsgXoXjL4CcmgplyUVijijzG9C/Cu+ErH45KVh8 P5C1ch46ymp0R229Lvf0aJSubDpQsALy9H+/9GuSGV8ECxnytdcq3uGgitTdVMCAUSnUd7heLyp LD4v3VRfvJ43gUS/i2ZRg0/t/TCVHQwHjhSvIA2qx7TMcOKD4lk4HD4/C4hUWDJ002Cnf6/BLkm qckV5lxA== X-Gm-Gg: ASbGncuwPwh2iyA9nPAcWjC6E1XobvwLu30a3Y7GoJk0IB8QwSOk/iBgyprW75d1Xh5 9dG9PuuMeoUFg6tl1LcRQvgHAz0J6xKxeSAr/Ba9hfHDJMKE3SZ7gzuzDB0GTT6NIdbVxMThy7A /9gB262OclRb+8AIbulZlMHwwltCO0zr2ZIYIKNyLhe3EZoHLIPjD3JTPlpMyg9FiUzF6T/MxCN qK5ZtPx/7K1iwldUGvaOZm08RH9oZF/Am3xwwVieH99Dx6nzyCeppSCDrSjd+5Oz4UpmjoWXFcI +WMTqvqnoXvS0SnXeQHLweCQCgAjRYcuM/cE3o1KDS+JBUxHaJPkd8H61yFyq685CFGqgnRcz01 t/+W+ENnXeZAbIqR4uDSrmy7FXqo+eXS3PmAS9I5t/1wGtoR6ojuZuWlaocnvZFo41bqzYWmVzT K1EiENCSQ93JhlCdHQ+s90vm0= X-Received: by 2002:a05:6402:358b:b0:643:ab7:2e7b with SMTP id 4fb4d7f45d1cf-645559f9dd0mr38694721a12.0.1764676341134; Tue, 02 Dec 2025 03:52:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNMdUcbKmi/gMtf98cLSdMWXvArBVuk0t5kodbo3nTcLBM5sFT8yTGpmgTFvPpZdtsAj5W6Q== X-Received: by 2002:a05:6402:358b:b0:643:ab7:2e7b with SMTP id 4fb4d7f45d1cf-645559f9dd0mr38694702a12.0.1764676340740; Tue, 02 Dec 2025 03:52:20 -0800 (PST) Received: from amikhalitsyn.lan (p200300cf5702200011ee99ed0f378a51.dip0.t-ipconnect.de. [2003:cf:5702:2000:11ee:99ed:f37:8a51]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-647510519efsm15206765a12.29.2025.12.02.03.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 03:52:20 -0800 (PST) From: Alexander Mikhalitsyn To: kees@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, Andy Lutomirski , Will Drewry , Jonathan Corbet , Shuah Khan , Aleksa Sarai , Tycho Andersen , Andrei Vagin , Christian Brauner , =?UTF-8?q?St=C3=A9phane=20Graber?= , Alexander Mikhalitsyn Subject: [PATCH v2 6/6] tools/testing/selftests/seccomp: test nested listeners Date: Tue, 2 Dec 2025 12:51:58 +0100 Message-ID: <20251202115200.110646-7-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251202115200.110646-1-aleksandr.mikhalitsyn@canonical.com> References: <20251202115200.110646-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add some basic tests for nested listeners. Cc: linux-kernel@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: bpf@vger.kernel.org Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Jonathan Corbet Cc: Shuah Khan Cc: Aleksa Sarai Cc: Tycho Andersen Cc: Andrei Vagin Cc: Christian Brauner Cc: St=C3=A9phane Graber Signed-off-by: Alexander Mikhalitsyn --- tools/testing/selftests/seccomp/seccomp_bpf.c | 162 ++++++++++++++++++ 1 file changed, 162 insertions(+) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/= selftests/seccomp/seccomp_bpf.c index fc4910d35342..0bf02d04fe15 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -293,6 +293,10 @@ struct seccomp_notif_addfd_big { #define SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV (1UL << 5) #endif =20 +#ifndef SECCOMP_FILTER_FLAG_ALLOW_NESTED_LISTENERS +#define SECCOMP_FILTER_FLAG_ALLOW_NESTED_LISTENERS (1UL << 6) +#endif + #ifndef seccomp int seccomp(unsigned int op, unsigned int flags, void *args) { @@ -4408,6 +4412,164 @@ TEST(user_notification_sync) ASSERT_EQ(status, 0); } =20 +/* from kernel/seccomp.c */ +#define MAX_LISTENERS_PER_PATH 8 + +TEST(user_notification_nested_limits) +{ + pid_t pid; + long ret; + int i, status, listeners[MAX_LISTENERS_PER_PATH]; + + struct sock_filter filter[] =3D { + BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW), + }; + struct sock_fprog prog =3D { + .len =3D (unsigned short)ARRAY_SIZE(filter), + .filter =3D filter, + }; + + ret =3D prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); + ASSERT_EQ(0, ret) { + TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!"); + } + + /* Install 6 levels of listeners and allow nesting. */ + for (i =3D 0; i < 6; i++) { + listeners[i] =3D user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER | + SECCOMP_FILTER_FLAG_ALLOW_NESTED_LISTENERS); + ASSERT_GE(listeners[i], 0); + + /* Add some no-op filters for grins. */ + EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0); + } + + /* Check behavior when nesting is not allowed. */ + pid =3D fork(); + ASSERT_GE(pid, 0); + if (pid =3D=3D 0) { + /* Install a next listener in the chain without nesting allowed. */ + listeners[6] =3D user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER); + if (listeners[6] < 0) + exit(1); + + /* Add some no-op filters for grins. */ + ret =3D seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog); + if (ret !=3D 0) + exit(2); + + ret =3D user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER); + /* Installing a next listener in the chain should result in EBUSY. */ + exit((ret >=3D 0 || errno !=3D EBUSY) ? 3 : 0); + } + + EXPECT_EQ(waitpid(pid, &status, 0), pid); + EXPECT_EQ(true, WIFEXITED(status)); + EXPECT_EQ(0, WEXITSTATUS(status)); + + /* Install more filters with listeners to reach nesting levels limit. */ + for (; i < MAX_LISTENERS_PER_PATH; i++) { + listeners[i] =3D user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER | + SECCOMP_FILTER_FLAG_ALLOW_NESTED_LISTENERS); + ASSERT_GE(listeners[i], 0); + + /* Add some no-op filters for grins. */ + EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0); + } + + /* Installing a next listener in the chain should result in ELOOP. */ + EXPECT_EQ(user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER), + -1); + EXPECT_EQ(errno, ELOOP); +} + +TEST(user_notification_nested) +{ + pid_t pid; + long ret; + int i, status, listeners[6]; + struct seccomp_notif req =3D {}; + struct seccomp_notif_resp resp =3D {}; + + struct sock_filter filter[] =3D { + BPF_STMT(BPF_RET|BPF_K, SECCOMP_RET_ALLOW), + }; + struct sock_fprog prog =3D { + .len =3D (unsigned short)ARRAY_SIZE(filter), + .filter =3D filter, + }; + + ret =3D prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0); + ASSERT_EQ(0, ret) { + TH_LOG("Kernel does not support PR_SET_NO_NEW_PRIVS!"); + } + + /* Install 6 levels of listeners and allow nesting. */ + for (i =3D 0; i < 6; i++) { + listeners[i] =3D user_notif_syscall(__NR_getppid, + SECCOMP_FILTER_FLAG_NEW_LISTENER | + SECCOMP_FILTER_FLAG_ALLOW_NESTED_LISTENERS); + ASSERT_GE(listeners[i], 0); + + /* Add some no-op filters for grins. */ + EXPECT_EQ(seccomp(SECCOMP_SET_MODE_FILTER, 0, &prog), 0); + } + + pid =3D fork(); + ASSERT_GE(pid, 0); + + if (pid =3D=3D 0) { + ret =3D syscall(__NR_getppid); + exit(ret !=3D (USER_NOTIF_MAGIC-3)); + } + + /* + * We want to have the following picture: + * + * | Listener level (i) | Listener decision | + * |--------------------|-------------------| + * | 0 | WHATEVER | + * | 1 | WHATEVER | + * | 2 | WHATEVER | + * | 3 | RETURN | <-- stop here + * | 4 | CONTINUE SYSCALL | + * | 5 | CONTINUE SYSCALL | <- start here (current->seccomp.filter) + * + * First listener who receives a notification is level 5, then 4, + * then we expect to stop on level 3 and return from syscall with + * (USER_NOTIF_MAGIC - 3) return value. + */ + for (i =3D 6 - 1; i >=3D 3; i--) { + memset(&req, 0, sizeof(req)); + EXPECT_EQ(ioctl(listeners[i], SECCOMP_IOCTL_NOTIF_RECV, &req), 0); + EXPECT_EQ(req.pid, pid); + EXPECT_EQ(req.data.nr, __NR_getppid); + + memset(&resp, 0, sizeof(resp)); + resp.id =3D req.id; + + if (i =3D=3D 5 || i =3D=3D 4) { + resp.flags =3D SECCOMP_USER_NOTIF_FLAG_CONTINUE; + } else { + resp.error =3D 0; + resp.val =3D USER_NOTIF_MAGIC - i; + } + + EXPECT_EQ(ioctl(listeners[i], SECCOMP_IOCTL_NOTIF_SEND, &resp), 0); + } + + EXPECT_EQ(waitpid(pid, &status, 0), pid); + EXPECT_EQ(true, WIFEXITED(status)); + EXPECT_EQ(0, WEXITSTATUS(status)); + + for (i =3D 0; i < 6; i++) + close(listeners[i]); +} =20 /* Make sure PTRACE_O_SUSPEND_SECCOMP requires CAP_SYS_ADMIN. */ FIXTURE(O_SUSPEND_SECCOMP) { --=20 2.43.0