From nobody Tue Feb 10 07:39:03 2026 Received: from mail.0la.ch (mail.0la.ch [78.47.82.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5593430F953 for ; Tue, 2 Dec 2025 11:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.47.82.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764673394; cv=none; b=VmM+0Vifen+06hJAeWoMHpCLoPSvvilPM5waZHCS5J7LXK71fRamqHi2/qKqluFIVdUDNt8feIwHRKXVnRTiX1kBBQL1DnMUOZVFqiL7L55S3MY3KnQP2QLqv0/20igCLR24LhzhRT1ulj95VLCKNwCRcaDLNGZbLVsOMmuINUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764673394; c=relaxed/simple; bh=6dNebbPQsS+ptOM49W47ktOIjscJjcad2fll2TN2/uU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EqYQr2i+g41686DitN4ciKOUCQDVBOGU3lBvv3N8mPhIAwlFuCVoARsh2udGErAGYmi1YezR3uIKFq5J6StdroKYDBWRTbsr4oom9Mdk8kUVNaMKE35J0PcoOErUb83ZQlKdoEfUwjI+jNgl/ukBW93pUl3SF9kUBz3e33yw6rA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lach.pw; spf=pass smtp.mailfrom=lach.pw; dkim=pass (2048-bit key) header.d=lach.pw header.i=@lach.pw header.b=ixD9QGK4; dkim=permerror (0-bit key) header.d=lach.pw header.i=@lach.pw header.b=cDSad/Ni; arc=none smtp.client-ip=78.47.82.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=lach.pw Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lach.pw Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lach.pw header.i=@lach.pw header.b="ixD9QGK4"; dkim=permerror (0-bit key) header.d=lach.pw header.i=@lach.pw header.b="cDSad/Ni" DKIM-Signature: v=1; a=rsa-sha256; s=202502r; d=lach.pw; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1764673365; bh=BDAZeHaErjU5AdhnxRJ7MR2 NfN5vlAY+R8Q/T1fQ7s0=; b=ixD9QGK4IfioGOWZ4R9mNz/e81k/Mvxdk7kwymaEz4ULSzzq8F ZKZ6SSTV1xam1ctuVfPQyMvcqLYosB588tl9KHtovDeZZdQTFYgFnDnAYfG+30QQRsL0kniB/dU VpeCs3Oh1Wz7WXNcN9WqKfP1ld+VwnQMVwTQ+R03HK7WumwSKlBWVNjJUuxTVx20rmzhrrRijc6 A/8wZNzsGonJTXgWHbKZQTKXg0xJtyoYkto9Af4lon15lOIwLNqtAuiw+CryH3UsL/F1/ZEzJAR ew+8xmrs88PDgUTnSakjZEtT2oGRpjH8yHa0fM02ap6CLzgebpu+WuOspaY5TiPRGcg==; DKIM-Signature: v=1; a=ed25519-sha256; s=202502e; d=lach.pw; c=relaxed/relaxed; h=Message-ID:Date:Subject:To:From; t=1764673365; bh=BDAZeHaErjU5AdhnxRJ7MR2 NfN5vlAY+R8Q/T1fQ7s0=; b=cDSad/NiKfl4z9jXct6+VGQOZ/JFbAHC9M59i+FjYNbJJlBhNr gTbLaW6CqJZyN5Mam3UcoKsISonYecV+SOAg==; From: Yaroslav Bolyukin To: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Wayne Lin , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Yaroslav Bolyukin Subject: [PATCH v7 5/7] drm/edid: for consistency, use mask everywhere for block rev parsing Date: Tue, 2 Dec 2025 12:02:16 +0100 Message-ID: <20251202110218.9212-6-iam@lach.pw> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251202110218.9212-1-iam@lach.pw> References: <20251202110218.9212-1-iam@lach.pw> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Other usages of block.rev bitfields were refactored to use FIELD_GET instead of bitwise ops. Signed-off-by: Yaroslav Bolyukin Reviewed-by: Jani Nikula --- drivers/gpu/drm/drm_displayid_internal.h | 1 + drivers/gpu/drm/drm_edid.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_displayid_internal.h b/drivers/gpu/drm/drm= _displayid_internal.h index 724174b429f2..55f972d32847 100644 --- a/drivers/gpu/drm/drm_displayid_internal.h +++ b/drivers/gpu/drm/drm_displayid_internal.h @@ -139,6 +139,7 @@ struct displayid_formula_timings_9 { u8 vrefresh; } __packed; =20 +#define DISPLAYID_BLOCK_DESCRIPTOR_PAYLOAD_BYTES GENMASK(6, 4) struct displayid_formula_timing_block { struct displayid_block base; struct displayid_formula_timings_9 timings[]; diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b28ff4bafb1d..be8715632b91 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -6908,7 +6908,8 @@ static int add_displayid_formula_modes(struct drm_con= nector *connector, struct drm_display_mode *newmode; int num_modes =3D 0; bool type_10 =3D block->tag =3D=3D DATA_BLOCK_2_TYPE_10_FORMULA_TIMING; - int timing_size =3D 6 + ((formula_block->base.rev & 0x70) >> 4); + int timing_size =3D 6 + + FIELD_GET(DISPLAYID_BLOCK_DESCRIPTOR_PAYLOAD_BYTES, formula_block->base.= rev); =20 /* extended blocks are not supported yet */ if (timing_size !=3D 6) --=20 2.51.2