From nobody Wed Dec 17 08:05:16 2025 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1A9F31195D for ; Tue, 2 Dec 2025 09:36:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764668207; cv=none; b=gVqJBDm+GRMHfxqbGeBXsBkJmkjdcTJ28RRss3pc4tnQdyoqKqLxSRLEnyErrFD/IpxQ2HxBw1kC8Me5EoRxqqalQkiJZkqJDsyDpot/Z5j2pqgz83xNxLLl1hUXV6EuH3NvGFU3cZ8QKGYp7pzgvbnbrNViHcp2spD+hDy+3+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764668207; c=relaxed/simple; bh=oaRdTc+CudMCRIjCToZjk2dqfieeoQukCK4lffombqU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fqKdyor3ur1DSqGm/8Q3kTtKjQcurIeG08g4y6+OD5USZ9s8IN7Xqt205DE3MAUVQwWuSvmkd9jQWm0Xzvw78DU/gjYst6bgaETGaCJcfK3ce5hsmDb3Cg8nvu+qcyZXxS7zMvhz0yVLn+PSatxqUVk39OfmIXlwF9jAdila39U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AiR6ong8; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AiR6ong8" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4779393221aso28967165e9.2 for ; Tue, 02 Dec 2025 01:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764668203; x=1765273003; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/RtoQQKvZqv4xwY++1uskqrXtrGNBBDBwX6nETm2Mts=; b=AiR6ong8wJ4qEvs8sZgIaetFI6Ow03rXVpPXTbJ/ybkzxcXY7zoTbYCaL9Y+mPsPq8 23vxHl5FU8j/ixvEIW2MHzFKTn+hxjqNinwnyDrUdqy6uX8xmZJFVixpn/GB9z1At6NX bSsS0eymtMfUbnmAkHUQ7VCo09KzfNWGS2IfQCQO9iTUSl2emqAsfqx0nY+EeAuprtZN wfSq4Qp9U+XBCxH04QOVCB4FGAJ98rQXBmc/GZWqh4LWiEWz6ITPDsEhJwv8VfxqM6DP I77ny6UT48ibCbPnsE7N5B8fY1Mmh5XSnzx9+oqO1F4MZRqIg4Jsu6oNG7QRILWS43SH +Wmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764668203; x=1765273003; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/RtoQQKvZqv4xwY++1uskqrXtrGNBBDBwX6nETm2Mts=; b=M2hUJ4c9ZKnPiMtItoywhof38yvjGDlIQHwxyyjZtNSX3ofiX2lIq5FVZYknfqSYW5 R1G8tZ9dhUw6DQzCpQZEyPs9eocAe4PbUEIkMtxtsBYL9vOuZ7A7Tpu4z8m8MhF0gBDt SH0+D34oGT9zwJs326UB6xXnHX5uGnOXZGtEAZEE1wD4/DovIt+lEIj24/rAT1KDtqAo N67yDv8GHxjOtN2xnXpsEYG0SxrqXQA7l2FW1efqc4gP2t779Sv2aAGMpbcue83a99lk TNVe0TCX6b7Y7VmjnEGAndPOiFPdvK9T7bjwnyY/7bRPQpxyQJhhGgELdS0Ak75P8SBS JRvQ== X-Forwarded-Encrypted: i=1; AJvYcCUwBo81QdLdoAwr2ZrDf5cS2vuNE+J45f+DDkJZgI6oM9h86UZdgvtfeXG58VVONNHQUtn6Vo+883+LH0Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxMOZdlbXdcvlG3Q9UiD0G0yAzMN6L0+Axd6pzIM8J/KvsSawRn OCh9TP6GhobcahjnBCfKLZiFnI6w6WeDYUtv7LYzZDQQUfR7JtpyefBJOAE+VWSRrx5pJu3anLp bVbeDz7ID03uibjfyYzH6/A== X-Google-Smtp-Source: AGHT+IGUcFqotkZnIoQBBM1OMHuVXqQ+7PlebBHwvLOhTIEZw+4qCWorheTb8bRwyZqPz9VQr+j6/1h9iGZ0AV13 X-Received: from wrmr16.prod.google.com ([2002:adf:e690:0:b0:427:8af:f179]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a08:b0:477:7b16:5fa6 with SMTP id 5b1f17b1804b1-477c0162e8emr419428785e9.3.1764668203047; Tue, 02 Dec 2025 01:36:43 -0800 (PST) Date: Tue, 2 Dec 2025 09:36:05 +0000 In-Reply-To: <20251202093623.2337860-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251202093623.2337860-1-vdonnefort@google.com> X-Mailer: git-send-email 2.52.0.107.ga0afd4fd5b-goog Message-ID: <20251202093623.2337860-13-vdonnefort@google.com> Subject: [PATCH v9 12/30] ring-buffer: Export buffer_data_page and macros From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org, Vincent Donnefort Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for allowing the writing of ring-buffer compliant pages outside of ring_buffer.c, move buffer_data_page and timestamps encoding macros into the publicly available ring_buffer_types.h. Signed-off-by: Vincent Donnefort diff --git a/include/linux/ring_buffer_types.h b/include/linux/ring_buffer_= types.h new file mode 100644 index 000000000000..54577021a49d --- /dev/null +++ b/include/linux/ring_buffer_types.h @@ -0,0 +1,41 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_RING_BUFFER_TYPES_H +#define _LINUX_RING_BUFFER_TYPES_H + +#include + +#define TS_SHIFT 27 +#define TS_MASK ((1ULL << TS_SHIFT) - 1) +#define TS_DELTA_TEST (~TS_MASK) + +/* + * We need to fit the time_stamp delta into 27 bits. + */ +static inline bool test_time_stamp(u64 delta) +{ + return !!(delta & TS_DELTA_TEST); +} + +#define BUF_PAGE_HDR_SIZE offsetof(struct buffer_data_page, data) + +#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array)) +#define RB_ALIGNMENT 4U +#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX) +#define RB_EVNT_MIN_SIZE 8U /* two 32bit words */ + +#ifndef CONFIG_HAVE_64BIT_ALIGNED_ACCESS +# define RB_FORCE_8BYTE_ALIGNMENT 0 +# define RB_ARCH_ALIGNMENT RB_ALIGNMENT +#else +# define RB_FORCE_8BYTE_ALIGNMENT 1 +# define RB_ARCH_ALIGNMENT 8U +#endif + +#define RB_ALIGN_DATA __aligned(RB_ARCH_ALIGNMENT) + +struct buffer_data_page { + u64 time_stamp; /* page time stamp */ + local_t commit; /* write committed index */ + unsigned char data[] RB_ALIGN_DATA; /* data of buffer page */ +}; +#endif diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 9f28e7b3058c..7a1a8d5f3a25 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -4,6 +4,7 @@ * * Copyright (C) 2008 Steven Rostedt */ +#include #include #include #include @@ -156,23 +157,6 @@ int ring_buffer_print_entry_header(struct trace_seq *s) /* Used for individual buffers (after the counter) */ #define RB_BUFFER_OFF (1 << 20) =20 -#define BUF_PAGE_HDR_SIZE offsetof(struct buffer_data_page, data) - -#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array)) -#define RB_ALIGNMENT 4U -#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX) -#define RB_EVNT_MIN_SIZE 8U /* two 32bit words */ - -#ifndef CONFIG_HAVE_64BIT_ALIGNED_ACCESS -# define RB_FORCE_8BYTE_ALIGNMENT 0 -# define RB_ARCH_ALIGNMENT RB_ALIGNMENT -#else -# define RB_FORCE_8BYTE_ALIGNMENT 1 -# define RB_ARCH_ALIGNMENT 8U -#endif - -#define RB_ALIGN_DATA __aligned(RB_ARCH_ALIGNMENT) - /* define RINGBUF_TYPE_DATA for 'case RINGBUF_TYPE_DATA:' */ #define RINGBUF_TYPE_DATA 0 ... RINGBUF_TYPE_DATA_TYPE_LEN_MAX =20 @@ -315,10 +299,6 @@ EXPORT_SYMBOL_GPL(ring_buffer_event_data); #define for_each_online_buffer_cpu(buffer, cpu) \ for_each_cpu_and(cpu, buffer->cpumask, cpu_online_mask) =20 -#define TS_SHIFT 27 -#define TS_MASK ((1ULL << TS_SHIFT) - 1) -#define TS_DELTA_TEST (~TS_MASK) - static u64 rb_event_time_stamp(struct ring_buffer_event *event) { u64 ts; @@ -337,12 +317,6 @@ static u64 rb_event_time_stamp(struct ring_buffer_even= t *event) =20 #define RB_MISSED_MASK (3 << 30) =20 -struct buffer_data_page { - u64 time_stamp; /* page time stamp */ - local_t commit; /* write committed index */ - unsigned char data[] RB_ALIGN_DATA; /* data of buffer page */ -}; - struct buffer_data_read_page { unsigned order; /* order of the page */ struct buffer_data_page *data; /* actual data, stored in this page */ @@ -401,14 +375,6 @@ static void free_buffer_page(struct buffer_page *bpage) kfree(bpage); } =20 -/* - * We need to fit the time_stamp delta into 27 bits. - */ -static inline bool test_time_stamp(u64 delta) -{ - return !!(delta & TS_DELTA_TEST); -} - struct rb_irq_work { struct irq_work work; wait_queue_head_t waiters; --=20 2.52.0.107.ga0afd4fd5b-goog