From nobody Wed Dec 17 08:05:16 2025 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36C33101B8 for ; Tue, 2 Dec 2025 09:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764668205; cv=none; b=eSh/H/6oNu0WlvGzDsmh6YRvAMP0vXtfQlpBj1p4osoePWkbRIjcY8TLcNaWvAUalF50YUsjctqka1mmpofLv4baU9F8Y+cjEwhgb4YW5+8cGPRn5UqAiB1jUwn7cR/2/PBkhsFmESlOUSBI7KFZ9XAK3Sp4NjadWepfOk8d4r4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764668205; c=relaxed/simple; bh=qxvxJ2jhWhit59amBLOQDsgN4DCLBr6daXNmJfWK41w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FmMDoVazMhdwk1+tqe0i+Og0Em1OzcJIlWljNHu92meKV2axd2zWXgCZbNCstIw77NXUOC47CCCbYWXWhP1qToq3d4mXEeL/GWjWOeZfc82WSLr6x49cfhDGguVqQLux9JoyETpbeUNd1XJFqRTuxWCZfapwcDQ+eCeFQz/sOdw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Gi5gsMvW; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Gi5gsMvW" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-477771366cbso31850865e9.0 for ; Tue, 02 Dec 2025 01:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764668201; x=1765273001; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Qu7GyFLfNLwQVA6ni9FoSx3ZpEkIIUn3sjQhqzYAiz8=; b=Gi5gsMvWkckGLYUKpegUsANkhSiPdkCEWSWEYySFqQXNZ4eZuRmty4r+pPFSe350bK wgmB3Hp5WWo5dxJZYUmeFxA8iE65Cf/HjDJNnX1Kb40IVBDaCsYEJf2IT6YTO28CUBZK cgPeSU58Ion1S9VVyHQAV53zXVydmCvCAR0yHJip4vvZXuEf5hrqdqF0KfoFSRS+u5tZ WXN6x0Uj9PJxCQ51GF5UufEC0Mu+aFXvW2zeVViOhIOcjyl+WmQzPyu0gJh32XuGkX3H G4fBhQ626nCS03G4PK0k+PNJtydw3FthBtnk9O2gGIn90N6O0+czqquQJ0Xv3gGDPut7 2eeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764668201; x=1765273001; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qu7GyFLfNLwQVA6ni9FoSx3ZpEkIIUn3sjQhqzYAiz8=; b=YPqnydbads0U9N3Hu0Zpz1g0jHI6knSUAfZPjYntuAYSaErF4x+OJFGL0vnQ7NT9ct W512tocbsQYR5pJCVZmIh+Dxu+Wynnd8Am/yUVOmqoyrFeDofLxiURrQnU6hy/nwncJg FFyWm/ff9x41ffHRqhB78aZLEMnHd9KKppaAC38SZB62/EnGGtqRLjeT9hH411prFVTW mo0QXOLpIfxhInR/7DWjiGJ8A5xh70lvP75x5t8/wSqRZ20CxyR49szTrluaYiL0XPj6 bnAfdZjsxCS6wzPjzvOGd7bQWfaQgsUkNjszRloFUW4nBrgc457MD+kzPzemGnDsZIB5 jBgA== X-Forwarded-Encrypted: i=1; AJvYcCW0iN3ED0cwL6iQT1c9ZH+uHqIxWv+1BeGhnIuRvj0WMpgBW4+X5Qz0+8NVFyAIb7Tt96cqtlSfjj3MPvg=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ+CRu6TiidEZe3drcp7U7GrSPcrygOqVImvICeTA0cAG5TSWo O4QPkOBYsxO7QDArlMbnm6Dusuevv9zcf82UwGia4N8dTRidZLGY4BsiEMnnFmGXMW9xf6Tv4qj rvUnzBio3qtBXGoARIWSTXA== X-Google-Smtp-Source: AGHT+IGBhA+hYCk05ot5XcSydU2F4dh3hUYcdu6uEl1EyzVytZWMoWSTTtHR1nwrUQLSQ9KOqoRHKY+3DhHSVcCR X-Received: from wmaj12.prod.google.com ([2002:a05:600c:6c0c:b0:477:7893:c737]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:474b:b0:477:9dc1:b706 with SMTP id 5b1f17b1804b1-477c01b494fmr433009495e9.19.1764668200914; Tue, 02 Dec 2025 01:36:40 -0800 (PST) Date: Tue, 2 Dec 2025 09:36:03 +0000 In-Reply-To: <20251202093623.2337860-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251202093623.2337860-1-vdonnefort@google.com> X-Mailer: git-send-email 2.52.0.107.ga0afd4fd5b-goog Message-ID: <20251202093623.2337860-11-vdonnefort@google.com> Subject: [PATCH v9 10/30] tracing: Add events/ root files to trace remotes From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org, Vincent Donnefort Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Just like for the kernel events directory, add 'enable', 'header_page' and 'header_event' at the root of the trace remote events/ directory. Signed-off-by: Vincent Donnefort diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index cb674a9fc359..9f28e7b3058c 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -604,7 +604,8 @@ int ring_buffer_print_page_header(struct trace_buffer *= buffer, struct trace_seq trace_seq_printf(s, "\tfield: char data;\t" "offset:%u;\tsize:%u;\tsigned:%u;\n", (unsigned int)offsetof(typeof(field), data), - (unsigned int)buffer->subbuf_size, + (unsigned int)(buffer ? buffer->subbuf_size : + PAGE_SIZE - BUF_PAGE_HDR_SIZE), (unsigned int)is_signed_type(char)); =20 return !trace_seq_has_overflowed(s); diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c index 8527804f2d22..e54cc3e75dc5 100644 --- a/kernel/trace/trace_remote.c +++ b/kernel/trace/trace_remote.c @@ -1078,10 +1078,145 @@ static int remote_event_callback(const char *name,= umode_t *mode, void **data, return 0; } =20 +static ssize_t remote_events_dir_enable_write(struct file *filp, const cha= r __user *ubuf, + size_t count, loff_t *ppos) +{ + struct trace_remote *remote =3D file_inode(filp)->i_private; + int i, ret; + u8 enable; + + ret =3D kstrtou8_from_user(ubuf, count, 10, &enable); + if (ret) + return ret; + + guard(mutex)(&remote->lock); + + for (i =3D 0; i < remote->nr_events; i++) { + struct remote_event *evt =3D &remote->events[i]; + + trace_remote_enable_event(remote, evt, enable); + } + + return count; +} + +static ssize_t remote_events_dir_enable_read(struct file *filp, char __use= r *ubuf, size_t cnt, + loff_t *ppos) +{ + struct trace_remote *remote =3D file_inode(filp)->i_private; + const char enabled_char[] =3D {'0', '1', 'X'}; + char enabled_str[] =3D " \n"; + int i, enabled =3D -1; + + guard(mutex)(&remote->lock); + + for (i =3D 0; i < remote->nr_events; i++) { + struct remote_event *evt =3D &remote->events[i]; + + if (enabled =3D=3D -1) { + enabled =3D evt->enabled; + } else if (enabled !=3D evt->enabled) { + enabled =3D 2; + break; + } + } + + enabled_str[0] =3D enabled_char[enabled =3D=3D -1 ? 0 : enabled]; + + return simple_read_from_buffer(ubuf, cnt, ppos, enabled_str, 2); +} + +static const struct file_operations remote_events_dir_enable_fops =3D { + .write =3D remote_events_dir_enable_write, + .read =3D remote_events_dir_enable_read, +}; + +static ssize_t +remote_events_dir_header_page_read(struct file *filp, char __user *ubuf, s= ize_t cnt, loff_t *ppos) +{ + struct trace_seq *s; + int ret; + + s =3D kmalloc(sizeof(*s), GFP_KERNEL); + if (!s) + return -ENOMEM; + + trace_seq_init(s); + + ring_buffer_print_page_header(NULL, s); + ret =3D simple_read_from_buffer(ubuf, cnt, ppos, s->buffer, trace_seq_use= d(s)); + kfree(s); + + return ret; +} + +static const struct file_operations remote_events_dir_header_page_fops =3D= { + .read =3D remote_events_dir_header_page_read, +}; + +static ssize_t +remote_events_dir_header_event_read(struct file *filp, char __user *ubuf, = size_t cnt, loff_t *ppos) +{ + struct trace_seq *s; + int ret; + + s =3D kmalloc(sizeof(*s), GFP_KERNEL); + if (!s) + return -ENOMEM; + + trace_seq_init(s); + + ring_buffer_print_entry_header(s); + ret =3D simple_read_from_buffer(ubuf, cnt, ppos, s->buffer, trace_seq_use= d(s)); + kfree(s); + + return ret; +} + +static const struct file_operations remote_events_dir_header_event_fops = =3D { + .read =3D remote_events_dir_header_event_read, +}; + +static int remote_events_dir_callback(const char *name, umode_t *mode, voi= d **data, + const struct file_operations **fops) +{ + if (!strcmp(name, "enable")) { + *mode =3D TRACEFS_MODE_WRITE; + *fops =3D &remote_events_dir_enable_fops; + return 1; + } + + if (!strcmp(name, "header_page")) { + *mode =3D TRACEFS_MODE_READ; + *fops =3D &remote_events_dir_header_page_fops; + return 1; + } + + if (!strcmp(name, "header_event")) { + *mode =3D TRACEFS_MODE_READ; + *fops =3D &remote_events_dir_header_event_fops; + return 1; + } + + return 0; +} + static int trace_remote_init_eventfs(const char *remote_name, struct trace= _remote *remote, struct remote_event *evt) { struct eventfs_inode *eventfs =3D remote->eventfs; + static struct eventfs_entry dir_entries[] =3D { + { + .name =3D "enable", + .callback =3D remote_events_dir_callback, + }, { + .name =3D "header_page", + .callback =3D remote_events_dir_callback, + }, { + .name =3D "header_event", + .callback =3D remote_events_dir_callback, + } + }; static struct eventfs_entry entries[] =3D { { .name =3D "enable", @@ -1097,7 +1232,8 @@ static int trace_remote_init_eventfs(const char *remo= te_name, struct trace_remot bool eventfs_create =3D false; =20 if (!eventfs) { - eventfs =3D eventfs_create_events_dir("events", remote->dentry, NULL, 0,= NULL); + eventfs =3D eventfs_create_events_dir("events", remote->dentry, dir_entr= ies, + ARRAY_SIZE(dir_entries), remote); if (IS_ERR(eventfs)) return PTR_ERR(eventfs); =20 --=20 2.52.0.107.ga0afd4fd5b-goog