From nobody Mon Feb 9 09:40:09 2026 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E7D301485; Tue, 2 Dec 2025 07:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764661258; cv=none; b=LvVOaaA7UdbIxbeTKfJ71RGN891RjcIBMxHfzd1HsKeiUS59YfbeKTC4JjQCN2SwHgJJkVVxaTUnRO9Snr+RiexZu8y015M91V2/T02ySY6NS8jtLSfIx0cmidVTgVMGOo1qEiA5LARF4j7ij/qvLb6HTUkhdaWJ3BdQDKbQh1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764661258; c=relaxed/simple; bh=XHkzfdSUKh+xteezPUW2LDkRP0AOjWqQOgHgXx//qyo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hsDuCMPFC//ytnvVfFUqwoRt8CFqVISLrlzuwPImdgEbP10VQXxgo40TALtH8NgaLZLfE32spHtldJb55PDxQoCJIsUoaZQQs0uKZJ1b86ThqHuRMXUe0FDZAa2nrkFqqgicrCFsVW64XCrR0LEJqK3uXuw2pOQgCZWWdHVaA9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=axDTze66; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="axDTze66" X-UUID: 389c3668cf5211f0b33aeb1e7f16c2b6-20251202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=6rni7uJ0z5ZtWF2fAtSRscntxIpbbXoVq66CSOcHTro=; b=axDTze66VN7+LKHrwMCm7P5Ts2FO9yF0iFSy/b0Tuynb6xMakDl+aS1bn0aUWvzkC60PdT9UcpjhqkOLFpvCouQ9pPC0eAzWG3WrGPSwUvSTbBwlUnJ0g5eBOzEfEqK+jbIfIiYVRRq9m+v1vF744x6gZBU/oeJQoVU3XV9mGdg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:216b2fa9-56dc-40cd-aaba-5a1d8d8b6af0,IP:0,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:-5 X-CID-META: VersionHash:a9d874c,CLOUDID:e5d30e28-e3a2-4f78-a442-8c73c4eb9e9d,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|888|898,TC:-5,Content: 0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:nil,COL:0,OS I:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 389c3668cf5211f0b33aeb1e7f16c2b6-20251202 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1209075466; Tue, 02 Dec 2025 15:40:49 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Tue, 2 Dec 2025 15:40:48 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1748.26 via Frontend Transport; Tue, 2 Dec 2025 15:40:46 +0800 From: Kyrie Wu To: Tiffany Lin , Andrew-CT Chen , Yunfei Dong , "Mauro Carvalho Chehab" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Kyrie Wu , Hans Verkuil , Nicolas Dufresne , Nathan Hebert , "Arnd Bergmann" , Irui Wang , George Sun , , , , , CC: Neil Armstrong , Andrzej Pietrasiewicz , Yilong Zhou Subject: [PATCH v6 05/10] media: mediatek: vcodec: refactor setup dst buffer metadata interface for VP9 decoder Date: Tue, 2 Dec 2025 15:40:32 +0800 Message-ID: <20251202074038.3173-6-kyrie.wu@mediatek.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20251202074038.3173-1-kyrie.wu@mediatek.com> References: <20251202074038.3173-1-kyrie.wu@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" Previously, calling vdec_vp9_slice_setup_single_from_src_to_dst with v4l2_m2m_next_src_buf to obtain both buffers resulted in -EINVAL, interrupting the decoding process. To resolve this, the interface should be updated to set both src and dst buffers for metadata configuration. Signed-off-by: Kyrie Wu --- .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 21 ++++++++++--------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_r= eq_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_= req_lat_if.c index fa0f406f7726..9513ddde7c7c 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c @@ -696,21 +696,22 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi= _num, int tile_log2) return min(offset, mi_num); } =20 -static -int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_slice_inst= ance *instance) +static int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_sli= ce_instance *instance, + struct mtk_vcodec_mem *bs, + struct vdec_fb *fb) { - struct vb2_v4l2_buffer *src; - struct vb2_v4l2_buffer *dst; + struct mtk_video_dec_buf *src_buf_info; + struct mtk_video_dec_buf *dst_buf_info; =20 - src =3D v4l2_m2m_next_src_buf(instance->ctx->m2m_ctx); - if (!src) + src_buf_info =3D container_of(bs, struct mtk_video_dec_buf, bs_buffer); + if (!src_buf_info) return -EINVAL; =20 - dst =3D v4l2_m2m_next_dst_buf(instance->ctx->m2m_ctx); - if (!dst) + dst_buf_info =3D container_of(fb, struct mtk_video_dec_buf, frame_buffer); + if (!dst_buf_info) return -EINVAL; =20 - v4l2_m2m_buf_copy_metadata(src, dst, true); + v4l2_m2m_buf_copy_metadata(&src_buf_info->m2m_buf.vb, &dst_buf_info->m2m_= buf.vb, true); =20 return 0; } @@ -1800,7 +1801,7 @@ static int vdec_vp9_slice_setup_single(struct vdec_vp= 9_slice_instance *instance, struct vdec_vp9_slice_vsi *vsi =3D &pfc->vsi; int ret; =20 - ret =3D vdec_vp9_slice_setup_single_from_src_to_dst(instance); + ret =3D vdec_vp9_slice_setup_single_from_src_to_dst(instance, bs, fb); if (ret) goto err; =20 --=20 2.45.2