From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A6E7280325 for ; Mon, 1 Dec 2025 20:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621451; cv=none; b=KxTHRroSJZA8plHqoPLFjwRFepevL/CmxV+DUyY6+CWeUvJkfdrMP0D1HTW7y1AAx/aQgd+8k2bdJFfjdaouEgHQR34NcVsDbrWb/A+DQFCQz/jq+i/ZtAniCoy45tWmrE3eEU9JoSvn7HdUuZ52F32Y9m0mgCZFM8bX9OWtAuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621451; c=relaxed/simple; bh=t1stNn2JIg8QY9Rz687/0JNAKdfT4fwmYs5nGW+tfxk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T4V/pLv1Ok13j6pjvR2ffpN4mD+Q6nJiasAA3yyhI1i+bNESkSj+RJRQQvC84z+lrsxlIONasptubb+rWIF9xdOwGada9jzHcpID2uJXqijijkXhFOtoPne4vjc1vmGAE7r2xmC3yefLKwlwS/rKbtpN83l71FLQULD7/wZsnC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JpzPzgO3; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JpzPzgO3" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7ba55660769so3946999b3a.1 for ; Mon, 01 Dec 2025 12:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621449; x=1765226249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5EvZHP/L8HTDXW6Wdjo3Us9Wv7cX8ga9zfOaw1spm8=; b=JpzPzgO3CZObe/+R0MKlILckrCZorCZVB5t/nzxFytD5fqZSvb0S61frgTFg71EGWk 7A02xSSnKcY3OSF5oIW79fnOHeWmx2BuDydxYGLLcs94du9TX1TnKypBDmg16kffhzDu Pvyka8/5RqbKQJFV1rh0THcX6nBzfQ1RlUOF9n7CiZg9qg7paLIIGzziHzhvKvjrghPL olWzGEFErrSFP3ewKEYdEOtlT4RGXLf68VnPXDNWh3kqbHGT+oFQnrmkdUPUqaXjxWZO ymvKGXyTKgCGgYueTDGYSSlbg9F0HX9JtO7D0BBdvGHHR38mgpqoRTm62tI6l3JkfOlw FwrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621449; x=1765226249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T5EvZHP/L8HTDXW6Wdjo3Us9Wv7cX8ga9zfOaw1spm8=; b=FuiG5Lf00kM514lu5Srh/9Fv6QJU8tuCCamoiSDAb50qBq8ib0/hXg1iP1exkSXRkJ 3hI1WEe8MUpVd0OvodOpirPQhKKg9E+TxLYSWX/5QTfYD+sO5g8vkttBxK1h2rY6BaSE 3rXSQAEMVGKTgSCkBWAN1EMO7LM6V8/e4i+A/isiCQTf4asT1ZqxpNlPrsZTO1Xphk5q DGRDPpfBs84sq7YX5JO2kElyIOYoxF3AJTcUKXJsMc4J8BsZkBSJVtyRKzV3WbjyzXGG WOO+PewHmZ+UT9Xpj6/6C2VnJ7bSyPl03l+gkTBr3xfju13xI7peKm7VemtFuw1ooYJB pN/w== X-Forwarded-Encrypted: i=1; AJvYcCVyztN5oIam5XpEQYmC0juPCFsyPVkj4tEfie2bGV54nUd5+Bk5V0xXf+D08WWyBtj1lFFeaiDxZw7fkks=@vger.kernel.org X-Gm-Message-State: AOJu0YykQV+1gzhptP1NgsO5HBIqWb26H3rJ9qSTN55i+Ph/O4WSkk/k 63qxadx9qhOXBA+BwgNG4r/WKeCegTaTbkPbMtce+61dGZeRsRPsb+Eh1HuPQQ== X-Gm-Gg: ASbGncuv5KvgkT2Ss5gh7tooHbmkBYKSeX/gUNK8JSiGbT+bNkKZXKyZ838pQSC1Uht BEItB+6RKajJW4LpmnrqyuwuSaNn6+QErEUGkGrkGFqg8DxgWRSS1pWrYr5n2dUCN0mHqC43MHb UYIUp+7VR7syOgdUn8HL4e93l/awD+wGTWkei3gEfrm6y9Zj1zjOR3hO3GEi/UAXhQNVYiAosux oKbqqx3tdatwemHo+QD4xmGHqnbitqUR3v8DHaVX68hulAKG2lmfhqYkASgWm/VGe4Fz1h+IqG2 pgwT/XEma04YnpoyZT6ehRhd1F/czkTyu2y0irNdKug/ngjtvci2ko5DgL8iLkXaB8YnYSRNDmU 8DO9tzmUST/9qQVf7hJJ5JlEPKkOL5j3704YeOuAQzMBM5XE7OQDLHvUiU6YCrPgpztL3kflfsh d/AhtTmJtXSxMFIZJ0iTMZN4MWyuUUMLBbhEo= X-Google-Smtp-Source: AGHT+IGGWkNqfxSsX6EGB7T9IHuppSj4Hv0wTpEGLyZpu3BctLYgLyzqhlB5dEqW3K2Y4RA3M15dJg== X-Received: by 2002:a05:6a20:a126:b0:350:55e0:5522 with SMTP id adf61e73a8af0-36150ef925dmr45927393637.37.1764621449336; Mon, 01 Dec 2025 12:37:29 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:29 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 1/6] usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) Date: Tue, 2 Dec 2025 02:07:10 +0530 Message-ID: <20251201203715.17768-2-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace existing symbolic permissions S_IRUGO (Read-only) with octal permission 0444. This makes it much easier to read and and is consistent with the kernel coding style. Signed-off-by: Clint George --- drivers/usb/gadget/udc/dummy_hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 1cefca660..fadd3d0c6 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -73,11 +73,11 @@ static struct dummy_hcd_module_parameters mod_data =3D { .is_high_speed =3D true, .num =3D 1, }; -module_param_named(is_super_speed, mod_data.is_super_speed, bool, S_IRUGO); +module_param_named(is_super_speed, mod_data.is_super_speed, bool, 0444); MODULE_PARM_DESC(is_super_speed, "true to simulate SuperSpeed connection"); -module_param_named(is_high_speed, mod_data.is_high_speed, bool, S_IRUGO); +module_param_named(is_high_speed, mod_data.is_high_speed, bool, 0444); MODULE_PARM_DESC(is_high_speed, "true to simulate HighSpeed connection"); -module_param_named(num, mod_data.num, uint, S_IRUGO); +module_param_named(num, mod_data.num, uint, 0444); MODULE_PARM_DESC(num, "number of emulated controllers"); /*------------------------------------------------------------------------= -*/ =20 --=20 2.43.0 From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7F226C399 for ; Mon, 1 Dec 2025 20:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621455; cv=none; b=KYmNmm2GXUnSeO0weeNKA2DDrAz/VMTtikQdRpNS/zq+hFvULHNhEL9kS8oQsoFQEhxGhuN+7syC1aR9O6g4AGKqhD57OaBc4eWmhgyAsH5bJWIsgDHUMJ3wcw/0Y+rs64AstjVFjoKDjBOy3+/uhlTAPU2JQHP0+6850yb1d04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621455; c=relaxed/simple; bh=ulUB8KEvP4vIj0I99RHhhlg9mGtE59OTbz9tn/axA1g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q3Em7EGJm/hlZYJKbAXfqDmWsHGO4FkE6HcHhVtshIt40bXcpMwgWd0hv7l6k1Wq9AKw+7TfVd2Dbgz0OxnaJztkTDePItsWallPi7lme9PRLu1fafqO6uTvnOECoUtfd2bhSB0uiv1k2QfthXCnP4GJhLRe1aSI48MHuqtuWW0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LU+y35Ts; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LU+y35Ts" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7aa9be9f03aso4049752b3a.2 for ; Mon, 01 Dec 2025 12:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621454; x=1765226254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rddN2NbLsRsXaz5nK+hoW97gJimLd5zvIjhD50OcbhQ=; b=LU+y35TsBWSwwPs5+lfOPkSxcvVNT7/wpssiCpkLEnNuqk5g7cBZnhB7dOnkrFGBEe bjWY0Kin0PwFySH/X3H/uDqoPPWfuGr13KhHE/BkLEGVEV0aYjx1JKf/Qnv5ywoR7Oh6 k0c/3gXVSzvW0gqDa8G8vQUt4hVP02icqzB2SIHnM5gDtyFrhZCWX+lMOHrupnlFffES ajzvPOeiT+HXlF4qUN7ATgfI0OA4rYFme/fJFhr3THxF6PbM+JVPTkcUTmupzzGz7gVP /62dGLTJRP1OD/NXdLmfP/byQhRszBcEMkcsnszekYilTXsrzOcyj7OH6le4N171j0yu AIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621454; x=1765226254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rddN2NbLsRsXaz5nK+hoW97gJimLd5zvIjhD50OcbhQ=; b=SPS/zRGG1lpBDQLlcczX5/2AGq9n/sEIIOgnqL/YmDr6mwpEMNo0k/DoXnpYE3+/0q zjc5SBjgvyHfsroqHSA25NagRMHG1WeSzpQC5zq4akbpx0gmKpDKRU5Sqd+cHme7fK20 E6PlNwBbl+Ee2IRcFwNtgx2rdPKVPg+1N7gJZwoAq7n93w67dme/Ane2jFYzeheTxQfR X9hU9uBLasVoJ3RNA1RzippKLsOammCkaNWnvqSIYO4wY0FkxtAuPQGanvdtd1i77OyD GVhzrzA5ZkMe92Ehp/sOewfzlXtLtNnqxdguYyyf6XJFHiesRzDQaBVo80DaMLfGBcUh atwg== X-Forwarded-Encrypted: i=1; AJvYcCXM5l1vBi41H209K7iRw4sWxe8HIq9C9embhpakCQf44bZzVyMNapK7VUbE/W44ZCC5+YepaDhlCQGD4gI=@vger.kernel.org X-Gm-Message-State: AOJu0YxAloL+QdIqgSkYjr/5Hi5QwZ3MPqN9zRRFtR39Tb7dzo/I4KzJ d8OaWUM1gCwZkC9TrEYVQw+KuviVbO25z/3WPH9R8QLzGYBVyjznmqio X-Gm-Gg: ASbGncssOI+5UAV2BWfsUOC+Hkmi9Y7/l4EUJG+3kXljwoSMKB00mHeYBXSIZavNWxl mC5JDhf21/B7CKBsEdpSxr1jgbYlaNV0SLuWOfxqzf9o0itC46ZlaGpLcBSzX28NhQTdnGDzLxs BU/ActlvgOJBdZ3Ackr1kvM04OcMd7FjdaoSjc/rVFkPrnk5HNGTsKFbzjeuxaOnqkGfrVbU5QY iM3nKIRVy1BevGtqVijLWRKojWWLiMtK5RtNEPh2oFUSlr3kpNzw/2RgP3tWvEwGACwLGa50Fp0 C/BXKkBE8QKbSymvIZ12yzYVV69ym+FoMa3ucS4LtHw+hCbDpdPqwimjkba3h6PDlSb5jny/Oyz hksM6cskYTn0rUDWF12YmztVJ8vWgts9Da65b5ZYFy6qc4gMuqREjx3cNkbaph8sYfYIZDpdn/D 7DwzehcFArqjgjNT4NHyyszLqHxNqMgUw4OVo= X-Google-Smtp-Source: AGHT+IEEPQo7d9t7c6AjYuQvOyFFo9Jc2FlavWwe6HnggCJaRUGvoTe6BFxCVSmi4BX9k/Ck4u7Kkw== X-Received: by 2002:a05:6a20:1591:b0:35d:492e:2ed0 with SMTP id adf61e73a8af0-36150f34605mr45146172637.52.1764621453514; Mon, 01 Dec 2025 12:37:33 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:33 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 2/6] usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' Date: Tue, 2 Dec 2025 02:07:11 +0530 Message-ID: <20251201203715.17768-3-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use 'unsigned int' instead of 'unsigned' wherever possible to maintain consistency with the kernel coding style. --- drivers/usb/gadget/udc/dummy_hcd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index fadd3d0c6..39b571899 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -506,7 +506,7 @@ static int dummy_enable(struct usb_ep *_ep, struct dummy *dum; struct dummy_hcd *dum_hcd; struct dummy_ep *ep; - unsigned max; + unsigned int max; int retval; =20 ep =3D usb_ep_to_dummy_ep(_ep); @@ -1414,7 +1414,7 @@ static int transfer(struct dummy_hcd *dum_hcd, struct= urb *urb, top: /* if there's no request queued, the device is NAKing; return */ list_for_each_entry(req, &ep->queue, queue) { - unsigned host_len, dev_len, len; + unsigned int host_len, dev_len, len; int is_short, to_host; int rescan =3D 0; =20 @@ -1443,7 +1443,7 @@ static int transfer(struct dummy_hcd *dum_hcd, struct= urb *urb, /* not enough bandwidth left? */ if (limit < ep->ep.maxpacket && limit < len) break; - len =3D min_t(unsigned, len, limit); + len =3D min_t(unsigned int, len, limit); if (len =3D=3D 0) break; =20 @@ -1624,8 +1624,8 @@ static int handle_control_request(struct dummy_hcd *d= um_hcd, struct urb *urb, struct dummy_ep *ep2; struct dummy *dum =3D dum_hcd->dum; int ret_val =3D 1; - unsigned w_index; - unsigned w_value; + unsigned int w_index; + unsigned int w_value; =20 w_index =3D le16_to_cpu(setup->wIndex); w_value =3D le16_to_cpu(setup->wValue); --=20 2.43.0 From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4943B28504D for ; Mon, 1 Dec 2025 20:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621459; cv=none; b=roWjLtVmBl2O9HoMnpMnm3xr3NUW+34qlpHtyv8GmVAJC/bBjhywRASdYiOLbrAqcBsELTpMd7mnS6a3hm4IWuuMlaNoGGZ4Wf0smfYuz2pIjexR2K+gz+D5rgIbodGqoS9uVv07vkXBDVeQSjw+W5wjYlrOWLGInxBx0+fewzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621459; c=relaxed/simple; bh=2OV1vA17nQisqkFji+r6uSJUsr6kObVd34VeE1DNE2A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T6gszWLjnbSK+bHENNDmLVJJ5OSX1UbqIU4IbFseFcR1zA4BAuGybSDSO2Gm6j7Xyvqk8r8Qf1MPihSZdtp44N1WVB1cKswWwuLCAuM6IBJvN5rBxLFPTFniDqdpYMjmcDsvwukz8iGlHzpmG8rOwGd71WPS+qjr8BBunqz8UrM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bNlSNMjg; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bNlSNMjg" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2955623e6faso51397535ad.1 for ; Mon, 01 Dec 2025 12:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621458; x=1765226258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F4ycNkEEiF97kKkbGcrEYiUPA5+jyVCF2v146XXFMKA=; b=bNlSNMjg4YDYwU/jXa4+cZlC+XrevH9T736uZnRHk1YEbFZ4q1uALsnS57pPkQ3rSm hDahBbaydd168LkoXId46cOHE0XMQvPnH7gKocTeq1zrtD5q929MOUfXAV8xqT16W/aY K4zfrmA4h1zpcphYiHcneY9ewDC9eUd9ukDwc78+2hphxCoWBf2AycbCWoVGwkhYzh+o CrpCZ8s18A6YtXSgYrHR3S4fqejNTuD2XzwG9isujdWtRFvIZL9fC0MXAg5f/Nn8MklE w7vodh5efNBx//d9dsrRa8OSgJcLzxs9puAFFwmcqqH6KbnrpczEoWUxGlThNXKLibc+ FXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621458; x=1765226258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F4ycNkEEiF97kKkbGcrEYiUPA5+jyVCF2v146XXFMKA=; b=DBCqRtDiOWXDt8CNM5WriAt1dY4Yl3xi9Fj3FooB2fS7wwt8szNeh5bzUyaJkcfbdQ 9oDojU35cpk/NpXA7Z81E5eZ8qgwUVxKPEeV9Xh1gdqFpMeDVW7F5PK0+FFsI7jju6jB uL+QPk4QxRW9zb/YH6oZloOPgP9ZQ8AIBlGB9a1j8Wl88I0j+8qfZZFQtk6+iiVmsH6j zsvAjoLd/nHrxMI66JlYCMyp0fnDnw03HFgbpuxNr/I6SI0o/52zEb3QqpUrXeJONz7R puStLChSePqAMtc4RlUuQUZo/4ix7UTXpoiRu8Hoi7eXcN/dmquAE+w11jRIEhnFl5Ez bivA== X-Forwarded-Encrypted: i=1; AJvYcCWEQta4bezOxaOXiVM4D77788GPpDE9iCxoUCzKocQhAbdtqUlDQ01RZxZLCZm5ZKTRjd6YjfyiC8S28oI=@vger.kernel.org X-Gm-Message-State: AOJu0YynQ0ULfRGXbbQrUptQSBz8e+CogirjWBPjtlgL5WT9nQxiSXtL vDiRX/KYcfJM+bfgTbxHs/aTfYmR28X5xrnddka2XvuXXeDuM21vcIxL X-Gm-Gg: ASbGncvljgLGg/amhpE6o57IQAA1aOfEHaeI0sSG1e8PzLUCtqu6EvUpB4WEGu/0PRZ r08PCHH3EMENO3k8MAlJ+9OA0DNfkInro7nl1FtROZNzOPc7dyOzDwThNDII30Mv3Pcns/pdXBN QxQcZtsh3emwgFlmKtKjMWY1/aB5hRzJN91Zgg4TF/V55cPCe3Jycx2vtfBGFf4GaUD1ca463Tp uns50CMzjv3ofRKoUOxmEnMUxrZA/ZtUBjQewryV8OlPXjB4rc74RTzSdcEF3QEsLmsUdfD3KCX 1CNQmerl9Dz1gutShmzAuM3ss8RSB3QWWpsDZ62tKEG/pTfY2Al2jQ0cVS4NYaSnljBtQlGqRai YufwBYFRRwaq1CU18cb+HYqMfMF5WlYGfxuCvmarzEd8Y1uXV6xFk+YnVvrvVVyw00KNn/8EiKr 08/Br7fcTON4cuVJXFI75jS5AZSOnJcJlM0ZvGbUXDD9gL0g== X-Google-Smtp-Source: AGHT+IEtZwyJ1h84xNpSd8cwSnswEJ6N/+iIfdUSDQxIm5UJsYL1XcBZqW6zMMJ2pg+7syQbAsGqDA== X-Received: by 2002:a17:90b:2547:b0:341:88c9:ca62 with SMTP id 98e67ed59e1d1-3475ed6a904mr28534111a91.31.1764621457573; Mon, 01 Dec 2025 12:37:37 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:37 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 3/6] usb: gadget: dummy_hcd: document ISO endpoint allocation pattern Date: Tue, 2 Dec 2025 02:07:12 +0530 Message-ID: <20251201203715.17768-4-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove commented-out ISO definition and add relevant comment documenting the ISO endpoint allocation pattern. --- drivers/usb/gadget/udc/dummy_hcd.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 39b571899..e4124838e 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -151,35 +151,23 @@ static const struct { EP_INFO("ep2out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), /* - EP_INFO("ep3in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep4out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ + * If dummy-hcd supported isochronous transfers: + * - Endpoints 3 and 4 would be ISO IN/OUT respectively + * - Endpoints 8 and 9 would be ISO IN/OUT respectively + * - Endpoints 13 and 14 would be ISO IN/OUT respectively + */ EP_INFO("ep5in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), EP_INFO("ep6in-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_IN)), EP_INFO("ep7out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), -/* - EP_INFO("ep8in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep9out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ EP_INFO("ep10in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), EP_INFO("ep11in-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_IN)), EP_INFO("ep12out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), -/* - EP_INFO("ep13in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep14out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ EP_INFO("ep15in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), =20 --=20 2.43.0 From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308B02868A6 for ; Mon, 1 Dec 2025 20:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621463; cv=none; b=A7k5Qzr27Ez6KaRpD7tyxTUZ0X9qFpaoZviZIvERON7oFu/3L+XAhxI9pXHCo8TL/D2TEmeT3wdVgy8N7uFJUqDhMv9+yqdaAyjRfDNyO+wQ/37zEU6RYIghf8aix9q4cKHY8ytpN3OoRJtURTX57lZRWPox3yBgsA1DPqGu2dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621463; c=relaxed/simple; bh=HV83Y8jNILcsVoeAeEISwDwWVyNwvsbim/+VE/epq9k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pw4fmnh0UyHAwMK8CKTJ8u4o796qz6WtJZLWpaFIerUw+s0Pnb3q66oiTRLsUU+4nZsL95TEiOFqBQMVnjda2lCf5Yhrcm37jxojTcsxmGVESAHuGn7hPgXDrY+gsc8GGZt89EKdPUTgfVubV4/6kGLXAlJvQHOo6+H/lledoxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LVtTLUZS; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVtTLUZS" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-340e525487eso3853958a91.3 for ; Mon, 01 Dec 2025 12:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621461; x=1765226261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HMFinDzf12DskrYWTn3hquLiDv906s1+ITYvei0aZ1A=; b=LVtTLUZSUJDTvgC2Hgv+/8+gVPy9qkmXTM+UoyKwMXCD/BcqAL48R6CKA8kkvh9Sj/ 5wc2OFQ+UcvkWxSCkUlsJbHCszTYtFxweZJkCIwwPCpl9uXZfhaxODgL5MlMM7zvnKU/ 4JxffxF1DP6F1smTuMUPi5xZRMhREBMS7wBqD9zwxSvfALX5LQLg4ZgZ9KEKQWyZEvCR EjUmlvuoQHY6bvfikIPQ6blHa8W6Q9A4BlJakUKIEynN1r0GpMIFBHi8DDpDelz3QH9J blvkpDFLxuioNpB9Ygp9XLjqk7rljZYUWAvm+2+m4xBOU/HHKj66tzLFAROjSeWhl0xw 7gpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621461; x=1765226261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HMFinDzf12DskrYWTn3hquLiDv906s1+ITYvei0aZ1A=; b=Bs70mHybT9H2qFiMXNJrOxFYEy5iDSdhiLlQfV/pg6uWwr5cCOV3MS+6jeofXFHYon jLYzI5LT5M7sV4JTquFoGYHiQmghCc6aULjapE+tXW9byiHBbj1Y2pSJAB5aUG4vRe3L Xcu6jDUMpD2BSZhHL70JXuuowPO8ACTM1/9rs/Rk7H7Gy39NiWCFpfQQXbheoSk4zP7t Dbs8hFfcuKXiUr1sS1P6NkoPKNIUIP1r1hP2GQnKHSQRB4sw/vTP5oZd+sQJ4vVNlFss xdoOA8bTt8V6duvbvQajY8KAQ+kubKrE9/XO8AfQxgGDJBixWg/2qfaZ2Cd46z+aVXc1 vDyQ== X-Forwarded-Encrypted: i=1; AJvYcCU2BJamhgsp6zNvkQ7rIoHVzT1PsCfZeWGYdZzRaucort28s7AEPSUzBxdDZPuYhbbzHJ4/i4XzRQD7BcY=@vger.kernel.org X-Gm-Message-State: AOJu0YxEyikD+Zw8sSQ0Fjd+R12ILUdh/WtyLZIQ3vJAVfIxEgWwtE5Y SoCuMa6aMDKeu/MRDZHMThc/ONOzlQjIX6JXpVwiwM0M57igahg59d5RFyUATg== X-Gm-Gg: ASbGncvqbkU0Oq7sW6UDxm2YE7EOypNYeNc/z3CCcl9D6iLLTrexH72QKo0TRE0YYXW 1Zbi4EyuN0gEddbRKStbQK0ZBtE2UDwdoW+0029785heaj8ZvoOIXx4EI64itNekuWrStTUoxnM fliwwkyoZjaeSQAzIN399r5JdKI/qvbz7ydRpA0L85M971lQPcVo6jG/SVs9DLmmu4/wicph3Gy +A1lnzwu7uPpjVTnfsOoYWpINX1PPTuyiU4jfHZ1Z3AiYsGrDZb4MB9zF2QWxNpaFQ7mR3UljlL 7VFZsINwsP4JMytVCBGnu1x77m1ns9R8nEZQ+l3gP+DPvIjwHaaTn5Jru6P8xdg7oV94BGyy0nH Ke0b1LLnsn9ccBQSPbiLSnSPXHDfE3gj5hgmG8PyUUUSMkyyxD0m4MMGu5mZK/jwIAzjO7OtgSd VMFGyOGctGlkmIb9k84iFrQcQPwTzDAQGNs+0= X-Google-Smtp-Source: AGHT+IGy5roLh99dzfWSGIMY/TD3KRw3HUxv9eVTSnT6FUeNG1+/rruLpyAViKSztrwT/rheUxgTHw== X-Received: by 2002:a17:90b:534e:b0:341:a9e7:e5f9 with SMTP id 98e67ed59e1d1-34733d76c4dmr34752993a91.0.1764621461476; Mon, 01 Dec 2025 12:37:41 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:41 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 4/6] usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr Date: Tue, 2 Dec 2025 02:07:13 +0530 Message-ID: <20251201203715.17768-5-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use 'sizeof(*ptr)' instead of 'sizeof *ptr' to follow kernel coding style. This improves readability and maintains consistency across the code. --- drivers/usb/gadget/udc/dummy_hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index e4124838e..cbf9dbf2a 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1258,7 +1258,7 @@ static int dummy_urb_enqueue( unsigned long flags; int rc; =20 - urbp =3D kmalloc(sizeof *urbp, mem_flags); + urbp =3D kmalloc(sizeof(*urbp), mem_flags); if (!urbp) return -ENOMEM; urbp->urb =3D urb; @@ -2066,7 +2066,7 @@ static struct { static inline void ss_hub_descriptor(struct usb_hub_descriptor *desc) { - memset(desc, 0, sizeof *desc); + memset(desc, 0, sizeof(*desc)); desc->bDescriptorType =3D USB_DT_SS_HUB; desc->bDescLength =3D 12; desc->wHubCharacteristics =3D cpu_to_le16( @@ -2079,7 +2079,7 @@ ss_hub_descriptor(struct usb_hub_descriptor *desc) =20 static inline void hub_descriptor(struct usb_hub_descriptor *desc) { - memset(desc, 0, sizeof *desc); + memset(desc, 0, sizeof(*desc)); desc->bDescriptorType =3D USB_DT_HUB; desc->bDescLength =3D 9; desc->wHubCharacteristics =3D cpu_to_le16( --=20 2.43.0 From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFCC72798F3 for ; Mon, 1 Dec 2025 20:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621467; cv=none; b=X3kByXlR0KunPbLBGEZYtqFyDq3siUm/o8VfF/Jk9tUKCSz7Oqi3WB2955Q2qvQAeqligKj3m8UrpXaWuQHir3h7kcTkH1eI/LINglZuOfcYH/UKopIpJaemvBL9h5TeG0pCtONnWXILGXGkXhlEUVzc8WJNprKynOx67cyA0Xw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621467; c=relaxed/simple; bh=+z7MJUYb60LpP3DCrX45OA1BaY4HMzD8WKTvs9ZysQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pfmnhRUjUEbyPmMJ4SIYd7hYTYZHnn1TmXk0UCgr6ePjeLw0xR/gq34Q8DEjNV4GrGpPRUT/wByfcFz48VlOUwJUL9JG2mfbzQ/Fu/JWx5kGbPn5PlYUnZEwwzYmDjE3jbsuWAFJ+SRb7NzlQnvBJSL5DsNEnhu5ZG6Fw8xjlt0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z5DBXuTN; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z5DBXuTN" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7aad4823079so4086079b3a.0 for ; Mon, 01 Dec 2025 12:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621465; x=1765226265; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gma2nwegmLLD/sSpOFo/G4SpxpRQHV3w21+ECcPjv/8=; b=Z5DBXuTNNYvkyXwG1eq5HLl5fW92P1FZxBFqrceVUFlLWy5cZXYtochDEvn2dYts88 /ob12QdIjofpU3clC7NqjUbCq1Mg1n/xwo2nWFgV+RrCXGHwZH0tBwdMQdIf3Byc/z1g 8OlfiGU3PdvZQZvOEEjGIbYv4vp6iXBdsMGmJWJlS61DZjChnBa2nX4ysj6YeIO5c9cl jE5K88sbML9zW4tD7NTRDE5E1LwiKsUtHI3f4quMhVMXl0jK8G1zdkY9tFBOTEH1PkCx OEqci3/1YBv6Ng53eC0/1gcc89ZnHHvAJJnhC6zzmy9cvs8X6+obWGtWA9f8ZWcSSHVj gEuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621465; x=1765226265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gma2nwegmLLD/sSpOFo/G4SpxpRQHV3w21+ECcPjv/8=; b=LZ4eIT9b1zfFHX4r/lSN4BVwCm+jEDIq2Wkh67PK40Kk0drVJVvYg2FDs1J7nlgIhZ uQflnGtpzdlZswjcn4sOFjy5X4XnSu+esJ1+UZvHJ1OfVK5OfrAnHFItfS/FHCNrQ3kU brotl0I9kuBDORICMmXjJSPxzofgJJK0L3j2aHZwpIBroU42yT1dIHwBYeyiGCMjSGvz lh/XYHtmcAu0S9mH4PuNwVWEm/xFMpXg465/s8ngFZgvuCWRETzYnBU1h9aecZOwcU3u uesgpx5ag5BTi/gZRSKLB4+Y95RWwYM+pB++KZxAnvlB0VKXVPIe1ShU+mHW/sYEsr3/ whaQ== X-Forwarded-Encrypted: i=1; AJvYcCU0JZd1VSFCpeM2aiDtWrAenCKDz+xZr1bJuhOV8L052dKCbbBMejwt2XpaCLOIt3o+VRlu0NNbExti2U0=@vger.kernel.org X-Gm-Message-State: AOJu0YyQA1o7OaAfXW58zY7k+YkAwu8tVW+rPcr3P7GswBstCpzFuOCb 6zSjitG89D44MPct/wc7bX6UKLlJYfwTu9ZaErIuY7F85gCtX09ZOHQ0 X-Gm-Gg: ASbGnctBxFafO5Uebw9PwUgOJWPD/hwEeRHe0jIJDb890g3nEKCoGCJj/mXj6Ea/JWX 3z+Myiag23ZTiFNvk+BVMbjy5tI04RriaJhYBWd77WfIeudBcQy+ysz+Wu7tOnpw9w/Mptfhykp O9nH+5ScSrIWDAp5OMyPPclq0kARCoQIHWmQfIcTRSPs2LIPGbQWBfkWHxT1AP2GyQ3x6gwmrRV N5lBcCr8eU3Y4ACgWrSbfZJnRieORPUalDuzkKfUDYttnoCEHNVSkGCfarLYTq8J7HElKRcCrB7 i5meYD9snVMYDrYk2Jr3X6tr0etvTQ1RoXy6JFIeOaKNCeUXhHqcDgKKWrMJJQbsTKrJCDutL7C M0oGk5wlnaR++/LYAxaNjl3jgfNk0W/Ok83i4zZ0Oqs45rwgyueIr9CNoOYy5Btb2pFnLwvI1PR 7ZJ+//V9dOf5akpUyg+9wbqyWm07cfpQZGAT8= X-Google-Smtp-Source: AGHT+IEv6qggrkagHbHFmeDaBh6PQo2B1iDXMGqdGjyVpT30HqcEFvZQJvlPoYcmGYPdnYgzjepe8Q== X-Received: by 2002:a05:6a20:3d85:b0:341:6c8a:5218 with SMTP id adf61e73a8af0-36150f3539bmr46099057637.56.1764621465159; Mon, 01 Dec 2025 12:37:45 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:44 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 5/6] usb: gadget: dummy_hcd: remove unnecessary parentheses Date: Tue, 2 Dec 2025 02:07:14 +0530 Message-ID: <20251201203715.17768-6-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the extra parentheses around the if-statement conditions to make the code more readable. --- drivers/usb/gadget/udc/dummy_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index cbf9dbf2a..67b453620 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1407,7 +1407,7 @@ static int transfer(struct dummy_hcd *dum_hcd, struct= urb *urb, int rescan =3D 0; =20 if (dummy_ep_stream_en(dum_hcd, urb)) { - if ((urb->stream_id !=3D req->req.stream_id)) + if (urb->stream_id !=3D req->req.stream_id) continue; } =20 --=20 2.43.0 From nobody Sat Feb 7 18:21:08 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB26028750A for ; Mon, 1 Dec 2025 20:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621471; cv=none; b=MpALjI9sA0fnIJWuQkT+tFSpPF/Z3hOA686bg+0DPUYIh5vr1J8NzELI/F+vOQNW1QyUQndr82ugmS0DNGdoLNV+P78y7E5zPjhrzynokUldMLEjUR2vsUSfwYJ9pbVKxp3nXMIFFMG6lL/u/ewWmXMzuByiKBqx08TCrC1j3X8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764621471; c=relaxed/simple; bh=E+CGsND4ktzv4fl1slpx+4Ix84N/GoJePdgvIslDw/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BezlRIoI1uvP57Pxhg24XqJcyRbw1jQC0Vysti72P5MUDpdv6ObO/wYg/ION0Qf9G+7rRUpvCUIfjSaiJIug+lOLS7kV5Gs+U7WHmIERV2znTL1T8Q9N+p8HvEC3zcCjvCp56acy9zuKAxFM4p/BEi78aaqmFLHf9r1vJ/s13U8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jfncj/2/; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jfncj/2/" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-298039e00c2so66422315ad.3 for ; Mon, 01 Dec 2025 12:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764621469; x=1765226269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Foj/kZet4sWmPv6CgRgKvS0h296uX2HQ0BVM9JjiE9o=; b=jfncj/2/DyRu4dy9SMBV0z0MYMLL8LuO35YawBHkLwmeHhfssmRIpReSCYZ7aQJZGy kjaekYQTVp/tuqrtt9XuuWEj6g6Ull/BEg5w73XOE9LTPnwVFWF1rsJJJaKaMu/1udCi Bj7lCLCK34oZEUgIy0EjDbbV0gSJK7nFl2uFTr9Bgn56d+M86SouKugf9vTtusXlMnj9 BtSd8XkTRpWeUm/YSH9yF9S+jO4zDpWv55tAzJ7mAeYIke8tsiOoW6nunEJqaE1pkQGZ 6VVzY+j9YVtNe3f4O/6dQAv/xNnaw4zFFAc0ASIBLDTsKODRm5zoD/Eh2nqdUrlR7/0T flPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764621469; x=1765226269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Foj/kZet4sWmPv6CgRgKvS0h296uX2HQ0BVM9JjiE9o=; b=swyM+Ar1MYVbmkxSLWdwFc60LqXLTXQstWOuh67Y69uP3C6jYL6PY2o5aL77D7CK6m zkXlF9KRT2pSrc3F1idJiIWD0qvIcI1CPkEY0qk+TKAZyXoEPEjpKVFWONQprlDzeOz2 AfehVV0KuLD2T+iK5jPDc6XL0zm112pV8aVNfkygMU9F+qFVioAQNuxn4CWFGPAGS18t U9T9PV4f4yJ/SxDoHDdmSJTi2CXJdnW6Zj+mIBJPN39sILRBcx234EuSpwgRAR/Sl4UW UPrChz/NKPF55J/k5UaWuo97fx43qUqkkvGZygQmrY1nWo4NLyNDxrKW/S0+Td7OBQfd CtmQ== X-Forwarded-Encrypted: i=1; AJvYcCWFHm+epLBpgjobM/41kw6xPTXCqC5qjVlMyuuwxyExJPcf2/i5GTaCbzTCJjz5NIKe/yTwHga7R7qUSP0=@vger.kernel.org X-Gm-Message-State: AOJu0YyVjaVN9Xfkz5Iq9R8o42Ht15mLwF5oyjDRe3Dn5BuFNm1dX3rL 5VtDjNb4aq/somwmsby6inUQNmphAalkHJKAj5Q6npErGHmsZNvpyAhS X-Gm-Gg: ASbGncsYeqXVSrDtRKV8yDQt7DgoZdvhjiJzNKIJi/uysUkTlizmGMN3GQOUZwub+N5 rbN62liWfHV7LOx3bzMsCpLZvVEwj97+/6cDT0IoW4MBjB4IvF+Pa0xQhyaul/fj6YY9lZDq49A 5RjlljKWvgY+q33EvEFBz4csAp1F2UhSKDZ4rZrx6fCEblw7h/MTBmUbrQ3mvnR6QB6cHlaJ/vF wz61OuPGu7oGvi7650CTlrUj+MQ/ip5PqOoNmvjCavIxgKWRT3XY1geqtGj1ykIjOLU9kECXfO3 CRTg6vuHBNTMJTR5lACqVvMC+cArtE4LH/MPw2qyQWNZEHI1HnAQ2lbzV7hH60EP72Ego+9yx/S /4N5KotbOzaBym2E88wCQkow4v3cLvdTBmHtg5niaEkULYo5awDn578IsoFtOP7BCUswOUYNDao CrF/i2/KzaYUutlvCXJGoZUJsIYCnVUr//npU= X-Google-Smtp-Source: AGHT+IFpV3Ynx6OFmKG24ZAhlZ70Ahfik48Rrwq/82+ByEDfjerHTI7zqgix48BJMN/pNbi01wDMSw== X-Received: by 2002:a17:902:ebc7:b0:290:ac36:2ed6 with SMTP id d9443c01a7336-29b6bead349mr470192835ad.14.1764621469225; Mon, 01 Dec 2025 12:37:49 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.177.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm13113892a12.3.2025.12.01.12.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 12:37:48 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH v2 6/6] usb: gadget: dummy_hcd: move function braces Date: Tue, 2 Dec 2025 02:07:15 +0530 Message-ID: <20251201203715.17768-7-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201203715.17768-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> <20251201203715.17768-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch aims to fix the violations of the kernel coding style by moving the function braces to the next line. --- drivers/usb/gadget/udc/dummy_hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 67b453620..031f6ea2c 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1252,7 +1252,8 @@ static int dummy_urb_enqueue( struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags -) { +) +{ struct dummy_hcd *dum_hcd; struct urbp *urbp; unsigned long flags; @@ -2097,7 +2098,8 @@ static int dummy_hub_control( u16 wIndex, char *buf, u16 wLength -) { +) +{ struct dummy_hcd *dum_hcd; int retval =3D 0; unsigned long flags; --=20 2.43.0