From nobody Mon Dec 1 21:30:07 2025 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378883164BC for ; Mon, 1 Dec 2025 14:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764599918; cv=none; b=qGspzv5wW7xinaUkicjWBZyJ+2rUGm672+xhz7H1XWX2Jvq6ZUuK/OQXunJeFLe7jFAl9vMcXPckn431jGGWteKwZjLrYpIpgxGQgFXyIqFL7vqapjn+ID6WJwtciafIERAIMovfEaJefRWUy0Rbivz3b62jxWe3XeU/0XZrmgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764599918; c=relaxed/simple; bh=HDJieKVU1OPAPmWICR7jITnRxxHe+vYqQPrTd5IfbEM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZoReYaJjeSANp/GOd+TyhjFIJ/Y11FD+lfewmIu9w7xrll3UUMy9DsRDeqRp4DU2rxCDaPbxZ1qhsmTq+/HuHgw95FSyT2uunSd/pM3E8lRG5U76eKm6NJX2++eeg18nrgJabpTDYfO/Zmohm6Va3udUkE/BcA6oNspKkwyLSPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GS1Yp/Jz; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GS1Yp/Jz" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-640e065991dso3521783d50.3 for ; Mon, 01 Dec 2025 06:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764599916; x=1765204716; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nhV+wF32u4YWe4M1PbEZf3RsFPpmY7QIKhhlfIeHA4U=; b=GS1Yp/Jzhz5JCvYq7FdQms2sl/KVTBHemdR6laLuVDo2q40I9i3C9SUitNA39Gy9dL hlP2X+iAht1JWbydeeZltXELRfp1+cIt3NibrG13aF1VtKw6hPAZl2yMRQbVWFLgQJE4 NGtJl2u7LMf2eorIYqcm9RpCUH5PX7bev/xKzWFngU9wGw0MtBpFKgXm54e7OSo8B3Z0 lJWFB6PC/6wzf0CGO+Qxv7URIrUYLxgLuSfQHZ+rI2357Wbuku9WmD7f9KBVkyv+oOSI DhLPNJOXgWQg9Sq6Z9HsMcbuS7DXV9bwzHo8M4/6h3gpe/6Svu8PCFZd/D72OdozVS5O l/VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764599916; x=1765204716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nhV+wF32u4YWe4M1PbEZf3RsFPpmY7QIKhhlfIeHA4U=; b=W7IrZhEbNJ3ovbYv+hnCbHoioFOz56jILJQ6jqklDQ3P0ISlYsbdBaW6yjV4UJMDHw I+b08fFjh38Thl17sKNvyHMxDdv9UcKdUzT84W2ycvmsHvCTfVp5GltRtGW72sXh8U8Q mArC/rLW7/HOVl+DyTlGy3DZY1j2wdwW6P7ZpOrXIcP9CPQBSYUWfNzRAvB/Fz0C+Yma Zkupt8oy1w2QTSpnoIF63atuORD8EBY3y208pLjItOqDFviSULnRBPntIqMqtbrI/wz/ Xl2PEooY/6TXTZPgm+OXj7AOYw9sY56UZZyQt9KAe2vpBPJfF0whwmM3OAKy0DFanZcA Ke4Q== X-Forwarded-Encrypted: i=1; AJvYcCWb3shvH+wA2+cOaOKxVjZRq7dRFeOuUL6X+jK43p9S7BzLGME96eT5JK6htBszpBn4ZECsttC6N0cCxbA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn89MCpYuU01UEK1rB+OvO8AoH6oXiXiFg8WBPyUaRAr3p1YHF do8QpNXwuQxou/Vpsji8x+ybVN98rt5yjsFR0Z8pWqp8K1DDebBF7+5F X-Gm-Gg: ASbGncs93eBJCOz8LJSWyZ9XajgMY39FD8JhsUFlekDOjdZYUTK/6ovLEgnZxFAy1cx cjQMyjRfnkS/mZfM+jdkysxz1ingmQ9gLb98J9IfJ69ywPIvvLz1ns3qf6NQXESok3sidl6Hqfs RMxUjb/jAQfD7d5D23l8RcP1Eb7ycLSr9R86nwoJ6FhTgTKVTnq0Lj9TIWwbzIrYW7KCmDuFc/l gINQaPk38bsaK2q4E6TeeoN9E8QFTMplf0Tvv3z/fncdBvt3DPz92tJh+fCBPDhLXBVmhT6j11l IugAzCfNpi7QkI7sVyvttUtEOOpXPui8wZMvRe5LehL6N7sUiCRiZkhn2XURuJ+sveh6EEVvVcX a6QO3QjJY0vfV5GT2eJPc9R9nlGyWhWOn5jf0dvPEq17dvh36Kv8IbopTFs/49FOfMn5cAg+nai gfUGuWQv3N69Stk494bh9gkgm11FrXUAEaMjFFFBjAiQFYu+E2WqA= X-Google-Smtp-Source: AGHT+IGcQ9jCsPCNuCGcwtyK2voFJsZm0s38+03mKZJ/R8oA5ommDWOal1w4eF2QNct+gCkN7wdkhw== X-Received: by 2002:a53:acd6:0:20b0:641:73e:c50b with SMTP id 956f58d0204a3-64302ab7be9mr24371456d50.47.1764599915963; Mon, 01 Dec 2025 06:38:35 -0800 (PST) Received: from localhost.localdomain (45.62.117.175.16clouds.com. [45.62.117.175]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6433c078297sm4889911d50.9.2025.12.01.06.38.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 01 Dec 2025 06:38:35 -0800 (PST) From: Shuran Liu To: song@kernel.org, mattbobrowski@google.com, bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, electronlsr@gmail.com, Zesen Liu , Peili Gao , Haoran Ni Subject: [PATCH bpf 1/2] bpf: mark bpf_d_path() buffer as writeable Date: Mon, 1 Dec 2025 22:38:12 +0800 Message-ID: <20251201143813.5212-2-electronlsr@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251201143813.5212-1-electronlsr@gmail.com> References: <20251201143813.5212-1-electronlsr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 37cce22dbd51 ("bpf: verifier: Refactor helper access type tracking") started distinguishing read vs write accesses performed by helpers. The second argument of bpf_d_path() is a pointer to a buffer that the helper fills with the resulting path. However, its prototype currently uses ARG_PTR_TO_MEM without MEM_WRITE. Before 37cce22dbd51, helper accesses were conservatively treated as potential writes, so this mismatch did not cause issues. Since that commit, the verifier may incorrectly assume that the buffer contents are unchanged across the helper call and base its optimizations on this wrong assumption. This can lead to misbehaviour in BPF programs that read back the buffer, such as prefix comparisons on the returned path. Fix this by marking the second argument of bpf_d_path() as ARG_PTR_TO_MEM | MEM_WRITE so that the verifier correctly models the write to the caller-provided buffer. Fixes: 37cce22dbd51 ("bpf: verifier: Refactor helper access type tracking") Co-developed-by: Zesen Liu Signed-off-by: Zesen Liu Co-developed-by: Peili Gao Signed-off-by: Peili Gao Co-developed-by: Haoran Ni Signed-off-by: Haoran Ni Signed-off-by: Shuran Liu Reviewed-by: Matt Bobrowski --- kernel/trace/bpf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 4f87c16d915a..49e0bdaa7a1b 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -965,7 +965,7 @@ static const struct bpf_func_proto bpf_d_path_proto =3D= { .ret_type =3D RET_INTEGER, .arg1_type =3D ARG_PTR_TO_BTF_ID, .arg1_btf_id =3D &bpf_d_path_btf_ids[0], - .arg2_type =3D ARG_PTR_TO_MEM, + .arg2_type =3D ARG_PTR_TO_MEM | MEM_WRITE, .arg3_type =3D ARG_CONST_SIZE_OR_ZERO, .allowed =3D bpf_d_path_allowed, }; --=20 2.52.0