From nobody Mon Dec 1 20:56:34 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33AE130DD34 for ; Mon, 1 Dec 2025 13:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764595244; cv=none; b=WzFz0b9udXRaU0J69VDceFpLLEnchUtFEXPyQnMebSqIbglwiCa7fIYE0+9vO9/cYtL3HLIyknGkUpqf4HUHNqqs5idfRf2WBeiTCJG5d7d8trJj/bT9tpD11GW/3lkAaPHCzpshU4A9madr9QnXK9VgSI9mOqzjUbW8CYnEaDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764595244; c=relaxed/simple; bh=Ba4YHewJsBeFN9HspS3uO86WLlDcBz4A9HSc0LDhyp8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DvR0SXz2KD877Fjkat8yyI/gNPpSh1pkiHjRVpagbl0+IISmmIgBdvINBTW75Y0cEZgsusfy+4R3lEsJkngEfFYoCzGdwGow+IfqsUaln+KAf4zK52MXHgCuxP61f9AWyufCZYCIH7l1JIArY3TJJQ64zCJvbUJUKhBUamp07k0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vac9EPW6; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vac9EPW6" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6419aaced59so6258373a12.0 for ; Mon, 01 Dec 2025 05:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764595241; x=1765200041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ggs9rtQy4/FD8+ye9LTzpVHkqY70KYv0vVpjcEq/ojg=; b=Vac9EPW6eq2URFJSgI928sVlFkqGSbZ5a3aQHD4hEDHS5co5h9enTq0UdWlipvztP4 qMqtVZfbEuRXU8cIAi7L4r3HaWoQSXE0vBDHTcOiEobUIDmtBTVxlW4pXVnHYN+ff2qQ PlTfSj5gxOQZIBii5LOzBh6gZoA892gdszLLxZz8vaGhP8lgo00Rhe/9E1qMco0I9p6Y cH4YKEKTYN51SVmJSh9wemdPKj0mnZsC5M9y2oqd3QVZGRKePjApDqUzFXTeBy3R+aao wkwEesIHoXxyuhKfAtrOYkiWT0ixkllXVCR4jmyhmaTGNJwuwU1bErPI+iaWb/UgAMN3 5F1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764595241; x=1765200041; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ggs9rtQy4/FD8+ye9LTzpVHkqY70KYv0vVpjcEq/ojg=; b=sNUCqzLfhKcPuCKthLDtbtnQk3OFH70WY0fOL28onLpQajMhfyt+9o23jylKy5Czj8 Ul0XUNSa9yoZQkQAq8+8OfWuucXMCGNMPt+nLbiKd0xB3QkxjHr/ofLNbhJIhX2E/KX/ bmYIGM+iVtpvDk3moFmPYWuPdfea/m5HcXZcTM33Up1sOErz5BrJ9y5YuDt162wc4TDB 6U5odfnjXN7xKHLBbF6SiK4IpfYCqVMugnp/3pjOVeSkk3ruoU97NdD3ePWLKY+nJAug ySPYaDv4FNVVymgPVD+mWFIuX125iBFpswHe/YM/Io7WL6p2/RmcSx2x3btEL6NU15nZ ECLA== X-Forwarded-Encrypted: i=1; AJvYcCUV+WjSYUhLrQd2DSP8gQlxrPAWuoLqOzXxz2XKu77mhweNC+KUWWzVT+Asf9i6cjtUto91IjLOux/CD5E=@vger.kernel.org X-Gm-Message-State: AOJu0YwCjRcJdvDFl2Q2e3Jv1wlQ3xH2uRo/yKOxDrEuBqUXi/bPThSl WZSe7z9ZpqCNxvPr7chABVk6DVfWYShhZgvJonr8P4K8i+zTN7mH3D4Y X-Gm-Gg: ASbGncvVQV/ocUZPWodODI+qgoL0mk08Kj8FISDs9xTkrSHLojXyQbJ6tTIk+IvpnNn usW/ES1AOkb3ScLjOqoSjHsInsoIm5r+i3NbieU1vZki08DWAECZlSmIHYS0EEPWieoz5dNOH91 mF0x0Awao6LnJBm+oMnKeeN7zVAp4E4/z2eEH/nQ2VKHnQYu1lj6ahDC7BdRNJOvcDxWYr65luQ wAh/wrZ0acBIKBDhYjjUQqsheCZ5GjxcU4h8TPQtj35+OGWDX51I2Uec0zVd/X3g6klrDGhvQfm 7S8WYWXQUMVCNuRh58g833DoqqMskXBA1cvkq53hsyCFSNeDZm2zDq9fnnwn0gsQzLDFI74ykkQ 0GmiAkW27bKg9dYAfviCxnXw1o5STqsourq65+T2dJd2zL/QEiQbvz+YKoYf041QWMRzLuePmzc UwbakjWWs16TRLKSkMEhYD1IWCTNXasKu+zW+9crYqV+dJZNSoezaBk5J90iE= X-Google-Smtp-Source: AGHT+IGY6R1OszJYvwXO/NtamQfh/xgq0/Ghs/ZvXVrgOeyhXTX4FFNjJoz2R5b4i9tvDGn0MAgjEQ== X-Received: by 2002:a05:6402:2111:b0:640:a9fb:3464 with SMTP id 4fb4d7f45d1cf-645544421efmr33743604a12.7.1764595241256; Mon, 01 Dec 2025 05:20:41 -0800 (PST) Received: from f.. (cst-prg-14-82.cust.vodafone.cz. [46.135.14.82]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751062261sm13894203a12.33.2025.12.01.05.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 05:20:40 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH] fs: assert on I_FREEING not being set in iput() and iput_not_last() Date: Mon, 1 Dec 2025 14:20:37 +0100 Message-ID: <20251201132037.22835-1-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Mateusz Guzik --- fs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/inode.c b/fs/inode.c index cc8265cfe80e..521383223d8a 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1968,7 +1968,7 @@ void iput(struct inode *inode) =20 retry: lockdep_assert_not_held(&inode->i_lock); - VFS_BUG_ON_INODE(inode_state_read_once(inode) & I_CLEAR, inode); + VFS_BUG_ON_INODE(inode_state_read_once(inode) & (I_FREEING | I_CLEAR), in= ode); /* * Note this assert is technically racy as if the count is bogusly * equal to one, then two CPUs racing to further drop it can both @@ -2010,6 +2010,7 @@ EXPORT_SYMBOL(iput); */ void iput_not_last(struct inode *inode) { + VFS_BUG_ON_INODE(inode_state_read_once(inode) & (I_FREEING | I_CLEAR), in= ode); VFS_BUG_ON_INODE(atomic_read(&inode->i_count) < 2, inode); =20 WARN_ON(atomic_sub_return(1, &inode->i_count) =3D=3D 0); --=20 2.48.1