From nobody Mon Dec 1 22:35:46 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFF430C37D for ; Mon, 1 Dec 2025 12:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764592932; cv=none; b=lFSw2pn9r2YpIvAHDjmffm+H4bjJmG+5q4qQlj6iun6amHtuSTxocZDuU6DUumqqLmeyKdlkVwHsfLqIAKz1WDIPGTgfmHnK8uqnhoV3Afp3BJ184PZudP209FVisRuxq7bAzXIcwzs6Oj6cFh7sjWnTj08jAOdz8/roESuhxsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764592932; c=relaxed/simple; bh=/yJIMbw0pN7Tv4Sc1jnGyXAcHZjShnRJ61RDLzkuL64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j4jun1blhBeUuul4WP3hPbzWGvD4JFdrhW/2gb1MA+30A3lP0JIUAERI0iQWor9FquB7OY+J2UlxKBAZAiJp/QFCWTa3LjJNO4w1Z+rziGo/cKTQO9wpQEJWksK2/sdd2Mz+zmL/g72z+T5UHhha/wNCRmkVKbfGHudcoDaBlWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GWXHLoR2; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GWXHLoR2" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b735ce67d1dso687549766b.3 for ; Mon, 01 Dec 2025 04:42:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764592929; x=1765197729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zMOxQNbTJbyJkfx5C97heHQ9owdvgbQ7zmiPOjpmg/E=; b=GWXHLoR2pF4fCkxdfJKVQJ/NKhZpyCayT4LLL16miDCMs6JZt1AWLlTzXYwwH1N5cR 2ZzL3PMPsjiu2WMpcWAEEE6NSaRH1TIPyNSTCqjMACMIGRd3m4fhY1iXMzK3ybbLMlfq pGuOWArzXTWQx1VD/aQCXD2oSNzWoSMb1qtUpv3eXv13nSxrQP7Kr6E9XGYO7FTORu8N dGAtE7P9asFs48sKS7Xz6/0MMZAYKH2ubsrvq3ApW9LB1M5N3dMGEc9ooTbyXtzZJpqC EnAB4A6OX3jvqdOLM1V8u8nYJmYlVkopPuCOOsv9qBn5vRSbG4s5NTB1ClHeR6q09coe cOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764592929; x=1765197729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zMOxQNbTJbyJkfx5C97heHQ9owdvgbQ7zmiPOjpmg/E=; b=i2FyR4em4YOv5ZTT6SpGySSMDt2RaJcd0uWyw6AQ1awZlyrUSBGaEUH8jDa/xwBLNf ffMncIsSdKFzhHnz6+AvabwpVlNRBAnBusWmw17rA6KkgKMEHbDa8oYB67l1VbzYFAHs 9vMnwb1eSYA30GcYHrJuk3RwYXA4HMwVyuBDKu3uz2Brgr9HtfksTvDbbGMBQvDziywY RUAA4bQS8i6lrQtKp0b8d7fptr/igslQ7SwEoSxBE8qUvPlqOEkxYAz1tEQnWA0CV6TN JgomUmHRx472eCszrLWPrFJoTmR4BUJUrM4EeY4LdefsMi1eJ7XHjf3LollYZciqxwgW qF6w== X-Gm-Message-State: AOJu0YzjT7FGOz4f6i39Rc9FbLlme4QRjIl08ABsFZkcdfHU1mCUA5pM FVuQX7VNE23inhC5Daia7CsSJEGq7f059G944MTIjOTMsbnN0rLLnZVm X-Gm-Gg: ASbGnct0N9glnA4iySlgt9fd2kwEVJqOujDQaEjsGGPxMSdVh4U3lLShuksOCvz+6V8 qkAkak7uwOq7gAp8t5nk8qRTb4ndtWZw4wSA3N81W1iaeP8ul+RZp/dZ/H6rCMOqxZjaC0jCQWn UHhXf/BJGjeJfmnbSAlF3CUzC6WMHj/zlcmFEVtAFFZpwRFiPl5WctlBaSScKnJb+4kt/L2hIt2 pgXpcirBeinDHHsKPrI5xirEVtKroZ7qAN3zQkss0vBkjjYslojxP9ElnPUxmA15LA+U7S9LZiJ XBWvaM/Y9XDbdeKd4i0dvFIIeaTun1KrAMYyXWaS7guZzu85S9YcA0Q+OsLwrnfKUjygJXTBzoL HpoCDbxSOfG2tLbPPHbxB2KP3AuBerOuw7E7mH1DueoPI+dlSBktl1kon66ex11b62M377kKHDc o7CQk7KurZ X-Google-Smtp-Source: AGHT+IGV39T80ugkBft9UgM6j80yH3kMGRsNgzwIw/vB3ynxeWNqU+pUiOGDJs59WkZnQQSKfe3BWQ== X-Received: by 2002:a17:907:9496:b0:b73:2aa1:f9fb with SMTP id a640c23a62f3a-b76c55131ecmr2716290166b.32.1764592928894; Mon, 01 Dec 2025 04:42:08 -0800 (PST) Received: from victus-lab ([193.205.81.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59e8612sm1173738266b.52.2025.12.01.04.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 04:42:08 -0800 (PST) From: Yuri Andriaccio To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: [RFC PATCH v4 02/28] sched/deadline: Distinct between dl_rq and my_q Date: Mon, 1 Dec 2025 13:41:35 +0100 Message-ID: <20251201124205.11169-3-yurand2000@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251201124205.11169-1-yurand2000@gmail.com> References: <20251201124205.11169-1-yurand2000@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: luca abeni Split the single runqueue pointer in sched_dl_entity into two separate pointers, following the existing pattern used by sched_rt_entity: - dl_rq: Points to the deadline runqueue where this entity is queued (global runqueue). - my_q: Points to the runqueue that this entity serves (for servers). This distinction is currently redundant for the fair_server (both point to the same CPU's structures), but is essential for future RT cgroup support where deadline servers will be queued on the global dl_rq while serving tasks from cgroup-specific runqueues. Update rq_of_dl_se() to use container_of() to recover the global rq from dl_rq, and update fair.c to explicitly use my_q (local rq) when accessing the served runqueue. Update dl_server_init() to take a dl_rq pointer (use to retrieve the global runqueue where the dl_server is scheduled) and a rq pointer (for the local runqueue served by the server). Signed-off-by: luca abeni Signed-off-by: Yuri Andriaccio --- include/linux/sched.h | 6 ++++-- kernel/sched/deadline.c | 11 +++++++---- kernel/sched/fair.c | 4 ++-- kernel/sched/sched.h | 3 ++- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index b469878de2..000aa3b2b1 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -729,12 +729,14 @@ struct sched_dl_entity { * Bits for DL-server functionality. Also see the comment near * dl_server_update(). * - * @rq the runqueue this server is for + * @dl_rq the runqueue on which this entity is (to be) queued + * @my_q the runqueue "owned" by this entity * * @server_has_tasks() returns true if @server_pick return a * runnable task. */ - struct rq *rq; + struct dl_rq *dl_rq; + struct rq *my_q; dl_server_pick_f server_pick_task; =20 #ifdef CONFIG_RT_MUTEXES diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index d7940c45f7..e36d98eb5f 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -75,11 +75,12 @@ static inline struct rq *rq_of_dl_rq(struct dl_rq *dl_r= q) =20 static inline struct rq *rq_of_dl_se(struct sched_dl_entity *dl_se) { - struct rq *rq =3D dl_se->rq; + struct rq *rq; =20 if (!dl_server(dl_se)) rq =3D task_rq(dl_task_of(dl_se)); - + else + rq =3D container_of(dl_se->dl_rq, struct rq, dl); return rq; } =20 @@ -1604,10 +1605,12 @@ void dl_server_stop(struct sched_dl_entity *dl_se) dl_se->dl_server_active =3D 0; } =20 -void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq, +void dl_server_init(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq, + struct rq *served_rq, dl_server_pick_f pick_task) { - dl_se->rq =3D rq; + dl_se->dl_rq =3D dl_rq; + dl_se->my_q =3D served_rq; dl_se->server_pick_task =3D pick_task; } =20 diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5b75232427..9c724d8232 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8959,7 +8959,7 @@ static struct task_struct *__pick_next_task_fair(stru= ct rq *rq, struct task_stru =20 static struct task_struct *fair_server_pick_task(struct sched_dl_entity *d= l_se) { - return pick_task_fair(dl_se->rq); + return pick_task_fair(dl_se->my_q); } =20 void fair_server_init(struct rq *rq) @@ -8968,7 +8968,7 @@ void fair_server_init(struct rq *rq) =20 init_dl_entity(dl_se); =20 - dl_server_init(dl_se, rq, fair_server_pick_task); + dl_server_init(dl_se, &rq->dl, rq, fair_server_pick_task); } =20 /* diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index adfb6e3409..10733b7cb7 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -408,7 +408,8 @@ extern s64 dl_scaled_delta_exec(struct rq *rq, struct s= ched_dl_entity *dl_se, s6 extern void dl_server_update(struct sched_dl_entity *dl_se, s64 delta_exec= ); extern void dl_server_start(struct sched_dl_entity *dl_se); extern void dl_server_stop(struct sched_dl_entity *dl_se); -extern void dl_server_init(struct sched_dl_entity *dl_se, struct rq *rq, +extern void dl_server_init(struct sched_dl_entity *dl_se, struct dl_rq *dl= _rq, + struct rq *served_rq, dl_server_pick_f pick_task); extern void sched_init_dl_servers(void); =20 --=20 2.51.0