From nobody Mon Dec 1 22:03:20 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E830F30DED1 for ; Mon, 1 Dec 2025 12:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591988; cv=none; b=ZQTj97TJuvRao6fDMDEAWaDEt8V5XccHHzpbiaC0iO0x8fZ3H+gsUr2uIp67Pqtmc5Q97oEXnEhnaRtvdZkfCtfG7UmieY9T5c/sZOyiv9undgr0AswDK1UVRN8+qY3gpmyWFXHJLuE7f3KwQ+GNz8ehCYrujDrjL6aANUk/7xs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591988; c=relaxed/simple; bh=fqrnPd4WduD46/XBBnyXBF4b8D6EY+CUvKdyAZAiwiY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=soZ8FJ9Cfr1KEKOAqK75MM2OKiNAabzhOsb6VRtag1ZDkN8KrQ8bNYZIrYKV9PeSeNZ7OBKP1AdCEELdrwtHf+ms/c1zzjsKNPUyzJkcn0b5OBaaXjEyMmUWqBdEHqdfWPsntL79Gw81P0oxOpQ5qF6dr9vRR3WV6EQoms9cvLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=N24/OuYs; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="N24/OuYs" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b73161849e1so993988166b.2 for ; Mon, 01 Dec 2025 04:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1764591985; x=1765196785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8OH98ZYDJQZtNnl6fPGXU4bT8ZiUExlrTHFtG0JJc9Y=; b=N24/OuYsxvTnt0grSgvy/892SMM2pdrlfYW+21nkOn631MFZ8p4YBfiKibskb4sshg gqhpy1ZWmARgPD0g/cesbYbTN0kI6AWrI2rWYc+Icy3gMwwBNyMTZbwFjExqebsuOP5/ Xbqy95rKD27WvB0XyYnMAsfv+fFDCrcp+2WoQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764591985; x=1765196785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8OH98ZYDJQZtNnl6fPGXU4bT8ZiUExlrTHFtG0JJc9Y=; b=dxnQRq4UN/apbl3nGic1P+Dn77f6hj5aPWIP1ugr0dJf0AdMGmhshbU4jit5CPlL9a DAXaJbPmKdyrDhQI8l5gxi7TvMpapGSAPIO19pQIwfsBxkOiB2eOEylxvKzGVXIDCNkz 35gYWN9SOwsvjjl6hF0fLbFGfC0MFMSxhWW1Ciw2RaUJBattnkQVZfKY/XgUqg2C9RdS 8bIr2YvOx1pw6+e31kcOoi8EwQTf35aRKlnaKZga3r6BBXz3d48OZmUiTttZNt01uTIE ZABHwLYzqAKJSkyjjjORS+tJkoKDqDHlhPV6nZtuohis9VYYP8ndb60fvtcvb0+wOCco 9ZzQ== X-Forwarded-Encrypted: i=1; AJvYcCUfwD19vQ0aZ2Q5qfSg1R2oyBeh9yLv4TsYWh1zpGFcckILWEUJDNImvn8PBiFoFRM5aC6KZHPhvyupqdw=@vger.kernel.org X-Gm-Message-State: AOJu0YwswlVDEMiV1FmF4h5PMW2rAud0KJu8Mkn1WJxhH2qT2MhO0dX9 csDfTIx7IMigjFtSUhwrqsOo83G9n+frcoURCYKXnCQGIb4+ditTMppCi/5rOrps2w== X-Gm-Gg: ASbGncvzj+6yJ/u5pjtbnFd8IDDHB4RFPiCQHVWJdjQ4Q3cGzc3WgaZCMGkTKdCivqY Uwj5OueFGK3hrUnC+C0c4HTmL5pMIFTjKTzgaunkjiaS5HpYRs9LwADBshcdRgMNn5ak3hMNlH6 G7PQNO2tL4SnDtdYfZvhgJTZWiLqn7PyEh/kGJQ1EMUtLop+rBuoqTJDcVNMFJqdKDufiZ4ZuYQ xaWFsaNW+GvA4AGRZEMRX7D1cWIpat35jTj2vbzN7GeK/V1CjwGL2tA6sHfj/C5JR7TgT47cYbz QJcVMwT24jFXKag1fTjx5DNaykQ9v1QLSTgNkZRx6AZeoBU74UOk3+rdmdQT+uvduyNpl/RlTlS o+O7GoYfmAbIpnMkDR5/CJkIXz+31cxBqCtklam/KWuZhRTN5XdBQUEUhwspjYqlH8Qed3TE/YD dOHKw9x1cUphtSMC01Kk1xnmwwNYc6IetentSMNydOIu7xZ7iIlSPhV/MCnDNge5q/Y2NLQFLqf v+Hf9bl/MM= X-Google-Smtp-Source: AGHT+IGnKQdr5PepexfByhiK/VHIvgqI+kwxEyqKKnfjEsKm61/OkPzj8RjDbEc+U2QIWtElauJeDw== X-Received: by 2002:a17:907:940e:b0:b74:352d:6dc1 with SMTP id a640c23a62f3a-b7671695438mr3121812966b.28.1764591985193; Mon, 01 Dec 2025 04:26:25 -0800 (PST) Received: from akuchynski.c.googlers.com.com (218.127.147.34.bc.googleusercontent.com. [34.147.127.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f519e331sm1229049266b.24.2025.12.01.04.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 04:26:24 -0800 (PST) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , "Christian A. Ehrhardt" , Abel Vesa , Pooja Katiyar , Pavan Holla , Madhu M , Venkat Jayaraman , linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH RFC 6/8] usb: typec: ucsi: Implement enter_usb_mode operation Date: Mon, 1 Dec 2025 12:26:02 +0000 Message-ID: <20251201122604.1268071-7-akuchynski@chromium.org> X-Mailer: git-send-email 2.52.0.158.g65b55ccf14-goog In-Reply-To: <20251201122604.1268071-1-akuchynski@chromium.org> References: <20251201122604.1268071-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" `enter_usb_mode` uses the SET_USB UCSI command to manage USB modes such as USB3, and USB4 for current and future connections. It allows port drivers and user-space applications (via the "usb_mode" partner attribute) to enable and disable USB modes on a connector. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/ucsi/ucsi.c | 22 ++++++++++++++++++++++ drivers/usb/typec/ucsi/ucsi.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index ee96c42e9e27..3d4c277bcd49 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1624,7 +1624,29 @@ static int ucsi_pr_swap(struct typec_port *port, enu= m typec_role role) return ret; } =20 +static int ucsi_enter_usb_mode(struct typec_port *port, enum usb_mode mode) +{ + struct ucsi_connector *con =3D typec_get_drvdata(port); + u64 command; + int ret; + + command =3D UCSI_SET_USB | UCSI_CONNECTOR_NUMBER(con->num); + if (mode =3D=3D USB_MODE_USB3) + command |=3D UCSI_USB3_ENABLE; + else if (mode =3D=3D USB_MODE_USB4) + command |=3D UCSI_USB4_ENABLE; + + if (!ucsi_con_mutex_lock(con)) + return -ENOTCONN; + con->ucsi->message_in_size =3D 0; + ret =3D ucsi_send_command(con->ucsi, command); + ucsi_con_mutex_unlock(con); + + return ret; +} + static const struct typec_operations ucsi_ops =3D { + .enter_usb_mode =3D ucsi_enter_usb_mode, .dr_set =3D ucsi_dr_swap, .pr_set =3D ucsi_pr_swap }; diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 6e77bdbdaeae..a5ef35d9dce5 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -219,6 +219,9 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num); #define UCSI_GET_PD_MESSAGE_TYPE_IDENTITY 4 #define UCSI_GET_PD_MESSAGE_TYPE_REVISION 5 =20 +/* SET_USB command bits */ +#define UCSI_USB3_ENABLE ((u64)1 << 23) +#define UCSI_USB4_ENABLE ((u64)1 << 24) /* -----------------------------------------------------------------------= --- */ =20 /* Error information returned by PPM in response to GET_ERROR_STATUS comma= nd. */ --=20 2.52.0.158.g65b55ccf14-goog