From nobody Mon Dec 1 22:05:46 2025 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9B030BB9E for ; Mon, 1 Dec 2025 12:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591861; cv=none; b=LjMO5lqNjyHk/Y+X5ZXVkJN+plu7V9eMqkCSTrdjVVjICFxIO2pAlkpmVEZbcYUtBfuZLLc3KnpsgH6JFU+jsF+9RPENCkYKX7Pc+TbTNPrEQ1reshMpXTxoj2KuIxJjLODWveBDRAci9mRL/rTP1J93iEUBYKlHk/wv+HVvyXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591861; c=relaxed/simple; bh=/AVZ1KTl67UPm9oJo5daI+HtXeVjXE0ygjNScp5tOsM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=otOmGujDjC6cQhZzHJj3BDACcT/LKL4Ai8kjENPbI5qiGhrS4OsFBV3OQe7UBw/7KBTSlKOVG14Y/mEYua2GpRKftYZlxF0Tb6PJbFeC2gBCuG7CgMYOjUCi2SIpzE9W8ipMsDDQK9XJWfZC6Aj9ImNRwM66aCEtWo2EYbMMX1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=D/dae50V; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="D/dae50V" Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 93E213F0B8 for ; Mon, 1 Dec 2025 12:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1764591856; bh=7pZ0iEmlRC+UmoLWz0HVLhgvBs5Lg5e5yJ2fSZ1YjvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D/dae50VQO9wiRgn+1/EN4+b8E8U/UCwyXll6H/05MGOAPotteLdQFU+1m4Ww1FG9 fHyefQ97ZiER9ApArflJ9Y0e+AEDg/hbq7+uVmr3kMjNDp4T2uqUx9gdZOK89Dio/Z xsOdCv+d0LfGj1+evnaJARGm0DDrF5iw7lWNu/UrjvliofvqJ/aAF4HhpdxYmDe8pp T6Scv/zzWIr2VrOtHOqviiR7LX/WTpvmJopWbetqQE+oELLR9OoPPPZGCeCQyyVtQ+ JQBOfefvu54nJphaYYVi2U8znUjWDsjafRlhy8QPm+6VIsSHULClJEJ9PYLVLiF1/p 76LJbGzWbMRWRJNKnRHPA2Tf6lybDCJSVjtViDBx6axNYYH1Fr7K/5hwznjpGmMLLn gn01ncIoiC4QNitRSQpuA74E/Ui5SFu+mTIM+lX4d3R8g/UyhaQ0o+sD8Glf/j81cW gZmL/UVkwOpr8hUUgiJOouCFEAUYc2kUDGA70hyPgUTQzr3kG98BVSqGZizxkDwLl7 hjeIxP0rK5NOpoTPhfuSzOpQE7uXMP5NEeLk9LeOEPXTRU8SJI7x6F4DMyxmmKuHkZ yXdKM0JCwdEueFcb6uHd+VNe24uO8O1nIuFOmVl0EUtp7ciwmxR+/IQNs+0CMn8UNO 8hHJ4FQD6UyG2GjQlx8gXWpk= Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b735eea0bddso352285666b.2 for ; Mon, 01 Dec 2025 04:24:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764591856; x=1765196656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7pZ0iEmlRC+UmoLWz0HVLhgvBs5Lg5e5yJ2fSZ1YjvY=; b=KdM3uTjzK9h54FRWNPi6A8elnq7HUQzY8UtaraMuEHRlKkYs9F7cXMHwq4QN8UKrx4 uGVOyKt+3CeUByqETJYkWIBOaRGYh7SfBcnTrGw+DU7BHXZlgXqSp2scoceqKrXLpN49 x3riqwxYuD3hUFp1+h1uPuiEOfI51Sp1ULRtwX1wC4S72dd46XZV64Bc0blw6X+OY2XE mloZdKKc5fHbaJf7Mrc7o+7frPrNDIo9vckG8u5+KUjMn+z8PjgPTBv3dZbz7Yy9kR1v j8jzxiz+Zb1cUuqdQ/aJDJaUgTn5fpDKzPOf5TXv+KZZ/PyHO7+Jjk9wwpHm5kBkoK1q kbDg== X-Forwarded-Encrypted: i=1; AJvYcCVWaW5Rh4OYaS6TTkkAvud4oC8Zlh7XEOowsiKQB0EHTPNSewT1ZZGANDB+UMgQu6H9iZpTLgEcmlulLKc=@vger.kernel.org X-Gm-Message-State: AOJu0YznJmeFJnVApwmij0npwZ/4SzL+mkv+4+jVGeqVVdy+rHbL8X4d j0VWxC1HfiCq0MgutZHpLXdOy4kf9/LShxpokNClsWwfKhqN2eAc0iaDhAQ+LsTaoHaBprK9CrN Qm7ECGvn2a5T5J+K6G/Yft9XaWwhmpTdD4dFWtCamJim73WdZxWVfD3QhmqZXv0BPtAIxTMgVNa 9mjjuG5g== X-Gm-Gg: ASbGncumUjKpzApYkpZQI9LzPWfnS4j6p9POvYnaOkjiAXn+g7SVLkf+KUQJFZXefmO xQCuftwCS5/HZYANf38indUzh4hR6ca2g2OL1zScY5TfADgmgukNUQD1N7FJuOf9PfJ8mPmZJg9 k9kppuOXkINcGiljsTTyTIxGNqjYurjf0xw5L+gBIYFw1VCj2zjFKAtg67f0ihBojD/hy7V5t7q uxDgVWh+EHMYCIVRUKcD4nOYIf8gfAqdb/ILAlLiYTSOYb6WIwlDz4KRYy61DxlJn6Zyw3Kj4V2 AGfn+Z3DPxdYoswn2Ica9ezfUZpHeDEI6oAh9SFHD80ccneJ/jSoLNvu5AeEw1PXvb/p7bFXjb9 QNIy02wYwRUbtjj7O+Oe+v8PlytrMMKp8opxpRkkWqiq6pKYgaqhg2TRnStRibtIBzJzEMmzQrh muTIJiGSZokLMATK2I7j1ZAUUA X-Received: by 2002:a17:907:da4:b0:b73:3ced:2f66 with SMTP id a640c23a62f3a-b767159eea3mr3956230066b.14.1764591856095; Mon, 01 Dec 2025 04:24:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIZW7AV81jLeOVeNdSzCklwOYrFNBodBijapwm/R3JQVkCZsHyMjBHE1GdiGc2mvTdOFtc5A== X-Received: by 2002:a17:907:da4:b0:b73:3ced:2f66 with SMTP id a640c23a62f3a-b767159eea3mr3956227266b.14.1764591855671; Mon, 01 Dec 2025 04:24:15 -0800 (PST) Received: from amikhalitsyn.lan (p200300cf5749de007c66abd95f8bdeba.dip0.t-ipconnect.de. [2003:cf:5749:de00:7c66:abd9:5f8b:deba]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a6ea36sm12307884a12.2.2025.12.01.04.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 04:24:15 -0800 (PST) From: Alexander Mikhalitsyn To: kees@kernel.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Will Drewry , Jonathan Corbet , Shuah Khan , Tycho Andersen , Andrei Vagin , Christian Brauner , =?UTF-8?q?St=C3=A9phane=20Graber?= , Alexander Mikhalitsyn Subject: [PATCH v1 1/6] seccomp: remove unused argument from seccomp_do_user_notification Date: Mon, 1 Dec 2025 13:23:58 +0100 Message-ID: <20251201122406.105045-2-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201122406.105045-1-aleksandr.mikhalitsyn@canonical.com> References: <20251201122406.105045-1-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove unused this_syscall argument from seccomp_do_user_notification() and add kdoc for it. Cc: linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Kees Cook Cc: Andy Lutomirski Cc: Will Drewry Cc: Jonathan Corbet Cc: Shuah Khan Cc: Tycho Andersen Cc: Andrei Vagin Cc: Christian Brauner Cc: St=C3=A9phane Graber Signed-off-by: Alexander Mikhalitsyn Reviewed-by: Tycho Andersen (AMD) --- kernel/seccomp.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/kernel/seccomp.c b/kernel/seccomp.c index 3bbfba30a777..f944ea5a2716 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -1142,8 +1142,18 @@ static bool should_sleep_killable(struct seccomp_fil= ter *match, return match->wait_killable_recv && n->state >=3D SECCOMP_NOTIFY_SENT; } =20 -static int seccomp_do_user_notification(int this_syscall, - struct seccomp_filter *match, +/** + * seccomp_do_user_notification - sends seccomp notification to the usersp= ace + * listener and waits for a reply. + * @match: seccomp filter we are notifying + * @sd: seccomp data (syscall_nr, args, etc) to be passed to the userspace= listener + * + * Returns + * - -1 on success if userspace provided a reply for the syscall, + * - -1 on interrupted wait, + * - 0 on success if userspace requested to continue the syscall + */ +static int seccomp_do_user_notification(struct seccomp_filter *match, const struct seccomp_data *sd) { int err; @@ -1317,7 +1327,7 @@ static int __seccomp_filter(int this_syscall, const b= ool recheck_after_trace) return 0; =20 case SECCOMP_RET_USER_NOTIF: - if (seccomp_do_user_notification(this_syscall, match, &sd)) + if (seccomp_do_user_notification(match, &sd)) goto skip; =20 return 0; --=20 2.43.0