From nobody Mon Dec 1 21:33:24 2025 Received: from ewsoutbound.kpnmail.nl (ewsoutbound.kpnmail.nl [195.121.94.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79D330C610 for ; Mon, 1 Dec 2025 12:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.121.94.185 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591893; cv=none; b=Rz5tjldVSGDf0nXNHQ1nF6YjiWhp3i0Yk/V6s+82lZOGZRBwaAEeia54dDOfgKT0BBglAwICbhAMeUQ1Ppnmp96G74j2zqqwefwVvIGuzfejXPnjFjT/3n82fnoBRnuLJluQNo8W4HTKjrtL6mMASzCc+HqT6LVMLvn7FwY+LkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591893; c=relaxed/simple; bh=56cb3YdZc1cykq4EkFWo/lcakYetsVZmqQZwb6/OAZY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R3VfnXA6p6ShfiGXe8555HM8jwQEHaGsJwg1yedne+0mcy6eIq/nibMMb3POTT2JpdcTTjLS/PljbJDygO3Pan+F5Rv1VnY5uxk0COxIv4hnXWzacdIEi9MbDDWJz5NvWf8QUYr4/SWW9S0GvQYvTRkJUIICX8kYiPNo715ZO9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl; spf=pass smtp.mailfrom=xs4all.nl; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b=fSiTtCTr; arc=none smtp.client-ip=195.121.94.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xs4all.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="fSiTtCTr" X-KPN-MessageId: cbbad8dc-ceb0-11f0-ad1a-005056999439 Received: from smtp.kpnmail.nl (unknown [10.31.155.8]) by ewsoutbound.so.kpn.org (Halon) with ESMTPS id cbbad8dc-ceb0-11f0-ad1a-005056999439; Mon, 01 Dec 2025 13:25:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=xs4all01; h=mime-version:message-id:date:subject:to:from; bh=KsLVCpoM4MWR28f7fpgiBNgd99GIsEWbZNmTOC2H+Xs=; b=fSiTtCTr4+pc7h76ySfV36j3m0WzGT879NA8cSphkcsSf4Eb97+2khXeBCYJh8bIBKhsCqa+mVc6f dg1bn2tmDugPQa9+k6KhibvKD6lB6G4JQxwnlhLpxz94HaNcuXPQZsB1NmiO4CJweCB22kTbrUfeB4 jP5XQEsht6alG8HjWlgkThJW3OwIUxYikYTxkpQHHblkqHk2ArnvApY4nT3SmIo2ZPPJY/OfJthT4A 3J90MRgwewxlluy5EiNksURHDUcppsxmQQ8iUq1lOLdwp11g3Rf4BKZ+8CuNH71TKI+ZAMDKRjsneg Bc0zrbRngKHNG+hPVVxdVndAJiejkOw== X-KPN-MID: 33|dRmk6EJSnAwyNdBPW8Pi0qkNwAU5QbjvAxtfukHnCh0EzicOZbo1c7HMvrLkBe4 O6he4kgid5KroCXdGp3YXqJUiIcOhz6KrL/DpV2cJsVw= X-KPN-VerifiedSender: Yes X-CMASSUN: 33|MHL0GE2OBs9tMNC02h381ITKL3xDy5VGWv/KiPL3McYqKvgVyD41lrLad4HsrYu PNcXk08mI2bEVZ3Jcuat56A== Received: from daedalus.home (unknown [178.231.9.90]) by smtp.xs4all.nl (Halon) with ESMTPSA id 8becfe2c-ceb0-11f0-9bf6-00505699d6e5; Mon, 01 Dec 2025 13:23:39 +0100 (CET) From: Jori Koolstra To: Jan Kara Cc: Christian Brauner , Jori Koolstra , Tetsuo Handa , Shuah Khan , linux-kernel@vger.kernel.org Subject: [PATCH v2] Corrected errno in minix_new_inode Date: Mon, 1 Dec 2025 13:23:38 +0100 Message-ID: <20251201122338.90568-1-jkoolstra@xs4all.nl> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cases (!j || j > sbi->s_ninodes) can never occur unless the filesystem is broken, so this should not return ENOSPC, but EFSCORRUPTED. Signed-off-by: Jori Koolstra --- Changes in v2: - added unnecessary variable assignment back in the spirit of defensive programming after feedback from Jan Kara: https://lkml.org/lkml/2025/11/24/1278 --- fs/minix/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/minix/bitmap.c b/fs/minix/bitmap.c index 7da66ca184f4..abec438330a7 100644 --- a/fs/minix/bitmap.c +++ b/fs/minix/bitmap.c @@ -247,7 +247,7 @@ struct inode *minix_new_inode(const struct inode *dir, = umode_t mode) j +=3D i * bits_per_zone; if (!j || j > sbi->s_ninodes) { iput(inode); - return ERR_PTR(-ENOSPC); + return ERR_PTR(-EFSCORRUPTED); } inode_init_owner(&nop_mnt_idmap, inode, dir, mode); inode->i_ino =3D j; --=20 2.51.2