From nobody Mon Dec 1 22:05:47 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD08302154 for ; Mon, 1 Dec 2025 10:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764583231; cv=none; b=qwX/HgFYcIR9seDwwh0n3snHc1Pu6cfj+yhdX5TAv3EHgGspJCZf3g1R0WE8NVTnmyYm3MyWxMjE3OI0De3hitjbWS4WymDUXITBuhZ4jqHHXn2yAabCzGsLGKr1kBRVBcgeC9obB+Jdqhv6h0Nfekxpu1gn+kFo+xORb0SU6GI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764583231; c=relaxed/simple; bh=Xb/mqp4+YwITWlbn8v8dEwFHqYPu9zYkndT2tCfzi90=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nmgAfJqE/VP37uBy7nKr+PAjM8grTgSJ8g+96Sl4nS3PjKZQtYfAK9xjYDxknhbAsPTsvk+oIce8sDBrh2kzwC44BrcsBvQeQ+Zr4nT7ctK+AiS+Fy7ODsuW3f2Y4MtAF5GY17CZJMIrTvFseWgGKdvkJR7TznKN/CHNryuiwWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Gh7UyBSZ; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Gh7UyBSZ" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b736cd741c1so618610766b.0 for ; Mon, 01 Dec 2025 02:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764583226; x=1765188026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Ib0drqFrjnDrbAYTSSfxv4es9CvzBMVOslQd6EXaRk=; b=Gh7UyBSZ4vBRUQl6KzVy4tlg0NQElm49hDqToU0Rw8SXU0b7yDeQzFmMyTHhLo04Pz oS3s89/DRRwaI7QhmRJsQE/PFNhvRUtowN1pQNCMm9NRJrrvedq/fulUgHBiu4czso92 3g4by10vvRltJTXnJbPwTk3/9TjVHzrtxzsq6R+Ltg2dkSiA9nxOTmD+Ck4LLTUgWLr0 UBROpO7L0QCbPqbnsmKQzVYWDrb6iRqDRG9LR1HF6BJjlawgwyiV9IXN9/M95/JxEYdH ba8AWJ1yGrsLc3xCWAfjF70z/GgZbBqn42N4nvkCmfkKDxQvbjC89b+geXKjMKyueQgX OOtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764583226; x=1765188026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Ib0drqFrjnDrbAYTSSfxv4es9CvzBMVOslQd6EXaRk=; b=B88WgYesiCcXuJ7lKuri5i9fGMmmVoUf1v6+1DxFmy8vrzwOqs6r/2xRISw55bqIyU c+gl3vtEjhKms4WGdc9aCTuk3xDX/wKeBbmQW+5ZOjGjOWDb84HL099yVvfPERE+dQ6c bX/dYM46cxbuLlG7M2VTd/Mt9IaqaYi9B/BYW2i9pwEVsdBuaSobYOFjdHcXKE6xUsRW grVoxelBI7p1sfCT2vbaWKYoKVHNmSqMuLZoy7YGrhAX5rXfdwLo8yLqZpBLtSDlWHVA w8P/D0E4qRkQrFfyt+n+fKVxpK8C6ju4YjXH06rOBcpQXPeHT+bf4MUMxsYUxzrXRRj5 7NIQ== X-Forwarded-Encrypted: i=1; AJvYcCWisQv1rh5IZun8Jfvxl/q6sCiQtNFxwNsoA/FKW4QzmTJUXgQyeo0IlbGHv7H9mWP1AVtJ575kvochC7Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5cBxKhxQiayoPc5ofGEogtZFmW+W+Z7+0/kWb6Vyd1g+64vKi 73Ne5GaR5neCdbEhcZddxsCr2LdWr82FKk1DZNZbi6d8xfw2n1xNg2lm9ihiEymHW4IzjqC96sI KyUsn X-Gm-Gg: ASbGncv/ga8iFwCiZjXg30WFDLAIEMCEe5Lfjsf6dBgLT8B4Eh8O2OxFwbhtmw9pF/X 59RjozqW2g7BryZbeNWjdf//3nrJRFQ6PtfwNwS0FaLGtuM/bzRiXRAAIqJ+LcVHfxxb/0ahBPO ht4cEqKJZOlX8BaIvtAVZsB0tIRDQpQsqxS1XY9bcMicYs6NnThcdQadLn2KGIIRYWsRDVcj5DU mmTh5G9Fe9QVQ9aH8pQWVRwjtAgmhi96xbeMyEkEbGDB+pFGl9j1ciY2VuadVBa08KGGe84ZClK X7lXYtYggstXGtXo6CchbTqB4s1l3BBN4YSZQKIYcs+pnFR5UGje+jlsV9JG5f9ELhONvp4ZPlw lUW6RAAcvJosoh54SekuZqIQOd+ubOwG2XQTSIEr3WMKMUvtYSIEbSFA+xSN1iWmnuMY= X-Google-Smtp-Source: AGHT+IHC478PO3CBUR5BJC5WOGgav4Icn/Pzk7/d7NpV1ZUnrHGzUJIvyLPUE9PiVEdjfFEhOsXrTA== X-Received: by 2002:a17:907:3e1a:b0:b73:8b7f:8c48 with SMTP id a640c23a62f3a-b76716955b4mr3856310966b.37.1764583226234; Mon, 01 Dec 2025 02:00:26 -0800 (PST) Received: from localhost ([151.35.151.28]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59a63dfsm1143505566b.37.2025.12.01.02.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 02:00:25 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 1/9] iio: imu: st_lsm6dsx: fix iio_chan_spec for sensors without event detection Date: Mon, 1 Dec 2025 11:00:10 +0100 Message-Id: <20251201100018.426749-2-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251201100018.426749-1-flavra@baylibre.com> References: <20251201100018.426749-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2615; i=flavra@baylibre.com; h=from:subject; bh=Xb/mqp4+YwITWlbn8v8dEwFHqYPu9zYkndT2tCfzi90=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpLWb3b7PSvMCE4FL2AoX2G7rJWV6MWZPzu6uCj zuR4kzIvpiJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaS1m9wAKCRDt8TtzzpQ2 X6tGDACcRTAVsUnFhiTu4Fo7AEW9fUiqYY8H1hpQUXLtQq+tYt9Y//j7NarFeqPN31hJXx06fkr OQDGV6jXDsMz0GzaJBkn/Jx70XLEFQwdyY3+fQFTXSyWlGi0wrqWnrvSi0ueSzW6DSLwAQffPJk WVnGE4A4FMdZWuflwuh0gzp6PXrMfNj8qrrMEuSzqp1jN8heS0YLORGUKAhRVKVQezOn6L+ezm4 nT0PWB8Yz2lqV6YfLa/BA4AIMhxdMEBjxtB1tq4Y3Hj53QuhLQrvp2te2Ird0nRQyRGvOh0tsp2 kaj+sQPcfCdZGWerIK2phhh4n4i5lKUxCxxYZkFXLCCOklHDf+Qbr7TVP/FwwEHYBhSNCvdKkLS TNH8A2ffJ/zZTsfYMq9lNtfD09eLZWunc6YbHByEHJmQhSQN0u8zOh9qRiNLz0efLPYYaToD2a8 X8SI/2Xa7dyo55fmd9hPUmdoAtqlgjYNL1dEauh6K8E7+sCwQ+JW08Bu11sIMJjZaTOIQ= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The st_lsm6dsx_acc_channels array of struct iio_chan_spec has a non-NULL event_spec field, indicating support for IIO events. However, event detection is not supported for all sensors, and if userspace tries to configure accelerometer wakeup events on a sensor device that does not support them (e.g. LSM6DS0), st_lsm6dsx_write_event() dereferences a NULL pointer when trying to write to the wakeup register. Define an additional struct iio_chan_spec array whose members have a NULL event_spec field, and use this array instead of st_lsm6dsx_acc_channels for sensors without event detection capability. Fixes: b5969abfa8b8 ("iio: imu: st_lsm6dsx: add motion events") Signed-off-by: Francesco Lavra Reviewed-by: Andy Shevchenko Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index 216160549b5a..a09df9d772dd 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -103,6 +103,13 @@ static const struct iio_chan_spec st_lsm6dsx_acc_chann= els[] =3D { IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 +static const struct iio_chan_spec st_lsm6ds0_acc_channels[] =3D { + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x28, IIO_MOD_X, 0), + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2a, IIO_MOD_Y, 1), + ST_LSM6DSX_CHANNEL(IIO_ACCEL, 0x2c, IIO_MOD_Z, 2), + IIO_CHAN_SOFT_TIMESTAMP(3), +}; + static const struct iio_chan_spec st_lsm6dsx_gyro_channels[] =3D { ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x22, IIO_MOD_X, 0), ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x24, IIO_MOD_Y, 1), @@ -144,8 +151,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sens= or_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6ds0_acc_channels, + .len =3D ARRAY_SIZE(st_lsm6ds0_acc_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6ds0_gyro_channels, @@ -1445,8 +1452,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_se= nsor_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6ds0_acc_channels, + .len =3D ARRAY_SIZE(st_lsm6ds0_acc_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6dsx_gyro_channels, --=20 2.39.5