From nobody Mon Dec 1 22:05:46 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788DC3054D2 for ; Mon, 1 Dec 2025 10:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764583251; cv=none; b=DU7FzR4mhJpiQywRnCMAafD32xqgIaIe7qKxOnlMyDETGhsonwzM3zzxlWtPpw0DkA8mbD5lBguZV1Rnyqfx8MPlnwkpU1VreccyQuMlxtSLeReg29zsUgAnzsosuZCWJnWoXHrxdzx3dzl7TNVasS1Q1eD72jqpEVoqA1NEWh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764583251; c=relaxed/simple; bh=3AqaMzAo/SdteHE5mpmxKXza3NAKzUzx2yzL4sMysqg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LnDvXN+fSabkGo31tqEokkX5fIohMVorNcq0ydE0W15ymrKk/2AlJ1cVbgJ1rwCLd4huMkDw79Las5iW4vw/fx1Bcbqyspa3XJG75POD8diFANNZegmG1tyfi3z4N+EjrdPWNNJTo9hJFuQWlRSFPdqDkhn2nbln5ZLvLMUHdrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=iyZLJA2t; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="iyZLJA2t" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-64074f01a6eso7170474a12.2 for ; Mon, 01 Dec 2025 02:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764583248; x=1765188048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9/G8mYUOngTogtLwRSsvnDIX3G5P9ST+QdTt2B0Gx9Y=; b=iyZLJA2t6gQ2WNxkkWNT3Oy07bqnFruSK+mlGj/iM1cv5oVoPds83FupSLBhjkCFEM fT91cAtAfEeDBBZsnj1DYrsCj6LIGURsZqGpTcaz5axd0JeC2oehDlD2Jaq+sxYszJkY HmlWsSAe0fxkbHJ/RXaXvCpLtWB5MQz+IU96C9lEBvl1IDqEVtwWDgGL1hwqhoJBtUuU kzyjw4KHCyVJ5scFz9UyvIclcAI1rOSAIh2xH61RlDmuy0rreJ47/9GSJ74xh9R4DYQO Wa9laNn06i6s051egwbIsae6fIVW9i1hYTcm/3DE8o8xSbJR95idckwB+NzufUNhqCNb H8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764583248; x=1765188048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9/G8mYUOngTogtLwRSsvnDIX3G5P9ST+QdTt2B0Gx9Y=; b=xGsWLQUE34qN3yjfAAvxTo9Uety3sNxonoM6yGNovqNwqpOWPtgqyHdvMKI7IU5f6M nQaAGc5UnFNpwrsUOSvhQ/GRAJAlz1XAu9sUq5s0TLdYjTmf21Je7trUkBumsvCAQA6Q sBINp6kSgxx+n8gdbFnfbKcWkogaVBPzi+aLMtakrorkHo1yz406ZnAJU+EreERbb1c2 hsD/d8wvbgO2B4lz9ND3DQKS6F3vjXhhM0fnSDOGcqZ1w9AfGQfYb4SDiz0yQSk83zZt i/+WCWQzxQwOnWEOpU/G3sHV+VAhT2OYDuwwVAEyC1iHNHTMUS8thb4uUI/MdPIEEt7o I5rQ== X-Forwarded-Encrypted: i=1; AJvYcCW0n2AhPtv69/fVT/wBPtHU7OW+NhtyJUucxCHSwJ2rPhPGOyS5h5/wW8qywdkRnkwNqm+V8VG7/ohORlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwlGuiAB1IpFG+FdesxgpEd47mnhuUrWQR8NzbaCKApGnuzCOHq hzLyHMlluCaTGAAUvr42jo5YD3fMIm1OBt5k1dyiRTc7Au7R9dcAVQBVaiMiRBkUBy4= X-Gm-Gg: ASbGncsIjBVDR72Gz6Y15Xpqil5OUUP3ZbBLosCvP7Rkv5AT6XisWee3cZO2V/E+8pM tQdmOhJLo46fMJowuuIB+LcQppOqMgDwOO7cuqLHoYfKzSSbz+gkq55x7F0Fm7A0q1w69ye4c03 PpFNWhOiZfO4tY57dD9SEHf4fJlyHXRrptE8TAlwMw2sWDHfpd0eOw668lY0x1PN7Un8EOc/54X GgRRaTAzlWsS4ntHepviVHaVKjfT/lrtBT070rZtzBFivmdOXbopAMOpl9ivKKzcVzYvVIt3Enq hOeSgOi6qsC8kzlBdBfhCYE/rXWjq3fPUygq/clsxlwCyJw4iHP7fFrPMVYhqnJmA+x0jwpD92h WAOoaF4+CWduOZqQVWWorczjwUlZPCLUBoQp8TzdGy6LSXuoy80a/HBFy X-Google-Smtp-Source: AGHT+IGthK7Ty7J1t2xmMgR2lsVCeQrT3yEG/RN8BxEQ059Av5b9KH09w+Gv6NVNxv95SdHGMgRmNg== X-Received: by 2002:a17:906:9fc6:b0:b76:3599:649e with SMTP id a640c23a62f3a-b767168e416mr3364388566b.11.1764583247805; Mon, 01 Dec 2025 02:00:47 -0800 (PST) Received: from localhost ([151.35.151.28]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59aea78sm1139206766b.36.2025.12.01.02.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 02:00:47 -0800 (PST) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 9/9] iio: imu: st_lsm6dsx: add tap event detection Date: Mon, 1 Dec 2025 11:00:18 +0100 Message-Id: <20251201100018.426749-10-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251201100018.426749-1-flavra@baylibre.com> References: <20251201100018.426749-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4582; i=flavra@baylibre.com; h=from:subject; bh=3AqaMzAo/SdteHE5mpmxKXza3NAKzUzx2yzL4sMysqg=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBpLWb7TTjJL6EHV7uldI7M8K5+O6aAHfDEcn0lg j5nmvAKlc+JAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaS1m+wAKCRDt8TtzzpQ2 XymQC/4nfpZDOY4Lk08dRDTOaBdnFI8xracqk8/m1uisl9mKmcS0eJE/64gq7UMg3lpxhr1grY6 kbsmcp/uRvYcvmQOvvBZHhTwIOlHDjWT4kvSAKpzuo2yeg+Skz/Q2wcXy3T5HGHeFERCvnX+AjS yG5iLyW4eTKitLCqVeRexLnWYtXeg+l+iZ46RMA9tO6YwQBmcs3q7R+w8/emMRLmFOMfecwt3YZ KpUUddmYXgjTupX55TwlARIPp187LVs9vV7c0eiX1TXeeZMw0YFW0CKsJrY+jiSWmPfrb8QeXMC b/dIY/LxLn2t2jp1PvZ3lExH3+YQOR6uCOiKkNlg95ikYK661+tallecLEldUAql2TikYzKDzNF Y1KUmxAEjXkfTJUOI6vEXnK3rHpElj2TwuNmKYaSlZPKDAABT5wpV37lIvcy2HmCwAPXRkeOmJA qs9U7nrujdU/Dwi15p/pjPlsM9PjYpNTfuxZywKrWlrw0lC32oyntVBs8JPH+Nvxlx3XQ= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In order to allow sensors to advertise tap event capability and report tap events, define a new struct iio_event_spec array that includes a tap event spec, and a new struct iio_chan_spec array that references the new iio_event_spec array; for the LSM6DSV chip family, use the new iio_chan_spec array and define an event source for tap events. Tested on LSMDSV16X. Signed-off-by: Francesco Lavra Reviewed-by: Andy Shevchenko Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 1 + drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 57 +++++++++++++++++++- 2 files changed, 56 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_l= sm6dsx/st_lsm6dsx.h index 3edff8456a8f..957dae73e13d 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -245,6 +245,7 @@ struct st_lsm6dsx_shub_settings { =20 enum st_lsm6dsx_event_id { ST_LSM6DSX_EVENT_WAKEUP, + ST_LSM6DSX_EVENT_TAP, ST_LSM6DSX_EVENT_MAX }; =20 diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index 04a3c65d4546..e99556ccacd4 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -105,6 +105,21 @@ static const struct iio_event_spec st_lsm6dsx_ev_motio= n[] =3D { }, }; =20 +static const struct iio_event_spec st_lsm6dsx_ev_motion_tap[] =3D { + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_EITHER, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_ENABLE), + }, + { + .type =3D IIO_EV_TYPE_GESTURE, + .dir =3D IIO_EV_DIR_SINGLETAP, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_ENABLE), + }, +}; + static const struct iio_chan_spec st_lsm6dsx_acc_channels[] =3D { ST_LSM6DSX_CHANNEL_ACC(0x28, IIO_MOD_X, 0, st_lsm6dsx_ev_motion), ST_LSM6DSX_CHANNEL_ACC(0x2a, IIO_MOD_Y, 1, st_lsm6dsx_ev_motion), @@ -119,6 +134,13 @@ static const struct iio_chan_spec st_lsm6ds0_acc_chann= els[] =3D { IIO_CHAN_SOFT_TIMESTAMP(3), }; =20 +static const struct iio_chan_spec st_lsm6dsx_acc_tap_channels[] =3D { + ST_LSM6DSX_CHANNEL_ACC(0x28, IIO_MOD_X, 0, st_lsm6dsx_ev_motion_tap), + ST_LSM6DSX_CHANNEL_ACC(0x2a, IIO_MOD_Y, 1, st_lsm6dsx_ev_motion_tap), + ST_LSM6DSX_CHANNEL_ACC(0x2c, IIO_MOD_Z, 2, st_lsm6dsx_ev_motion_tap), + IIO_CHAN_SOFT_TIMESTAMP(3), +}; + static const struct iio_chan_spec st_lsm6dsx_gyro_channels[] =3D { ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x22, IIO_MOD_X, 0), ST_LSM6DSX_CHANNEL(IIO_ANGL_VEL, 0x24, IIO_MOD_Y, 1), @@ -1260,8 +1282,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_se= nsor_settings[] =3D { }, .channels =3D { [ST_LSM6DSX_ID_ACC] =3D { - .chan =3D st_lsm6dsx_acc_channels, - .len =3D ARRAY_SIZE(st_lsm6dsx_acc_channels), + .chan =3D st_lsm6dsx_acc_tap_channels, + .len =3D ARRAY_SIZE(st_lsm6dsx_acc_tap_channels), }, [ST_LSM6DSX_ID_GYRO] =3D { .chan =3D st_lsm6dsx_gyro_channels, @@ -1438,6 +1460,32 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_s= ensor_settings[] =3D { .status_y_mask =3D BIT(1), .status_x_mask =3D BIT(2), }, + [ST_LSM6DSX_EVENT_TAP] =3D { + .x_value =3D { + .addr =3D 0x57, + .mask =3D GENMASK(4, 0), + }, + .y_value =3D { + .addr =3D 0x58, + .mask =3D GENMASK(4, 0), + }, + .z_value =3D { + .addr =3D 0x59, + .mask =3D GENMASK(4, 0), + }, + .enable_mask =3D BIT(6), + .enable_axis_reg =3D 0x56, + .enable_x_mask =3D BIT(3), + .enable_y_mask =3D BIT(2), + .enable_z_mask =3D BIT(1), + .status =3D { + .addr =3D 0x46, + .mask =3D BIT(5), + }, + .status_x_mask =3D BIT(2), + .status_y_mask =3D BIT(1), + .status_z_mask =3D BIT(0), + }, }, }, }, @@ -1952,6 +2000,8 @@ st_lsm6dsx_get_event_id(enum iio_event_type type) switch (type) { case IIO_EV_TYPE_THRESH: return ST_LSM6DSX_EVENT_WAKEUP; + case IIO_EV_TYPE_GESTURE: + return ST_LSM6DSX_EVENT_TAP; default: return ST_LSM6DSX_EVENT_MAX; } @@ -2620,6 +2670,9 @@ static bool st_lsm6dsx_report_motion_event(struct st_= lsm6dsx_hw *hw) events_found =3D st_lsm6dsx_report_events(hw, ST_LSM6DSX_EVENT_WAKEUP, IIO_EV_TYPE_THRESH, IIO_EV_DIR_EITHER); + events_found |=3D st_lsm6dsx_report_events(hw, ST_LSM6DSX_EVENT_TAP, + IIO_EV_TYPE_GESTURE, + IIO_EV_DIR_SINGLETAP); =20 return events_found; } --=20 2.39.5