From nobody Mon Dec 1 21:30:58 2025 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C01302CA6 for ; Mon, 1 Dec 2025 09:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764582764; cv=none; b=DWz9Ua7hNIbgwC8djVMluB+xwomUSFtI7Q5LJX1dODSIdveRq7QWHgnySpgplG8MF4So6evy36Ovi79sz1V+6NIe/E1wq8AmfTfH1cwIzansd7NUegqBkzJDexWlYskbTbvmRat+8qp+w4dViYMtpVLsbUisCrwWIRycMoZHmGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764582764; c=relaxed/simple; bh=zZ4uahyRAA8rsS343WPAmxBYVvoK8T4deCapwX4YkhU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IM2lY/bApBbgxJtnp5gmQnugqiVCMg+LVU6aX1AHiwuh/+EIpX5ys1HrL2KwBLqmWaYPhsRFukNkcNoUZ9co9QJQ2hpvOgLl5WRIReayLkqAWnDJZCfRhVyDVS5nEmjBF4aL5nFujygHftVV7CijKWQ+DA4KS6BV6NNdllGFl98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fAU2o4Tk; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fAU2o4Tk" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7baf61be569so4690146b3a.3 for ; Mon, 01 Dec 2025 01:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764582762; x=1765187562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+rjHsH8Bx/+IHKZLfcoDmpiz05m3E/CkK2Bfpjlnb+o=; b=fAU2o4TkPMCEcmDeIpEGofOBTbYwAWsQjw78Mdy02fOFmR+MYLzBi5eD63+RHnMpvW 7RA8ZxThknU7ku1oBgmluDrlZbN2P1a3/1keJXmwSXajo1IMeLlMYvwoXd2t5k1i+KAA BPgbtOFFuG6lxfMqjysUVOjmbHWU4G25BcTcQwLe3ilCw1sz91MebNnOhDHXy0WR5AjU T92+JfMAH3z2fCViJj4MNYZuEz/RWd8wz+eWDCK3xh82k+ImvYru/sNrGSTnxB4LCirh EtLV+tSVH2Qlfc2Pg83LsQydYz1B56uk1GWejDIlAanzvqC7bjm81a3RAzJh229jIqVp LARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764582762; x=1765187562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rjHsH8Bx/+IHKZLfcoDmpiz05m3E/CkK2Bfpjlnb+o=; b=mEE1uuJC5OG3GIxGMYMCdbT3IlBJa1cy3Mfcjv8thMgPRaRk4fRa4ZqGtifEBe2mre 6SQQ0o1QfbiqjdrDildy7FND62Jr+lbiTVdPkv8Opzb0GmHplIlslo2ZsifdejqbuYPw lFI/wpG4wY7hxVJwQLqtBboB/IE9UwDKqnY421dVtoPTEXbjiuVzninZuVRsq/GBtmT7 TEwV4DnLfok9aTtGJ4sJJGihdsDU/+iJJ/KZbcd+xEmgMYKRAClbHSIiLQ+HW2h6TGGr LxnFMKHjiYtEyzg99/ZvMcJgt1FpiCxaatTJSeIwnCd9wViCYTXMBNVJkAzejUrqKjHo zAXg== X-Forwarded-Encrypted: i=1; AJvYcCUNVw9H8WVpSCa9VXO3+c7ePyDIlZ/JLUH7pbOA/qE8c7DrGzLT9uiC0Xz05vYJVpMnPxEj42dszGDK21Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwKtsjgS5RgNpnLlpMxDOQSRZmAeWnEvVw1IzH61OoX/6Y3FuEA SII7xgs48BA/1yLKmfn3sluXHfns0epwv6IEjXUiPKLEXaDz0/VPHOpO X-Gm-Gg: ASbGncvjxchkD/SOWH7vTIXqYra99dm5IpAxns+bjQQWybD8mB8AZth9cfpgqBfYF0H C9WUboslhlDlvAnCfolFSL+KlfHpbkKeyubEt52DOAw7GwfVs5o/CLlGmt2xXUt/EeXBzN6zB5Y 1NTZMrNI03J58qS+OnWpS3lOZUznB08r9JBuo1apS3W5IzwtMJtYFtNESdXADUg/Ta6RTuWsffa Dj3sC1DVir48LzyHZNR0uM93EDK9ktefun9tW8HOpMAauvTS3wUqcedqHNuldEGNZgTaocgDjoc KDMm3Dm249WQSYg9H5UE8HRRBBltNeQ4cOj9jb1C9pHCefcGDypUmv+3vABkHo1zqT8AVMqlEQo EVQcT7jo7dU7fOYue1JbBvnldNJ6PJB4S4y2iDh0lFb2YvoJCUCElmK95isudFx343blbfSP0PJ 2N6WsNKh39B0TAn0WS5I0E9zQ6IcgKS1jqQPLkwBkjPxK0Ef5JHtbhv3XrgG5lw0Scrx3OzNgq+ I6CEVg+u2JvvQXUci+SmY8E X-Google-Smtp-Source: AGHT+IF3WOvTGIxt+bSrODAhW9gVIWO5Fy6ov3TQKRAk9K4oppyhq2XbWwPpQleVzVUFv59vmr2h9Q== X-Received: by 2002:a05:6a20:734f:b0:35c:fd6d:b1f0 with SMTP id adf61e73a8af0-36150f25276mr44107506637.40.1764582762153; Mon, 01 Dec 2025 01:52:42 -0800 (PST) Received: from visitorckw-work01.c.googlers.com.com (14.250.194.35.bc.googleusercontent.com. [35.194.250.14]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm11776408a12.3.2025.12.01.01.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 01:52:41 -0800 (PST) From: Kuan-Wei Chiu To: suzuki.poulose@arm.com Cc: mike.leach@linaro.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, leo.yan@arm.com, Al.Grant@arm.com, jserv@ccns.ncku.edu.tw, marscheng@google.com, ericchancf@google.com, milesjiang@google.com, nickpan@google.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kuan-Wei Chiu Subject: [PATCH v2] coresight: etm3x: Fix cntr_val_show() to match cntr_val_store() behavior Date: Mon, 1 Dec 2025 09:52:28 +0000 Message-ID: <20251201095228.1905489-1-visitorckw@gmail.com> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cntr_val_show() function was intended to print the values of all counters using a loop. However, due to a buffer overwrite issue with sprintf(), it effectively only displayed the value of the last counter. The companion function, cntr_val_store(), allows users to modify a specific counter selected by 'cntr_idx'. To maintain consistency between read and write operations and to align with the ETM4x driver behavior, modify cntr_val_show() to report only the value of the currently selected counter. This change removes the loop and the "counter %d:" prefix, printing only the hexadecimal value. It also adopts sysfs_emit() for standard sysfs output formatting. Fixes: a939fc5a71ad ("coresight-etm: add CoreSight ETM/PTM driver") Signed-off-by: Kuan-Wei Chiu --- Build test only. Changes in v2: - Redesigned the fix to match cntr_val_store() logic (display only the currently selected counter) instead of attempting to list all counters. - Removed the loop and the "counter %d:" prefix. - Switched from sprintf() to sysfs_emit(). - Refactored control flow to use a single return point. v1: https://lore.kernel.org/lkml/20251121002350.1166758-1-visitorckw@gmail.= com/ .../hwtracing/coresight/coresight-etm3x-sysfs.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/= hwtracing/coresight/coresight-etm3x-sysfs.c index 762109307b86..a6a650331196 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c @@ -717,26 +717,19 @@ static DEVICE_ATTR_RW(cntr_rld_event); static ssize_t cntr_val_show(struct device *dev, struct device_attribute *attr, char *buf) { - int i, ret =3D 0; u32 val; struct etm_drvdata *drvdata =3D dev_get_drvdata(dev->parent); struct etm_config *config =3D &drvdata->config; =20 if (!coresight_get_mode(drvdata->csdev)) { spin_lock(&drvdata->spinlock); - for (i =3D 0; i < drvdata->nr_cntr; i++) - ret +=3D sprintf(buf, "counter %d: %x\n", - i, config->cntr_val[i]); + val =3D config->cntr_val[config->cntr_idx]; spin_unlock(&drvdata->spinlock); - return ret; - } - - for (i =3D 0; i < drvdata->nr_cntr; i++) { - val =3D etm_readl(drvdata, ETMCNTVRn(i)); - ret +=3D sprintf(buf, "counter %d: %x\n", i, val); + } else { + val =3D etm_readl(drvdata, ETMCNTVRn(config->cntr_idx)); } =20 - return ret; + return sysfs_emit(buf, "%x\n", val); } =20 static ssize_t cntr_val_store(struct device *dev, --=20 2.52.0.487.g5c8c507ade-goog