From nobody Mon Dec 1 22:05:59 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49C673002C5 for ; Mon, 1 Dec 2025 09:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764580398; cv=none; b=g/1Kr2QwDxAsHdILqKwlAAKM/y6exjLGSDysWZWFtMVQPWSbTnNh3s2rNC6UivraiYjjvLbVxhXmj7i0dzs390cmy/ft3cCW/z5JlahDoz9Z/u0dMWryL4UU+FNSVH0waOrLJrgpoTtF+iFEEaqaTTY3s6jTyTmipuywNf7+iWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764580398; c=relaxed/simple; bh=4TjgOClD9MZ3bpoMuNewJ2AXb9TzO5tUug3pj3x8AyM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J3Xyu7sjBK/7jUjTN9NM0bsnoHeV9Er1hL/NWrWbRp0fWTRqMpylZ9EKUSOlrSN9peow2paR3NAJfolCnp6T9Pvs/JP2ZyOG5doX51CXeVXdcWP+UJ6sgD6261CwDi6Wk9FrrtMD+crM3zcK7cxxFvsZFsiMaYMJwMUVwFhhs5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CN9KPChi; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CN9KPChi" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso39944175e9.0 for ; Mon, 01 Dec 2025 01:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764580394; x=1765185194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8fl5Pg9Y8yiY67LalwVtDEwtUsWcIOn3WvNZLWDGeNc=; b=CN9KPChiN1kflbaNNFcVeVPa8NfnnGadZtOe0c6e4bn17kXeN2w4EKsS4fOnGCN4YQ hrcklGLtc/i44+pZUMqyDXeobE8mzbkLEmEkW1twCYlpur8U3xK4qVOcB6VI34olzusm ahzuj04ChhGyr07/IFudNhHhH8C/cDjElMtDPOHPUzp9K+5pAHn0XJPdcs9u2vhkW/+R VxpE/scU+ueUUwTb8MQDrTu2yQwmDjSbQdrwdTqcvJgsKzEk3Vbw+oaFcRpCM00X8FWY V6EYlLXy39cOpi/ksgLyFVge2/Zie6/c9kADOH43XfrETZMOo5M3I3/9DluNiNW3ewWw bfEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764580394; x=1765185194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8fl5Pg9Y8yiY67LalwVtDEwtUsWcIOn3WvNZLWDGeNc=; b=DxML8DTQlmcUAEZwh8j92yD6uc45tTje1Db+ltLDcYvTkXVI/JDwJNTjlaNTZsP1kp BgFNURCXfzbsz7u/QRQ5uuQLDjBc7pQZRmhAMYLURlJbuK3sJf4cwVbYYaJ1APQJ1125 sj6JX9+2obaUpMXpMD/FNnHQNWcXccJbPSC4YZUbs0VtepB+QN9Y3+kAI1kROs9y0l1P 7T3yoTvDF/8rzzq+iD/WrT2CXGSzBY+k+mWMplDsESulMTUp9Z80c40X8EeDcd+13Bx0 suAa7a7AKND584/sf9wBx+88XQeNyQeKqstheaYS9G4ZnU2R++IgnytvXHMVUwSOlbfv 8kGQ== X-Forwarded-Encrypted: i=1; AJvYcCWWJZr19q3ITz+gzG+7trJpyYUcOmw+AbGZazWSLBuKVPF3OXMudLZMXY6dwQO++opWSJt5ERnPQ4p01S4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6hOGnG+iPE+Cka4icIsy/Fi8xtSY1fkCvPdl7V7CNg3Mm0eCm 5601fsDFWpyA4yBPOoao5Xzq92LqFlONCdxOB91L2EA/KjyVtAPEX8v2giURDGcsvqQ= X-Gm-Gg: ASbGncuVoPgjXMpi9hZ7xX+Vk7jCbCEkiZLjoUR9wbjX0nvi7EoR1VFSB18WPTKsN1y 7QzRCrrgNJKGzNUjl8S/4VQkifIKQJAtK86XInIwu14n8GLt15EzN1xkSZ5uNQPmLxWDpNiBvux cEi6PzwxMfwwZowin0BCghF19rJpjU25LBCfFPhSIUqJpFstxlrHaL9gAcARezXxqvgMo+IHZ+B lAnn6soW2qCc5KpHBWuTkvQfUgrQ4k2PSFCES7bLcMoHsQW/7bfRk6uvjYZmuUgeh9hz7VBRRdw BMfFZsRKGbQKYajSTuQzOx7mRioIU/h0GRJQpijdMBv9/JFd0pnZiV61FDJhXjLDztRMAcIoMEM fxZoTN0kIIFEup3cNyvT24mkxxqRJuBCf096EQkOyAIn0Q0qpcSDbLqOcisKoM8PbSOavAuFwDK J6bJ4DrhFLWyNwHkYNAvg= X-Google-Smtp-Source: AGHT+IHo7/kZSUWNFwyzin4Mrz7uGa1uyn/rEhoKmv9Y3WFoT0OloGB+9YngizrzX1dTqMMe/edb4A== X-Received: by 2002:a05:6000:2906:b0:42b:41d3:daf1 with SMTP id ffacd0b85a97d-42cc1d1965amr42404387f8f.38.1764580394544; Mon, 01 Dec 2025 01:13:14 -0800 (PST) Received: from vingu-cube.. ([2a01:e0a:f:6020:77d1:da59:4ce1:741c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1caa767dsm25344110f8f.38.2025.12.01.01.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 01:13:13 -0800 (PST) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, pierre.gondois@arm.com, kprateek.nayak@amd.com Cc: qyousef@layalina.io, hongyan.xia2@arm.com, christian.loehle@arm.com, luis.machado@arm.com, Vincent Guittot Subject: [PATCH 2/6 v7] sched/fair: Update overutilized detection Date: Mon, 1 Dec 2025 10:13:04 +0100 Message-ID: <20251201091308.761711-3-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251201091308.761711-1-vincent.guittot@linaro.org> References: <20251201091308.761711-1-vincent.guittot@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Checking uclamp_min is useless and counterproductive for overutilized state as misfit can now happen without being in overutilized state Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b10f04715251..f430ec890b72 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6785,16 +6785,15 @@ static inline void hrtick_update(struct rq *rq) =20 static inline bool cpu_overutilized(int cpu) { - unsigned long rq_util_min, rq_util_max; + unsigned long rq_util_max; =20 if (!sched_energy_enabled()) return false; =20 - rq_util_min =3D uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); rq_util_max =3D uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); =20 /* Return true only if the utilization doesn't fit CPU's capacity */ - return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu); + return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu); } =20 /* --=20 2.43.0