From nobody Mon Dec 1 22:02:39 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FCC2FF65D for ; Mon, 1 Dec 2025 09:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764579907; cv=none; b=U/VAmLEIOSWzKVbG+MzJx7NPU5EOwHSzeUy4DqXCaWYKKIMtKcPpAI3iTirO1dQBZSCts7Zxp4c0IWYYEhZBmwuI+Wnof1uHeHtm4k2EfK72OcNpgT2UVR59DLNyNS966/i7/4oThmGeX+CPczRT4t6Wlj3QugzKnIWxL3Ecvl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764579907; c=relaxed/simple; bh=9o7pMGLR+wHFQD17nhkv0K8NYO8+CXCbWzvTdLvv3IA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Zp4/NJDfkG6n1+AqIAKdRvi6daNCccXiUjbHokYoitFgQgMI9zpv4vpeHjQarnTgJRWluePbvqCkWsvG/5sb3dWxvzG8WXeFTlh82Otm5mrdMyWqoH0EWXAFBrBF6eiAi9FIzgIy1EYWeZ/D6c3nIl6qiaU03v3Qg4oppcb4alQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vhl5GEBa; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vhl5GEBa" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7bf0ad0cb87so4727421b3a.2 for ; Mon, 01 Dec 2025 01:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764579904; x=1765184704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aw316iKTX/2VGJbIgc6JIwbU4eBfsa9UZDP5Ykz1NQ8=; b=Vhl5GEBa/6ceMPeelPbR6icywBTHZ0JJO6fJqxpJzIO/diC4ORggfcoswFxs5vsOIW GAxx9OV4MCvj3sWngrfu2LeSS3yzdvZxnaEZGgVa58E++ecYOwBnXomQK2yc7UYJMoz2 82AZAuHRCIAMoa6uXMxkRsZgaoAqrfKbZ30T3XgmpUpMRlrZDi9bsZBd0jL38v5H1CUy FTTzWNaZiwYy/6wMYsDqGDyWPgXpY7qsVAcb5bR4ij73OW2EJM/xN0gLW9BrHJr/hYkF GC7HlFyjgg8qUr7VfOMLsHJvP+pUtGJOV7YgpA2EbVp4QWhMdA5kIiGdX5rWRlQATsbw J19Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764579904; x=1765184704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aw316iKTX/2VGJbIgc6JIwbU4eBfsa9UZDP5Ykz1NQ8=; b=w0pZslUeowLo1ZWdkYtkm5o/Y+vFSJzTQbAjWxiuU9HsiOmnm5PyBrCZ3dYg7FuNdB sz2kgP3m87TGJf2zGlur9bUw69FPJeKoWUHsWMMUs0wQLAL2EGwIgrQvKip4j/3BRART JGi39Di1UYEpRqQAriTr5g85jm0XZOUjmyxkFN+VnKAcRZiS1cAcs/Mu2VR1Ph/2w1++ FD1FVNUhxMPV7mm/JEctHZapsuYi4xSwVk77AKweJhHK2e9PhbvQN/AwYaqwc+SP1qym ebXnph4etIiBS7tUuEJ/llM0dq+/IlXhIwatGviyrrdplzWNM1jK0MreD5o8kuS1RChD gUrQ== X-Forwarded-Encrypted: i=1; AJvYcCVKhz6TXYJUb+VqshB3YTBLJX0vOSNPV6DSQtB51fopRzVnnaoen+pf4e8VYdF+isar0N3lcMdby8j9ORQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyWa46GwMqgTsZOkzfjoRUQguFM84whf8cB/Y9AUp6W4ieKTOtV lqahdtZEOD0XcJ0QT8uqHYeu2Vicf5cD6zf2e5jHOD21BKXUZtNQkF3s X-Gm-Gg: ASbGncttibfoAMpYLyViaxh+VjzzQpkov4LmHRxV/OAQDWKAIf4hGtIqU/cwBXTrvzK jcaF2NWkik7hmgLcK5TIT5q8GmAqvMwcjSoWFkKTUrQ5uTUKIE6u96MJWgnP2UZyC5qvJM9Zpvw kXP1yfXn4lfd0kAjvRqPCVzxAsFNK7eJu8oorYiHuYBGm1l9ojBxy71/SzwcUEf22jyTj+drNFW Cdsu1pfxOtdwNl/DBNSxti8pyOZJXTygIka8bAkShywlP5vykmBdr1KIYkbEsMB9C92vLz29jmX OhM0rHdghMQX6+DMi/b0OPkDyinuyeeL75FxtgqV6xP5TDBQPE0cwIr6E3xoOatTjK0Rm0KzFE/ dOe4FjX3n1TfNp0SLD4sSsG0hzeu4ifzxSu/FSZ4iOdthurfPP5uwpey7v2MXZix2DAyDsgILVm 4R/7cDWQ/2bC2mII/k4s99vwfHPg== X-Google-Smtp-Source: AGHT+IGoGR2vvfoyHhoCGadAIM1tRSK0aixyW3oTcQUZl+ZTkQaaORwlprV0B52obn6Pxd8CCBZOyg== X-Received: by 2002:a05:7022:e80e:b0:119:e569:f624 with SMTP id a92af1059eb24-11c9d84bf9fmr17998389c88.29.1764579903743; Mon, 01 Dec 2025 01:05:03 -0800 (PST) Received: from localhost.localdomain ([104.128.72.44]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcae73bedsm54908307c88.0.2025.12.01.01.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 01:05:03 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com, Christoph Hellwig Subject: [PATCH v4 2/3] block: prohibit calls to bio_chain_endio Date: Mon, 1 Dec 2025 17:04:41 +0800 Message-Id: <20251201090442.2707362-3-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251201090442.2707362-1-zhangshida@kylinos.cn> References: <20251201090442.2707362-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Now that all potential callers of bio_chain_endio have been eliminated, completely prohibit any future calls to this function. Suggested-by: Ming Lei Suggested-by: Andreas Gruenbacher Suggested-by: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Shida Zhang --- block/bio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/bio.c b/block/bio.c index b3a79285c27..1b5e4577f4c 100644 --- a/block/bio.c +++ b/block/bio.c @@ -320,9 +320,13 @@ static struct bio *__bio_chain_endio(struct bio *bio) return parent; } =20 +/** + * This function should only be used as a flag and must never be called. + * If execution reaches here, it indicates a serious programming error. + */ static void bio_chain_endio(struct bio *bio) { - bio_endio(__bio_chain_endio(bio)); + BUG_ON(1); } =20 /** --=20 2.34.1