From nobody Mon Dec 1 22:02:39 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9812FCC16 for ; Mon, 1 Dec 2025 09:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764579902; cv=none; b=Kp+ouiHCKyDKtDG57JvwdkpcXjOdzWnOKbPxtqgXovzAGxAJz4lOA+BnfcnQKLji/LuHEH7SdBz3WCZe2VnMal1Arjj0ggNOQNGMBYYYpmaLhKWsdheo1ygHl6Arsr8gR4GoAH8xOCZX04FU+vGHbFDJgmnKmdb8jkbHzYvPtA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764579902; c=relaxed/simple; bh=JLIdNXPMejF737Jv1xzF5GicNRibkuRDb9iX4pmjoI8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nrapz+CX/+8LMvoC7VdQDlMS1Ze4L9IGv7B+a3RXGzsXrrJm/N5iw8rrjcBhrzuuIfWGkqthqAz72+2xEYqTCkctyT0bjYBvGOE4lKaFJioI/hWrlJGHomy6vW1hXrZDfjAoy18XW1M6d5fMVG2ES+swzyGDRi7r2U3LbXmWtS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nbieNTfq; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nbieNTfq" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-297f35be2ffso58910975ad.2 for ; Mon, 01 Dec 2025 01:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764579900; x=1765184700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=nbieNTfqgJGTlh/GgrhZAIZaBLoZjTBD6ft2QW7Rgu7WMrpzdkJ5NdroTW8N4xGBjg HFw+YJzO7Qw0/Tj4c7AQVPrtPflzgGweYjFVtri7hzymjCSmpw+wvUAv6Jt+lCmCaLad uMEsGfgGnuwvyvt6GWD7MwF4SDOI+CP24OLoVGrYQPRzyk+bO6ZbMnAceFKP1ip7ibP9 0d1vgMJsFcVXJuBLzkOvTQr2fbw6dOW4WcKClu9QV9h5X6uYvs103wmCyEP5J9wRSY7d 9CnHwGQECUKQQs+ATXtFoWZA2sJ7Lytmem/TdoRksgpsHcZZ8blVBQbZUOBJp2IwvYg7 1haw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764579900; x=1765184700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=AjusDYo1+Zt67LNhUfb4YqXF1Yv5g9CRW3b11XDRMhQg+cO+caH96Y65dLX5JueXVV +ub8ygFGfGYD6fHiiws+CpBMbvHJ9xJPt1Bq0Jtb4pBSgoVPkXBZJa0U9bhvfhpX4+lV ukMoy9kVOGKKIDF29copqAPHakpSixX7kNWLWlN3SgluzHdYitRbvcU8+ZrIEYfJ8M6p 4n9sXneCKdtd/7GADKI1sXh5pwFpTRu8HmQAwkq/TnZpCg4FrkvTt8O0wu+HEwArRTJp rrFDZfA4pv6tD0K07TsN5T+cgGilgcEMqbCaOfMWHeio1E+MRH0cisAF8SIyQWotaEs3 lAlA== X-Forwarded-Encrypted: i=1; AJvYcCWW8o8tT9DMUJIXZv0a9FyH3pAaIGIySzPvZSAeAmwaCVgE1KdV+eiZQFku1aL8sgvJIbwL0oFBxYQEnqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzpmG+FnQynhQAmfpWAhzwwcSWy+jzdoK4yZ6JrPJ4ASo7QrcN+ PXjJD6lpfiEzOJvY29KnsUjE7BxBHjoOkN6CpOqH1/lzkG6kiBzMdkOe X-Gm-Gg: ASbGnctxaAq7gDMFIpjco7cLQOw3dHlhmVKyuWbmNk4nkdUNlv7MgqIacSs7Ibs/f/G W9DMeigsSb1rc4dxZKShI29oC20do0k1UxmA1yxg6eBQfbX0Fm8wV4xfg/vJWK4/bvtg8UmGExh pJL6au+buBII1S45VykbW8BMr1k2BbimW3vmQr+Joiu5WOKBpx1UfZewy/2IeIfIgK0/F9zwhiO waSl2m7dEeoVIgNKEUB8bF5ZrL1GmM38rRPdxb00LPIT56dUChWprwAZ6m/Q1jZWQRRM3YoGNiM qLKSgtKYEOtbL3xkvYoEYKbvcydwZhsRfsypTbGnpU/iWSwElVNG7f4GrMczE5qx8oTBObKzwws W+ZfSXlgkv5z5c50yqWShKin6EuQBenA9x0hzZCC498vn/EGTWRirVrwJo7wUj5ONDhz1QeBHnp WBGbJ7hmuckReMs3mkYr0vykBkrQ== X-Google-Smtp-Source: AGHT+IH19AutgiB4q5n1yDQ8ciHD5SRBcvRXU/5QyAJ1UaeK08hADApRcLuj+Gt1810PslIB22fggg== X-Received: by 2002:a05:7022:6885:b0:119:e569:f61e with SMTP id a92af1059eb24-11c9d84bc2amr26089780c88.23.1764579899796; Mon, 01 Dec 2025 01:04:59 -0800 (PST) Received: from localhost.localdomain ([104.128.72.44]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcae73bedsm54908307c88.0.2025.12.01.01.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 01:04:59 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com, colyli@fnnas.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com Subject: [PATCH v4 1/3] bcache: fix improper use of bi_end_io Date: Mon, 1 Dec 2025 17:04:40 +0800 Message-Id: <20251201090442.2707362-2-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251201090442.2707362-1-zhangshida@kylinos.cn> References: <20251201090442.2707362-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Don't call bio->bi_end_io() directly. Use the bio_endio() helper function instead, which handles completion more safely and uniformly. Suggested-by: Christoph Hellwig Signed-off-by: Shida Zhang --- drivers/md/bcache/request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index af345dc6fde..82fdea7dea7 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio) } =20 kfree(ddip); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static void detached_dev_do_request(struct bcache_device *d, struct bio *b= io, @@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, ddip =3D kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); if (!ddip) { bio->bi_status =3D BLK_STS_RESOURCE; - bio->bi_end_io(bio); + bio_endio(bio); return; } =20 @@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, =20 if ((bio_op(bio) =3D=3D REQ_OP_DISCARD) && !bdev_max_discard_sectors(dc->bdev)) - bio->bi_end_io(bio); + detached_dev_end_io(bio); else submit_bio_noacct(bio); } --=20 2.34.1