From nobody Mon Dec 1 22:05:13 2025 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBAD530DEB1 for ; Mon, 1 Dec 2025 12:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591577; cv=none; b=BokXDK1YC3rd3Kvr3B/13s01pyjLPFtp0h0cusWomnZtTJOkWGeXIwXoLqa/acz2fNXLeih/8TBLTS4PIBMqehiSZOjQVF+rGIQROEsTo8Ev23t4akVgZKzF/l5TgYXjuRr8cl0F01QiKpjiOsOa6u/ZQFQjHMkCxsQhaBFL57M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591577; c=relaxed/simple; bh=jcF9TO4w0dmiNuHteMC+0VDVhFz7gX4DbHPqYH+9J6g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bCdtEU0ZdpQjaTYP26oDaMs/crzdmWMrv9SFbX1OIAsU2YC3Jf1/+CIpqXdTL0w4KBHtTaQkAdQXeIjS9MjqrXSo9wwuPO7kJ0y6Jxq+Fq8lgcyjK3SVbWaxpjb3obfdyO5+fZegLHfh7+O1Ky9SXtOFLTDQmIPSOqXUwQ6Y+c0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=RReApWLb; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RReApWLb" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F5091E4B; Mon, 1 Dec 2025 13:17:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764591433; bh=jcF9TO4w0dmiNuHteMC+0VDVhFz7gX4DbHPqYH+9J6g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RReApWLbTyxJWD22y2GmnUUpFn//mnW3Lw5XQQSPkJjXhX0MjW7ZyK22/dOoleXxF /WATlQdgyPgoCEq20Kb5oQ4OSfWmbADvMn4exDHF+bE6zwmN0EVcpkQnN1W67PaonJ aedXBZ5ifx7WIcAl9+M7i/JE91TxFcz90I6SJlBU= From: Tomi Valkeinen Date: Mon, 01 Dec 2025 14:18:49 +0200 Subject: [PATCH v7 07/11] drm: xlnx: zynqmp: Use drm helpers when calculating buffer sizes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-xilinx-formats-v7-7-1e1558adfefc@ideasonboard.com> References: <20251201-xilinx-formats-v7-0-1e1558adfefc@ideasonboard.com> In-Reply-To: <20251201-xilinx-formats-v7-0-1e1558adfefc@ideasonboard.com> To: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Michal Simek Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=jcF9TO4w0dmiNuHteMC+0VDVhFz7gX4DbHPqYH+9J6g=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpLYfEfZmq9rMMb7XREQXrBUQZGI0efqtoepCeJ wCkVIedINeJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaS2HxAAKCRD6PaqMvJYe 9Rz0EAChHd8Sd7lzWnz6AUfj6G7wX/dX1y6uGTNSgk5bKcciyz28xtn2LLNv6cMM0C4XciEdSWt nxhFFaVmZy2wg4EbgpBb8J/3wbzfWr//zpxQ9w4sJAOvTlShR4tr/xmWvTSgUKoD4jKU94BQxhv c96Akpcqrf4LTs7+LX6OtZgs7N9pqlf62KSzjSewUQ6k+SwPO40sriWG8fz29Z/GnVvcPx0xkAA IJEou4DAvC7qzCi4EMGVf0OyQpiyVJk3gGfw/L049lyoDUySVH8fJNxBKP8D932yLkiAA2kLYGk WnJVkMTMWd1c8bJ4XyAAECgYCbcxf4KRBh49bBXvk0eCCvS6NFt0dmrL89hq6TCHcRxGbO2+opJ WNlGE+OsfdvnKguLfOECivp8uYu7m1GFh4pKHBmf4NFKAMWkSRTXX8EOktcVXyOn02P0HTxVn0p g9s/BRikDuwxpOS18YE8tKkWiX7h5jws+8+bFeG76+kntrdFHJcBbBWUbCqO7eHvvES9crqM87C OiE6CbPx2i2i+pYvSvsGBw61hiVOk8TEztAJJRZYUgbqHQfKP7HCXqTMZIRTlYLxmQtMqdbY35s IaVtqIOSwa6WaiHMBANYkAYkt1CZRATwLbrEykUPbrSBJ1agCI0s5XypX4Z4Mvab0lL3tr13LJ3 LHUSeof9GKkEgoA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Use drm helpers, drm_format_info_plane_width(), drm_format_info_plane_height() and drm_format_info_min_pitch() to calculate sizes for the DMA. This cleans up the code, but also makes it possible to support more complex formats (like XV15, XV20). Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynq= mp_disp.c index 80d1e499a18d..b9883ea2d03e 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -1116,16 +1116,19 @@ int zynqmp_disp_layer_update(struct zynqmp_disp_lay= er *layer, return 0; =20 for (i =3D 0; i < info->num_planes; i++) { - unsigned int width =3D state->crtc_w / (i ? info->hsub : 1); - unsigned int height =3D state->crtc_h / (i ? info->vsub : 1); struct zynqmp_disp_layer_dma *dma =3D &layer->dmas[i]; struct dma_async_tx_descriptor *desc; dma_addr_t dma_addr; + unsigned int width; + unsigned int height; + + width =3D drm_format_info_plane_width(info, state->crtc_w, i); + height =3D drm_format_info_plane_height(info, state->crtc_h, i); =20 dma_addr =3D drm_fb_dma_get_gem_addr(state->fb, state, i); =20 dma->xt.numf =3D height; - dma->sgl.size =3D width * info->cpp[i]; + dma->sgl.size =3D drm_format_info_min_pitch(info, i, width); dma->sgl.icg =3D state->fb->pitches[i] - dma->sgl.size; dma->xt.src_start =3D dma_addr; dma->xt.frame_size =3D 1; --=20 2.43.0