From nobody Mon Dec 1 22:03:55 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 393C230146B for ; Mon, 1 Dec 2025 09:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581618; cv=none; b=i1NC1qgEkmo27zTlVLUFwr1+pltzBeUloRNKlVcAgGp159Cl5vH+nXnLJJU44RHweZB1gxP/mjqICAQYaFjojVRI4rBTKixkTux7quRDKM4EtB7/0wu/hT40xIwplzaqTVpWLz57k35Pt4YnjgutujdRvxV7HWCUkDUATyWzHEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581618; c=relaxed/simple; bh=gvSVxoCm7+LJlnSucQTnrfYh5mL799iZd5hm2jd1smU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zw7Z8UJHiw13fF2uHwzFR1S97SABNsbIZbhiXWfWuEE9C+LgvW3aijStdmnJ3thrqS9i3IWVZucLTLA9sIPrBnynMIv59rpevEHXtoUVebPJTHX7m6rE1zCeg2/4adMA0fQuRfRbq9KgFA6tIeAwIfpkiMJZI01DIBQtB3SWE/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YB8IFaZw; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YB8IFaZw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764581617; x=1796117617; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=gvSVxoCm7+LJlnSucQTnrfYh5mL799iZd5hm2jd1smU=; b=YB8IFaZwzp9hN6JvaRfySozqyAzy+Bx+iIp8r5LgFkyw0LwlavwCFFRc c9QppfyVLGCYJDrnTsw8Bnox138az0NOQB0gT4dWq2hfQhkhGpoGpZILL IEznmN6TACMIsGU2SWdrvDzkSty9p8FKW3CAsdxWdvN9YPCVbLMfY1pR0 zxLxebKjUY3Q9S5CsPL6ZKhUQJrsMrZpX9C2eduaLnTl+0Kkf+9Y9AXyW XZQpRVAnOlQyYfpUMhqWHKpHP6sca+CYHHaefId7RS/1uAoJc8ZCKWIL+ hLQ281fBMiRqKqNgiR5nT389FLPyoHptp0BS0tHxgNX51CoNVeEwrD+9f g==; X-CSE-ConnectionGUID: MjiNPazyTreYIMUJ/ArO4w== X-CSE-MsgGUID: 9AkU81hgTt2GKxQYURXkrw== X-IronPort-AV: E=McAfee;i="6800,10657,11629"; a="66586550" X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="66586550" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:24 -0800 X-CSE-ConnectionGUID: N8mdau3KR5OeSw/UqSSocw== X-CSE-MsgGUID: uME5QcErRLC8jfCFrU+FLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="194014784" Received: from lab-ah.igk.intel.com (HELO [127.0.1.1]) ([10.211.135.228]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:19 -0800 From: Andrzej Hajda Date: Mon, 01 Dec 2025 10:31:26 +0100 Subject: [PATCH v2 5/5] mm: simplify variadic args handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-va_format_call-v2-5-2906f3093b60@intel.com> References: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> In-Reply-To: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrzej Hajda X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1871; i=andrzej.hajda@intel.com; h=from:subject:message-id; bh=gvSVxoCm7+LJlnSucQTnrfYh5mL799iZd5hm2jd1smU=; b=owEB7QES/pANAwAKASNispPeEP3XAcsmYgBpLWCDqiBXNy04SmJYV2im6OViRn+7iKSUqg00o 2dytiZ+4vqJAbMEAAEKAB0WIQT8qEQxNN2/XeF/A00jYrKT3hD91wUCaS1ggwAKCRAjYrKT3hD9 16atC/9VGz30NkzaVRwueNj4Ef8JUWpVlZNPb00u0k0MtZw6cY1kXOptb37F+QHud4kZ3UoJZqg hp16GX/CAdaa36gRLKN64PBnfs9vZYlOuhMQG1dIXVlmsQKi0Z1Fmm0D5/sp1nWK1wG5g/EJwuz S0xv/dnBhfWkRo4mVZrqEhYJOSt66RQJgJRGJnvGX1E9KEmJkxiKf6qlBve9XEJSvdB8p+czrSb VRhXgCYIrVrRdNzcNa05vPCJeOzpY4kJTtO2VPki7fTJHayThLv5UTE/yjXymc/hAAOkgyQA/Xd fDs4ylTcQx3Ple6Wgm+yTBk8rdJRbL2wUenTSMYfxJYpTmnhzLOYTx9jpcTQq4hU0XX2bwKOR0+ AMOBRHQ+HwexKeuHPNTfjUbSWxd+ZUGAwoDOIH51phixPrnraGnCs7ERdZ2UFzUbQ/UKob6BGEx 0vMt/TTQLENVACk/3lNHo63MrbIwSKP90CP7tEmPGRboyMu+/NB8oigad3jKB4TlNNLuk= X-Developer-Key: i=andrzej.hajda@intel.com; a=openpgp; fpr=FCA8443134DDBF5DE17F034D2362B293DE10FDD7 Changing argument type from va_list to struct va_format * allows to simplify variadic argument handling with va_format_call helper. Signed-off-by: Andrzej Hajda --- mm/slub.c | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 786c5a4195d4..12d8ec97eac5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1135,27 +1135,16 @@ void skip_orig_size_check(struct kmem_cache *s, con= st void *object) set_orig_size(s, (void *)object, s->object_size); } =20 -static void __slab_bug(struct kmem_cache *s, const char *fmt, va_list args= p) +static void __slab_bug(struct kmem_cache *s, const char *fmt, struct va_fo= rmat *vaf) { - struct va_format vaf; - va_list args; - - va_copy(args, argsp); - vaf.fmt =3D fmt; - vaf.va =3D &args; pr_err("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D\n"); - pr_err("BUG %s (%s): %pV\n", s ? s->name : "", print_tainted(), = &vaf); + pr_err("BUG %s (%s): %pV\n", s ? s->name : "", print_tainted(), = vaf); pr_err("-----------------------------------------------------------------= ------------\n\n"); - va_end(args); } =20 static void slab_bug(struct kmem_cache *s, const char *fmt, ...) { - va_list args; - - va_start(args, fmt); - __slab_bug(s, fmt, args); - va_end(args); + va_format_call(fmt, __slab_bug, s, fmt, va_format_arg); } =20 __printf(2, 3) @@ -1252,14 +1241,10 @@ static void __slab_err(struct slab *slab) static __printf(3, 4) void slab_err(struct kmem_cache *s, struct slab *sla= b, const char *fmt, ...) { - va_list args; - if (slab_add_kunit_errors()) return; =20 - va_start(args, fmt); - __slab_bug(s, fmt, args); - va_end(args); + va_format_call(fmt, __slab_bug, s, fmt, va_format_arg); =20 __slab_err(slab); } --=20 2.43.0