From nobody Mon Dec 1 22:03:56 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C24301701 for ; Mon, 1 Dec 2025 09:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581617; cv=none; b=uTHpelVM3WokLiOkndqPEu1OZH0jPloxQA/g/T+5qM2d/p+9lQVEAg5h8JZcVL4p/D/gfSg9bgmEVwa3lM39Fb0B+T5yVitijz4I3F1/SDoHshpQaH+xEaYzVRqVLLXqMXvjh/DBbP/SQ2ymHTUV52D+Q4CGrQXkREqhN2WUR20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581617; c=relaxed/simple; bh=YczG0pLDYiEdMJk14SHF4xJmNNuo3F25zh2TrGVWcRw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gpuNc5Chr95y64V0A5l7wl9R3/I/Uovbt0vdm2s8qndm+fNcO+uw/J+KLx6FCuxj/a6mOOB0pEq/8H02TGXpYoxrnuuQ5UVclfiLFa552+2MOYiSU0a0EDy/K1JAuYLYrib2GrDhGGi/WdmTb1B8/7wj59Sfcc0WfqgI82kBjH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FqYTFKF6; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FqYTFKF6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764581616; x=1796117616; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=YczG0pLDYiEdMJk14SHF4xJmNNuo3F25zh2TrGVWcRw=; b=FqYTFKF6fg0JMTBYte4kzfQAihITmlMTPV23l1PrtbPN4BDkVOTpOW/R sDtbTJUFCi5To2piLg+83L0FA97CR6oKh42dNdB01XoiD9UYM2gGcKF60 bKdr/4eXx3KZ6IQbYp5agTvTbkISpydz7brNGtsCWfM+KPS1jVjk7L5po lsztKnlrciI0Y4MwQb89P5OLIT0NU0V+4vxvySZglzVpdAjjyHugi3Ha8 6Tf5/AZCAHoSTpAgQ64XqvvfTEkGSsRhY10bJ9dHx305t3UIymtOLNPc+ UF2GcmE0Vf1ecZhmqN6wvhh+edfE7XVY2pRGHa+rS0idunp3l7Lm+zdtw w==; X-CSE-ConnectionGUID: egsqB6OoR0yhkUvBfl5Qcw== X-CSE-MsgGUID: F5hMnNU2QWq7QItV45TcXQ== X-IronPort-AV: E=McAfee;i="6800,10657,11629"; a="66586508" X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="66586508" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:19 -0800 X-CSE-ConnectionGUID: zd4+EoNNSpuRB2cD/CPatA== X-CSE-MsgGUID: JF39Mmk8RS6NbLfNcBE8rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="194014774" Received: from lab-ah.igk.intel.com (HELO [127.0.1.1]) ([10.211.135.228]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:14 -0800 From: Andrzej Hajda Date: Mon, 01 Dec 2025 10:31:25 +0100 Subject: [PATCH v2 4/5] mm: use va_format_call helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-va_format_call-v2-4-2906f3093b60@intel.com> References: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> In-Reply-To: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrzej Hajda X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1930; i=andrzej.hajda@intel.com; h=from:subject:message-id; bh=YczG0pLDYiEdMJk14SHF4xJmNNuo3F25zh2TrGVWcRw=; b=owEB7QES/pANAwAKASNispPeEP3XAcsmYgBpLWCDBdzFMEbv9il+/ZP56YrIY2JKu7pYw36o7 Q73w7a7LLuJAbMEAAEKAB0WIQT8qEQxNN2/XeF/A00jYrKT3hD91wUCaS1ggwAKCRAjYrKT3hD9 15BOC/4n+qzjz6UOABhwlcO/wB7+6977X1yi9kKQ77MSaMWPblDviLXjg78spMbak97KvbyeUKK EOYMfpbzmJuJPIzPL6bi2A/O47E/5wiejBNLd8+g7/VdOMGettNh936pWeWVtwhLlBek+yqdIbF qIcJZURUOsy+w9Ltw6/HQJRFxZoUuwfW1a5M68jYewOu/WQk2vWTIRk88jbb7vhy6qlVoWSSHVU pBBAWK5L2aeZlG4RqjXI0dJ69ODy09IZ2JOifzmFzxSMXSA4bN/mOKeFZ9arAu3iEc6rz7BDhf7 qGjA8kXetf5V2qcYZoa+WVzdubGkhVkioJgEeKFJvgMbwEDSenPqCDFbsUMP/AEi6yfSJygu0Er FRjuS12OVywZmBp3L9XpxcSqLeoVk03AfBadaB8lhEkDBv1tSPIV6nAGb60jtoXR5MdwWlZnbMc qVjO6wuheKfnmPXHGY9hCl+X5AngljUIZDtb+b91PB4UdM+MfgrOqwsD5gI1KTj0rXwvw= X-Developer-Key: i=andrzej.hajda@intel.com; a=openpgp; fpr=FCA8443134DDBF5DE17F034D2362B293DE10FDD7 It simplifies the code and makes it more clear. Signed-off-by: Andrzej Hajda --- mm/page_alloc.c | 14 ++++---------- mm/slub.c | 10 +--------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ed82ee55e66a..cd0b17ea4de0 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3940,22 +3940,16 @@ static void warn_alloc_show_mem(gfp_t gfp_mask, nod= emask_t *nodemask) =20 void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) { - struct va_format vaf; - va_list args; static DEFINE_RATELIMIT_STATE(nopage_rs, 10*HZ, 1); =20 if ((gfp_mask & __GFP_NOWARN) || !__ratelimit(&nopage_rs) || ((gfp_mask & __GFP_DMA) && !has_managed_dma())) return; - - va_start(args, fmt); - vaf.fmt =3D fmt; - vaf.va =3D &args; - pr_warn("%s: %pV, mode:%#x(%pGg), nodemask=3D%*pbl", - current->comm, &vaf, gfp_mask, &gfp_mask, - nodemask_pr_args(nodemask)); - va_end(args); + va_format_call(fmt, pr_warn, + "%s: %pV, mode:%#x(%pGg), nodemask=3D%*pbl", + current->comm, va_format_arg, gfp_mask, &gfp_mask, + nodemask_pr_args(nodemask)); =20 cpuset_print_current_mems_allowed(); pr_cont("\n"); diff --git a/mm/slub.c b/mm/slub.c index 1a5fc3429042..786c5a4195d4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1161,17 +1161,9 @@ static void slab_bug(struct kmem_cache *s, const cha= r *fmt, ...) __printf(2, 3) static void slab_fix(struct kmem_cache *s, const char *fmt, ...) { - struct va_format vaf; - va_list args; - if (slab_add_kunit_errors()) return; - - va_start(args, fmt); - vaf.fmt =3D fmt; - vaf.va =3D &args; - pr_err("FIX %s: %pV\n", s->name, &vaf); - va_end(args); + va_format_call(fmt, pr_err, "FIX %s: %pV\n", s->name, va_format_arg); } =20 static void print_trailer(struct kmem_cache *s, struct slab *slab, u8 *p) --=20 2.43.0