From nobody Mon Dec 1 22:03:56 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 811B52E54DE for ; Mon, 1 Dec 2025 09:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581617; cv=none; b=YfCFp1oKBgZbbQo6eca+/AsJuVERRfVyEtKLMMnihUNza33gXjfsHs/7Z3j9KSlH2Uf12oBCB6y2eJcpWtShswb8voyUI/aYVnAmEbVXNzEEuOK/DH64I5XReNanoaPMm0h25low/xmY6TTyMDmX+69DxI4x3DttleSt0T/VET0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764581617; c=relaxed/simple; bh=aLe4KcA4NSXkuz6n3mPRoFlQksa7NsVPK3f3ZLIZZ90=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ovb6ItMVsBkoY8dT2Fu5IrXa31/zf5K94qs1Gn9Csjwrvl4JWXD7FRET2QXuu6ktONwLjtj3BlUJOAz1bzxvpM51zVtfJblB2MGZ2V0L67wOlYWF4cZZ1kEXJZYvoofO7mg5Tp/UpWSXQ3Jt3wF9kEE1o2Pd51ulO7uqrShH1AQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=afx9xJCM; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="afx9xJCM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764581615; x=1796117615; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=aLe4KcA4NSXkuz6n3mPRoFlQksa7NsVPK3f3ZLIZZ90=; b=afx9xJCMPF5YCC7nsn+MUT9iTC2Az54+lxzIdMthn9aEmxYmCqwbAY3n v6UbAGguwrw1MRcpO2W2jyhfhp0TtsQvTIemh+e5Cb4BSUF5YDq/c3TWV 3bvwCS1788QAeVLeIoCKDgbdutlURxbA9ULXTZ1GjFI3xQlHad7DbA5aZ BKa4/caBIBZqCoJav51Ap/wSNp3vc2LufHOeazrBFadQ4UpMb5VTAqSlu iw8yC1b4v/sIGjk2HdGyVS0+vbvoSCWiV6ZStZCFPpW2b7iF9deXQk+Vm fRP01uBL8fKURweeg5WcH0W8D30Qx1NEf+RrNDSGwMxY6kjBtrKynsIfk g==; X-CSE-ConnectionGUID: kApuN9KRR9y40drWbw4aLQ== X-CSE-MsgGUID: eq9JbPWsSYm7u4ixwdQrGw== X-IronPort-AV: E=McAfee;i="6800,10657,11629"; a="66586490" X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="66586490" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:16 -0800 X-CSE-ConnectionGUID: PTLk49HIQ42h8lk9mJqShg== X-CSE-MsgGUID: 7rzMsVPWTW+JaOplq6fONg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,240,1758610800"; d="scan'208";a="194014762" Received: from lab-ah.igk.intel.com (HELO [127.0.1.1]) ([10.211.135.228]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2025 01:33:09 -0800 From: Andrzej Hajda Date: Mon, 01 Dec 2025 10:31:24 +0100 Subject: [PATCH v2 3/5] drivers/core: simplify variadic args handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-va_format_call-v2-3-2906f3093b60@intel.com> References: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> In-Reply-To: <20251201-va_format_call-v2-0-2906f3093b60@intel.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrzej Hajda X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=3161; i=andrzej.hajda@intel.com; h=from:subject:message-id; bh=aLe4KcA4NSXkuz6n3mPRoFlQksa7NsVPK3f3ZLIZZ90=; b=owEB7QES/pANAwAKASNispPeEP3XAcsmYgBpLWCDrFS81p5xl7Y4ta+Lv+9MYmMyR7mYdfpHU VNBnvpCZwGJAbMEAAEKAB0WIQT8qEQxNN2/XeF/A00jYrKT3hD91wUCaS1ggwAKCRAjYrKT3hD9 16TtDACXjKOhA8ukJfEVaatD9RMTdXDzxWSTE6JGwiD22eMpKA/P+LbxSVg+iwrqFKUMSMygpBV 2VwVLP/IB/zRqeWCM5tDojIojNiN4zbx3a/HHcC57d2oaqUI9YXv0h1akeLjnMXGl2fA9rfYsAi ZFzaIW1XZrtJdYdfixg6SP8ImWc4+6RHl4msn8b9Morrng5z+Zx1kuvpzXlsnwtksY/V7ZyS+uH 8QW3QlSFYonKXmV73Bx8rJBTB/omNDf28xYE8iL01En+tR9fjVGwebrgXAq8Abw0rgp1i3c0XBx DC8bBFh4JEOnAqmovMoDdRSA5VMq3YEljX6dEGflJz17FyJltOP2YBGmAqjhqi7u+rtFbpvCGxq Z9Xy3bkn/u2gUyviBU3+X3N32zVoO95dimpNz8rYrV8q+edG486ULFyqxaanGq+U9mnAK1ntaxs 64td9HywJS68L+44/YSRu08Dsi5n3hKfetqYPKHGx1OWQbYBYnqvcYvgSGbb9KjspwWGM= X-Developer-Key: i=andrzej.hajda@intel.com; a=openpgp; fpr=FCA8443134DDBF5DE17F034D2362B293DE10FDD7 Changing argument type from va_list to struct va_format * allows to simplify variadic argument handling with va_format_call helper. Signed-off-by: Andrzej Hajda --- drivers/base/core.c | 50 +++++++------------------------------------------- 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 513e5ef8a6da..4d76b67a87e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4965,30 +4965,12 @@ define_dev_printk_level(_dev_info, KERN_INFO); #endif =20 static void __dev_probe_failed(const struct device *dev, int err, bool fat= al, - const char *fmt, va_list vargsp) + const char *fmt, struct va_format *vaf) { - struct va_format vaf; - va_list vargs; - - /* - * On x86_64 and possibly on other architectures, va_list is actually a - * size-1 array containing a structure. As a result, function parameter - * vargsp decays from T[1] to T*, and &vargsp has type T** rather than - * T(*)[1], which is expected by its assignment to vaf.va below. - * - * One standard way to solve this mess is by creating a copy in a local - * variable of type va_list and then using a pointer to that local copy - * instead, which is the approach employed here. - */ - va_copy(vargs, vargsp); - - vaf.fmt =3D fmt; - vaf.va =3D &vargs; - switch (err) { case -EPROBE_DEFER: - device_set_deferred_probe_reason(dev, &vaf); - dev_dbg(dev, "error %pe: %pV", ERR_PTR(err), &vaf); + device_set_deferred_probe_reason(dev, vaf); + dev_dbg(dev, "error %pe: %pV", ERR_PTR(err), vaf); break; =20 case -ENOMEM: @@ -4998,13 +4980,11 @@ static void __dev_probe_failed(const struct device = *dev, int err, bool fatal, default: /* Log fatal final failures as errors, otherwise produce warnings */ if (fatal) - dev_err(dev, "error %pe: %pV", ERR_PTR(err), &vaf); + dev_err(dev, "error %pe: %pV", ERR_PTR(err), vaf); else - dev_warn(dev, "error %pe: %pV", ERR_PTR(err), &vaf); + dev_warn(dev, "error %pe: %pV", ERR_PTR(err), vaf); break; } - - va_end(vargs); } =20 /** @@ -5042,15 +5022,7 @@ static void __dev_probe_failed(const struct device *= dev, int err, bool fatal, */ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) { - va_list vargs; - - va_start(vargs, fmt); - - /* Use dev_err() for logging when err doesn't equal -EPROBE_DEFER */ - __dev_probe_failed(dev, err, true, fmt, vargs); - - va_end(vargs); - + va_format_call(fmt, __dev_probe_failed, dev, err, true, fmt, va_format_ar= g); return err; } EXPORT_SYMBOL_GPL(dev_err_probe); @@ -5090,15 +5062,7 @@ EXPORT_SYMBOL_GPL(dev_err_probe); */ int dev_warn_probe(const struct device *dev, int err, const char *fmt, ...) { - va_list vargs; - - va_start(vargs, fmt); - - /* Use dev_warn() for logging when err doesn't equal -EPROBE_DEFER */ - __dev_probe_failed(dev, err, false, fmt, vargs); - - va_end(vargs); - + va_format_call(fmt, __dev_probe_failed, dev, err, false, fmt, va_format_a= rg); return err; } EXPORT_SYMBOL_GPL(dev_warn_probe); --=20 2.43.0