From nobody Mon Dec 1 21:31:21 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8FA336ED2 for ; Mon, 1 Dec 2025 16:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764607317; cv=none; b=KZeb3E2foaIuyQk4DtQHvidnTFEIheWGszzBeKUJCz7mXeMg38a6d58ebVc9ex+IitfCcPAA/0kuOgImGS7zP7V08KImyDSnFfd/FNxJk0YX1Lc3ut8696TtEbIZi06HnuAsT40Yi0c2q1UFuvHsoTeMuLXOh3KTmj6G8ozAO24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764607317; c=relaxed/simple; bh=XDHLC1TToim0ot24UHTP8tg0u/f4uP/BR8HUnpB+CwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dP6nLXWMbY9NXyjD9n0ig5R4O6UGIDEqrYSq0PhZCnFMZ3yBsIOUFYNcik3CvD5/azOWoUVw34ZMT+xCuNAjUoAuAxBd3JIVlTeMhLpBtRz4WPy0DH4PccWCnh+Q9n6+TAkBHS7v5nig3XJsknPsa6w4fXwoKshqF2IbwN1T0Pc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K5hMjO3t; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K5hMjO3t" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47796a837c7so31007595e9.0 for ; Mon, 01 Dec 2025 08:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764607313; x=1765212113; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2GmRPB0jBQgoThlmGWejjg28u4BOouUoY2C6pZo+51c=; b=K5hMjO3tkDxSzE9NvXv86os0KLjJSgCCvpFMzEmDN+cVOz+7GYNULjgrFOrb99xJMw APiH1SK/iNiIcZjpJsjigs/qBMd1cVmXd8ECuRiBgZD/e5EgA9kcWqgI7ovShKvyLGMB 1ESiwPCjWm+2yNOfVQxkxgS9oUK3BOFzNdpFCUCau2yTNV8T89+FjmlGVqaJJwRYUebu b3ykGByTIVD6Dd9WtJPgRA3Rc5WoSQ0RsKtMBYqgXV2XMSQJAps4/bayjg+Inl4rhTbY wgtGQFmL9KJlUHsxZCW6Cy6mTlNRTaK1daO0IL+6mfzB2jQD25+GDhBWsY4EDhD3qM9Z Z9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764607313; x=1765212113; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2GmRPB0jBQgoThlmGWejjg28u4BOouUoY2C6pZo+51c=; b=rqR8Pv485uPL+HSipjFgjt4xX4g/Si4cDSr7W1uBfJwpqw8ymWo4p5hEXdw3owgF2A wIGf4KC/8fHTse7HEpqtiPethDxASjEr471BAcV7ro33/jKAVjY7bYManLh1wmLRWJ6L lGHJf4hsWsURlBK/ofCcmTIj2MT8awoRf/InfqO90JRY7tyFmSTcvINwOIac2MP6UlHF gygSgFlAdTyddBEs6L4ze1GGti/dXWacwsmLa8iePufqRmC8X08rOq0X8/n7G90OaU51 V4adtCtNhseK7jpkw7fzJUnbRYBROZ76Ozb1CiiYKVF0Mr1dO3GVR8KrtSbVDFHkEt3q AQsg== X-Forwarded-Encrypted: i=1; AJvYcCXzQSRekB36ZhUsfYv+b9cKYIKi5V+PlCE7PgvEhB0c3+DmgbVgVeBgGG393bgZ1+ar9OcaR91T/p/y0jQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9UtuFgKujcG8aISYSX7txNqCkU1nAuZHcUOH6lNvBiY+mV6Ou U35xvxAcLgICupnFjcTfaB+XXZ7i3CTOpRCS8xh0a4fWQid3guYUPJclVEtCCJUuPAQ= X-Gm-Gg: ASbGncsBUTV/NakmmfrRo+4wOSXAW7qU3gjWR+q2dA7W63ftto7uWbn6nOKE+2D6MBL 8+rB5liH9xy2ZDhAgTCSVb4HT4v8rdEw5K72ukvJMRG2p5qy5qHRzC1LI53g+a4zSl3eZ+QEkl1 UgJgV8RrgfeQnwoVorGeSyswMhMNcc8v8Fy2+8zb6dcm6x0ppO4JfpQeiyyb9hNjcVb1wRs5Bil HkrNBCRp20LiR2NrS/N29+X5c/ltxPb3ts7ub9vAPxkH2Jjg0F3CGVieE0EeZ6fx15O1WIf9bmZ hjQGFNFgrI9nWT27fQYTnD1OC2H8ZHXUt5yobk27u5gCtfa7si/nHd4JHKJrJ2rGLdxXI6lRZgG P2nJeDp+E8h8PXDo6zuab2zD23nSA3k9LWz/psaPxdCoMCL1qgvil4LgYUwIHqrdHi6qBYgYDVt +1cfBs4XHEjQPzaf0+zTXb X-Google-Smtp-Source: AGHT+IFPwkzUwt5EiRHYLaJ1366EfwcLCjCSX4vJLGbexn4dFtCnAICQ5GKj987Mcpxp3OuhbV/5PQ== X-Received: by 2002:a05:600c:4ed2:b0:477:55ce:f3c3 with SMTP id 5b1f17b1804b1-477c0162dd6mr377290195e9.5.1764607313297; Mon, 01 Dec 2025 08:41:53 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4791164d4f3sm255901275e9.13.2025.12.01.08.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 08:41:52 -0800 (PST) From: James Clark Date: Mon, 01 Dec 2025 16:41:10 +0000 Subject: [PATCH 7/7] perf arm-spe: Don't hard code config attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-james-perf-config-bits-v1-7-22ecbbf8007c@linaro.org> References: <20251201-james-perf-config-bits-v1-0-22ecbbf8007c@linaro.org> In-Reply-To: <20251201-james-perf-config-bits-v1-0-22ecbbf8007c@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Use the config attribute that's published by the driver instead of hard coding "attr.config". Signed-off-by: James Clark --- tools/perf/arch/arm64/util/arm-spe.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/u= til/arm-spe.c index d5ec1408d0ae..6c3dc97fde30 100644 --- a/tools/perf/arch/arm64/util/arm-spe.c +++ b/tools/perf/arch/arm64/util/arm-spe.c @@ -256,7 +256,7 @@ static __u64 arm_spe_pmu__sample_period(const struct pe= rf_pmu *arm_spe_pmu) =20 static void arm_spe_setup_evsel(struct evsel *evsel, struct perf_cpu_map *= cpus) { - u64 bit; + u64 pa_enable_bit; =20 evsel->core.attr.freq =3D 0; evsel->core.attr.sample_period =3D arm_spe_pmu__sample_period(evsel->pmu); @@ -288,9 +288,10 @@ static void arm_spe_setup_evsel(struct evsel *evsel, s= truct perf_cpu_map *cpus) * inform that the resulting output's SPE samples contain physical addres= ses * where applicable. */ - bit =3D perf_pmu__format_bits(evsel->pmu, "pa_enable"); - if (evsel->core.attr.config & bit) - evsel__set_sample_bit(evsel, PHYS_ADDR); + + if (!evsel__get_config_val(evsel->pmu, evsel, "pa_enable", &pa_enable_bit= )) + if (pa_enable_bit) + evsel__set_sample_bit(evsel, PHYS_ADDR); } =20 static int arm_spe_setup_aux_buffer(struct record_opts *opts) @@ -397,6 +398,7 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, struct perf_cpu_map *cpus =3D evlist->core.user_requested_cpus; bool discard =3D false; int err; + u64 discard_bit; =20 sper->evlist =3D evlist; =20 @@ -425,9 +427,8 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, evlist__for_each_entry_safe(evlist, tmp, evsel) { if (evsel__is_aux_event(evsel)) { arm_spe_setup_evsel(evsel, cpus); - if (evsel->core.attr.config & - perf_pmu__format_bits(evsel->pmu, "discard")) - discard =3D true; + if (!evsel__get_config_val(evsel->pmu, evsel, "discard", &discard_bit)) + discard =3D !!discard_bit; } } =20 --=20 2.34.1