From nobody Tue Dec 2 00:24:05 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89744283FD9 for ; Mon, 1 Dec 2025 22:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764626824; cv=none; b=M5hO3MmxEtLwuo8OItbzM+YefrRkaBt2XD5QS/AchPh7qjBRtFeW7TAApMTgoWQdnLgoxjRHkPDLJ0Y6c07HhWuuksAQRqOlVGypmQinlG0GGCgTpDtn++anToyJGigGeF+wKv2S4DpbN0mt9gkOmUcMx2iqD07JU9PhGVSbtmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764626824; c=relaxed/simple; bh=77IR71vazhMBo/1VoNxEizLBWQX33SJ3o+8OJafVX9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Lu6AslNvVB4x+nN8l+rC27htNnSAkpQXS/KWARI4XHo5bNhMdwxGHhhf8dMy0FcXPSYbY3qsJ8U/YBQRdphq4rLPNwznwuWElzuNUNKzwqGJgpX6c9l+Ies1PPPxNUc/QJMc9iJSHiilFSG4fXGdRfg4WZw0k7spFXREWuzY/fI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UJCseyTM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Nmv3DVqb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UJCseyTM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nmv3DVqb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764626821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=scXExgic2EXaygicpqyZLz/imYsLOFX9PqneQqDmIy4=; b=UJCseyTM9y9vCb+Afglc+sYs2deFUmTlLt35J9Zm5HUuF+1/crSduHUNRHdbtkEC7kXE4+ 4fXBk02uOI3Jqiwb0OwxnEarEp0Ln/gfU4Jl1h2DuvXxNoL4ZZ6TYdDUqiCjLtbGA1ikaX lv7FkQqygtifRsEvZNSWfGEMIutEyeM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-gyQYzbgsN9ql8jNKwP_2lA-1; Mon, 01 Dec 2025 17:07:00 -0500 X-MC-Unique: gyQYzbgsN9ql8jNKwP_2lA-1 X-Mimecast-MFC-AGG-ID: gyQYzbgsN9ql8jNKwP_2lA_1764626820 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b2e41884a0so1098790985a.1 for ; Mon, 01 Dec 2025 14:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764626820; x=1765231620; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=scXExgic2EXaygicpqyZLz/imYsLOFX9PqneQqDmIy4=; b=Nmv3DVqb58vz6lUEhBHnu1iC/f1+bEh02OejXVWlROiIGuz9MtT5nnAJBLZqJScYn6 gU2dh26BOedaHhW6jrZxwitG+VZTyuydRBxzJ6vyA5Kaeby0OAfFBg/YVa8189+GuOZb tKTFPnfXkS8zqnzVifx1IWIp1TYlXGWred5RXpw5E2lykeldJWuqsZXusv008PiSYNjc 6rfF1FloAVDw3UrIVlWCM2EFu3Mlp/gEEx6kk1SdDStIFxnzflOrF7d+bl9Wm0zizLHX QKYPThL1A/hCoFDB2m511P6xyrX1qvFR1+OVNtnBZPnE64osAJaCjjSuf3mThW//cUu5 StBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764626820; x=1765231620; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=scXExgic2EXaygicpqyZLz/imYsLOFX9PqneQqDmIy4=; b=Yt6SH4sCowkMhtO8Vw6FmsI0SVbheHpUewhud9EWVn7jzSOI2FwiH2fQ0wq5uT7ED3 tF5L4R10TFeGOq5c6yjsYPKGAuOWQkQ/K3nO2gNZdUqmdUqq49kZ5isoXT8nQSajQdjZ 3kaisrUveRgMAQ9hzRMeF5odu68AytBkyirMIEtE+iG4xJ6s79pcVUSbj4tYIJ6XSm89 94Ek1iijhxeKnFKG/jYbSP3N8ky45npLdhSXXiOoeUg4cgJdLHVc3+6DXp2ZCh2luNU/ AglZtMYjRC5jRqdwh5Xv9cfGhdEBpwCxBch26GDtpOst82HXkpYwGexeV3x1HC88QXN1 nwUg== X-Forwarded-Encrypted: i=1; AJvYcCUKRXR97QtbuTVZs0d5++ETPxRyR+jraMGiCeDVKy4ntbsRxq7Vflxz6HVYhdmarF5i8OPtpA+fkOLMquk=@vger.kernel.org X-Gm-Message-State: AOJu0YysCNJ6O3VxM6MB5/7AHybwTOtkLKk2Ld9kv6iqI9Cwy9A7qduw AINs6VXC8whXb+u+B+6afJgEEL1W9dp+aekNipFI4IzAEAZ/dy5GhF+O5TGwBBY+/y0vXEkvMXC Dlp+/uWIWxBzJa1wOIOobIxKMJbSBX6a8SBuohQQ4IBR/MyYUBCrO1j69tLpF6k6NbA== X-Gm-Gg: ASbGncvQAyDR5wKb/Um/sb+bkMKoI2neK5ypsrc2tfE1QklX1JUT/3dfB/noh44Ed7w auI8LZGIWtG8XphBXRsOb60YunELR8MY1pKrulMugAe3qBlgDazY/QEblBMEqN2hZ7fx+fyiOi2 PimVGwXGRJcuLQSyy7asm7FDdzy9gy9F2eJF8MHD8xLJZyd4kdXelKdVWTLtkzjc8Jh58GMZQTv O13KZ/cbsNhZgBUpt3+OY9+MDKK706yvSugG/pm7CoaYq8IrQKUocjMGlh0UiPZBbVr/eXrwJ+r feSq3/7lh1ghIYLfqpVCYYGwwd1JJcnmqYVoqgabX004Em9rr0XNfWF5SYbTvVU0i4bMd0EB5NO NZWJy1NE1m9NFxzQl X-Received: by 2002:a05:620a:1727:b0:89e:baa5:c822 with SMTP id af79cd13be357-8b33d225854mr5087935985a.40.1764626819693; Mon, 01 Dec 2025 14:06:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkFqvc+nOoqniDujUfdBx+68TawJbQWz+yb3He2552JGKpdSit/958LX13hETXS04YY8IrVA== X-Received: by 2002:a05:620a:1727:b0:89e:baa5:c822 with SMTP id af79cd13be357-8b33d225854mr5087933185a.40.1764626819387; Mon, 01 Dec 2025 14:06:59 -0800 (PST) Received: from [10.235.125.224] ([2600:382:850e:4ee7:c142:114b:2df7:89ef]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b529993978sm944541085a.5.2025.12.01.14.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 14:06:58 -0800 (PST) From: Brian Masney Date: Mon, 01 Dec 2025 17:06:37 -0500 Subject: [PATCH v2 1/3] clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251201-clk-microchip-fixes-v2-1-9d5a0daadd98@redhat.com> References: <20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com> In-Reply-To: <20251201-clk-microchip-fixes-v2-0-9d5a0daadd98@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Claudiu Beznea , Conor Dooley Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , kernel test robot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2011; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=77IR71vazhMBo/1VoNxEizLBWQX33SJ3o+8OJafVX9U=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDL1BOtrlD/v/Nq93fxRUaHUDpf+o4kKf7eJn9ZPyy38m 771zazjHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEzERYCRoclW6RMDg/o5lw+s X0TeLVs+/STfigerDq5dwx3wpu9DnwfD/ySr82+zQzPkovR+ZJwQDxFb+KZ9qYqcfsqdWwcyZzF +ZAAA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 pic32_sclk_ops previously had a sclk_round_rate() member, and this was recently converted over to sclk_determine_rate() with the help of a Coccinelle semantic patch. pic32_sclk_ops now has two conflicting determine_rate ops members. Prior to the conversion, pic32_sclk_ops already had a determine_rate member that points to __clk_mux_determine_rate(). When both the round_rate() and determine_rate() ops are defined, the clk core only uses the determine_rate() op. Let's go ahead and drop the recently converted sclk_determine_rate() to match the previous functionality prior to the conversion. Fixes: e9f039c08cdc ("clk: microchip: core: convert from round_rate() to de= termine_rate()") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202511222115.uvHrP95A-lkp@int= el.com/ Signed-off-by: Brian Masney --- drivers/clk/microchip/clk-core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-c= ore.c index b34348d491f3e1b576b2b9a8a66bfddd8c2296ea..a0163441dfe5c1dfc27dae48e64= cf3cb3d6b764f 100644 --- a/drivers/clk/microchip/clk-core.c +++ b/drivers/clk/microchip/clk-core.c @@ -780,15 +780,6 @@ static unsigned long sclk_get_rate(struct clk_hw *hw, = unsigned long parent_rate) return parent_rate / div; } =20 -static int sclk_determine_rate(struct clk_hw *hw, - struct clk_rate_request *req) -{ - req->rate =3D calc_best_divided_rate(req->rate, req->best_parent_rate, - SLEW_SYSDIV, 1); - - return 0; -} - static int sclk_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { @@ -912,7 +903,6 @@ static int sclk_init(struct clk_hw *hw) const struct clk_ops pic32_sclk_ops =3D { .get_parent =3D sclk_get_parent, .set_parent =3D sclk_set_parent, - .determine_rate =3D sclk_determine_rate, .set_rate =3D sclk_set_rate, .recalc_rate =3D sclk_get_rate, .init =3D sclk_init, --=20 2.51.1